|
»
»
»
[patches] fix format errors
|
View:
New views
1 Messages
—
Rating Filter:
Alert me
|
 |
[patches] fix format errors
by Guillaume Rousse
::
Rate this Message:
Hello.
Here are two simple patches fixing some string format error in openvrml. -- BOFH excuse #64: CPU needs recalibration --- src/mozilla-plugin/openvrml.cpp~ 2009-07-04 17:19:48.000000000 -0400 +++ src/mozilla-plugin/openvrml.cpp 2009-08-21 01:51:07.000000000 -0400 @@ -526,7 +526,7 @@ } catch (std::bad_alloc &) { return NPERR_OUT_OF_MEMORY_ERROR; } catch (std::runtime_error & ex) { - g_critical(ex.what()); + g_critical("%s",ex.what()); return NPERR_GENERIC_ERROR; } return NPERR_NO_ERROR; --- src/openvrml-player/curlbrowserhost.cpp~ 2009-07-04 17:20:21.000000000 -0400 +++ src/openvrml-player/curlbrowserhost.cpp 2009-08-21 02:33:36.000000000 -0400 @@ -802,7 +802,7 @@ cancellable, &error); if (error) { - g_warning(error->message); + g_warning("%s",error->message); g_error_free(error); error = 0; } --- src/openvrml-xembed/main.cpp~ 2009-07-04 17:19:48.000000000 -0400 +++ src/openvrml-xembed/main.cpp 2009-08-21 02:35:25.000000000 -0400 @@ -187,7 +187,7 @@ g_option_context_add_group(context, gtk_get_option_group(true)); gboolean succeeded = g_option_context_parse(context, &argc, &argv, &error); if (!succeeded) { - if (error) { g_critical(error->message); } + if (error) { g_critical("%s",error->message); } return EXIT_FAILURE; } --- src/openvrml-xembed/browser.cpp~ 2009-07-04 17:19:48.000000000 -0400 +++ src/openvrml-xembed/browser.cpp 2009-08-21 02:42:23.000000000 -0400 @@ -360,6 +360,7 @@ g_set_error(error, OPENVRML_XEMBED_ERROR, OPENVRML_XEMBED_ERROR_UNKNOWN_STREAM, + "%s", ex.what()); return false; } @@ -383,6 +384,7 @@ g_set_error(error, OPENVRML_XEMBED_ERROR, OPENVRML_XEMBED_ERROR_UNKNOWN_STREAM, + "%s", ex.what()); return false; } @@ -409,6 +411,7 @@ g_set_error(error, OPENVRML_XEMBED_ERROR, OPENVRML_XEMBED_ERROR_UNKNOWN_STREAM, + "%s", ex.what()); } return true; @@ -437,6 +440,7 @@ } catch (const std::exception & ex) { *error = g_error_new(OPENVRML_XEMBED_ERROR, OPENVRML_XEMBED_ERROR_FAILED, + "%s", ex.what()); return false; } diff -Naur -x '*~' openvrml-0.18.5/src/openvrml-player/curlbrowserhost.cpp openvrml-0.18.5-fix-format-errors/src/openvrml-player/curlbrowserhost.cpp --- openvrml-0.18.5/src/openvrml-player/curlbrowserhost.cpp 2009-10-27 18:21:35.000000000 +0100 +++ openvrml-0.18.5-fix-format-errors/src/openvrml-player/curlbrowserhost.cpp 2010-02-16 10:51:10.000000000 +0100 @@ -445,7 +445,7 @@ g_set_error(error, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR_CURL, - curl_easy_strerror(setopt_result)); + "%s", curl_easy_strerror(setopt_result)); } return setopt_result; } @@ -475,7 +475,7 @@ g_set_error(error, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR_CURL, - curl_easy_strerror(setopt_result)); + "%s", curl_easy_strerror(setopt_result)); return 1; } @@ -485,7 +485,7 @@ g_set_error(error, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR_CURL, - curl_easy_strerror(setopt_result)); + "%s", curl_easy_strerror(setopt_result)); return 1; } @@ -495,7 +495,7 @@ g_set_error(error, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR_CURL, - curl_easy_strerror(setopt_result)); + "%s", curl_easy_strerror(setopt_result)); return 1; } @@ -507,7 +507,7 @@ g_set_error(error, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR_CURL, - curl_easy_strerror(setopt_result)); + "%s", curl_easy_strerror(setopt_result)); return 1; } @@ -517,7 +517,7 @@ g_set_error(error, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR_CURL, - curl_easy_strerror(setopt_result)); + "%s", curl_easy_strerror(setopt_result)); return 1; } @@ -527,7 +527,7 @@ g_set_error(error, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR_CURL, - curl_multi_strerror(add_handle_result)); + "%s", curl_multi_strerror(add_handle_result)); return 1; } @@ -553,7 +553,7 @@ g_set_error(error, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR, OPENVRML_PLAYER_CURL_BROWSER_HOST_ERROR_OUT_OF_MEMORY, - ex.what()); + "%s", ex.what()); return 1; } return 0; ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ openvrml-develop mailing list openvrml-develop@... https://lists.sourceforge.net/lists/listinfo/openvrml-develop |
| Free embeddable forum powered by Nabble | Forum Help |
