[plexus-dev] [jira] Created: (PLX-197) incorporate "followSymlinks" functionality in FileUtils API

incorporate "followSymlinks" functionality in FileUtils API
-----------------------------------------------------------

         Key: PLX-197
         URL: http://jira.codehaus.org/browse/PLX-197
     Project: Plexus
        Type: New Feature

  Components: plexus-utils  
    Reporter: John Casey
 Assigned to: John Casey
    Priority: Blocker
     Fix For: 1.0-alpha-10


In order to avoid infinite looping when deleting directories in FileUtils, we should add a "followSymlinks" flag to the API to allow people to determine which semantics they want. This will allow the maven-clean-plugin to start using FileUtils instead of its homespun version of the directory delete.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/PLX-197?page=all ]

John Casey updated PLX-197:
---------------------------

    Assign To:     (was: John Casey)

> incorporate "followSymlinks" functionality in FileUtils API
> -----------------------------------------------------------
>
>          Key: PLX-197
>          URL: http://jira.codehaus.org/browse/PLX-197
>      Project: Plexus
>         Type: New Feature

>   Components: plexus-utils
>     Reporter: John Casey
>     Priority: Blocker
>      Fix For: 1.0-alpha-10

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In order to avoid infinite looping when deleting directories in FileUtils, we should add a "followSymlinks" flag to the API to allow people to determine which semantics they want. This will allow the maven-clean-plugin to start using FileUtils instead of its homespun version of the directory delete.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/PLX-197?page=comments#action_63829 ]

Brett Porter commented on PLX-197:
----------------------------------

test jira mail

> incorporate "followSymlinks" functionality in FileUtils API
> -----------------------------------------------------------
>
>          Key: PLX-197
>          URL: http://jira.codehaus.org/browse/PLX-197
>      Project: Plexus
>         Type: New Feature

>   Components: plexus-utils
>     Reporter: John Casey
>     Priority: Blocker
>      Fix For: 1.0-alpha-10

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In order to avoid infinite looping when deleting directories in FileUtils, we should add a "followSymlinks" flag to the API to allow people to determine which semantics they want. This will allow the maven-clean-plugin to start using FileUtils instead of its homespun version of the directory delete.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/PLX-197?page=all ]

Brett Porter updated PLX-197:
-----------------------------

    Comment: was deleted

> incorporate "followSymlinks" functionality in FileUtils API
> -----------------------------------------------------------
>
>          Key: PLX-197
>          URL: http://jira.codehaus.org/browse/PLX-197
>      Project: Plexus
>         Type: New Feature

>   Components: plexus-utils
>     Reporter: John Casey
>     Priority: Blocker
>      Fix For: 1.0-alpha-10

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In order to avoid infinite looping when deleting directories in FileUtils, we should add a "followSymlinks" flag to the API to allow people to determine which semantics they want. This will allow the maven-clean-plugin to start using FileUtils instead of its homespun version of the directory delete.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/PLX-197?page=all ]

Brett Porter updated PLX-197:
-----------------------------

    Comment: was deleted

> incorporate "followSymlinks" functionality in FileUtils API
> -----------------------------------------------------------
>
>          Key: PLX-197
>          URL: http://jira.codehaus.org/browse/PLX-197
>      Project: Plexus
>         Type: New Feature

>   Components: plexus-utils
>     Reporter: John Casey
>     Priority: Blocker
>      Fix For: 1.0-alpha-10

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> In order to avoid infinite looping when deleting directories in FileUtils, we should add a "followSymlinks" flag to the API to allow people to determine which semantics they want. This will allow the maven-clean-plugin to start using FileUtils instead of its homespun version of the directory delete.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/PLXUTILS-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kenney Westerhof updated PLXUTILS-16:
-------------------------------------

    Remaining Estimate:     (was: 2 hours)
     Original Estimate:     (was: 2 hours)

Just out of curiosity - is there a way to detect symlinks in java?

> incorporate "followSymlinks" functionality in FileUtils API
> -----------------------------------------------------------
>
>                 Key: PLXUTILS-16
>                 URL: http://jira.codehaus.org/browse/PLXUTILS-16
>             Project: Plexus Utils
>          Issue Type: New Feature
>            Reporter: John Casey
>            Priority: Blocker
>
> In order to avoid infinite looping when deleting directories in FileUtils, we should add a "followSymlinks" flag to the API to allow people to determine which semantics they want. This will allow the maven-clean-plugin to start using FileUtils instead of its homespun version of the directory delete.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/PLXUTILS-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=128365#action_128365 ]

Benjamin Bentmann commented on PLXUTILS-16:
-------------------------------------------

bq. is there a way to detect symlinks in java?
Somehow: As described in the javadoc for {{[File.getCanonicalPath()|http://java.sun.com/javase/6/docs/api/java/io/File.html#getCanonicalPath()]}}, this method resolves symbolic links, unlike {{File.getAbsolutePath()}}. So, if for a given path the return values from {{getCanonicalPath()}} and {{getAbsolutePath()}} differ, this is likely caused by a symlink. See also the docs for the [Ant symlink task|http://ant.apache.org/manual/OptionalTasks/symlink.html] and the implementation of Plexus' {{DirectoryScanner.isSymbolicLink()}}.

Implementors of this heuristic need to keep in mind the following cases that can cause false positives for the symlink detection:
- {{getCanonicalPath()}} also performs path normalization (e.g. removing ".." references), so any non-normalized input path will be errorneously detected as a symlink.
- On Windows, {{getCanonicalPath()}} performs case corrections to deliver the original case-preserved file path (e.g. "c:\POM.XML" might become "C:\pom.xml"). For this reason, symlink detection should not compare canonical and absolute paths literally using {{String.equals()}} but rather using {{File.equals()}} which will automatically perform a case-insensitive comparison on Windows.

> incorporate "followSymlinks" functionality in FileUtils API
> -----------------------------------------------------------
>
>                 Key: PLXUTILS-16
>                 URL: http://jira.codehaus.org/browse/PLXUTILS-16
>             Project: Plexus Utils
>          Issue Type: New Feature
>            Reporter: John Casey
>            Priority: Blocker
>
> In order to avoid infinite looping when deleting directories in FileUtils, we should add a "followSymlinks" flag to the API to allow people to determine which semantics they want. This will allow the maven-clean-plugin to start using FileUtils instead of its homespun version of the directory delete.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email