[s4] Patches for password handling

View: New views
2 Messages — Rating Filter:   Alert me  

[s4] Patches for password handling

by Matthias Dieter Wallnöfer-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Here two patches for password handling

Matthias






mdw.git-0b0a30a3bf0c2335dbcbd28d37552ea968652c6f.patch (5K) Download Attachment
mdw.git-6a36add2d6b29b8c3c8ede98b2a6e0bb27eadf91.patch (29K) Download Attachment

Re: [s4] Patches for password handling

by Andrew Bartlett :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, 2009-10-30 at 09:59 +0000, Matthias Dieter Wallnöfer wrote:
> s4:password_hash - Various (mostly cosmetic) prework
>
> - Enhance comments
> - Remove (now) unnecessary code for single valued attribute checking

Matthias,

I'm not sure that this is the case.  The single-value checks on
userPassword are important, because we intercept, but don't store, that
value.  

Also, while clearTextPassword is not normally an externally set
attribute, we have to check it's validity because we don't currently
have a control on that.

Even for the other attributes, while they may be checked for
single-value status later, I think it's too late.

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.



signature.asc (196 bytes) Download Attachment