0.2.x -> 0.3.x search behavior change

[Derek Yarnell]

So one of my users noticed that the search has changed a bunch going  
from 0.2.x to 0.3.x.  That by default the roll down has only Subject  
checked (this used to be subject and sender?).  Well that was all fine  
I added a patch to change the default behavior to subject and sender.  
However the user also noticed that the Sent folder changed this  
behavior to search on the recipient in 0.2.x.  Now in 0.3.x this all  
gets to whatever is set by this line in program/steps/mail/func.inc,

$OUTPUT->set_env('search_mods', $_SESSION['search_mods'] ? $_SESSION
['search_mods'] : array('subject'=>'subject'));

First do people believe that this is a good thing that this behavior  
is changed (aka is this not a bug)?  Secondly I had two thoughts on  
the sent folder behavior. One is that one could just change the  
default behavior for that folder(s).  Otherwise you could setup a  
preference to choose your default search fields however this may just  
really be able to be a global setting and wouldn't really fix the sent  
folder problem.

Thoughts?

Derek Yarnell
UNIX Systems Administrator
University of Maryland
Institute for Advanced Computer Studies



_______________________________________________
List info: http://lists.roundcube.net/dev/

[Raoul Bhatia [IPAX]]

On 11/09/2009 07:03 AM, Derek Yarnell wrote:
> So one of my users noticed that the search has changed a bunch going  
> from 0.2.x to 0.3.x.  That by default the roll down has only Subject  
> checked (this used to be subject and sender?).  Well that was all fine  
> I added a patch to change the default behavior to subject and sender.  
> However the user also noticed that the Sent folder changed this  
> behavior to search on the recipient in 0.2.x.  Now in 0.3.x this all  
> gets to whatever is set by this line in program/steps/mail/func.inc,

i'd like to see a "subject, from or recipient" filter like in
thunderbird 3.0 (pre).

cheers,
raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc.          email.          r.bhatia@...
Technischer Leiter

IPAX - Aloy Bhatia Hava OEG         web.          http://www.ipax.at
Barawitzkagasse 10/2/2/11           email.            office@...
1190 Wien                           tel.               [phone]
FN 277995t HG Wien                  fax.            [phone]
____________________________________________________________________
_______________________________________________
List info: http://lists.roundcube.net/dev/

[Cor Bosman]

On Nov 9, 2009, at 7:03 AM, Derek Yarnell wrote:

> So one of my users noticed that the search has changed a bunch going
> from 0.2.x to 0.3.x.  That by default the roll down has only Subject
> checked (this used to be subject and sender?).  Well that was all fine
> I added a patch to change the default behavior to subject and sender.

You dont need to patch RC for this. You can use my searchbox plugin. I  
also have a new version that makes it user-configurable but it's  
waiting for a bugfix in rc and probably 0.3.2.

Cor

_______________________________________________
List info: http://lists.roundcube.net/dev/

[Derek Yarnell]

On Nov 9, 2009, at 4:16 AM, Cor Bosman wrote:

> On Nov 9, 2009, at 7:03 AM, Derek Yarnell wrote:
>> So one of my users noticed that the search has changed a bunch going
>> from 0.2.x to 0.3.x.  That by default the roll down has only Subject
>> checked (this used to be subject and sender?).  Well that was all  
>> fine
>> I added a patch to change the default behavior to subject and sender.
>
> You dont need to patch RC for this. You can use my searchbox plugin.  
> I also have a new version that makes it user-configurable but it's  
> waiting for a bugfix in rc and probably 0.3.2.

Thanks, the plugin is good however my question is more why the default  
changed to just the subject too?

It also does not address the change in the Sent folder(s) behavior to  
use subject instead of the recipient by default.  To implement this I  
see that it would require a bit of retooling the search code, and i  
don't know if that could be accomplished in a plugin (sorry still  
reading the API docs).

Derek Yarnell
UNIX Systems Administrator
University of Maryland
Institute for Advanced Computer Studies



_______________________________________________
List info: http://lists.roundcube.net/dev/

[Cor Bosman]

You dont need to patch RC for this. You can use my searchbox plugin. I also have a new version that makes it user-configurable but it's waiting for a bugfix in rc and probably 0.3.2.

Thanks, the plugin is good however my question is more why the default changed to just the subject too?

The default has been the subject for as long as I can remember, no idea why it was changed or if it ever was any different. I agree this less than ideal, thats why I made the plugin. I think sender is almost more important than subject. You could make the default to/from/subject, then it would also give you your 'Sent' searches. Not perfect, but something at least.

Cor

_______________________________________________
List info: http://lists.roundcube.net/dev/