0.5.14 release in two weeks?

[Martin Pitt-4]

Hello all,

there's a fair amount of fixes in hal trunk. I'd like to do a 0.5.14
release in about two weeks, to once again free everyone from carrying
heavy patches. So now would be a good time to send your remaining
patches to the list for review.

Thanks,

Martin
--
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

[Dmitry Torokhov-4]

Hi Matrtin,

On Thu, Nov 05, 2009 at 03:26:03PM +0100, Martin Pitt wrote:
> Hello all,
>
> there's a fair amount of fixes in hal trunk. I'd like to do a 0.5.14
> release in about two weeks, to once again free everyone from carrying
> heavy patches. So now would be a good time to send your remaining
> patches to the list for review.
>

Please consider applying the patch below.

Thanks.

--
Dmitry

From: Dmitry Torokhov <dmitry.torokhov@...>
Date: Mon, 2 Nov 2009 16:59:10 -0800
Subject: [PATCH] Correctly identify touchpads

BTN_TOUCH (as well as ABS_PRESSURE) is used not only by touchpads but
by touchscreens as well. The proper ceck for a touchpad is presence
of BTN_TOOL_FINGER and absence of BTN_TOOL_PEN (the latter to filter
out some tablets that use BTN_TOOL_FINGER).

Tablet matching should be on either BTN_TOOL_PEN or BTN_STULYS.

Signed-off-by: Dmitry Torokhov <dtor@...>
---
 hald/linux/device.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/hald/linux/device.c b/hald/linux/device.c
index 2eca1ef..e7c9d4f 100644
--- a/hald/linux/device.c
+++ b/hald/linux/device.c
@@ -1157,12 +1157,12 @@ input_test_abs (HalDevice *d, const char *sysfs_path)
  {
  num_bits_key = input_str_to_bitmask (s, bitmask_key, sizeof (bitmask_key));
 
- if (test_bit (BTN_STYLUS, bitmask_key)) {
+ if (test_bit (BTN_STYLUS, bitmask_key) || test_bit (BTN_TOOL_PEN, bitmask_key)) {
  hal_device_add_capability (d, "input.tablet");
  goto out;
  }
 
- if (test_bit (BTN_TOUCH, bitmask_key)) {
+ if (test_bit (BTN_TOOL_FINGER, bitmask_key) && !test_bit (BTN_TOOL_PEN, bitmask_key)) {
  hal_device_add_capability (d, "input.touchpad");
  goto out;
  }
@@ -1181,11 +1181,6 @@ input_test_abs (HalDevice *d, const char *sysfs_path)
  goto out;
  }
  }
-
- if (test_bit (ABS_PRESSURE, bitmask_abs)) {
- hal_device_add_capability (d, "input.touchpad");
- goto out;
- }
  }
 out:
  ;
--
1.6.2.5
_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

[Gilles Dartiguelongue-4]

Le jeudi 05 novembre 2009 à 15:26 +0100, Martin Pitt a écrit :

> Hello all,
>
> there's a fair amount of fixes in hal trunk. I'd like to do a 0.5.14
> release in about two weeks, to once again free everyone from carrying
> heavy patches. So now would be a good time to send your remaining
> patches to the list for review.
>
> Thanks,
>
> Martin

Gentoo patches may be found at [1], not all of them are suitable for
upstream use, but you can notice one nice thing, our patch stack is
quite smaller than it used to be.

http://dev.gentoo.org/~dang/files/

--
Gilles Dartiguelongue <gilles.dartiguelongue@...>


_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

[Michael Biebl-2]

2009/11/5 Martin Pitt <martin.pitt@...>:
> Hello all,
>
> there's a fair amount of fixes in hal trunk. I'd like to do a 0.5.14
> release in about two weeks, to once again free everyone from carrying
> heavy patches. So now would be a good time to send your remaining
> patches to the list for review.

Hi Martin,

please also consider the attached patch, which fixes build failures
with binutils-gold


http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=554767

--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[0001-Fix-build-failures-with-binutils-gold.patch]

---

From 3b721bf06162d2c62f69873963076b1daff97799 Mon Sep 17 00:00:00 2001
From: Michael Biebl <biebl@...>
Date: Mon, 9 Nov 2009 16:20:18 +0100
Subject: [PATCH] Fix build failures with binutils-gold

binutils gold is an alternative linker which is more strict and requires
to specify all needed libraries when linking.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=554767
---
 hald/linux/probing/Makefile.am |   12 ++++++------
 tools/Makefile.am              |    2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/hald/linux/probing/Makefile.am b/hald/linux/probing/Makefile.am
index 7440924..ec7f94d 100644
--- a/hald/linux/probing/Makefile.am
+++ b/hald/linux/probing/Makefile.am
@@ -24,17 +24,17 @@ libexec_PROGRAMS = \
 endif
 
 hald_probe_smbios_SOURCES = probe-smbios.c ../../logger.c
-hald_probe_smbios_LDADD = $(top_builddir)/libhal/libhal.la
+hald_probe_smbios_LDADD = $(top_builddir)/libhal/libhal.la @DBUS_LIBS@
 
 hald_probe_printer_SOURCES = probe-printer.c ../../logger.c
 hald_probe_printer_LDADD = $(top_builddir)/libhal/libhal.la @GLIB_LIBS@
 #TODO : get rid of glib in hald_probe_printer
 
 hald_probe_input_SOURCES = probe-input.c ../../logger.c
-hald_probe_input_LDADD = $(top_builddir)/libhal/libhal.la
+hald_probe_input_LDADD = $(top_builddir)/libhal/libhal.la @DBUS_LIBS@
 
 hald_probe_hiddev_SOURCES = probe-hiddev.c ../../logger.c
-hald_probe_hiddev_LDADD = $(top_builddir)/libhal/libhal.la
+hald_probe_hiddev_LDADD = $(top_builddir)/libhal/libhal.la @DBUS_LIBS@
 
 hald_probe_serial_SOURCES = probe-serial.c ../../logger.c
 hald_probe_serial_LDADD = $(top_builddir)/libhal/libhal.la
@@ -48,11 +48,11 @@ hald_probe_volume_SOURCES = probe-volume.c linux_dvd_rw_utils.c ../../logger.c
 hald_probe_volume_LDADD = $(top_builddir)/libhal/libhal.la $(top_builddir)/partutil/libpartutil.la @GLIB_LIBS@ @BLKID_LIBS@
 
 hald_probe_ieee1394_unit_SOURCES = probe-ieee1394-unit.c ../../logger.c
-hald_probe_ieee1394_unit_LDADD = $(top_builddir)/libhal/libhal.la
+hald_probe_ieee1394_unit_LDADD = $(top_builddir)/libhal/libhal.la @DBUS_LIBS@
 
 hald_probe_net_bluetooth_SOURCES = probe-net-bluetooth.c ../../logger.c
-hald_probe_net_bluetooth_LDADD = $(top_builddir)/libhal/libhal.la
+hald_probe_net_bluetooth_LDADD = $(top_builddir)/libhal/libhal.la @DBUS_LIBS@
 
 hald_probe_video4linux_SOURCES = probe-video4linux.c ../../logger.c
-hald_probe_video4linux_LDADD = $(top_builddir)/libhal/libhal.la
+hald_probe_video4linux_LDADD = $(top_builddir)/libhal/libhal.la @DBUS_LIBS@
 
diff --git a/tools/Makefile.am b/tools/Makefile.am
index 0b99d35..e7f029d 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -91,7 +91,7 @@ endif #HAVE_GPERF
 
 hal_setup_keymap_SOURCES = hal-setup-keymap.c
 nodist_hal_setup_keymap_SOURCES = hal-setup-keymap-hash-name.h
-hal_setup_keymap_LDADD = $(top_builddir)/libhal/libhal.la
+hal_setup_keymap_LDADD = $(top_builddir)/libhal/libhal.la @DBUS_LIBS@
 
 endif #BUILD_KEYMAPS
 
--
1.6.5.2

---

_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

[Martin Pitt-4]

Hello Michael,

Michael Biebl [2009-11-09 16:27 +0100]:
> please also consider the attached patch, which fixes build failures
> with binutils-gold

Thank you! Applied.

Martin
--
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

[Dmitry Torokhov-4]

On Saturday 07 November 2009 01:46:57 pm Gilles Dartiguelongue wrote:

> Le jeudi 05 novembre 2009 à 15:26 +0100, Martin Pitt a écrit :
> > Hello all,
> >
> > there's a fair amount of fixes in hal trunk. I'd like to do a 0.5.14
> > release in about two weeks, to once again free everyone from carrying
> > heavy patches. So now would be a good time to send your remaining
> > patches to the list for review.
> >
> > Thanks,
> >
> > Martin
>
> Gentoo patches may be found at [1], not all of them are suitable for
> upstream use, but you can notice one nice thing, our patch stack is
> quite smaller than it used to be.
>
> http://dev.gentoo.org/~dang/files/

Why do you force evdev driver for touchpads instead of synaptics?

--
Dmitry
_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

[Rémi Cardona-3]

Le 09/11/2009 18:42, Dmitry Torokhov a écrit :
> Why do you force evdev driver for touchpads instead of synaptics?

Because evdev is part of our default X install while synaptics isn't.

Feel free to ignore that patch :)

Rémi
_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

[Martin Pitt-4]

Helly Dmitry,

Dmitry Torokhov [2009-11-05 23:47 -0800]:
> BTN_TOUCH (as well as ABS_PRESSURE) is used not only by touchpads but
> by touchscreens as well. The proper ceck for a touchpad is presence
> of BTN_TOOL_FINGER and absence of BTN_TOOL_PEN (the latter to filter
> out some tablets that use BTN_TOOL_FINGER).
>
> Tablet matching should be on either BTN_TOOL_PEN or BTN_STULYS.

Thanks! This seems to work well, applied.

Martin

--
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)


_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal