2.6.30 dom0 Xen patches

[dbaxps]

Two replacements CONFIG_SPARSE_IRQ by CONFIG_GENERIC_HARDIRQS

60035_xen3-patch-2.6.29.patch1 line 11568

+#ifdef CONFIG_SPARSE_IRQ
+ irq_to_desc(irq)->kstat_irqs[cpu] = 0;
+#else
kstat_cpu(cpu).irqs[irq] = 0;

60036_xen3-patch-2.6.30.patch1 line 18283

+#ifdef CONFIG_SPARSE_IRQ
+int __init arch_probe_nr_irqs(void)
+{
+ int nr;
+
+ if (nr_irqs > (NR_VECTORS * nr_cpu_ids))
+ nr_irqs = NR_VECTORS * nr_cpu_ids;

in 2.6.30 Andy's patch set allows to build working xenified 2.6.30.1 kernel
been tested on Q9550,C2D E8400 boxes.

Boris.

--- On Fri, 7/10/09, Jan Beulich <JBeulich@...> wrote:

From: Jan Beulich <JBeulich@...>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
To: "Andrew Lyon" <andrew.lyon@...>, "Boris Derzhavets" <bderzhavets@...>
Cc: "Xen-devel" <xen-devel@...>
Date: Friday, July 10, 2009, 8:52 AM

>>> Boris Derzhavets <bderzhavets@...> 10.07.09 14:40 >>>
>I still believe in 60035_xen3-patch-2.6.29.patch1 line 11568 
>
>+#ifdef CONFIG_SPARSE_IRQ
>+                       irq_to_desc(irq)->kstat_irqs[cpu] = 0;
>+#else
>                        kstat_cpu(cpu).irqs[irq] = 0;
>
>causes a problem.

Sure - that's what I keep telling you: This needs to be replaced by
CONFIG_GENERIC_HARDIRQS in the .30 patch.

Oh, I think I now understand what you first did: You apparently replaced
the *other* +#ifdef CONFIG_SPARSE_IRQ in the .30 patch - that's wrong.
You need to make the .30 patch *additionally* make the change indicated
above. (Of course, you could do that in the .29 patch right away, but then
your .29 patch will no longer properly reflect what's needed for that version
to build and/or work right.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[dbaxps]

Building Xen 3.4.1 Dom0 via xenified 2.6.30.1 kernel on top Ubuntu 9.04 Server
http://bderzhavets.wordpress.com/2009/07/07/building-xenified-2-6-30-1-kernel-via-xen-patches-2-6-30-2-tar-bz2/

[Kris Shannon-3]

2009/7/2 Andrew Lyon <andrew.lyon@...>:

> I have rebased the xen-patches from opensuse
> kernel-source-2.6.30-50.1.src.rpm so that they can be applied to
> vanilla 2.6.30, the usual patches tarball and gentoo ebuild are
> available at http://code.google.com/p/gentoo-xen-kernel/downloads/list
> , if you are not using Gentoo simply apply the patches in numeric
> order.
>
> Some notes:
>
> both dom0 and domU require CONFIG_SPARSE_IRQ=y and CONFIG_HOTPLUG=y
> 64 bit dom0/domU requires CONFIG_IA32_EMULATION=y
>
> Andy

The error:
drivers/xen/core/evtchn.c: In function 'unbind_from_irq':
drivers/xen/core/evtchn.c:641: error: 'struct kernel_stat' has no
member named 'irqs'

when CONFIG_SPARSE_IRQ is not set is due to a missing #ifdef change a couple
of lines earlier.  The commit d52a61c04c6c0814ca270a088feedb126436598e altered
the kernel_stat.irqs dependency to CONFIG_GENERIC_HARDIRQS.

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[dbaxps]

I  made two replacements
CONFIG_SPARSE_IRQ by CONFIG_GENERIC_HARDIRQS.

****************************************************
In 60035_xen3-patch-2.6.29.patch1 line 11568
****************************************************
+#ifdef CONFIG_SPARSE_IRQ
+ irq_to_desc(irq)->kstat_irqs[cpu] = 0;
+#else
kstat_cpu(cpu).irqs[irq] = 0;
****************************************************
In 60036_xen3-patch-2.6.30.patch1 line 18283
****************************************************
+#ifdef CONFIG_SPARSE_IRQ
+int __init arch_probe_nr_irqs(void)
+{
+ int nr;
+
+ if (nr_irqs > (NR_VECTORS * nr_cpu_ids))
+ nr_irqs = NR_VECTORS * nr_cpu_ids;

To fix this issue. But, i don't know how to rebuild Andy's patch set
based on your commit.

Boris.
P.S.  I haven't heard from Andy for a while.

--- On Thu, 7/16/09, Kris Shannon <kris@...> wrote:

From: Kris Shannon <kris@...>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
To: "Andrew Lyon" <andrew.lyon@...>
Cc: "Xen-devel" <xen-devel@...>
Date: Thursday, July 16, 2009, 6:56 PM

2009/7/2 Andrew Lyon <andrew.lyon@...>:

> I have rebased the xen-patches from opensuse
> kernel-source-2.6.30-50.1.src.rpm so that they can be applied to
> vanilla 2.6.30, the usual patches tarball and gentoo ebuild are
> available at http://code.google.com/p/gentoo-xen-kernel/downloads/list
> , if you are not using Gentoo simply apply the patches in numeric
> order.
>
> Some notes:
>
> both dom0 and domU require CONFIG_SPARSE_IRQ=y and CONFIG_HOTPLUG=y
> 64 bit dom0/domU requires CONFIG_IA32_EMULATION=y
>
> Andy

The error:
drivers/xen/core/evtchn.c: In function 'unbind_from_irq':
drivers/xen/core/evtchn.c:641: error: 'struct kernel_stat' has no
member named 'irqs'

when CONFIG_SPARSE_IRQ is not set is due to a missing #ifdef change a couple
of lines earlier.  The commit d52a61c04c6c0814ca270a088feedb126436598e altered
the kernel_stat.irqs dependency to CONFIG_GENERIC_HARDIRQS.

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[Pasi Kärkkäinen]

On Fri, Jul 17, 2009 at 12:11:18AM -0700, Boris Derzhavets wrote:

>
> I  made two replacements
> CONFIG_SPARSE_IRQ by CONFIG_GENERIC_HARDIRQS.
>
> ****************************************************
> In 60035_xen3-patch-2.6.29.patch1 line 11568
> ****************************************************
> +#ifdef CONFIG_SPARSE_IRQ
> + irq_to_desc(irq)->kstat_irqs[cpu] = 0;
> +#else
> kstat_cpu(cpu).irqs[irq] = 0;
> ****************************************************
> In 60036_xen3-patch-2.6.30.patch1 line 18283
> ****************************************************
> +#ifdef CONFIG_SPARSE_IRQ
> +int __init arch_probe_nr_irqs(void)
> +{
> + int nr;
> +
> + if (nr_irqs > (NR_VECTORS * nr_cpu_ids))
> + nr_irqs = NR_VECTORS * nr_cpu_ids;
>
> To fix this issue. But, i don't know how to rebuild Andy's patch set
> based on your commit.
>
> Boris.
> P.S.  I haven't heard from Andy for a while.
>

Boris: Just generate a new (additional) patch that fixes the problem with
CONFIG_SPARSE_IRQ. Much easier for other people to apply it then, and get it
right.. also no need to explain many times what to change and where..

-- Pasi

> --- On Thu, 7/16/09, Kris Shannon <kris@...> wrote:
>
> From: Kris Shannon <kris@...>
> Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
> To: "Andrew Lyon" <andrew.lyon@...>
> Cc: "Xen-devel" <xen-devel@...>
> Date: Thursday, July 16, 2009, 6:56 PM
>
> 2009/7/2 Andrew Lyon <andrew.lyon@...>:
> > I have rebased the xen-patches from opensuse
> > kernel-source-2.6.30-50.1.src.rpm so that they can be applied to
> > vanilla 2.6.30, the usual patches tarball and gentoo ebuild are
> > available at http://code.google.com/p/gentoo-xen-kernel/downloads/list
> > , if you are not using Gentoo simply apply the patches in numeric
> > order.
> >
> > Some notes:
> >
> > both dom0 and domU require CONFIG_SPARSE_IRQ=y and CONFIG_HOTPLUG=y
> > 64 bit dom0/domU requires CONFIG_IA32_EMULATION=y
> >
> > Andy
>
> The error:
> drivers/xen/core/evtchn.c: In function 'unbind_from_irq':
> drivers/xen/core/evtchn.c:641: error: 'struct kernel_stat' has no
> member named 'irqs'
>
> when CONFIG_SPARSE_IRQ is not set is due to a missing #ifdef change a couple
> of lines earlier.  The commit d52a61c04c6c0814ca270a088feedb126436598e altered
> the kernel_stat.irqs dependency to CONFIG_GENERIC_HARDIRQS.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel
>
>
>
>      
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[dbaxps]

Pasi,

I understand it, but i cannot rebuild Andy's patch set.
I am not aware of  what the procedure is, but suspect it's not
too much complicated.
If commit was mentioned, it says to me only that some Git Repo is a source.
Nothing else. If you can , please , do it.

Boris


--- On Fri, 7/17/09, Pasi Kärkkäinen <pasik@...> wrote:

From: Pasi Kärkkäinen <pasik@...>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
To: "Boris Derzhavets" <bderzhavets@...>
Cc: "Andrew Lyon" <andrew.lyon@...>, "Xen-devel" <xen-devel@...>, "Kris Shannon" <kris@...>
Date: Friday, July 17, 2009, 6:06 AM

On Fri, Jul 17, 2009 at 12:11:18AM -0700, Boris Derzhavets wrote:

>
> I  made two replacements
> CONFIG_SPARSE_IRQ by CONFIG_GENERIC_HARDIRQS.
>
> ****************************************************
> In 60035_xen3-patch-2.6.29.patch1 line 11568
> ****************************************************
> +#ifdef CONFIG_SPARSE_IRQ
> + irq_to_desc(irq)->kstat_irqs[cpu] = 0;
> +#else
> kstat_cpu(cpu).irqs[irq] = 0;
> ****************************************************
> In 60036_xen3-patch-2.6.30.patch1 line 18283
> ****************************************************
> +#ifdef CONFIG_SPARSE_IRQ
> +int __init arch_probe_nr_irqs(void)
> +{
> + int nr;
> +
> + if (nr_irqs > (NR_VECTORS * nr_cpu_ids))
> + nr_irqs = NR_VECTORS * nr_cpu_ids;
>
> To fix this issue. But, i don't know how to rebuild Andy's patch set
> based on your commit.
>
> Boris.
> P.S.  I haven't heard from Andy for a while.
>

Boris: Just generate a new (additional) patch that fixes the problem with
CONFIG_SPARSE_IRQ. Much easier for other people to apply it then, and get it
right.. also no need to explain many times what to change and where..

-- Pasi

> --- On Thu, 7/16/09, Kris Shannon <kris@...> wrote:
>
> From: Kris Shannon <kris@...>
> Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
> To: "Andrew Lyon" <andrew.lyon@...>
> Cc: "Xen-devel" <xen-devel@...>
> Date: Thursday, July 16, 2009, 6:56 PM
>
> 2009/7/2 Andrew Lyon <andrew.lyon@...>:
> > I have rebased the xen-patches from opensuse
> > kernel-source-2.6.30-50.1.src.rpm so that they can be applied to
> > vanilla 2.6.30, the usual patches tarball and gentoo ebuild are
> > available at http://code.google.com/p/gentoo-xen-kernel/downloads/list
> > , if you are not using Gentoo simply apply the patches in numeric
> > order.
> >
> > Some notes:
> >
> > both dom0 and domU require CONFIG_SPARSE_IRQ=y and CONFIG_HOTPLUG=y
> > 64 bit dom0/domU requires CONFIG_IA32_EMULATION=y
> >
> > Andy
>
> The error:
> drivers/xen/core/evtchn.c: In function 'unbind_from_irq':
> drivers/xen/core/evtchn.c:641: error: 'struct kernel_stat' has no
> member named 'irqs'
>
> when CONFIG_SPARSE_IRQ is not set is due to a missing #ifdef change a couple
> of lines earlier.  The commit d52a61c04c6c0814ca270a088feedb126436598e altered
> the kernel_stat.irqs dependency to CONFIG_GENERIC_HARDIRQS.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel
>
>
>
>       
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[dbaxps]

Sorry, i've got your point - just one more *.patch1 file.
That's it.

Thanks.
Boris.

--- On Fri, 7/17/09, Pasi Kärkkäinen <pasik@...> wrote:

From: Pasi Kärkkäinen <pasik@...>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
To: "Boris Derzhavets" <bderzhavets@...>
Cc: "Andrew Lyon" <andrew.lyon@...>, "Xen-devel" <xen-devel@...>, "Kris Shannon" <kris@...>
Date: Friday, July 17, 2009, 6:06 AM

On Fri, Jul 17, 2009 at 12:11:18AM -0700, Boris Derzhavets wrote:

>
> I  made two replacements
> CONFIG_SPARSE_IRQ by CONFIG_GENERIC_HARDIRQS.
>
> ****************************************************
> In 60035_xen3-patch-2.6.29.patch1 line 11568
> ****************************************************
> +#ifdef CONFIG_SPARSE_IRQ
> + irq_to_desc(irq)->kstat_irqs[cpu] = 0;
> +#else
> kstat_cpu(cpu).irqs[irq] = 0;
> ****************************************************
> In 60036_xen3-patch-2.6.30.patch1 line 18283
> ****************************************************
> +#ifdef CONFIG_SPARSE_IRQ
> +int __init arch_probe_nr_irqs(void)
> +{
> + int nr;
> +
> + if (nr_irqs > (NR_VECTORS * nr_cpu_ids))
> + nr_irqs = NR_VECTORS * nr_cpu_ids;
>
> To fix this issue. But, i don't know how to rebuild Andy's patch set
> based on your commit.
>
> Boris.
> P.S.  I haven't heard from Andy for a while.
>

Boris: Just generate a new (additional) patch that fixes the problem with
CONFIG_SPARSE_IRQ. Much easier for other people to apply it then, and get it
right.. also no need to explain many times what to change and where..

-- Pasi

> --- On Thu, 7/16/09, Kris Shannon <kris@...> wrote:
>
> From: Kris Shannon <kris@...>
> Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
> To: "Andrew Lyon" <andrew.lyon@...>
> Cc: "Xen-devel" <xen-devel@...>
> Date: Thursday, July 16, 2009, 6:56 PM
>
> 2009/7/2 Andrew Lyon <andrew.lyon@...>:
> > I have rebased the xen-patches from opensuse
> > kernel-source-2.6.30-50.1.src.rpm so that they can be applied to
> > vanilla 2.6.30, the usual patches tarball and gentoo ebuild are
> > available at http://code.google.com/p/gentoo-xen-kernel/downloads/list
> > , if you are not using Gentoo simply apply the patches in numeric
> > order.
> >
> > Some notes:
> >
> > both dom0 and domU require CONFIG_SPARSE_IRQ=y and CONFIG_HOTPLUG=y
> > 64 bit dom0/domU requires CONFIG_IA32_EMULATION=y
> >
> > Andy
>
> The error:
> drivers/xen/core/evtchn.c: In function 'unbind_from_irq':
> drivers/xen/core/evtchn.c:641: error: 'struct kernel_stat' has no
> member named 'irqs'
>
> when CONFIG_SPARSE_IRQ is not set is due to a missing #ifdef change a couple
> of lines earlier.  The commit d52a61c04c6c0814ca270a088feedb126436598e altered
> the kernel_stat.irqs dependency to CONFIG_GENERIC_HARDIRQS.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel
>
>
>
>       
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[Pasi Kärkkäinen]

On Fri, Jul 17, 2009 at 03:19:46AM -0700, Boris Derzhavets wrote:
> Sorry, i've got your point - just one more *.patch1 file.
> That's it.
>

Yep, that's what I meant :)

Then you can just attach the additional patch to an email and Andy can then
later add it as a part of his patchset..

-- Pasi

> Thanks.
> Boris.
>
> --- On Fri, 7/17/09, Pasi Kärkkäinen <pasik@...> wrote:
>
> From: Pasi Kärkkäinen <pasik@...>
> Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
> To: "Boris Derzhavets" <bderzhavets@...>
> Cc: "Andrew Lyon" <andrew.lyon@...>, "Xen-devel" <xen-devel@...>, "Kris Shannon" <kris@...>
> Date: Friday, July 17, 2009, 6:06 AM
>
> On Fri, Jul 17, 2009 at 12:11:18AM -0700, Boris Derzhavets wrote:
> >
> > I  made two replacements
> > CONFIG_SPARSE_IRQ by CONFIG_GENERIC_HARDIRQS.
> >
> > ****************************************************
> > In 60035_xen3-patch-2.6.29.patch1 line 11568
> > ****************************************************
> > +#ifdef CONFIG_SPARSE_IRQ
> > + irq_to_desc(irq)->kstat_irqs[cpu] = 0;
> > +#else
> > kstat_cpu(cpu).irqs[irq] = 0;
> > ****************************************************
> > In 60036_xen3-patch-2.6.30.patch1 line 18283
> > ****************************************************
> > +#ifdef CONFIG_SPARSE_IRQ
> > +int __init arch_probe_nr_irqs(void)
> > +{
> > + int nr;
> > +
> > + if (nr_irqs > (NR_VECTORS * nr_cpu_ids))
> > + nr_irqs = NR_VECTORS * nr_cpu_ids;
> >
> > To fix this issue. But, i don't know how to rebuild Andy's patch set
> > based on your commit.
> >
> > Boris.
> > P.S.  I haven't heard from Andy for a while.
> >
>
> Boris: Just generate a new (additional) patch that fixes the problem with
> CONFIG_SPARSE_IRQ. Much easier for other people to apply it then, and get it
> right.. also no need to explain many times what to change and where..
>
> -- Pasi
>
> > --- On Thu, 7/16/09, Kris Shannon <kris@...> wrote:
> >
> > From: Kris Shannon <kris@...>
> > Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
> > To: "Andrew Lyon" <andrew.lyon@...>
> > Cc: "Xen-devel" <xen-devel@...>
> > Date: Thursday, July 16, 2009, 6:56 PM
> >
> > 2009/7/2 Andrew Lyon <andrew.lyon@...>:
> > > I have rebased the xen-patches from opensuse
> > > kernel-source-2.6.30-50.1.src.rpm so that they can be applied to
> > > vanilla 2.6.30, the usual patches tarball and gentoo ebuild are
> > > available at http://code.google.com/p/gentoo-xen-kernel/downloads/list
> > > , if you are not using Gentoo simply apply the patches in numeric
> > > order.
> > >
> > > Some notes:
> > >
> > > both dom0 and domU require CONFIG_SPARSE_IRQ=y and CONFIG_HOTPLUG=y
> > > 64 bit dom0/domU requires CONFIG_IA32_EMULATION=y
> > >
> > > Andy
> >
> > The error:
> > drivers/xen/core/evtchn.c: In function 'unbind_from_irq':
> > drivers/xen/core/evtchn.c:641: error: 'struct kernel_stat' has no
> > member named 'irqs'
> >
> > when CONFIG_SPARSE_IRQ is not set is due to a missing #ifdef change a couple
> > of lines earlier.  The commit d52a61c04c6c0814ca270a088feedb126436598e altered
> > the kernel_stat.irqs dependency to CONFIG_GENERIC_HARDIRQS.
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@...
> > http://lists.xensource.com/xen-devel
> >
> >
> >
> >       
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@...
> > http://lists.xensource.com/xen-devel
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel
>
>
>
>      

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[dbaxps]

Fix patch set before applying.

Boris.

--- On Fri, 7/17/09, Pasi Kärkkäinen <pasik@...> wrote:

From: Pasi Kärkkäinen <pasik@...>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
To: "Boris Derzhavets" <bderzhavets@...>
Cc: "Andrew Lyon" <andrew.lyon@...>, "Xen-devel" <xen-devel@...>, "Kris Shannon" <kris@...>
Date: Friday, July 17, 2009, 6:38 AM

On Fri, Jul 17, 2009 at 03:19:46AM -0700, Boris Derzhavets wrote:
> Sorry, i've got your point - just one more *.patch1 file.
> That's it.
>

Yep, that's what I meant :)

Then you can just attach the additional patch to an email and Andy can then
later add it as a part of his patchset..

-- Pasi

> Thanks.
> Boris.
>
> --- On Fri, 7/17/09, Pasi Kärkkäinen <pasik@...> wrote:
>
> From: Pasi Kärkkäinen <pasik@...>
> Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
> To: "Boris Derzhavets" <bderzhavets@...>
> Cc: "Andrew Lyon" <andrew.lyon@...>, "Xen-devel" <xen-devel@...>, "Kris Shannon" <kris@...>
> Date: Friday, July 17, 2009, 6:06 AM
>
> On Fri, Jul 17, 2009 at 12:11:18AM -0700, Boris Derzhavets wrote:
> >
> > I  made two replacements
> > CONFIG_SPARSE_IRQ by CONFIG_GENERIC_HARDIRQS.
> >
> > ****************************************************
> > In 60035_xen3-patch-2.6.29.patch1 line 11568
> > ****************************************************
> > +#ifdef CONFIG_SPARSE_IRQ
> > + irq_to_desc(irq)->kstat_irqs[cpu] = 0;
> > +#else
> > kstat_cpu(cpu).irqs[irq] = 0;
> > ****************************************************
> > In 60036_xen3-patch-2.6.30.patch1 line 18283
> > ****************************************************
> > +#ifdef CONFIG_SPARSE_IRQ
> > +int __init arch_probe_nr_irqs(void)
> > +{
> > + int nr;
> > +
> > + if (nr_irqs > (NR_VECTORS * nr_cpu_ids))
> > + nr_irqs = NR_VECTORS * nr_cpu_ids;
> >
> > To fix this issue. But, i don't know how to rebuild Andy's patch set
> > based on your commit.
> >
> > Boris.
> > P.S.  I haven't heard from Andy for a while.
> >
>
> Boris: Just generate a new (additional) patch that fixes the problem with
> CONFIG_SPARSE_IRQ. Much easier for other people to apply it then, and get it
> right.. also no need to explain many times what to change and where..
>
> -- Pasi
>
> > --- On Thu, 7/16/09, Kris Shannon <kris@...> wrote:
> >
> > From: Kris Shannon <kris@...>
> > Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
> > To: "Andrew Lyon" <andrew.lyon@...>
> > Cc: "Xen-devel" <xen-devel@...>
> > Date: Thursday, July 16, 2009, 6:56 PM
> >
> > 2009/7/2 Andrew Lyon <andrew.lyon@...>:
> > > I have rebased the xen-patches from opensuse
> > > kernel-source-2.6.30-50.1.src.rpm so that they can be applied to
> > > vanilla 2.6.30, the usual patches tarball and gentoo ebuild are
> > > available at http://code.google.com/p/gentoo-xen-kernel/downloads/list
> > > , if you are not using Gentoo simply apply the patches in numeric
> > > order.
> > >
> > > Some notes:
> > >
> > > both dom0 and domU require CONFIG_SPARSE_IRQ=y and CONFIG_HOTPLUG=y
> > > 64 bit dom0/domU requires CONFIG_IA32_EMULATION=y
> > >
> > > Andy
> >
> > The error:
> > drivers/xen/core/evtchn.c: In function 'unbind_from_irq':
> > drivers/xen/core/evtchn.c:641: error: 'struct kernel_stat' has no
> > member named 'irqs'
> >
> > when CONFIG_SPARSE_IRQ is not set is due to a missing #ifdef change a couple
> > of lines earlier.  The commit d52a61c04c6c0814ca270a088feedb126436598e altered
> > the kernel_stat.irqs dependency to CONFIG_GENERIC_HARDIRQS.
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@...
> > http://lists.xensource.com/xen-devel
> >
> >
> >
> >       
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@...
> > http://lists.xensource.com/xen-devel
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel
>
>
>
>       

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[tip-bot for Jan Beulich]

>>> Boris Derzhavets <bderzhavets@...> 17.07.09 14:57 >>>
>Fix patch set before applying.

The second hunk is at best bogus: arch_probe_nr_irqs() only gets
referenced from a code section that's inside CONFIG_SPARSE_IRQ, and
when that option is selected, you'll have a duplicate symbol definition
issue between the arch_probe_nr_irqs() in arch/x86/kernel/apic/io_apic.c
and the one in drivers/xen/core/evtchn.c. Additionally, simply enabling
the function in arch/x86/kernel/apic/io_apic.c does not do, as it may
leave you with insufficient space for dynamic IRQs (which is why I
cloned it into a properly working function in drivers/xen/core/evtchn.c).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[Andrew Lyon]

> As I don't expect to get the stuff I have pushed out before our tree gets
> switched to 2.6.31-rc, I'll attach the whole patch set as it is after fixing the
> !ia32-emulation problem you pointed out.

I have rebased the 2.6.30 Xen patches
(xen-patches-2.6.30-20090703.tb2) that Jan Beulich was kind enough to
send to me before openSUSE switch their tree to 2.6.31-git etc, the
new files are available at
http://code.google.com/p/gentoo-xen-kernel/downloads/list

xen-sources-2.6.30-r2.ebuild
xen-patches-2.6.30-3.tar.bz2

Non-Gentoo users can simply apply the patches to 2.6.30.1 in numeric order.

As usual I did not include patches that are for backwards
compatibility, suse specific features, experimental features (eg
tmem), or that require patches to Xen itself.

Note that James Harper's gplpv driver for networking (xennet.sys) does
not work with 2.6.30, he has given me a patch which works around the
problem but you will need to recompile the drivers yourself, the patch
is:

diff -r 36221c314d54 xennet/xennet_common.c
--- a/xennet/xennet_common.c    Wed Jul 15 20:05:36 2009 +1000
+++ b/xennet/xennet_common.c    Fri Jul 17 23:53:12 2009 +1000
@@ -181,6 +181,12 @@
      return PARSE_TOO_SMALL;
          }
            }
            +
            +  if ((ULONG)XN_HDR_SIZE + pi->ip4_length > pi->total_length)
            +  {
            +    KdPrint((__DRIVER_NAME "     XN_HDR_SIZE + ip4_length
(%d) > total_length (%d)\n", XN_HDR_SIZE + pi->ip4_length,
pi->total_length));
            +    return PARSE_UNKNOWN_TYPE;
            +  }

              pi->tcp_length = pi->ip4_length - pi->ip4_header_length
- pi->tcp_header_length;
                pi->tcp_remaining = pi->tcp_length;


Andy

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[dbaxps]

  Seems to work nice Solaris 10 U7 (64-bit) HVM DomU  loads
pretty fast  with PV drivers at Xen 3.4.1-rc7 Ubuntu 9.04 Dom0 with
2.6.30.1 xenified via rebased patch set V.3
 
  I believe V.2 should be considered as deprecated due to recent message from Jan Beulich :-

>>> Boris Derzhavets <bderzhavets@...> 17.07.09 14:57 >>>
>Fix patch set before applying.

The second hunk is at best bogus: arch_probe_nr_irqs() only gets
referenced from a code section that's inside CONFIG_SPARSE_IRQ, and
when that option is selected, you'll have a duplicate symbol definition
issue between the arch_probe_nr_irqs() in arch/x86/kernel/apic/io_apic.c
and the one in drivers/xen/core/evtchn.c. Additionally, simply enabling
the function in arch/x86/kernel/apic/io_apic.c does not do, as it may
leave you with insufficient space for dynamic IRQs (which is why I
cloned it into a properly working function in drivers/xen/core/evtchn.c).

Jan

--- On Fri, 7/17/09, Andrew Lyon <andrew.lyon@...> wrote:

From: Andrew Lyon <andrew.lyon@...>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
To: "Xen-devel" <xen-devel@...>
Cc: "Jan Beulich" <JBeulich@...>
Date: Friday, July 17, 2009, 2:11 PM

> As I don't expect to get the stuff I have pushed out before our tree gets
> switched to 2.6.31-rc, I'll attach the whole patch set as it is after fixing the
> !ia32-emulation problem you pointed out.

I have rebased the 2.6.30 Xen patches
(xen-patches-2.6.30-20090703.tb2) that Jan Beulich was kind enough to
send to me before openSUSE switch their tree to 2.6.31-git etc, the
new files are available at
http://code.google.com/p/gentoo-xen-kernel/downloads/list

xen-sources-2.6.30-r2.ebuild
xen-patches-2.6.30-3.tar.bz2

Non-Gentoo users can simply apply the patches to 2.6.30.1 in numeric order.

As usual I did not include patches that are for backwards
compatibility, suse specific features, experimental features (eg
tmem), or that require patches to Xen itself.

Note that James Harper's gplpv driver for networking (xennet.sys) does
not work with 2.6.30, he has given me a patch which works around the
problem but you will need to recompile the drivers yourself, the patch
is:

diff -r 36221c314d54 xennet/xennet_common.c
--- a/xennet/xennet_common.c    Wed Jul 15 20:05:36 2009 +1000
+++ b/xennet/xennet_common.c    Fri Jul 17 23:53:12 2009 +1000
@@ -181,6 +181,12 @@
      return PARSE_TOO_SMALL;
          }
            }
            +
            +  if ((ULONG)XN_HDR_SIZE + pi->ip4_length > pi->total_length)
            +  {
            +    KdPrint((__DRIVER_NAME "     XN_HDR_SIZE + ip4_length
(%d) > total_length (%d)\n", XN_HDR_SIZE + pi->ip4_length,
pi->total_length));
            +    return PARSE_UNKNOWN_TYPE;
            +  }

              pi->tcp_length = pi->ip4_length - pi->ip4_header_length
- pi->tcp_header_length;
                pi->tcp_remaining = pi->tcp_length;


Andy

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel

[Jun Koi]

On Sat, Jul 18, 2009 at 6:14 AM, Boris Derzhavets<bderzhavets@...> wrote:
>   Seems to work nice Solaris 10 U7 (64-bit) HVM DomU  loads
> pretty fast  with PV drivers at Xen 3.4.1-rc7 Ubuntu 9.04 Dom0 with
> 2.6.30.1 xenified via rebased patch set V.3
>
>   I believe V.2 should be considered as deprecated due to recent message
> from Jan Beulich :-
>

So where to get the final perfect patch? I would like to try that with 3.4.1

Thanks,
J

>>>> Boris Derzhavets <bderzhavets@...> 17.07.09 14:57 >>>
>>Fix patch set before applying.
>
> The second hunk is at best bogus: arch_probe_nr_irqs() only gets
> referenced from a code section that's inside CONFIG_SPARSE_IRQ, and
> when that option is selected, you'll have a duplicate symbol definition
> issue between the arch_probe_nr_irqs() in arch/x86/kernel/apic/io_apic.c
> and the one in drivers/xen/core/evtchn.c. Additionally, simply enabling
> the function in arch/x86/kernel/apic/io_apic.c does not do, as it may
> leave you with insufficient space for dynamic IRQs (which is why I
> cloned it into a properly working function in drivers/xen/core/evtchn.c).
>
> Jan
>
> --- On Fri, 7/17/09, Andrew Lyon <andrew.lyon@...> wrote:
>
> From: Andrew Lyon <andrew.lyon@...>
> Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
> To: "Xen-devel" <xen-devel@...>
> Cc: "Jan Beulich" <JBeulich@...>
> Date: Friday, July 17, 2009, 2:11 PM
>
>> As I don't expect to get the stuff I have pushed out before our tree gets
>> switched to 2.6.31-rc, I'll attach the whole patch set as it is after
>> fixing the
>> !ia32-emulation problem you pointed out.
>
> I have rebased the 2.6.30 Xen patches
> (xen-patches-2.6.30-20090703.tb2) that Jan Beulich was kind enough to
> send to me before openSUSE switch their tree to 2.6.31-git etc, the
> new files are available at
> http://code.google.com/p/gentoo-xen-kernel/downloads/list
>
> xen-sources-2.6.30-r2.ebuild
> xen-patches-2.6.30-3.tar.bz2
>
> Non-Gentoo users can simply apply the patches to 2.6.30.1 in numeric order.
>
> As usual I did not include patches that are for backwards
> compatibility, suse specific features, experimental features (eg
> tmem), or that require patches to Xen itself.
>
> Note that James Harper's gplpv driver for networking (xennet.sys) does
> not work with 2.6.30, he has given me a patch which works around the
> problem but you will need to recompile the drivers yourself, the patch
> is:
>
> diff -r 36221c314d54 xennet/xennet_common.c
> --- a/xennet/xennet_common.c    Wed Jul 15 20:05:36 2009 +1000
> +++ b/xennet/xennet_common.c    Fri Jul 17 23:53:12 2009 +1000
> @@ -181,6 +181,12 @@
>       return PARSE_TOO_SMALL;
>           }
>             }
>             +
>             +  if ((ULONG)XN_HDR_SIZE + pi->ip4_length > pi->total_length)
>             +  {
>             +    KdPrint((__DRIVER_NAME "     XN_HDR_SIZE + ip4_length
> (%d) > total_length (%d)\n", XN_HDR_SIZE + pi->ip4_length,
> pi->total_length));
>             +    return PARSE_UNKNOWN_TYPE;
>             +  }
>
>               pi->tcp_length = pi->ip4_length - pi->ip4_header_length
> - pi->tcp_header_length;
>                 pi->tcp_remaining = pi->tcp_length;
>
>
> Andy
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...
> http://lists.xensource.com/xen-devel
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@...
http://lists.xensource.com/xen-devel