2.6.34-rc? + appletouch + Regression

[Elimar Riesebieter]

Hi all,

is someone out there testing 2.6.34? There is a change in
appletouch.c [0] (reverted via attached patch) which breaks the use
of TapPad on my PowerBook5,8. At console (vt*) the cursor stays in
exact one line while moving my finger from leftup to rigntdown and
else.

[0] http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/01212.html

Elimar

--
  Experience is something you don't get until
  just after you need it!

---

--- linux-2.6.34-rc4/drivers/input/mouse/appletouch.c 2010-04-13 19:42:38.000000000 +0200
+++ linux-2.6.34-rc3/drivers/input/mouse/appletouch.c 2010-03-31 02:06:23.000000000 +0200
@@ -205,8 +205,8 @@
  bool overflow_warned;
  int x_old; /* last reported x/y, */
  int y_old; /* used for smoothing */
- u8 xy_cur[ATP_XSENSORS + ATP_YSENSORS];
- u8 xy_old[ATP_XSENSORS + ATP_YSENSORS];
+ signed char xy_cur[ATP_XSENSORS + ATP_YSENSORS];
+ signed char xy_old[ATP_XSENSORS + ATP_YSENSORS];
  int xy_acc[ATP_XSENSORS + ATP_YSENSORS];
  int idlecount; /* number of empty packets */
  struct work_struct work;
@@ -531,7 +531,7 @@
 
  for (i = 0; i < ATP_XSENSORS + ATP_YSENSORS; i++) {
  /* accumulate the change */
- int change = dev->xy_old[i] - dev->xy_cur[i];
+ signed char change = dev->xy_old[i] - dev->xy_cur[i];
  dev->xy_acc[i] -= change;
 
  /* prevent down drifting */

---

[Michel Dänzer-3]

On Die, 2010-04-20 at 21:41 +0200, Elimar Riesebieter wrote:
> Hi all,
>
> is someone out there testing 2.6.34? There is a change in
> appletouch.c [0] (reverted via attached patch) which breaks the use
> of TapPad on my PowerBook5,8. At console (vt*) the cursor stays in
> exact one line while moving my finger from leftup to rigntdown and
> else.
>
> [0] http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/01212.html

You should follow up with the people discussing the patch in that
thread.


--
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


--
To UNSUBSCRIBE, email to debian-powerpc-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...
Archive: http://lists.debian.org/1271838064.5642.61.camel@...