2.8.0 Fork - File API

View: New views
1 Messages — Rating Filter:   Alert me  

2.8.0 Fork - File API

by Josh Suereth :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Erik,

A few thoughts from my gander through the source:

  • I'm thinking the "Stuff" trait belongs in either a "Files" object, or insidea Filesystem abstraction
  • We should migrate from java.nio.charset.Charset to paulp's new Codec class
  • We should probably be using xyzStream.buffered for any of the pass-through File api calls (writeLines/readLines, etc.)

Other than that, I like what you've done.  The use of Option/Either instead of null is great!  I'm wondering if we should make some extractors to make pattern matching files somewhat easier...

e.g.


myPath match {
     case  _ / _ / "*.foo".r =>
    case File("/") / _ / "log" / glob("**/*.log")
     case Directory() =>
}

Anyway, curious if you had any other thoughts/designs.

Also, has anyone else looked through the API to give us an idea of what they think?  I plan to find sometime this week to really compare it against the upcoming JSR for Java 7.