3.0.4 RC6

[Jaroslav Hajek-2]

hi,

I've tried to fix the graphics bug in rc5 by extracting some patches
from the thread:
http://www.nabble.com/octave-3.0.4-rc5-td22177145.html#a22201560

so the rc6 tarballs are available in the usual location:
http://artax.karlin.mff.cuni.cz/~hajej2am/ulozna/octave/

I was kinda lost in the conversation, so I'm not sure I did a good
job. If not, then please suggest fixes directly applicable against
3.0.x.

regards

--
RNDr. Jaroslav Hajek
computing expert & GNU Octave developer
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz

[Rob Mahurin]

On Mar 25, 2009, at 10:26 AM, Jaroslav Hajek wrote:

> I've tried to fix the graphics bug in rc5 by extracting some patches
> from the thread:
> http://www.nabble.com/octave-3.0.4-rc5-td22177145.html#a22201560
>
> so the rc6 tarballs are available in the usual location:
> http://artax.karlin.mff.cuni.cz/~hajej2am/ulozna/octave/
>
> I was kinda lost in the conversation, so I'm not sure I did a good
> job. If not, then please suggest fixes directly applicable against
> 3.0.x.

make check on Debian gives
> Summary:
>
>   PASS   4136
>   FAIL      1
>
> There were 2 expected failures (see fntests.log for details).

which is pretty good, I guess.

There is a failure in "controldemo" (option 3, then option 2, then  
option 1) which is fixed by the attached patch.

The bug exposed by "subplot(111); clf; plot([1 2],[3 4])" is gone.

Cheers,
Rob

--
Rob Mahurin
Department of Physics and Astronomy
University of Tennessee 865 207 2594
Knoxville, TN 37996 rob@...


diff --git a/scripts/ChangeLog b/scripts/ChangeLog
index cfd4172..2824d3c 100644
--- a/scripts/ChangeLog
+++ b/scripts/ChangeLog
@@ -2,6 +2,10 @@

         Version 3.0.4 released.

[phone]  Rob Mahurin  <rob@...>
+
+       * set/create_set.m: return a row vector.  From M. Caliari.
+
  2009-03-25  Jaroslav Hajek  <highegg@...>

         * plot/clf.m: Fix due to M. Caliari.
diff --git a/scripts/set/create_set.m b/scripts/set/create_set.m
index a9ea7d9..958ad09 100644
--- a/scripts/set/create_set.m
+++ b/scripts/set/create_set.m
@@ -52,7 +52,8 @@ function y = create_set (x, rows_opt)
    endif

    if (nargin == 1)
-    y = unique (x).';
+    y = unique (x);
+    y = y(:).';
    elseif (strcmpi (rows_opt, "rows"))
      y = unique (x, "rows");
    else

[Tatsuro MATSUOKA-2]

Hello

I have tested on mingw (GCC-4.3.3-dw2-TDM).

> There is a failure in "controldemo" (option 3, then option 2, then  
> option 1) which is fixed by the attached patch.
I have confirmed fix by Rob's patch for control demo
 
> The bug exposed by "subplot(111); clf; plot([1 2],[3 4])" is gone.
I have also confirmed and also exdiff.m

  d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc  PASS    2/3    FAIL 1
  test_string.m .......................................... PASS  130/131  FAIL 1

  PASS   4124
  FAIL      2


The problem of ov-fcn-handle.cc is not corrected
>>>>> processing d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc
  ***** test
 a = 2;
 f = @(x) a + x;
 g = @(x) 2 * x;
 h = @log2;
 f2 = f;
 g2 = g;
 h2 = h;
 nm = tmpnam();
 unwind_protect
   save ("-text", nm, "f2", "g2", "h2");
   clear f2 g2 h2
   load (nm);
   assert (f(2),f2(2));
   assert (g(2),g2(2));
   assert (g(3),g2(3));
   unlink (nm);
   save ("-text", nm, "f2", "g2", "h2");
 unwind_protect_cleanup
   unlink (nm);
 end_unwind_protect
!!!!! test failed

Please see,
http://www-old.cae.wisc.edu/pipermail/octave-maintainers/2009-March/011319.html

Hi Benjamin, can you prepare the patch for this problem against RC6?

About test_string.m
  test_string.m .......................................... PASS  130/131  FAIL 1

Please use the below.
--- a/ChangeLog Tue Aug 19 16:15:52 2008 -0400
+++ b/ChangeLog Fri Aug 22 13:37:16 2008 +0900
@@ -1,3 +1,7 @@
[phone]  Tatsuro MATSUOKA  <tmacchant@...>
+
+       test/octave.test/string/isprint-1.m in test_string.m for fixed.
+
 2008-08-19  Jaroslav Hajek <highegg@...>
 
        Version 3.0.2 released.
diff -r 4908e39553b0 test/test_string.m
--- a/test/test_string.m        Tue Aug 19 16:15:52 2008 -0400
+++ b/test/test_string.m        Fri Aug 22 13:37:16 2008 +0900
@@ -532,7 +532,7 @@
 %! result = zeros (1, 128);
 %!
 %! result (33:127) = 1;
-%! if (ispc () && ! isunix ())
+%! if (size(findstr (octave_config_info('canonical_host_type'), 'msvc'),2))
 %!   result(10) = 1;
 %! endif
 %!


Regards

Tatsuro
 
--- Rob Mahurin wrote:

> On Mar 25, 2009, at 10:26 AM, Jaroslav Hajek wrote:
> > I've tried to fix the graphics bug in rc5 by extracting some patches
> > from the thread:
> > http://www.nabble.com/octave-3.0.4-rc5-td22177145.html#a22201560
> >
> > so the rc6 tarballs are available in the usual location:
> > http://artax.karlin.mff.cuni.cz/~hajej2am/ulozna/octave/
> >
> > I was kinda lost in the conversation, so I'm not sure I did a good
> > job. If not, then please suggest fixes directly applicable against
> > 3.0.x.
>
>
> make check on Debian gives
> > Summary:
> >
> >   PASS   4136
> >   FAIL      1
> >
> > There were 2 expected failures (see fntests.log for details).
>
> which is pretty good, I guess.
>
> There is a failure in "controldemo" (option 3, then option 2, then  
> option 1) which is fixed by the attached patch.
>
> The bug exposed by "subplot(111); clf; plot([1 2],[3 4])" is gone.
>
> Cheers,
> Rob
>
> --
> Rob Mahurin
> Department of Physics and Astronomy
> University of Tennessee 865 207 2594
> Knoxville, TN 37996 rob@...
>
>
> diff --git a/scripts/ChangeLog b/scripts/ChangeLog
> index cfd4172..2824d3c 100644
> --- a/scripts/ChangeLog
> +++ b/scripts/ChangeLog
> @@ -2,6 +2,10 @@
>
>          Version 3.0.4 released.
>
> [phone]  Rob Mahurin  <rob@...>
> +
> +       * set/create_set.m: return a row vector.  From M. Caliari.
> +
>   2009-03-25  Jaroslav Hajek  <highegg@...>
>
>          * plot/clf.m: Fix due to M. Caliari.
> diff --git a/scripts/set/create_set.m b/scripts/set/create_set.m
> index a9ea7d9..958ad09 100644
> --- a/scripts/set/create_set.m
> +++ b/scripts/set/create_set.m
> @@ -52,7 +52,8 @@ function y = create_set (x, rows_opt)
>     endif
>
>     if (nargin == 1)
> -    y = unique (x).';
> +    y = unique (x);
> +    y = y(:).';
>     elseif (strcmpi (rows_opt, "rows"))
>       y = unique (x, "rows");
>     else
>
>

--------------------------------------
Power up the Internet with Yahoo! Toolbar.
http://pr.mail.yahoo.co.jp/toolbar/

[Jaroslav Hajek-2]

On Wed, Mar 25, 2009 at 9:29 PM, Rob Mahurin <rob@...> wrote:

> On Mar 25, 2009, at 10:26 AM, Jaroslav Hajek wrote:
>>
>> I've tried to fix the graphics bug in rc5 by extracting some patches
>> from the thread:
>> http://www.nabble.com/octave-3.0.4-rc5-td22177145.html#a22201560
>>
>> so the rc6 tarballs are available in the usual location:
>> http://artax.karlin.mff.cuni.cz/~hajej2am/ulozna/octave/
>>
>> I was kinda lost in the conversation, so I'm not sure I did a good
>> job. If not, then please suggest fixes directly applicable against
>> 3.0.x.
>
>
> make check on Debian gives
>>
>> Summary:
>>
>>  PASS   4136
>>  FAIL      1
>>
>> There were 2 expected failures (see fntests.log for details).
>
> which is pretty good, I guess.
>
> There is a failure in "controldemo" (option 3, then option 2, then option 1)
> which is fixed by the attached patch.
>
> The bug exposed by "subplot(111); clf; plot([1 2],[3 4])" is gone.
>
> Cheers,
> Rob
>

I applied this patch.

Thanks

--
RNDr. Jaroslav Hajek
computing expert & GNU Octave developer
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz

[Jaroslav Hajek-2]

2009/3/26 Tatsuro MATSUOKA <tmacchant@...>:

> Hello
>
> I have tested on mingw (GCC-4.3.3-dw2-TDM).
>
>> There is a failure in "controldemo" (option 3, then option 2, then
>> option 1) which is fixed by the attached patch.
> I have confirmed fix by Rob's patch for control demo
>
>> The bug exposed by "subplot(111); clf; plot([1 2],[3 4])" is gone.
> I have also confirmed and also exdiff.m
>
>  d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc  PASS    2/3    FAIL 1
>  test_string.m .......................................... PASS  130/131  FAIL 1
>
>  PASS   4124
>  FAIL      2
>
>
> The problem of ov-fcn-handle.cc is not corrected
>>>>>> processing d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc
>  ***** test
>  a = 2;
>  f = @(x) a + x;
>  g = @(x) 2 * x;
>  h = @log2;
>  f2 = f;
>  g2 = g;
>  h2 = h;
>  nm = tmpnam();
>  unwind_protect
>   save ("-text", nm, "f2", "g2", "h2");
>   clear f2 g2 h2
>   load (nm);
>   assert (f(2),f2(2));
>   assert (g(2),g2(2));
>   assert (g(3),g2(3));
>   unlink (nm);
>   save ("-text", nm, "f2", "g2", "h2");
>  unwind_protect_cleanup
>   unlink (nm);
>  end_unwind_protect
> !!!!! test failed
>
> Please see,
> http://www-old.cae.wisc.edu/pipermail/octave-maintainers/2009-March/011319.html
>
> Hi Benjamin, can you prepare the patch for this problem against RC6?
>

There's no need; the patch was directly applicable, just I obviously
missed it. Just CCing me does not help much, because I got the CC from
mailing list anyway and the message is sorted identically - I can only
notice that gmail may show "me" in the conversation header. Obviously,
bug tracker would do a much better job. I need to be more zealous
about it.

> About test_string.m
>  test_string.m .......................................... PASS  130/131  FAIL 1
>
> Please use the below.
> --- a/ChangeLog Tue Aug 19 16:15:52 2008 -0400
> +++ b/ChangeLog Fri Aug 22 13:37:16 2008 +0900
> @@ -1,3 +1,7 @@
> [phone]  Tatsuro MATSUOKA  <tmacchant@...>
> +
> +       test/octave.test/string/isprint-1.m in test_string.m for fixed.
> +
>  2008-08-19  Jaroslav Hajek <highegg@...>
>
>        Version 3.0.2 released.
> diff -r 4908e39553b0 test/test_string.m
> --- a/test/test_string.m        Tue Aug 19 16:15:52 2008 -0400
> +++ b/test/test_string.m        Fri Aug 22 13:37:16 2008 +0900
> @@ -532,7 +532,7 @@
>  %! result = zeros (1, 128);
>  %!
>  %! result (33:127) = 1;
> -%! if (ispc () && ! isunix ())
> +%! if (size(findstr (octave_config_info('canonical_host_type'), 'msvc'),2))
>  %!   result(10) = 1;
>  %! endif
>  %!
>

OK applied. Again I have a vague impression that this is not the first
time I see this one. I'll prepare RC7 immediatelly.

regards

--
RNDr. Jaroslav Hajek
computing expert & GNU Octave developer
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz

[Jaroslav Hajek-2]

On Thu, Mar 26, 2009 at 7:34 AM, Jaroslav Hajek <highegg@...> wrote:

> 2009/3/26 Tatsuro MATSUOKA <tmacchant@...>:
>> Hello
>>
>> I have tested on mingw (GCC-4.3.3-dw2-TDM).
>>
>>> There is a failure in "controldemo" (option 3, then option 2, then
>>> option 1) which is fixed by the attached patch.
>> I have confirmed fix by Rob's patch for control demo
>>
>>> The bug exposed by "subplot(111); clf; plot([1 2],[3 4])" is gone.
>> I have also confirmed and also exdiff.m
>>
>>  d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc  PASS    2/3    FAIL 1
>>  test_string.m .......................................... PASS  130/131  FAIL 1
>>
>>  PASS   4124
>>  FAIL      2
>>
>>
>> The problem of ov-fcn-handle.cc is not corrected
>>>>>>> processing d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc
>>  ***** test
>>  a = 2;
>>  f = @(x) a + x;
>>  g = @(x) 2 * x;
>>  h = @log2;
>>  f2 = f;
>>  g2 = g;
>>  h2 = h;
>>  nm = tmpnam();
>>  unwind_protect
>>   save ("-text", nm, "f2", "g2", "h2");
>>   clear f2 g2 h2
>>   load (nm);
>>   assert (f(2),f2(2));
>>   assert (g(2),g2(2));
>>   assert (g(3),g2(3));
>>   unlink (nm);
>>   save ("-text", nm, "f2", "g2", "h2");
>>  unwind_protect_cleanup
>>   unlink (nm);
>>  end_unwind_protect
>> !!!!! test failed
>>
>> Please see,
>> http://www-old.cae.wisc.edu/pipermail/octave-maintainers/2009-March/011319.html
>>
>> Hi Benjamin, can you prepare the patch for this problem against RC6?
>>
>
> There's no need; the patch was directly applicable, just I obviously
> missed it. Just CCing me does not help much, because I got the CC from
> mailing list anyway and the message is sorted identically - I can only
> notice that gmail may show "me" in the conversation header. Obviously,
> bug tracker would do a much better job. I need to be more zealous
> about it.
>

OK, correction: It applies but does not work. So no RC7 yet; I'll be
waiting for a patch.

cheers


--
RNDr. Jaroslav Hajek
computing expert & GNU Octave developer
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz

[Rafael Laboissiere]

* Jaroslav Hajek <highegg@...> [2009-03-25 15:26]:

> I've tried to fix the graphics bug in rc5 by extracting some patches
> from the thread:
> http://www.nabble.com/octave-3.0.4-rc5-td22177145.html#a22201560
>
> so the rc6 tarballs are available in the usual location:
> http://artax.karlin.mff.cuni.cz/~hajej2am/ulozna/octave/

Thanks for that, it works great in my Debian sid chroot:

    Summary:

      PASS   4137
      FAIL      0
   
Also, the graphics bug is gone.

[N.B.: The following is Debian-related, so if you are not interested in
Debian, please stop reading here.]

I think that this tarball is of release-quality. The Debian package
octave3.0 version 3.0.4~rc5-4, which integrated the graphics fix, has
been sitting in Debian unstable for a while and there has been no bug
reports.  I am preventing [1] this version from entering Debian testing
but I am now changing my mind.  The package autobuilds correctly on all
official architectures [2] and it will be perhaps a good idea to let it
in testing and enlarge the potential number of people testing the
package.  If things go really wrong, we can revert to 3.0.3 by adding an
epoch number.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=520220
[2] https://buildd.debian.org/~luk/status/package.php?p=octave3.0
 
--
Rafael

[Tatsuro MATSUOKA-2]

Hello Jaroslav and Benjamin

I have now arranged Benjamin's patch and now am testing on mingw and cygwin.

Please wait until the test will be done.

Regards

Tatsuro


--- Jaroslav Hajek  wrote:

> On Thu, Mar 26, 2009 at 7:34 AM, Jaroslav Hajek <highegg@...> wrote:
> > 2009/3/26 Tatsuro MATSUOKA <tmacchant@...>:
> >> Hello
> >>
> >> I have tested on mingw (GCC-4.3.3-dw2-TDM).
> >>
> >>> There is a failure in "controldemo" (option 3, then option 2, then
> >>> option 1) which is fixed by the attached patch.
> >> I have confirmed fix by Rob's patch for control demo
> >>
> >>> The bug exposed by "subplot(111); clf; plot([1 2],[3 4])" is gone.
> >> I have also confirmed and also exdiff.m
> >>
> >> d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc PASS  2/3  FAIL 1
> >> test_string.m .......................................... PASS 130/131 FAIL 1
> >>
> >> PASS  4124
> >> FAIL   2
> >>
> >>
> >> The problem of ov-fcn-handle.cc is not corrected
> >>>>>>> processing d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc
> >> ***** test
> >> a = 2;
> >> f = @(x) a + x;
> >> g = @(x) 2 * x;
> >> h = @log2;
> >> f2 = f;
> >> g2 = g;
> >> h2 = h;
> >> nm = tmpnam();
> >> unwind_protect
> >>  save ("-text", nm, "f2", "g2", "h2");
> >>  clear f2 g2 h2
> >>  load (nm);
> >>  assert (f(2),f2(2));
> >>  assert (g(2),g2(2));
> >>  assert (g(3),g2(3));
> >>  unlink (nm);
> >>  save ("-text", nm, "f2", "g2", "h2");
> >> unwind_protect_cleanup
> >>  unlink (nm);
> >> end_unwind_protect
> >> !!!!! test failed
> >>
> >> Please see,
> >> http://www-old.cae.wisc.edu/pipermail/octave-maintainers/2009-March/011319.html
> >>
> >> Hi Benjamin, can you prepare the patch for this problem against RC6?
> >>
> >
> > There's no need; the patch was directly applicable, just I obviously
> > missed it. Just CCing me does not help much, because I got the CC from
> > mailing list anyway and the message is sorted identically - I can only
> > notice that gmail may show "me" in the conversation header. Obviously,
> > bug tracker would do a much better job. I need to be more zealous
> > about it.
> >
>
> OK, correction: It applies but does not work. So no RC7 yet; I'll be
> waiting for a patch.
>
> cheers
>
>
> --
> RNDr. Jaroslav Hajek
> computing expert & GNU Octave developer
> Aeronautical Research and Test Institute (VZLU)
> Prague, Czech Republic
> url: www.highegg.matfyz.cz
>

--------------------------------------
Power up the Internet with Yahoo! Toolbar.
http://pr.mail.yahoo.co.jp/toolbar/

[Tatsuro MATSUOKA-2]

Hello

I have arranged the Benjamin's Patch for RC6.

Please download the below
http://www.tatsuromatsuoka.com/octave/Eng/Win/fix-ascii-text-mode-crlf-r.tar.bz2

with the patches

  d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc  PASS    3/3

for both mingw and cygwin.

Regards

Tatsuro

--- Tatsuro MATSUOKA  wrote:

> Hello Jaroslav and Benjamin
>
> I have now arranged Benjamin's patch and now am testing on mingw and cygwin.
>
> Please wait until the test will be done.
>
> Regards
>
> Tatsuro
>
>
> --- Jaroslav Hajek  wrote:
>
> > On Thu, Mar 26, 2009 at 7:34 AM, Jaroslav Hajek <highegg@...> wrote:
> > > 2009/3/26 Tatsuro MATSUOKA <tmacchant@...>:
> > >> Hello
> > >>
> > >> I have tested on mingw (GCC-4.3.3-dw2-TDM).
> > >>
> > >>> There is a failure in "controldemo" (option 3, then option 2, then
> > >>> option 1) which is fixed by the attached patch.
> > >> I have confirmed fix by Rob's patch for control demo
> > >>
> > >>> The bug exposed by "subplot(111); clf; plot([1 2],[3 4])" is gone.
> > >> I have also confirmed and also exdiff.m
> > >>
> > >> d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc PASS  2/3  FAIL 1
> > >> test_string.m .......................................... PASS 130/131 FAIL 1
> > >>
> > >> PASS  4124
> > >> FAIL   2
> > >>
> > >>
> > >> The problem of ov-fcn-handle.cc is not corrected
> > >>>>>>> processing d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc
> > >> ***** test
> > >> a = 2;
> > >> f = @(x) a + x;
> > >> g = @(x) 2 * x;
> > >> h = @log2;
> > >> f2 = f;
> > >> g2 = g;
> > >> h2 = h;
> > >> nm = tmpnam();
> > >> unwind_protect
> > >>  save ("-text", nm, "f2", "g2", "h2");
> > >>  clear f2 g2 h2
> > >>  load (nm);
> > >>  assert (f(2),f2(2));
> > >>  assert (g(2),g2(2));
> > >>  assert (g(3),g2(3));
> > >>  unlink (nm);
> > >>  save ("-text", nm, "f2", "g2", "h2");
> > >> unwind_protect_cleanup
> > >>  unlink (nm);
> > >> end_unwind_protect
> > >> !!!!! test failed
> > >>
> > >> Please see,
> > >> http://www-old.cae.wisc.edu/pipermail/octave-maintainers/2009-March/011319.html
> > >>
> > >> Hi Benjamin, can you prepare the patch for this problem against RC6?
> > >>
> > >
> > > There's no need; the patch was directly applicable, just I obviously
> > > missed it. Just CCing me does not help much, because I got the CC from
> > > mailing list anyway and the message is sorted identically - I can only
> > > notice that gmail may show "me" in the conversation header. Obviously,
> > > bug tracker would do a much better job. I need to be more zealous
> > > about it.
> > >
> >
> > OK, correction: It applies but does not work. So no RC7 yet; I'll be
> > waiting for a patch.
> >
> > cheers
> >
> >
> > --
> > RNDr. Jaroslav Hajek
> > computing expert & GNU Octave developer
> > Aeronautical Research and Test Institute (VZLU)
> > Prague, Czech Republic
> > url: www.highegg.matfyz.cz
> >
>
>
> --------------------------------------
> Power up the Internet with Yahoo! Toolbar.
> http://pr.mail.yahoo.co.jp/toolbar/
>

--------------------------------------
Power up the Internet with Yahoo! Toolbar.
http://pr.mail.yahoo.co.jp/toolbar/