3.1.0.5 KDE4 status?

[Christoph Willing]

Since the next Slackware (and I suspect most distros that support KDE)  
will have KDE 4.x, I'd like to be able to provide OO with the KDE4  
option enabled. I've added KDE4 locally to my distro-config but it  
looks like the patches brought in by this option are out of date (see  
first patch failure below).

I manually fixed the first failed patch file (kde4-kdebe.diff) so that  
is would apply cleanly but then another patch failed (kde4-
fpicker.diff) which is quite a bit messier to fix. Before I continue  
down that path,

1. is KDE4 option supported for the 3.1 release? It looks broken right  
now - less than ideal for a release. I see its marked "Experimental"  
in the apply file

2. does anyone have the corrected patches waiting to submit?

3. has anyone succeeded in setting KDE4 option with 3.1.0.5 as is?


 From the apply file, it looks like only one distro includes KDE4  
explicitly at the moment so maybe this area of the code isn't much  
exercised. However it would be a shame to release it broken when some  
distros are perhaps just about to release new versions with kde-4.x).


chris


#### This is the first failed patch when KDE4 is enabled ####
.....
.....
kde4-kdebe.diff: testing...< /var/tmp/openoffice-3.1.0.5/patches/
dev300/./kde4-kdebe.diff sed 's/^\(@.*\)\r$/\1/' | patch  -l -p0  -d /
var/tmp/openoffice-3.1.0.5/build/ooo310-m11 --dry-run
patching file shell/source/backends/kdebe/kdecommonlayer.cxx
Hunk #1 succeeded at 87 (offset -17 lines).
Hunk #3 succeeded at 145 (offset -17 lines).
patching file shell/source/backends/kdebe/kdeinetlayer.cxx
Hunk #1 succeeded at 94 (offset -14 lines).
Hunk #3 succeeded at 144 (offset -14 lines).
Hunk #5 succeeded at 190 (offset -14 lines).
Hunk #7 succeeded at 232 (offset -14 lines).
patching file shell/source/backends/kdebe/kdepathslayer.cxx
Hunk #1 FAILED at 107.
Hunk #2 succeeded at 115 (offset -22 lines).
1 out of 2 hunks FAILED -- saving rejects to file shell/source/
backends/kdebe/kdepathslayer.cxx.rej
Testing patch kde4-kdebe.diff failed. at /var/tmp/openoffice-3.1.0.5/
patches/apply.pl line 97.
make: *** [stamp/patch.apply] Error 1




Christoph Willing                       [phone]
QCIF Access Grid Manager
University of Queensland

_______________________________________________
Dev mailing list
Dev@...
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org

[Jan Holesovsky]

Hi Christoph,

On Thursday 28 May 2009, Christoph Willing wrote:

> Since the next Slackware (and I suspect most distros that support KDE)
> will have KDE 4.x, I'd like to be able to provide OO with the KDE4
> option enabled. I've added KDE4 locally to my distro-config but it
> looks like the patches brought in by this option are out of date (see
> first patch failure below).
>
> I manually fixed the first failed patch file (kde4-kdebe.diff) so that
> is would apply cleanly but then another patch failed (kde4-
> fpicker.diff) which is quite a bit messier to fix. Before I continue
> down that path,
>
> 1. is KDE4 option supported for the 3.1 release? It looks broken right
> now - less than ideal for a release. I see its marked "Experimental"
> in the apply file
>
> 2. does anyone have the corrected patches waiting to submit?
>
> 3. has anyone succeeded in setting KDE4 option with 3.1.0.5 as is?

Basically, KDE 4 is not yet supported.  Unfortunately, just the basic support
was created by Eric Bischoff and Bero [thank you guys so much!], but
unfortunately nobody had time to clean it up & finish :-(

So, if you have some time to help make it work, any help is most appreciated.

Regards,
Kendy
_______________________________________________
Dev mailing list
Dev@...
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org