802.11n Block ack review

[Mirko Banchi]

Hi all,

i've created a new issue http://codereview.appspot.com/144050 for  
review. For now only compressed variant is supported but i'm working  
on little changes in order to also add support for basic variant.

I'd like to start a first review to know if changes to existing code  
could be ok. However, don't worry, i have separate patches, one for  
each added feature in order to keep history clean. I hope that all  
could be merged in next realese.

Best regards,

Mirko

--
Mirko Banchi

e-mail:    mk.banchi@...
e-mail:    mk.banchi@...
id-jabber: mk.banchi@...

PGP key fingerprint:

308F BFB1 4E67 2522 C88E
DC69 7631 52ED 32A5 6456

[Faker Moatamri]

Mirko Banchi wrote:
> Hi all,
>
> i've created a new issue http://codereview.appspot.com/144050 for
> review. For now only compressed variant is supported but i'm working
> on little changes in order to also add support for basic variant.
>

Hi Mirko,
I reviewed your code and my comments can be found in
http://codereview.appspot.com/144050/show
Overall the code is good but some points need to be revisited:
-Doxygen
-Some setters are redundant, you can use only one setter with an input
variable and get the expected behavior
-Two or three similar functions did the same thing using copy and paste,
you should find a better solution

> I'd like to start a first review to know if changes to existing code
> could be ok. However, don't worry, i have separate patches, one for
> each added feature in order to keep history clean. I hope that all
> could be merged in next realese.
Two weeks left for that, any other reviews? Nicolas, Pavel? any review?

Best regards
Faker Moatamri

>
> Best regards,
>
> Mirko
>
> --
> Mirko Banchi
>
> e-mail:    mk.banchi@...
> e-mail:    mk.banchi@...
> id-jabber: mk.banchi@...
>
> PGP key fingerprint:
>
> 308F BFB1 4E67 2522 C88E
> DC69 7631 52ED 32A5 6456
>
>
>
>

[Mirko Banchi]

I've made changes to the code as Nicola, Faker and Andey suggested.  
New patchset is available on http://codereview.appspot.com/144050/show.

Any advice and review are the welcome.

Thank you all.

Mirko

--
Mirko Banchi

e-mail:    mk.banchi@...
e-mail:    mk.banchi@...
id-jabber: mk.banchi@...

PGP key fingerprint:

308F BFB1 4E67 2522 C88E
DC69 7631 52ED 32A5 6456