A couple of patches

View: New views
2 Messages — Rating Filter:   Alert me  

A couple of patches

by Yury Aliaev :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi!

Recently I've found a couple of bugs in ST and fixed them. First is
incorrect memory allocation in Jack driver. In ST-gtk2 this causes to
segfault, while in ST-gtk1 doesn't. But the bug presents in both STs so
it's better to fix it to avoid possible crashes. The second is buffer
overflow when using UTF-8 locale with some languages (also cause ST to
crash).

Cheers!
Yury.

--- soundtracker-0.6.8/app/drivers/jack-output.c.orig 2006-02-25 15:30:54 +0300
+++ soundtracker-0.6.8/app/drivers/jack-output.c 2008-08-04 18:07:58 +0400
@@ -314,7 +314,7 @@
  d->position = 0;
  d->is_active = FALSE;
  d->process_mx = (pthread_mutex_t*)malloc(sizeof (pthread_mutex_t));
- d->state_cv = (pthread_cond_t *)malloc(sizeof (pthread_mutex_t));
+ d->state_cv = (pthread_cond_t *)malloc(sizeof (pthread_cond_t));
  d->do_declick = TRUE;
  pthread_mutex_init (d->process_mx, NULL);
  pthread_cond_init (d->state_cv, NULL);


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Soundtracker-discuss mailing list
Soundtracker-discuss@...
https://lists.sourceforge.net/lists/listinfo/soundtracker-discuss

soundtracker-0.6.8-utf8overflow-alt.patch.bz2 (1K) Download Attachment

Re: A couple of patches

by Bugzilla from uncensored.assault@gmail.com :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Yury,

Can you create a new version with a patched tarball ? I don't really want to search how patch this...
Did you solve the problems with the alsa driver ? I remember that it was instable and hard to use... in 2006.

--
Stan

http://www.claviceps.com
http://www.claviceps-friends.com
= The ultimate dancefloor hit : http://pagesperso-orange.fr/uncensored.assault/richard_stallman.htm =

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Soundtracker-discuss mailing list
Soundtracker-discuss@...
https://lists.sourceforge.net/lists/listinfo/soundtracker-discuss