ABI break; API bump?

View: New views
6 Messages — Rating Filter:   Alert me  

ABI break; API bump?

by Andrew Cowie :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I just made an ABI break.

It's a teeny tiny one, and as a signature fix it comes under the warning
on the main /4.0/ web page.

The fix is going in (it has to), but I am debating whether this should
cue a bump in java-gnome's API version number.

ie, we are [quite deliberately] set up as

        epoch.api.version

right now. So the next release will either be

        4.0.13

or

        4.1.1

The glitch in question is that we had gunichar registered as Java char,
not Java int. So, surprise, splat. The method that is changing is
TextIter's getChar(), now returning int.

No one with a widely distributed libre codebase is using it, so I don't
feel compelled to bump java-gnome's API version number, but I thought
I'd let you know I was thinking about it.

[if it wasn't for the fact that StringBuffer's append(int) doesn't
append the codepoint but instead does a Integer.toString(int), this
would have been transparent. Alas]

If I do, I'll remove all the @deprecated stuff at the same time.

AfC
Sydney

--
Andrew Frederick Cowie

Operational Dynamics is an operations and engineering consultancy
focusing on IT strategy, organizational architecture, systems
review, and effective procedures for change management: enabling
successful deployment of mission critical information technology in
enterprises, worldwide.

http://www.operationaldynamics.com/

Sydney   New York   Toronto   London


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
java-gnome-hackers mailing list
java-gnome-hackers@...
https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers

signature.asc (205 bytes) Download Attachment

Re: ABI break; API bump?

by Andrew Cowie :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Correcting the unicode behaviour is really important, so I'm going to do
the a bug fix release of java-gnome quite soon and without much fanfare.
If anyone has anything they want in, then now would be a good time.

AfC
Sydney




------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
java-gnome-hackers mailing list
java-gnome-hackers@...
https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers

signature.asc (205 bytes) Download Attachment

Re: ABI break; API bump?

by Guillaume Mazoyer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello Andrew,

> If anyone has anything they want in, then now would be a good time.
I did some changes (the ones we talk on IRC) on my GTK 2.16 entry branch
[bzr/java-gnome/hackers/guillaume/entry-gtk-2.16/]. If you can take a
look to see if it's ready to be pulled in mainline it would be nice. And
of course, if it's ready to be pulled then pushed go ahead :)

--
Guillaume Mazoyer - http://www.respawner.fr/


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
java-gnome-hackers mailing list
java-gnome-hackers@...
https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers

signature.asc (204 bytes) Download Attachment

Re: ABI break; API bump?

by Andrew Cowie :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Thu, 2009-08-20 at 13:58 +0200, Guillaume Mazoyer wrote:

> I did some changes (the ones we talk on IRC) on my GTK 2.16 entry branch

Nice!

I did a pass over ExampleShowSomeone; I did do some minor comment
cleanup. See 'hackers/andrew/entry-icon'.

I think that example needs to use a TreeModelFilter rather than the
manual clear & repopulate you're doing now, but that doesn't matter
enough for me to block your branch.

One last thing, though: were you planning on *using* the Snapshots you
created? I think you need to add <img> to the Entry.java class javadoc
comment :)

Your branch is otherwise fine and will be merged to 'mainline'. If you
can just maybe do that one thing for the docs, that'd be great.

Cheers,

AfC
Sydney



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
java-gnome-hackers mailing list
java-gnome-hackers@...
https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers

signature.asc (205 bytes) Download Attachment

Re: ABI break; API bump?

by Guillaume Mazoyer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

> I think that example needs to use a TreeModelFilter rather than the
> manual clear & repopulate you're doing now, but that doesn't matter
> enough for me to block your branch.
I did not think about using the TreeModelFilter but now the example is
using it. Thank you for the tip.

> One last thing, though: were you planning on *using* the Snapshots you
> created? I think you need to add <img> to the Entry.java class javadoc
> comment :)
Actually, the snapshot was used into EntryIconPosition. It was a mistake
I made when I did the documentation, the "fix" is now pushed.

> Your branch is otherwise fine and will be merged to 'mainline'.
Nice :)

--
Guillaume Mazoyer - http://www.respawner.fr/


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
java-gnome-hackers mailing list
java-gnome-hackers@...
https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers

signature.asc (204 bytes) Download Attachment

Re: ABI break; API bump?

by Andrew Cowie :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, 2009-08-21 at 22:32 +0200, Guillaume Mazoyer wrote:
> I did not think about using the TreeModelFilter but now the example is
> using it. Thank you for the tip.

Nicely done!

I simplified the logic a bit, but this was great.

Merged to 'mainline'.

Minimum version of GTK required by java-gnome now 2.16

AfC
Sydney



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
java-gnome-hackers mailing list
java-gnome-hackers@...
https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers

signature.asc (205 bytes) Download Attachment