AW: [PATCH] Git Change log takes current path into account

View: New views
1 Messages — Rating Filter:   Alert me  

AW: [PATCH] Git Change log takes current path into account

by struberg :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Hi Imran!

What is the special usecase for this?
Maybe multi-module builds where the current pom is only 1 sub-module of the whole build?

I'm not really sure if we can safely assume to always execute in the modules path. To be honest, I doubt it! I have something in my mind, but I'm not sure which case it was. Maybe CI builds, hmmm? In those cases a single '.' would not be sufficient.

And there is a really subtle difference with git in releasing multi-module builds.

As you know, Git only handles full trees and not single files. So the behaviour of a release differes if the git repo contains all the modules (including parent) or if there is a git-submodule involved.

So there are most probably still a few things left to do.

LieGrue,
strub

--- Imran M Yousuf <imyousuf@...> schrieb am Di, 7.4.2009:

> Von: Imran M Yousuf <imyousuf@...>
> Betreff: [PATCH] Git Change log takes current path into account
> An: scm-dev@...
> CC: "Mark Struberg" <struberg@...>
> Datum: Dienstag, 7. April 2009, 5:23
> Hi,
>
> I was just checking the commands generated by git changelog
> and I
> noticed that it does not respect the path, whereas it is
> very easy to
> integrate it, mentioning a simple '.' at the end of the
> 'git
> whatchanged' command does the trick and thats what the
> attached patch
> does.
>
> I would be grateful if this would be integrated with the
> current
> version as this change has a grave positive effect on maven
> site's
> changelog report.
>
> Thank you,
>
> --
> Imran M Yousuf
> Entrepreneur & Software Engineer
> Smart IT Engineering
> Dhaka, Bangladesh
> Email: imran@...
> Blog: http://imyousuf-tech.blogs.smartitengineering.com/
> Mobile: +880-1711402557
>