tag:old.nabble.com,2006:forum-2354
Nabble - ActiveMQ
2009-11-25T13:03:52Z
<a href="http://activemq.apache.org/" target="_top" rel="nofollow">Apache ActiveMQ</a> is the most popular and powerful open source Message Broker. Apache ActiveMQ is fast, supports many <a href="http://activemq.apache.org/cross-language-clients.html" target="_top" rel="nofollow">Cross Language Clients and Protocols</a> and many <a href="http://activemq.apache.org/features.html" target="_top" rel="nofollow">advanced features<a target="_top"> while fully supporting JMS 1.1 and J2EE 1.4. Apache ActiveMQ is released under the Apache 2.0 License
tag:old.nabble.com,2006:post-26520269
[jira] Updated: (AMQ-2513) JMX bug - javax.management.InstanceNotFoundException
2009-11-25T13:03:52Z
2009-11-25T13:03:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Dariusz Szablinski updated AMQ-2513:
<br>------------------------------------
<br><br> Component/s: JMX
<br><div class='shrinkable-quote'><br>> JMX bug - javax.management.InstanceNotFoundException
<br>> ----------------------------------------------------
<br>>
<br>> Key: AMQ-2513
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2513" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2513</a><br>> Project: ActiveMQ
<br>> Issue Type: Bug
<br>> Components: JMX
<br>> Affects Versions: 5.3.1
<br>> Reporter: Dariusz Szablinski
<br>> Fix For: 5.3.1, 5.4.0
<br>>
<br>> Attachments: activemq.log, activemq.xml, jconsole.jpg
<br>>
<br>>
<br>> How to reproduce:
<br>> 1) start broker
<br>> 2) start sending/receiving messages to/from a queue
<br>> 3) the queue will show up in MBeans tree
<br>> 4) kill the broker (e.g. end process on windows)
<br>> 5) stat broker again
<br>> 6) you can find your queue in Broker->Queues attribute, but not as a separate node on MBeans tree (see screenshot)
<br>> 7) (optional) start sending/receiving messages to/from a queue
<br>> 8) open web console. following exception will be thrown:
<br>> 2009-11-25 21:47:45,525 | ERROR | /admin/queues.jsp;jsessionid=yjy1i2uuahpk | org.mortbay.log | btpool0-1
<br>> javax.el.ELException: java.lang.reflect.UndeclaredThrowableException
<br>> at javax.el.BeanELResolver.getValue(BeanELResolver.java:266)
<br>> at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:143)
<br>> at com.sun.el.parser.AstValue.getValue(AstValue.java:138)
<br>> at com.sun.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:206)
<br>> at org.apache.jasper.runtime.PageContextImpl.evaluateExpression(PageContextImpl.java:984)
<br>> at org.apache.jsp.queues_jsp._jspx_meth_c_forEach_0(org.apache.jsp.queues_jsp:141)
<br>> at org.apache.jsp.queues_jsp._jspService(org.apache.jsp.queues_jsp:101)
<br>> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:93)
<br>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br>> at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:373)
<br>> at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:470)
<br>> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:364)
<br>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br>> at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093)
<br>> at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:83)
<br>> at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:76)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.apache.activemq.web.SessionFilter.doFilter(SessionFilter.java:43)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.apache.activemq.web.filter.ApplicationContextFilter.doFilter(ApplicationContextFilter.java:81)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
<br>> at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
<br>> at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
<br>> at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
<br>> at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:726)
<br>> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
<br>> at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
<br>> at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
<br>> at org.mortbay.jetty.Server.handle(Server.java:324)
<br>> at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
<br>> at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:828)
<br>> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514)
<br>> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
<br>> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
<br>> at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:395)
<br>> at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:450)
<br>> Caused by: java.lang.reflect.UndeclaredThrowableException
<br>> at $Proxy4.getName(Unknown Source)
<br>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
<br>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
<br>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
<br>> at java.lang.reflect.Method.invoke(Method.java:597)
<br>> at javax.el.BeanELResolver.getValue(BeanELResolver.java:261)
<br>> ... 39 more
<br>> Caused by: javax.management.InstanceNotFoundException: org.apache.activemq:BrokerName=localhost,Type=Queue,Destination=dee.q
<br>> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1094)
<br>> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:662)
<br>> at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638)
<br>> at javax.management.MBeanServerInvocationHandler.invoke(MBeanServerInvocationHandler.java:263)
<br>> ... 45 more
<br>> I'm using latest 5.3.1-SNAPSHOT
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26520270
[jira] Updated: (AMQ-2513) JMX bug - javax.management.InstanceNotFoundException
2009-11-25T13:03:52Z
2009-11-25T13:03:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Dariusz Szablinski updated AMQ-2513:
<br>------------------------------------
<br><br> Attachment: activemq.xml
<br><div class='shrinkable-quote'><br>> JMX bug - javax.management.InstanceNotFoundException
<br>> ----------------------------------------------------
<br>>
<br>> Key: AMQ-2513
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2513" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2513</a><br>> Project: ActiveMQ
<br>> Issue Type: Bug
<br>> Components: JMX
<br>> Affects Versions: 5.3.1
<br>> Reporter: Dariusz Szablinski
<br>> Fix For: 5.3.1, 5.4.0
<br>>
<br>> Attachments: activemq.log, activemq.xml, jconsole.jpg
<br>>
<br>>
<br>> How to reproduce:
<br>> 1) start broker
<br>> 2) start sending/receiving messages to/from a queue
<br>> 3) the queue will show up in MBeans tree
<br>> 4) kill the broker (e.g. end process on windows)
<br>> 5) stat broker again
<br>> 6) you can find your queue in Broker->Queues attribute, but not as a separate node on MBeans tree (see screenshot)
<br>> 7) (optional) start sending/receiving messages to/from a queue
<br>> 8) open web console. following exception will be thrown:
<br>> 2009-11-25 21:47:45,525 | ERROR | /admin/queues.jsp;jsessionid=yjy1i2uuahpk | org.mortbay.log | btpool0-1
<br>> javax.el.ELException: java.lang.reflect.UndeclaredThrowableException
<br>> at javax.el.BeanELResolver.getValue(BeanELResolver.java:266)
<br>> at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:143)
<br>> at com.sun.el.parser.AstValue.getValue(AstValue.java:138)
<br>> at com.sun.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:206)
<br>> at org.apache.jasper.runtime.PageContextImpl.evaluateExpression(PageContextImpl.java:984)
<br>> at org.apache.jsp.queues_jsp._jspx_meth_c_forEach_0(org.apache.jsp.queues_jsp:141)
<br>> at org.apache.jsp.queues_jsp._jspService(org.apache.jsp.queues_jsp:101)
<br>> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:93)
<br>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br>> at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:373)
<br>> at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:470)
<br>> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:364)
<br>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br>> at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093)
<br>> at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:83)
<br>> at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:76)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.apache.activemq.web.SessionFilter.doFilter(SessionFilter.java:43)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.apache.activemq.web.filter.ApplicationContextFilter.doFilter(ApplicationContextFilter.java:81)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
<br>> at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
<br>> at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
<br>> at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
<br>> at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:726)
<br>> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
<br>> at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
<br>> at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
<br>> at org.mortbay.jetty.Server.handle(Server.java:324)
<br>> at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
<br>> at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:828)
<br>> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514)
<br>> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
<br>> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
<br>> at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:395)
<br>> at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:450)
<br>> Caused by: java.lang.reflect.UndeclaredThrowableException
<br>> at $Proxy4.getName(Unknown Source)
<br>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
<br>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
<br>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
<br>> at java.lang.reflect.Method.invoke(Method.java:597)
<br>> at javax.el.BeanELResolver.getValue(BeanELResolver.java:261)
<br>> ... 39 more
<br>> Caused by: javax.management.InstanceNotFoundException: org.apache.activemq:BrokerName=localhost,Type=Queue,Destination=dee.q
<br>> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1094)
<br>> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:662)
<br>> at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638)
<br>> at javax.management.MBeanServerInvocationHandler.invoke(MBeanServerInvocationHandler.java:263)
<br>> ... 45 more
<br>> I'm using latest 5.3.1-SNAPSHOT
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26520229
[jira] Updated: (AMQ-2513) JMX bug - javax.management.InstanceNotFoundException
2009-11-25T13:01:52Z
2009-11-25T13:01:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Dariusz Szablinski updated AMQ-2513:
<br>------------------------------------
<br><br> Attachment: jconsole.jpg
<br><div class='shrinkable-quote'><br>> JMX bug - javax.management.InstanceNotFoundException
<br>> ----------------------------------------------------
<br>>
<br>> Key: AMQ-2513
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2513" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2513</a><br>> Project: ActiveMQ
<br>> Issue Type: Bug
<br>> Affects Versions: 5.3.1
<br>> Reporter: Dariusz Szablinski
<br>> Fix For: 5.3.1, 5.4.0
<br>>
<br>> Attachments: activemq.log, jconsole.jpg
<br>>
<br>>
<br>> How to reproduce:
<br>> 1) start broker
<br>> 2) start sending/receiving messages to/from a queue
<br>> 3) the queue will show up in MBeans tree
<br>> 4) kill the broker (e.g. end process on windows)
<br>> 5) stat broker again
<br>> 6) you can find your queue in Broker->Queues attribute, but not as a separate node on MBeans tree (see screenshot)
<br>> 7) (optional) start sending/receiving messages to/from a queue
<br>> 8) open web console. following exception will be thrown:
<br>> 2009-11-25 21:47:45,525 | ERROR | /admin/queues.jsp;jsessionid=yjy1i2uuahpk | org.mortbay.log | btpool0-1
<br>> javax.el.ELException: java.lang.reflect.UndeclaredThrowableException
<br>> at javax.el.BeanELResolver.getValue(BeanELResolver.java:266)
<br>> at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:143)
<br>> at com.sun.el.parser.AstValue.getValue(AstValue.java:138)
<br>> at com.sun.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:206)
<br>> at org.apache.jasper.runtime.PageContextImpl.evaluateExpression(PageContextImpl.java:984)
<br>> at org.apache.jsp.queues_jsp._jspx_meth_c_forEach_0(org.apache.jsp.queues_jsp:141)
<br>> at org.apache.jsp.queues_jsp._jspService(org.apache.jsp.queues_jsp:101)
<br>> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:93)
<br>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br>> at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:373)
<br>> at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:470)
<br>> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:364)
<br>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br>> at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093)
<br>> at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:83)
<br>> at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:76)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.apache.activemq.web.SessionFilter.doFilter(SessionFilter.java:43)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.apache.activemq.web.filter.ApplicationContextFilter.doFilter(ApplicationContextFilter.java:81)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
<br>> at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
<br>> at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
<br>> at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
<br>> at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:726)
<br>> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
<br>> at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
<br>> at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
<br>> at org.mortbay.jetty.Server.handle(Server.java:324)
<br>> at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
<br>> at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:828)
<br>> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514)
<br>> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
<br>> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
<br>> at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:395)
<br>> at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:450)
<br>> Caused by: java.lang.reflect.UndeclaredThrowableException
<br>> at $Proxy4.getName(Unknown Source)
<br>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
<br>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
<br>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
<br>> at java.lang.reflect.Method.invoke(Method.java:597)
<br>> at javax.el.BeanELResolver.getValue(BeanELResolver.java:261)
<br>> ... 39 more
<br>> Caused by: javax.management.InstanceNotFoundException: org.apache.activemq:BrokerName=localhost,Type=Queue,Destination=dee.q
<br>> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1094)
<br>> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:662)
<br>> at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638)
<br>> at javax.management.MBeanServerInvocationHandler.invoke(MBeanServerInvocationHandler.java:263)
<br>> ... 45 more
<br>> I'm using latest 5.3.1-SNAPSHOT
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26520230
[jira] Updated: (AMQ-2513) JMX bug - javax.management.InstanceNotFoundException
2009-11-25T13:01:52Z
2009-11-25T13:01:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Dariusz Szablinski updated AMQ-2513:
<br>------------------------------------
<br><br> Attachment: activemq.log
<br><div class='shrinkable-quote'><br>> JMX bug - javax.management.InstanceNotFoundException
<br>> ----------------------------------------------------
<br>>
<br>> Key: AMQ-2513
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2513" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2513</a><br>> Project: ActiveMQ
<br>> Issue Type: Bug
<br>> Affects Versions: 5.3.1
<br>> Reporter: Dariusz Szablinski
<br>> Fix For: 5.3.1, 5.4.0
<br>>
<br>> Attachments: activemq.log, jconsole.jpg
<br>>
<br>>
<br>> How to reproduce:
<br>> 1) start broker
<br>> 2) start sending/receiving messages to/from a queue
<br>> 3) the queue will show up in MBeans tree
<br>> 4) kill the broker (e.g. end process on windows)
<br>> 5) stat broker again
<br>> 6) you can find your queue in Broker->Queues attribute, but not as a separate node on MBeans tree (see screenshot)
<br>> 7) (optional) start sending/receiving messages to/from a queue
<br>> 8) open web console. following exception will be thrown:
<br>> 2009-11-25 21:47:45,525 | ERROR | /admin/queues.jsp;jsessionid=yjy1i2uuahpk | org.mortbay.log | btpool0-1
<br>> javax.el.ELException: java.lang.reflect.UndeclaredThrowableException
<br>> at javax.el.BeanELResolver.getValue(BeanELResolver.java:266)
<br>> at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:143)
<br>> at com.sun.el.parser.AstValue.getValue(AstValue.java:138)
<br>> at com.sun.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:206)
<br>> at org.apache.jasper.runtime.PageContextImpl.evaluateExpression(PageContextImpl.java:984)
<br>> at org.apache.jsp.queues_jsp._jspx_meth_c_forEach_0(org.apache.jsp.queues_jsp:141)
<br>> at org.apache.jsp.queues_jsp._jspService(org.apache.jsp.queues_jsp:101)
<br>> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:93)
<br>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br>> at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:373)
<br>> at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:470)
<br>> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:364)
<br>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br>> at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093)
<br>> at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:83)
<br>> at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:76)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.apache.activemq.web.SessionFilter.doFilter(SessionFilter.java:43)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.apache.activemq.web.filter.ApplicationContextFilter.doFilter(ApplicationContextFilter.java:81)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
<br>> at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
<br>> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br>> at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
<br>> at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
<br>> at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
<br>> at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:726)
<br>> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
<br>> at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
<br>> at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
<br>> at org.mortbay.jetty.Server.handle(Server.java:324)
<br>> at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
<br>> at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:828)
<br>> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514)
<br>> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
<br>> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
<br>> at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:395)
<br>> at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:450)
<br>> Caused by: java.lang.reflect.UndeclaredThrowableException
<br>> at $Proxy4.getName(Unknown Source)
<br>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
<br>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
<br>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
<br>> at java.lang.reflect.Method.invoke(Method.java:597)
<br>> at javax.el.BeanELResolver.getValue(BeanELResolver.java:261)
<br>> ... 39 more
<br>> Caused by: javax.management.InstanceNotFoundException: org.apache.activemq:BrokerName=localhost,Type=Queue,Destination=dee.q
<br>> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1094)
<br>> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:662)
<br>> at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638)
<br>> at javax.management.MBeanServerInvocationHandler.invoke(MBeanServerInvocationHandler.java:263)
<br>> ... 45 more
<br>> I'm using latest 5.3.1-SNAPSHOT
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26520199
[jira] Created: (AMQ-2513) JMX bug - javax.management.InstanceNotFoundException
2009-11-25T12:59:52Z
2009-11-25T12:59:52Z
JIRA jira@apache.org
JMX bug - javax.management.InstanceNotFoundException
<br>----------------------------------------------------
<br><br> Key: AMQ-2513
<br> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2513" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2513</a><br> Project: ActiveMQ
<br> Issue Type: Bug
<br> Affects Versions: 5.3.1
<br> Reporter: Dariusz Szablinski
<br> Fix For: 5.3.1, 5.4.0
<br><br><br>How to reproduce:
<br><br>1) start broker
<br>2) start sending/receiving messages to/from a queue
<br>3) the queue will show up in MBeans tree
<br>4) kill the broker (e.g. end process on windows)
<br>5) stat broker again
<br>6) you can find your queue in Broker->Queues attribute, but not as a separate node on MBeans tree (see screenshot)
<br>7) (optional) start sending/receiving messages to/from a queue
<br>8) open web console. following exception will be thrown:
<br><br>2009-11-25 21:47:45,525 | ERROR | /admin/queues.jsp;jsessionid=yjy1i2uuahpk | org.mortbay.log | btpool0-1
<br>javax.el.ELException: java.lang.reflect.UndeclaredThrowableException
<br> at javax.el.BeanELResolver.getValue(BeanELResolver.java:266)
<br> at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:143)
<br> at com.sun.el.parser.AstValue.getValue(AstValue.java:138)
<br> at com.sun.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:206)
<br> at org.apache.jasper.runtime.PageContextImpl.evaluateExpression(PageContextImpl.java:984)
<br> at org.apache.jsp.queues_jsp._jspx_meth_c_forEach_0(org.apache.jsp.queues_jsp:141)
<br> at org.apache.jsp.queues_jsp._jspService(org.apache.jsp.queues_jsp:101)
<br> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:93)
<br> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br> at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:373)
<br> at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:470)
<br> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:364)
<br> at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
<br> at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
<br> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093)
<br> at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:83)
<br> at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:76)
<br> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br> at org.apache.activemq.web.SessionFilter.doFilter(SessionFilter.java:43)
<br> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br> at org.apache.activemq.web.filter.ApplicationContextFilter.doFilter(ApplicationContextFilter.java:81)
<br> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br> at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:118)
<br> at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:52)
<br> at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084)
<br> at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
<br> at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
<br> at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
<br> at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:726)
<br> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
<br> at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
<br> at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
<br> at org.mortbay.jetty.Server.handle(Server.java:324)
<br> at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
<br> at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:828)
<br> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514)
<br> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
<br> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
<br> at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:395)
<br> at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:450)
<br>Caused by: java.lang.reflect.UndeclaredThrowableException
<br> at $Proxy4.getName(Unknown Source)
<br> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
<br> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
<br> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
<br> at java.lang.reflect.Method.invoke(Method.java:597)
<br> at javax.el.BeanELResolver.getValue(BeanELResolver.java:261)
<br> ... 39 more
<br>Caused by: javax.management.InstanceNotFoundException: org.apache.activemq:BrokerName=localhost,Type=Queue,Destination=dee.q
<br> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1094)
<br> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:662)
<br> at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638)
<br> at javax.management.MBeanServerInvocationHandler.invoke(MBeanServerInvocationHandler.java:263)
<br> ... 45 more
<br><br><br>I'm using latest 5.3.1-SNAPSHOT
<br><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26520175
[jira] Commented: (AMQ-2511) Regression: Inactivity monitor does not time out stale connections.
2009-11-25T12:57:52Z
2009-11-25T12:57:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56115#action_56115" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56115#action_56115</a> ]
<br><br>Hiram Chirino commented on AMQ-2511:
<br>------------------------------------
<br><br>fix applied to 5.4 branch in rev 884267.
<br>need to back port to 5.3 branch.
<br><div class='shrinkable-quote'><br>> Regression: Inactivity monitor does not time out stale connections.
<br>> -------------------------------------------------------------------
<br>>
<br>> Key: AMQ-2511
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2511" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2511</a><br>> Project: ActiveMQ
<br>> Issue Type: Bug
<br>> Components: Broker
<br>> Affects Versions: 5.3.0
<br>> Reporter: Hiram Chirino
<br>> Assignee: Hiram Chirino
<br>> Fix For: 5.4.0
<br>>
<br>>
<br>> The fix @ AMQ-2088 cause a the Inactivity Monitor to regress.
<br>> Now when a socket is waiting to read the next message, or is in the middle of receiving the next message it sets a flag that disable the inactivity monitor from timing out the connection. The problem is that if the connection gets hung, then it won't time out since the flag is set.
<br>> I think a better approach would be for the wireformat to expose a counter which is incremented as data is read.
<br>> That way between inactivity check intervals the inactivity monitor can check to see if that value has changed since it's last check.
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26520155
svn commit: r884267 - in /activemq/trunk: activemq-core/src/main/java/org/apache/activemq/openwire/ activemq-core/src/main/java/org/apache/activemq/transport/ activemq-core/src/main/java/org/apache/activemq/transport/failover/ activemq-core/src/main/ja...
2009-11-25T12:56:30Z
2009-11-25T12:56:30Z
chirino
Author: chirino
<br>Date: Wed Nov 25 20:56:28 2009
<br>New Revision: 884267
<br><br>URL: <a href="http://svn.apache.org/viewvc?rev=884267&view=rev" target="_top" rel="nofollow">http://svn.apache.org/viewvc?rev=884267&view=rev</a><br>Log:
<br>Fix for AMQ-2511: Inactivity monitor does not time out stale connections.
<br><br>Modified:
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/openwire/OpenWireFormat.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/Transport.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/TransportFilter.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/failover/FailoverTransport.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/fanout/FanoutTransport.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/mock/MockTransport.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompWireFormat.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpBufferedInputStream.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandChannel.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramChannel.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramSocket.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/UdpTransport.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/vm/VMTransport.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/ObjectStreamWireFormat.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/WireFormat.java
<br> activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/StubTransport.java
<br> activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/BlockingQueueTransport.java
<br> activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpClientTransport.java
<br> activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpTransport.java
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/openwire/OpenWireFormat.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/openwire/OpenWireFormat.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/openwire/OpenWireFormat.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/openwire/OpenWireFormat.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/openwire/OpenWireFormat.java Wed Nov 25 20:56:28 2009
<br>@@ -22,7 +22,6 @@
<br> import java.lang.reflect.Method;
<br> import java.util.HashMap;
<br> import java.util.Map;
<br>-import java.util.concurrent.atomic.AtomicBoolean;
<br>
<br> import org.apache.activemq.command.CommandTypes;
<br> import org.apache.activemq.command.DataStructure;
<br>@@ -63,8 +62,6 @@
<br> private DataByteArrayInputStream bytesIn = new DataByteArrayInputStream();
<br> private WireFormatInfo preferedWireFormatInfo;
<br>
<br>- private AtomicBoolean receivingMessage = new AtomicBoolean(false);
<br>-
<br> public OpenWireFormat() {
<br> this(DEFAULT_VERSION);
<br> }
<br>@@ -353,7 +350,6 @@
<br>
<br> public Object doUnmarshal(DataInput dis) throws IOException {
<br> byte dataType = dis.readByte();
<br>- receivingMessage.set(true);
<br> if (dataType != NULL_TYPE) {
<br> DataStreamMarshaller dsm = (DataStreamMarshaller)dataMarshallers[dataType & 0xFF];
<br> if (dsm == null) {
<br>@@ -367,10 +363,8 @@
<br> } else {
<br> dsm.looseUnmarshal(this, data, dis);
<br> }
<br>- receivingMessage.set(false);
<br> return data;
<br> } else {
<br>- receivingMessage.set(false);
<br> return null;
<br> }
<br> }
<br>@@ -595,10 +589,6 @@
<br> public WireFormatInfo getPreferedWireFormatInfo() {
<br> return preferedWireFormatInfo;
<br> }
<br>-
<br>- public boolean inReceive() {
<br>- return receivingMessage.get();
<br>- }
<br>
<br> public void renegotiateWireFormat(WireFormatInfo info) throws IOException {
<br>
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java Wed Nov 25 20:56:28 2009
<br>@@ -23,6 +23,7 @@
<br> import java.util.concurrent.ThreadPoolExecutor;
<br> import java.util.concurrent.TimeUnit;
<br> import java.util.concurrent.atomic.AtomicBoolean;
<br>+import java.util.concurrent.atomic.AtomicInteger;
<br>
<br> import org.apache.activemq.command.KeepAliveInfo;
<br> import org.apache.activemq.command.WireFormatInfo;
<br>@@ -56,6 +57,8 @@
<br>
<br> private final AtomicBoolean commandReceived = new AtomicBoolean(true);
<br> private final AtomicBoolean inReceive = new AtomicBoolean(false);
<br>+ private final AtomicInteger lastReceiveCounter = new AtomicInteger(0);
<br>+
<br> private SchedulerTimerTask writeCheckerTask;
<br> private SchedulerTimerTask readCheckerTask;
<br>
<br>@@ -153,7 +156,9 @@
<br> }
<br>
<br> final void readCheck() {
<br>- if (inReceive.get() || wireFormat.inReceive()) {
<br>+ int currentCounter = next.getReceiveCounter();
<br>+ int previousCounter = lastReceiveCounter.getAndSet(currentCounter);
<br>+ if (inReceive.get() || currentCounter!=previousCounter ) {
<br> if (LOG.isTraceEnabled()) {
<br> LOG.trace("A receive is in progress");
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/Transport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/Transport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/Transport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/Transport.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/Transport.java Wed Nov 25 20:56:28 2009
<br>@@ -154,4 +154,12 @@
<br> */
<br> void reconnect(URI uri) throws IOException;
<br>
<br>+ /**
<br>+ * Returns a counter which gets incremented as data is read from the transport.
<br>+ * It should only be used to determine if there is progress being made in reading the next command from the transport.
<br>+ * The value may wrap into the negative numbers.
<br>+ *
<br>+ * @return a counter which gets incremented as data is read from the transport.
<br>+ */
<br>+ int getReceiveCounter();
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/TransportFilter.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/TransportFilter.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/TransportFilter.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/TransportFilter.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/TransportFilter.java Wed Nov 25 20:56:28 2009
<br>@@ -137,4 +137,8 @@
<br> public void reconnect(URI uri) throws IOException {
<br> next.reconnect(uri);
<br> }
<br>+
<br>+ public int getReceiveCounter() {
<br>+ return next.getReceiveCounter();
<br>+ }
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/failover/FailoverTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/failover/FailoverTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/failover/FailoverTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/failover/FailoverTransport.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/failover/FailoverTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -868,4 +868,12 @@
<br> public void reconnect(URI uri) throws IOException {
<br> add(new URI[] {uri});
<br> }
<br>+
<br>+ public int getReceiveCounter() {
<br>+ Transport transport = connectedTransport.get();
<br>+ if( transport == null ) {
<br>+ return 0;
<br>+ }
<br>+ return transport.getReceiveCounter();
<br>+ }
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/fanout/FanoutTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/fanout/FanoutTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/fanout/FanoutTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/fanout/FanoutTransport.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/fanout/FanoutTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -586,4 +586,16 @@
<br> public boolean isConnected() {
<br> return connected;
<br> }
<br>+
<br>+ public int getReceiveCounter() {
<br>+ int rc = 0;
<br>+ synchronized (reconnectMutex) {
<br>+ for (FanoutTransportHandler th : transports) {
<br>+ if (th.transport != null) {
<br>+ rc += th.transport.getReceiveCounter();
<br>+ }
<br>+ }
<br>+ }
<br>+ return rc;
<br>+ }
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/mock/MockTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/mock/MockTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/mock/MockTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/mock/MockTransport.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/mock/MockTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -151,4 +151,8 @@
<br> public void reconnect(URI uri) throws IOException {
<br> getNext().reconnect(uri);
<br> }
<br>+
<br>+ public int getReceiveCounter() {
<br>+ return getNext().getReceiveCounter();
<br>+ }
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompWireFormat.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompWireFormat.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompWireFormat.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompWireFormat.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompWireFormat.java Wed Nov 25 20:56:28 2009
<br>@@ -202,11 +202,4 @@
<br> this.version = version;
<br> }
<br>
<br>- public boolean inReceive() {
<br>- //TODO implement the inactivity monitor
<br>- return false;
<br>- }
<br>-
<br>-
<br>-
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpBufferedInputStream.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpBufferedInputStream.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpBufferedInputStream.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpBufferedInputStream.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpBufferedInputStream.java Wed Nov 25 20:56:28 2009
<br>@@ -43,7 +43,7 @@
<br> internalBuffer = new byte[size];
<br> }
<br>
<br>- private void fill() throws IOException {
<br>+ protected void fill() throws IOException {
<br> byte[] buffer = internalBuffer;
<br> count = 0;
<br> position = 0;
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -118,6 +118,7 @@
<br> private Boolean keepAlive;
<br> private Boolean tcpNoDelay;
<br> private Thread runnerThread;
<br>+ private volatile int receiveCounter;
<br>
<br> /**
<br> * Connect to a remote Node - e.g. a Broker
<br>@@ -504,7 +505,28 @@
<br> }
<br>
<br> protected void initializeStreams() throws Exception {
<br>- TcpBufferedInputStream buffIn = new TcpBufferedInputStream(socket.getInputStream(), ioBufferSize);
<br>+ TcpBufferedInputStream buffIn = new TcpBufferedInputStream(socket.getInputStream(), ioBufferSize) {
<br>+ @Override
<br>+ public int read() throws IOException {
<br>+ receiveCounter++;
<br>+ return super.read();
<br>+ }
<br>+ @Override
<br>+ public int read(byte[] b, int off, int len) throws IOException {
<br>+ receiveCounter++;
<br>+ return super.read(b, off, len);
<br>+ }
<br>+ @Override
<br>+ public long skip(long n) throws IOException {
<br>+ receiveCounter++;
<br>+ return super.skip(n);
<br>+ }
<br>+ @Override
<br>+ protected void fill() throws IOException {
<br>+ receiveCounter++;
<br>+ super.fill();
<br>+ }
<br>+ };
<br> this.dataIn = new DataInputStream(buffIn);
<br> buffOut = new TcpBufferedOutputStream(socket.getOutputStream(), ioBufferSize);
<br> this.dataOut = new DataOutputStream(buffOut);
<br>@@ -551,4 +573,9 @@
<br> }
<br> });
<br> }
<br>+
<br>+
<br>+ public int getReceiveCounter() {
<br>+ return receiveCounter;
<br>+ }
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandChannel.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandChannel.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandChannel.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandChannel.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandChannel.java Wed Nov 25 20:56:28 2009
<br>@@ -50,4 +50,7 @@
<br> void setReplayAddress(SocketAddress address);
<br>
<br> void setReplayBuffer(ReplayBuffer replayBuffer);
<br>+
<br>+ public int getReceiveCounter();
<br>+
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramChannel.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramChannel.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramChannel.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramChannel.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramChannel.java Wed Nov 25 20:56:28 2009
<br>@@ -54,6 +54,7 @@
<br> // writing
<br> private Object writeLock = new Object();
<br> private int defaultMarshalBufferSize = 64 * 1024;
<br>+ private volatile int receiveCounter;
<br>
<br> public CommandDatagramChannel(UdpTransport transport, OpenWireFormat wireFormat, int datagramSize, SocketAddress targetAddress, DatagramHeaderMarshaller headerMarshaller,
<br> DatagramChannel channel, ByteBufferPool bufferPool) {
<br>@@ -85,6 +86,8 @@
<br> if (readBuffer.limit() == 0) {
<br> continue;
<br> }
<br>+
<br>+ receiveCounter++;
<br> from = headerMarshaller.createEndpoint(readBuffer, address);
<br>
<br> int remaining = readBuffer.remaining();
<br>@@ -252,4 +255,8 @@
<br> }
<br> }
<br>
<br>+ public int getReceiveCounter() {
<br>+ return receiveCounter;
<br>+ }
<br>+
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramSocket.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramSocket.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramSocket.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramSocket.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/CommandDatagramSocket.java Wed Nov 25 20:56:28 2009
<br>@@ -48,6 +48,8 @@
<br> private Object readLock = new Object();
<br> private Object writeLock = new Object();
<br>
<br>+ private volatile int receiveCounter;
<br>+
<br> public CommandDatagramSocket(UdpTransport transport, OpenWireFormat wireFormat, int datagramSize, SocketAddress targetAddress, DatagramHeaderMarshaller headerMarshaller,
<br> DatagramSocket channel) {
<br> super(transport, wireFormat, datagramSize, targetAddress, headerMarshaller);
<br>@@ -70,8 +72,9 @@
<br>
<br> // TODO could use a DataInput implementation that talks direct
<br> // to the byte[] to avoid object allocation
<br>- DataInputStream dataIn = new DataInputStream(new ByteArrayInputStream(datagram.getData()));
<br>-
<br>+ receiveCounter++;
<br>+ DataInputStream dataIn = new DataInputStream(new ByteArrayInputStream(datagram.getData(), 0, datagram.getLength()));
<br>+
<br> from = headerMarshaller.createEndpoint(datagram, dataIn);
<br> answer = (Command)wireFormat.unmarshal(dataIn);
<br> break;
<br>@@ -232,4 +235,8 @@
<br> protected ByteArrayOutputStream createByteArrayOutputStream() {
<br> return new ByteArrayOutputStream(datagramSize);
<br> }
<br>+
<br>+ public int getReceiveCounter() {
<br>+ return receiveCounter;
<br>+ }
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/UdpTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/UdpTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/UdpTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/UdpTransport.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/udp/UdpTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -462,4 +462,11 @@
<br> }
<br> return null;
<br> }
<br>+
<br>+ public int getReceiveCounter() {
<br>+ if (commandChannel == null) {
<br>+ return 0;
<br>+ }
<br>+ return commandChannel.getReceiveCounter();
<br>+ }
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/vm/VMTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/vm/VMTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/vm/VMTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/vm/VMTransport.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/vm/VMTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -60,6 +60,7 @@
<br> private final Object lazyInitMutext = new Object();
<br> private final Valve enqueueValve = new Valve(true);
<br> private final AtomicBoolean stopping = new AtomicBoolean();
<br>+ private volatile int receiveCounter;
<br>
<br> public VMTransport(URI location) {
<br> this.location = location;
<br>@@ -110,6 +111,7 @@
<br> if( command == DISCONNECT ) {
<br> transportListener.onException(new TransportDisposedIOException("Peer (" + peer.toString() + ") disposed."));
<br> } else {
<br>+ peer.receiveCounter++;
<br> transportListener.onCommand(command);
<br> }
<br> }
<br>@@ -124,6 +126,7 @@
<br> if (messageQueue != null && !async) {
<br> Object command;
<br> while ((command = messageQueue.poll()) != null && !stopping.get() ) {
<br>+ receiveCounter++;
<br> transportListener.onCommand(command);
<br> }
<br> }
<br>@@ -341,4 +344,8 @@
<br> public void reconnect(URI uri) throws IOException {
<br> throw new IOException("Not supported");
<br> }
<br>+
<br>+ public int getReceiveCounter() {
<br>+ return receiveCounter;
<br>+ }
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/ObjectStreamWireFormat.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/ObjectStreamWireFormat.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/ObjectStreamWireFormat.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/ObjectStreamWireFormat.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/ObjectStreamWireFormat.java Wed Nov 25 20:56:28 2009
<br>@@ -75,11 +75,4 @@
<br> return 0;
<br> }
<br>
<br>- public boolean inReceive() {
<br>- // TODO implement the inactivity monitor
<br>- return false;
<br>- }
<br>-
<br>-
<br>-
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/WireFormat.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/WireFormat.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/WireFormat.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/WireFormat.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/wireformat/WireFormat.java Wed Nov 25 20:56:28 2009
<br>@@ -61,9 +61,4 @@
<br> */
<br> int getVersion();
<br>
<br>- /**
<br>- * @return true if message is being received
<br>- */
<br>- boolean inReceive();
<br>-
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/StubTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/StubTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/StubTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/StubTransport.java (original)
<br>+++ activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/StubTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -29,6 +29,7 @@
<br> public class StubTransport extends TransportSupport {
<br>
<br> private Queue<Object> queue = new ConcurrentLinkedQueue<Object>();
<br>+ private volatile int receiveCounter;
<br>
<br> protected void doStop(ServiceStopper stopper) throws Exception {
<br> }
<br>@@ -37,6 +38,7 @@
<br> }
<br>
<br> public void oneway(Object command) throws IOException {
<br>+ receiveCounter++;
<br> queue.add(command);
<br> }
<br>
<br>@@ -48,4 +50,8 @@
<br> return null;
<br> }
<br>
<br>+ public int getReceiveCounter() {
<br>+ return receiveCounter;
<br>+ }
<br>+
<br> }
<br><br>Modified: activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/BlockingQueueTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/BlockingQueueTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/BlockingQueueTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/BlockingQueueTransport.java (original)
<br>+++ activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/BlockingQueueTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -64,5 +64,9 @@
<br> }
<br>
<br> protected void doStop(ServiceStopper stopper) throws Exception {
<br>+ }
<br>+
<br>+ public int getReceiveCounter() {
<br>+ return 0;
<br> }
<br> }
<br><br>Modified: activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpClientTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpClientTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpClientTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpClientTransport.java (original)
<br>+++ activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpClientTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -58,6 +58,7 @@
<br> private final String clientID = CLIENT_ID_GENERATOR.generateId();
<br> private boolean trace;
<br> private GetMethod httpMethod;
<br>+ private volatile int receiveCounter;
<br>
<br> public HttpClientTransport(TextWireFormat wireFormat, URI remoteUrl) {
<br> super(wireFormat, remoteUrl);
<br>@@ -135,6 +136,7 @@
<br> break;
<br> }
<br> } else {
<br>+ receiveCounter++;
<br> DataInputStream stream = new DataInputStream(httpMethod.getResponseBodyAsStream());
<br> Object command = (Object)getTextWireFormat().unmarshal(stream);
<br> if (command == null) {
<br>@@ -221,4 +223,8 @@
<br> this.trace = trace;
<br> }
<br>
<br>+ public int getReceiveCounter() {
<br>+ return receiveCounter;
<br>+ }
<br>+
<br> }
<br><br>Modified: activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpTransport.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpTransport.java?rev=884267&r1=884266&r2=884267&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpTransport.java?rev=884267&r1=884266&r2=884267&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpTransport.java (original)
<br>+++ activemq/trunk/activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpTransport.java Wed Nov 25 20:56:28 2009
<br>@@ -47,7 +47,8 @@
<br> private HttpURLConnection receiveConnection;
<br> private URL url;
<br> private String clientID;
<br>-
<br>+ private volatile int receiveCounter;
<br>+
<br> // private String sessionID;
<br>
<br> public HttpTransport(TextWireFormat wireFormat, URI remoteUrl) throws MalformedURLException {
<br>@@ -102,6 +103,7 @@
<br> // checkSession(connection);
<br>
<br> // Create a String for the UTF content
<br>+ receiveCounter++;
<br> InputStream is = connection.getInputStream();
<br> ByteArrayOutputStream baos = new ByteArrayOutputStream(connection.getContentLength() > 0 ? connection.getContentLength() : 1024);
<br> int c = 0;
<br>@@ -228,4 +230,8 @@
<br> }
<br> }
<br>
<br>+ public int getReceiveCounter() {
<br>+ return receiveCounter;
<br>+ }
<br>+
<br> }
<br><br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Commits-f23834.html" embed="fixTarget[23834]" target="_top" >ActiveMQ - Commits</a></p>
tag:old.nabble.com,2006:post-26519840
[jira] Updated: (AMQ-2512) "Failed to page in more queue messages"
2009-11-25T12:33:52Z
2009-11-25T12:33:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Dariusz Szablinski updated AMQ-2512:
<br>------------------------------------
<br><br> Attachment: activemq.xml
<br><div class='shrinkable-quote'><br>> "Failed to page in more queue messages"
<br>> ---------------------------------------
<br>>
<br>> Key: AMQ-2512
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2512" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2512</a><br>> Project: ActiveMQ
<br>> Issue Type: Bug
<br>> Affects Versions: 5.3.1
<br>> Reporter: Dariusz Szablinski
<br>> Fix For: 5.3.1, 5.4.0
<br>>
<br>> Attachments: activemq.log, activemq.xml, jconsole.jpg
<br>>
<br>>
<br>> Following exception occurs quite often at the moment when cursor percent usage is over 100% and suddenly drops down below 100%:
<br>> 2009-11-25 21:16:00,287 | INFO | Slow KahaDB access: cleanup took 547 | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Journal Checkpoint Worker
<br>> 2009-11-25 21:16:27,832 | INFO | Slow KahaDB access: Journal append took: 0 ms, Index update took 891 ms | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Transport: tcp:///192.168.1.4:57697
<br>> 2009-11-25 21:16:30,324 | INFO | Slow KahaDB access: Journal append took: 0 ms, Index update took 1172 ms | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Transport: tcp:///192.168.1.4:57697
<br>> 2009-11-25 21:16:31,283 | ERROR | Failed to page in more queue messages | org.apache.activemq.broker.region.Queue | Queue:dee.q
<br>> java.lang.NullPointerException
<br>> at org.apache.kahadb.index.BTreeIndex.loadNode(BTreeIndex.java:260)
<br>> at org.apache.kahadb.index.BTreeNode$BTreeIterator.findNextPage(BTreeNode.java:103)
<br>> at org.apache.kahadb.index.BTreeNode$BTreeIterator.hasNext(BTreeNode.java:120)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore$2.execute(KahaDBStore.java:194)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore$2.execute(KahaDBStore.java:190)
<br>> at org.apache.kahadb.page.Transaction.execute(Transaction.java:751)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore.getMessageCount(KahaDBStore.java:189)
<br>> at org.apache.activemq.broker.region.cursors.QueueStorePrefetch.getStoreSize(QueueStorePrefetch.java:63)
<br>> at org.apache.activemq.broker.region.cursors.AbstractStoreCursor.remove(AbstractStoreCursor.java:189)
<br>> at org.apache.activemq.broker.region.cursors.StoreQueueCursor.remove(StoreQueueCursor.java:141)
<br>> at org.apache.activemq.broker.region.Queue.doPageIn(Queue.java:1370)
<br>> at org.apache.activemq.broker.region.Queue.pageInMessages(Queue.java:1505)
<br>> at org.apache.activemq.broker.region.Queue.iterate(Queue.java:1176)
<br>> at org.apache.activemq.thread.DedicatedTaskRunner.runTask(DedicatedTaskRunner.java:98)
<br>> at org.apache.activemq.thread.DedicatedTaskRunner$1.run(DedicatedTaskRunner.java:36)
<br>> Additional side effect is that broker stops dispatching messages out of the queue (see queue size and consumer count on screenshot from jconsole)
<br>> Sometimes this exception is also followed by:
<br>> 2009-11-25 20:45:00,783 | WARN | Async error occurred: java.lang.ClassCastException: java.lang.String cannot be cast to org.apache.kahadb.journal.Location | org.apache.activemq.broker.TransportConnection.Service | ActiveMQ Transport: tcp:///192.168.1.4:57516
<br>> java.lang.ClassCastException: java.lang.String cannot be cast to org.apache.kahadb.journal.Location
<br>> at org.apache.kahadb.journal.Location.compareTo(Location.java:29)
<br>> at java.util.Arrays.binarySearch0(Arrays.java:2001)
<br>> at java.util.Arrays.binarySearch(Arrays.java:1943)
<br>> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:234)
<br>> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:240)
<br>> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:240)
<br>> at org.apache.kahadb.index.BTreeIndex.remove(BTreeIndex.java:194)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.updateIndex(MessageDatabase.java:873)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.access$700(MessageDatabase.java:82)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase$13.execute(MessageDatabase.java:757)
<br>> at org.apache.kahadb.page.Transaction.execute(Transaction.java:728)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.process(MessageDatabase.java:755)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase$11.visit(MessageDatabase.java:700)
<br>> at org.apache.activemq.store.kahadb.data.KahaRemoveMessageCommand.visit(KahaRemoveMessageCommand.java:220)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.process(MessageDatabase.java:692)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.store(MessageDatabase.java:644)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore.removeMessage(KahaDBStore.java:153)
<br>> at org.apache.activemq.broker.region.Queue.acknowledge(Queue.java:602)
<br>> at org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1235)
<br>> at org.apache.activemq.broker.region.QueueSubscription.acknowledge(QueueSubscription.java:60)
<br>> at org.apache.activemq.broker.region.PrefetchSubscription.acknowledge(PrefetchSubscription.java:250)
<br>> at org.apache.activemq.broker.region.AbstractRegion.acknowledge(AbstractRegion.java:369)
<br>> at org.apache.activemq.broker.region.RegionBroker.acknowledge(RegionBroker.java:470)
<br>> at org.apache.activemq.broker.TransactionBroker.acknowledge(TransactionBroker.java:194)
<br>> at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:74)
<br>> at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:74)
<br>> at org.apache.activemq.broker.MutableBrokerFilter.acknowledge(MutableBrokerFilter.java:85)
<br>> at org.apache.activemq.broker.TransportConnection.processMessageAck(TransportConnection.java:449)
<br>> at org.apache.activemq.command.MessageAck.visit(MessageAck.java:205)
<br>> at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:297)
<br>> at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:175)
<br>> at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
<br>> at org.apache.activemq.transport.WireFormatNegotiator.onCommand(WireFormatNegotiator.java:113)
<br>> at org.apache.activemq.transport.InactivityMonitor.onCommand(InactivityMonitor.java:210)
<br>> at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
<br>> at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
<br>> at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
<br>> at java.lang.Thread.run(Thread.java:619)
<br>> I'm using latest 5.3.1-SNAPSHOT
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26519809
[jira] Updated: (AMQ-2512) "Failed to page in more queue messages"
2009-11-25T12:31:52Z
2009-11-25T12:31:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Dariusz Szablinski updated AMQ-2512:
<br>------------------------------------
<br><br> Attachment: activemq.log
<br><div class='shrinkable-quote'><br>> "Failed to page in more queue messages"
<br>> ---------------------------------------
<br>>
<br>> Key: AMQ-2512
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2512" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2512</a><br>> Project: ActiveMQ
<br>> Issue Type: Bug
<br>> Affects Versions: 5.3.1
<br>> Reporter: Dariusz Szablinski
<br>> Fix For: 5.3.1, 5.4.0
<br>>
<br>> Attachments: activemq.log, jconsole.jpg
<br>>
<br>>
<br>> Following exception occurs quite often at the moment when cursor percent usage is over 100% and suddenly drops down below 100%:
<br>> 2009-11-25 21:16:00,287 | INFO | Slow KahaDB access: cleanup took 547 | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Journal Checkpoint Worker
<br>> 2009-11-25 21:16:27,832 | INFO | Slow KahaDB access: Journal append took: 0 ms, Index update took 891 ms | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Transport: tcp:///192.168.1.4:57697
<br>> 2009-11-25 21:16:30,324 | INFO | Slow KahaDB access: Journal append took: 0 ms, Index update took 1172 ms | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Transport: tcp:///192.168.1.4:57697
<br>> 2009-11-25 21:16:31,283 | ERROR | Failed to page in more queue messages | org.apache.activemq.broker.region.Queue | Queue:dee.q
<br>> java.lang.NullPointerException
<br>> at org.apache.kahadb.index.BTreeIndex.loadNode(BTreeIndex.java:260)
<br>> at org.apache.kahadb.index.BTreeNode$BTreeIterator.findNextPage(BTreeNode.java:103)
<br>> at org.apache.kahadb.index.BTreeNode$BTreeIterator.hasNext(BTreeNode.java:120)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore$2.execute(KahaDBStore.java:194)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore$2.execute(KahaDBStore.java:190)
<br>> at org.apache.kahadb.page.Transaction.execute(Transaction.java:751)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore.getMessageCount(KahaDBStore.java:189)
<br>> at org.apache.activemq.broker.region.cursors.QueueStorePrefetch.getStoreSize(QueueStorePrefetch.java:63)
<br>> at org.apache.activemq.broker.region.cursors.AbstractStoreCursor.remove(AbstractStoreCursor.java:189)
<br>> at org.apache.activemq.broker.region.cursors.StoreQueueCursor.remove(StoreQueueCursor.java:141)
<br>> at org.apache.activemq.broker.region.Queue.doPageIn(Queue.java:1370)
<br>> at org.apache.activemq.broker.region.Queue.pageInMessages(Queue.java:1505)
<br>> at org.apache.activemq.broker.region.Queue.iterate(Queue.java:1176)
<br>> at org.apache.activemq.thread.DedicatedTaskRunner.runTask(DedicatedTaskRunner.java:98)
<br>> at org.apache.activemq.thread.DedicatedTaskRunner$1.run(DedicatedTaskRunner.java:36)
<br>> Additional side effect is that broker stops dispatching messages out of the queue (see queue size and consumer count on screenshot from jconsole)
<br>> Sometimes this exception is also followed by:
<br>> 2009-11-25 20:45:00,783 | WARN | Async error occurred: java.lang.ClassCastException: java.lang.String cannot be cast to org.apache.kahadb.journal.Location | org.apache.activemq.broker.TransportConnection.Service | ActiveMQ Transport: tcp:///192.168.1.4:57516
<br>> java.lang.ClassCastException: java.lang.String cannot be cast to org.apache.kahadb.journal.Location
<br>> at org.apache.kahadb.journal.Location.compareTo(Location.java:29)
<br>> at java.util.Arrays.binarySearch0(Arrays.java:2001)
<br>> at java.util.Arrays.binarySearch(Arrays.java:1943)
<br>> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:234)
<br>> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:240)
<br>> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:240)
<br>> at org.apache.kahadb.index.BTreeIndex.remove(BTreeIndex.java:194)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.updateIndex(MessageDatabase.java:873)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.access$700(MessageDatabase.java:82)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase$13.execute(MessageDatabase.java:757)
<br>> at org.apache.kahadb.page.Transaction.execute(Transaction.java:728)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.process(MessageDatabase.java:755)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase$11.visit(MessageDatabase.java:700)
<br>> at org.apache.activemq.store.kahadb.data.KahaRemoveMessageCommand.visit(KahaRemoveMessageCommand.java:220)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.process(MessageDatabase.java:692)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.store(MessageDatabase.java:644)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore.removeMessage(KahaDBStore.java:153)
<br>> at org.apache.activemq.broker.region.Queue.acknowledge(Queue.java:602)
<br>> at org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1235)
<br>> at org.apache.activemq.broker.region.QueueSubscription.acknowledge(QueueSubscription.java:60)
<br>> at org.apache.activemq.broker.region.PrefetchSubscription.acknowledge(PrefetchSubscription.java:250)
<br>> at org.apache.activemq.broker.region.AbstractRegion.acknowledge(AbstractRegion.java:369)
<br>> at org.apache.activemq.broker.region.RegionBroker.acknowledge(RegionBroker.java:470)
<br>> at org.apache.activemq.broker.TransactionBroker.acknowledge(TransactionBroker.java:194)
<br>> at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:74)
<br>> at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:74)
<br>> at org.apache.activemq.broker.MutableBrokerFilter.acknowledge(MutableBrokerFilter.java:85)
<br>> at org.apache.activemq.broker.TransportConnection.processMessageAck(TransportConnection.java:449)
<br>> at org.apache.activemq.command.MessageAck.visit(MessageAck.java:205)
<br>> at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:297)
<br>> at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:175)
<br>> at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
<br>> at org.apache.activemq.transport.WireFormatNegotiator.onCommand(WireFormatNegotiator.java:113)
<br>> at org.apache.activemq.transport.InactivityMonitor.onCommand(InactivityMonitor.java:210)
<br>> at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
<br>> at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
<br>> at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
<br>> at java.lang.Thread.run(Thread.java:619)
<br>> I'm using latest 5.3.1-SNAPSHOT
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26519783
[jira] Updated: (AMQ-2512) "Failed to page in more queue messages"
2009-11-25T12:29:52Z
2009-11-25T12:29:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Dariusz Szablinski updated AMQ-2512:
<br>------------------------------------
<br><br> Attachment: jconsole.jpg
<br><div class='shrinkable-quote'><br>> "Failed to page in more queue messages"
<br>> ---------------------------------------
<br>>
<br>> Key: AMQ-2512
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2512" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2512</a><br>> Project: ActiveMQ
<br>> Issue Type: Bug
<br>> Affects Versions: 5.3.1
<br>> Reporter: Dariusz Szablinski
<br>> Fix For: 5.3.1, 5.4.0
<br>>
<br>> Attachments: jconsole.jpg
<br>>
<br>>
<br>> Following exception occurs quite often at the moment when cursor percent usage is over 100% and suddenly drops down below 100%:
<br>> 2009-11-25 21:16:00,287 | INFO | Slow KahaDB access: cleanup took 547 | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Journal Checkpoint Worker
<br>> 2009-11-25 21:16:27,832 | INFO | Slow KahaDB access: Journal append took: 0 ms, Index update took 891 ms | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Transport: tcp:///192.168.1.4:57697
<br>> 2009-11-25 21:16:30,324 | INFO | Slow KahaDB access: Journal append took: 0 ms, Index update took 1172 ms | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Transport: tcp:///192.168.1.4:57697
<br>> 2009-11-25 21:16:31,283 | ERROR | Failed to page in more queue messages | org.apache.activemq.broker.region.Queue | Queue:dee.q
<br>> java.lang.NullPointerException
<br>> at org.apache.kahadb.index.BTreeIndex.loadNode(BTreeIndex.java:260)
<br>> at org.apache.kahadb.index.BTreeNode$BTreeIterator.findNextPage(BTreeNode.java:103)
<br>> at org.apache.kahadb.index.BTreeNode$BTreeIterator.hasNext(BTreeNode.java:120)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore$2.execute(KahaDBStore.java:194)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore$2.execute(KahaDBStore.java:190)
<br>> at org.apache.kahadb.page.Transaction.execute(Transaction.java:751)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore.getMessageCount(KahaDBStore.java:189)
<br>> at org.apache.activemq.broker.region.cursors.QueueStorePrefetch.getStoreSize(QueueStorePrefetch.java:63)
<br>> at org.apache.activemq.broker.region.cursors.AbstractStoreCursor.remove(AbstractStoreCursor.java:189)
<br>> at org.apache.activemq.broker.region.cursors.StoreQueueCursor.remove(StoreQueueCursor.java:141)
<br>> at org.apache.activemq.broker.region.Queue.doPageIn(Queue.java:1370)
<br>> at org.apache.activemq.broker.region.Queue.pageInMessages(Queue.java:1505)
<br>> at org.apache.activemq.broker.region.Queue.iterate(Queue.java:1176)
<br>> at org.apache.activemq.thread.DedicatedTaskRunner.runTask(DedicatedTaskRunner.java:98)
<br>> at org.apache.activemq.thread.DedicatedTaskRunner$1.run(DedicatedTaskRunner.java:36)
<br>> Additional side effect is that broker stops dispatching messages out of the queue (see queue size and consumer count on screenshot from jconsole)
<br>> Sometimes this exception is also followed by:
<br>> 2009-11-25 20:45:00,783 | WARN | Async error occurred: java.lang.ClassCastException: java.lang.String cannot be cast to org.apache.kahadb.journal.Location | org.apache.activemq.broker.TransportConnection.Service | ActiveMQ Transport: tcp:///192.168.1.4:57516
<br>> java.lang.ClassCastException: java.lang.String cannot be cast to org.apache.kahadb.journal.Location
<br>> at org.apache.kahadb.journal.Location.compareTo(Location.java:29)
<br>> at java.util.Arrays.binarySearch0(Arrays.java:2001)
<br>> at java.util.Arrays.binarySearch(Arrays.java:1943)
<br>> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:234)
<br>> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:240)
<br>> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:240)
<br>> at org.apache.kahadb.index.BTreeIndex.remove(BTreeIndex.java:194)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.updateIndex(MessageDatabase.java:873)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.access$700(MessageDatabase.java:82)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase$13.execute(MessageDatabase.java:757)
<br>> at org.apache.kahadb.page.Transaction.execute(Transaction.java:728)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.process(MessageDatabase.java:755)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase$11.visit(MessageDatabase.java:700)
<br>> at org.apache.activemq.store.kahadb.data.KahaRemoveMessageCommand.visit(KahaRemoveMessageCommand.java:220)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.process(MessageDatabase.java:692)
<br>> at org.apache.activemq.store.kahadb.MessageDatabase.store(MessageDatabase.java:644)
<br>> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore.removeMessage(KahaDBStore.java:153)
<br>> at org.apache.activemq.broker.region.Queue.acknowledge(Queue.java:602)
<br>> at org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1235)
<br>> at org.apache.activemq.broker.region.QueueSubscription.acknowledge(QueueSubscription.java:60)
<br>> at org.apache.activemq.broker.region.PrefetchSubscription.acknowledge(PrefetchSubscription.java:250)
<br>> at org.apache.activemq.broker.region.AbstractRegion.acknowledge(AbstractRegion.java:369)
<br>> at org.apache.activemq.broker.region.RegionBroker.acknowledge(RegionBroker.java:470)
<br>> at org.apache.activemq.broker.TransactionBroker.acknowledge(TransactionBroker.java:194)
<br>> at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:74)
<br>> at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:74)
<br>> at org.apache.activemq.broker.MutableBrokerFilter.acknowledge(MutableBrokerFilter.java:85)
<br>> at org.apache.activemq.broker.TransportConnection.processMessageAck(TransportConnection.java:449)
<br>> at org.apache.activemq.command.MessageAck.visit(MessageAck.java:205)
<br>> at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:297)
<br>> at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:175)
<br>> at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
<br>> at org.apache.activemq.transport.WireFormatNegotiator.onCommand(WireFormatNegotiator.java:113)
<br>> at org.apache.activemq.transport.InactivityMonitor.onCommand(InactivityMonitor.java:210)
<br>> at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
<br>> at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
<br>> at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
<br>> at java.lang.Thread.run(Thread.java:619)
<br>> I'm using latest 5.3.1-SNAPSHOT
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26519757
[jira] Created: (AMQ-2512) "Failed to page in more queue messages"
2009-11-25T12:27:52Z
2009-11-25T12:27:52Z
JIRA jira@apache.org
"Failed to page in more queue messages"
<br>---------------------------------------
<br><br> Key: AMQ-2512
<br> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2512" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2512</a><br> Project: ActiveMQ
<br> Issue Type: Bug
<br> Affects Versions: 5.3.1
<br> Reporter: Dariusz Szablinski
<br> Fix For: 5.3.1, 5.4.0
<br><br><br>Following exception occurs quite often at the moment when cursor percent usage is over 100% and suddenly drops down below 100%:
<br><br>2009-11-25 21:16:00,287 | INFO | Slow KahaDB access: cleanup took 547 | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Journal Checkpoint Worker
<br>2009-11-25 21:16:27,832 | INFO | Slow KahaDB access: Journal append took: 0 ms, Index update took 891 ms | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Transport: tcp:///192.168.1.4:57697
<br>2009-11-25 21:16:30,324 | INFO | Slow KahaDB access: Journal append took: 0 ms, Index update took 1172 ms | org.apache.activemq.store.kahadb.MessageDatabase | ActiveMQ Transport: tcp:///192.168.1.4:57697
<br>2009-11-25 21:16:31,283 | ERROR | Failed to page in more queue messages | org.apache.activemq.broker.region.Queue | Queue:dee.q
<br>java.lang.NullPointerException
<br> at org.apache.kahadb.index.BTreeIndex.loadNode(BTreeIndex.java:260)
<br> at org.apache.kahadb.index.BTreeNode$BTreeIterator.findNextPage(BTreeNode.java:103)
<br> at org.apache.kahadb.index.BTreeNode$BTreeIterator.hasNext(BTreeNode.java:120)
<br> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore$2.execute(KahaDBStore.java:194)
<br> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore$2.execute(KahaDBStore.java:190)
<br> at org.apache.kahadb.page.Transaction.execute(Transaction.java:751)
<br> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore.getMessageCount(KahaDBStore.java:189)
<br> at org.apache.activemq.broker.region.cursors.QueueStorePrefetch.getStoreSize(QueueStorePrefetch.java:63)
<br> at org.apache.activemq.broker.region.cursors.AbstractStoreCursor.remove(AbstractStoreCursor.java:189)
<br> at org.apache.activemq.broker.region.cursors.StoreQueueCursor.remove(StoreQueueCursor.java:141)
<br> at org.apache.activemq.broker.region.Queue.doPageIn(Queue.java:1370)
<br> at org.apache.activemq.broker.region.Queue.pageInMessages(Queue.java:1505)
<br> at org.apache.activemq.broker.region.Queue.iterate(Queue.java:1176)
<br> at org.apache.activemq.thread.DedicatedTaskRunner.runTask(DedicatedTaskRunner.java:98)
<br> at org.apache.activemq.thread.DedicatedTaskRunner$1.run(DedicatedTaskRunner.java:36)
<br><br><br>Additional side effect is that broker stops dispatching messages out of the queue (see queue size and consumer count on screenshot from jconsole)
<br><br><br>Sometimes this exception is also followed by:
<br><br>2009-11-25 20:45:00,783 | WARN | Async error occurred: java.lang.ClassCastException: java.lang.String cannot be cast to org.apache.kahadb.journal.Location | org.apache.activemq.broker.TransportConnection.Service | ActiveMQ Transport: tcp:///192.168.1.4:57516
<br>java.lang.ClassCastException: java.lang.String cannot be cast to org.apache.kahadb.journal.Location
<br> at org.apache.kahadb.journal.Location.compareTo(Location.java:29)
<br> at java.util.Arrays.binarySearch0(Arrays.java:2001)
<br> at java.util.Arrays.binarySearch(Arrays.java:1943)
<br> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:234)
<br> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:240)
<br> at org.apache.kahadb.index.BTreeNode.remove(BTreeNode.java:240)
<br> at org.apache.kahadb.index.BTreeIndex.remove(BTreeIndex.java:194)
<br> at org.apache.activemq.store.kahadb.MessageDatabase.updateIndex(MessageDatabase.java:873)
<br> at org.apache.activemq.store.kahadb.MessageDatabase.access$700(MessageDatabase.java:82)
<br> at org.apache.activemq.store.kahadb.MessageDatabase$13.execute(MessageDatabase.java:757)
<br> at org.apache.kahadb.page.Transaction.execute(Transaction.java:728)
<br> at org.apache.activemq.store.kahadb.MessageDatabase.process(MessageDatabase.java:755)
<br> at org.apache.activemq.store.kahadb.MessageDatabase$11.visit(MessageDatabase.java:700)
<br> at org.apache.activemq.store.kahadb.data.KahaRemoveMessageCommand.visit(KahaRemoveMessageCommand.java:220)
<br> at org.apache.activemq.store.kahadb.MessageDatabase.process(MessageDatabase.java:692)
<br> at org.apache.activemq.store.kahadb.MessageDatabase.store(MessageDatabase.java:644)
<br> at org.apache.activemq.store.kahadb.KahaDBStore$KahaDBMessageStore.removeMessage(KahaDBStore.java:153)
<br> at org.apache.activemq.broker.region.Queue.acknowledge(Queue.java:602)
<br> at org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1235)
<br> at org.apache.activemq.broker.region.QueueSubscription.acknowledge(QueueSubscription.java:60)
<br> at org.apache.activemq.broker.region.PrefetchSubscription.acknowledge(PrefetchSubscription.java:250)
<br> at org.apache.activemq.broker.region.AbstractRegion.acknowledge(AbstractRegion.java:369)
<br> at org.apache.activemq.broker.region.RegionBroker.acknowledge(RegionBroker.java:470)
<br> at org.apache.activemq.broker.TransactionBroker.acknowledge(TransactionBroker.java:194)
<br> at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:74)
<br> at org.apache.activemq.broker.BrokerFilter.acknowledge(BrokerFilter.java:74)
<br> at org.apache.activemq.broker.MutableBrokerFilter.acknowledge(MutableBrokerFilter.java:85)
<br> at org.apache.activemq.broker.TransportConnection.processMessageAck(TransportConnection.java:449)
<br> at org.apache.activemq.command.MessageAck.visit(MessageAck.java:205)
<br> at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:297)
<br> at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:175)
<br> at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
<br> at org.apache.activemq.transport.WireFormatNegotiator.onCommand(WireFormatNegotiator.java:113)
<br> at org.apache.activemq.transport.InactivityMonitor.onCommand(InactivityMonitor.java:210)
<br> at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
<br> at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
<br> at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
<br> at java.lang.Thread.run(Thread.java:619)
<br><br>I'm using latest 5.3.1-SNAPSHOT
<br><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26519716
Re: Best implementation for reply-request
2009-11-25T12:24:09Z
2009-11-25T12:24:09Z
rajdavies
there could well be an improvement using nio. Also - it it possible to
<br>move to version 5.3 - which is generally a lot more stable.
<br>Btw - you didn't mention if you were having performance problems ?
<br><br>cheers,
<br><br>Rob
<br>On 25 Nov 2009, at 19:55, Andres Rangel wrote:
<br><div class='shrinkable-quote'><br>> Bruce thanks for your reply.
<br>> The consumers create the temporary queue only once, and they are
<br>> cached in a pool for subsequent usage.
<br>> We are using tcp connection. If we move to nio connection, will
<br>> there be any noticeable improvement?
<br>>
<br>> -----Original Message-----
<br>> From: Bruce Snyder [mailto:<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26519716&i=0" target="_top" rel="nofollow">bruce.snyder@...</a>]
<br>> Sent: Wednesday, November 25, 2009 1:45 PM
<br>> To: <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26519716&i=1" target="_top" rel="nofollow">users@...</a>
<br>> Subject: Re: Best implementation for reply-request
<br>>
<br>> On Wed, Nov 25, 2009 at 10:34 AM, Andres Rangel
<br>> <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26519716&i=2" target="_top" rel="nofollow">andresr@...</a>> wrote:
<br>>> Hi,
<br>>>
<br>>> We have currently running apache activemq 5.2 in a network of brokers
<br>>>
<br>>>
<br>>>
<br>>> It has close to 1500 producers and 1200 consumers.
<br>>>
<br>>> This producers have each one a temporary queue so that will be 1500
<br>>> temp queues in the system.
<br>>>
<br>>>
<br>>>
<br>>> The reply-request is implemented using temporary queues.
<br>>>
<br>>>
<br>>>
<br>>>
<br>>>
<br>>> I would like to know if there's a performance hit by using temporary
<br>>> queues instead of using another option.
<br>>>
<br>>>
<br>>>
<br>>> What do you guys think?
<br>>
<br>> There's more overhead involved with such constant creation/destruction
<br>> of temp queues, but that's it. As long as the broker has been tuned to
<br>> scale for handling such a large number of destinations, then you
<br>> should be OK:
<br>>
<br>> <a href="http://activemq.apache.org/scaling-queues.html" target="_top" rel="nofollow">http://activemq.apache.org/scaling-queues.html</a><br>>
<br>> Bruce
<br>> --
<br>> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!
<br>> G;6%I;\"YC;VT*"
<br>> );'
<br>>
<br>> ActiveMQ in Action: <a href="http://bit.ly/2je6cQ" target="_top" rel="nofollow">http://bit.ly/2je6cQ</a><br>> Blog: <a href="http://bruceblog.org/" target="_top" rel="nofollow">http://bruceblog.org/</a><br>> Twitter: <a href="http://twitter.com/brucesnyder" target="_top" rel="nofollow">http://twitter.com/brucesnyder</a></div><br>Rob Davies
<br><a href="http://twitter.com/rajdavies" target="_top" rel="nofollow">http://twitter.com/rajdavies</a><br>I work here: <a href="http://fusesource.com" target="_top" rel="nofollow">http://fusesource.com</a><br>My Blog: <a href="http://rajdavies.blogspot.com/" target="_top" rel="nofollow">http://rajdavies.blogspot.com/</a><br>I'm writing this: <a href="http://www.manning.com/snyder/" target="_top" rel="nofollow">http://www.manning.com/snyder/</a><br><br><br><br><br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>
tag:old.nabble.com,2006:post-26519260
RE: Best implementation for reply-request
2009-11-25T11:55:03Z
2009-11-25T11:55:03Z
Andres Rangel-2
Bruce thanks for your reply.
<br>The consumers create the temporary queue only once, and they are cached in a pool for subsequent usage.
<br>We are using tcp connection. If we move to nio connection, will there be any noticeable improvement?
<br><br>-----Original Message-----
<br>From: Bruce Snyder [mailto:<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26519260&i=0" target="_top" rel="nofollow">bruce.snyder@...</a>]
<br>Sent: Wednesday, November 25, 2009 1:45 PM
<br>To: <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26519260&i=1" target="_top" rel="nofollow">users@...</a>
<br>Subject: Re: Best implementation for reply-request
<br><br>On Wed, Nov 25, 2009 at 10:34 AM, Andres Rangel
<br><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26519260&i=2" target="_top" rel="nofollow">andresr@...</a>> wrote:
<div class='shrinkable-quote'><br>> Hi,
<br>>
<br>> We have currently running apache activemq 5.2 in a network of brokers
<br>>
<br>>
<br>>
<br>> It has close to 1500 producers and 1200 consumers.
<br>>
<br>> This producers have each one a temporary queue so that will be 1500
<br>> temp queues in the system.
<br>>
<br>>
<br>>
<br>> The reply-request is implemented using temporary queues.
<br>>
<br>>
<br>>
<br>>
<br>>
<br>> I would like to know if there's a performance hit by using temporary
<br>> queues instead of using another option.
<br>>
<br>>
<br>>
<br>> What do you guys think?
</div><br>There's more overhead involved with such constant creation/destruction
<br>of temp queues, but that's it. As long as the broker has been tuned to
<br>scale for handling such a large number of destinations, then you
<br>should be OK:
<br><br><a href="http://activemq.apache.org/scaling-queues.html" target="_top" rel="nofollow">http://activemq.apache.org/scaling-queues.html</a><br><br>Bruce
<br>--
<br>perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
<br>);'
<br><br>ActiveMQ in Action: <a href="http://bit.ly/2je6cQ" target="_top" rel="nofollow">http://bit.ly/2je6cQ</a><br>Blog: <a href="http://bruceblog.org/" target="_top" rel="nofollow">http://bruceblog.org/</a><br>Twitter: <a href="http://twitter.com/brucesnyder" target="_top" rel="nofollow">http://twitter.com/brucesnyder</a><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>
tag:old.nabble.com,2006:post-26518949
svn commit: r884234 [1/2] - in /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker: jmx/ region/ region/policy/
2009-11-25T11:35:10Z
2009-11-25T11:35:10Z
cmacnaug
Author: cmacnaug
<br>Date: Wed Nov 25 19:35:09 2009
<br>New Revision: 884234
<br><br>URL: <a href="http://svn.apache.org/viewvc?rev=884234&view=rev" target="_top" rel="nofollow">http://svn.apache.org/viewvc?rev=884234&view=rev</a><br>Log:
<br>Adding a blockedProducerWarningInterval attribute to destinations to control the rate at which warnings about blocked producers are generated (otherwise the warnings can flood the log).
<br><br>Modified:
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationViewMBean.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/BaseDestination.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Destination.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/DestinationFilter.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Topic.java
<br> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/policy/PolicyEntry.java
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java?rev=884234&r1=884233&r2=884234&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java?rev=884234&r1=884233&r2=884234&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java Wed Nov 25 19:35:09 2009
<br>@@ -82,11 +82,11 @@
<br> public long getDispatchCount() {
<br> return destination.getDestinationStatistics().getDispatched().getCount();
<br> }
<br>-
<br>+
<br> public long getInFlightCount() {
<br> return destination.getDestinationStatistics().getInflight().getCount();
<br> }
<br>-
<br>+
<br> public long getExpiredCount() {
<br> return destination.getDestinationStatistics().getExpired().getCount();
<br> }
<br>@@ -220,7 +220,7 @@
<br> OpenTypeFactory factory = OpenTypeSupport.getFactory(ActiveMQMessage.class);
<br> Message[] messages = destination.browse();
<br> CompositeType ct = factory.getCompositeType();
<br>- TabularType tt = new TabularType("MessageList", "MessageList", ct, new String[] {"JMSMessageID"});
<br>+ TabularType tt = new TabularType("MessageList", "MessageList", ct, new String[] { "JMSMessageID" });
<br> TabularDataSupport rc = new TabularDataSupport(tt);
<br>
<br> MessageEvaluationContext ctx = new MessageEvaluationContext();
<br>@@ -248,16 +248,16 @@
<br> public String sendTextMessage(String body) throws Exception {
<br> return sendTextMessage(Collections.EMPTY_MAP, body);
<br> }
<br>-
<br>+
<br> public String sendTextMessage(Map headers, String body) throws Exception {
<br>- return sendTextMessage(headers,body,null,null);
<br>+ return sendTextMessage(headers, body, null, null);
<br> }
<br>
<br> public String sendTextMessage(String body, String user, String password) throws Exception {
<br>- return sendTextMessage(Collections.EMPTY_MAP,body,user,password);
<br>+ return sendTextMessage(Collections.EMPTY_MAP, body, user, password);
<br> }
<br>
<br>- public String sendTextMessage(Map headers, String body,String userName,String password) throws Exception {
<br>+ public String sendTextMessage(Map headers, String body, String userName, String password) throws Exception {
<br>
<br> String brokerUrl = "vm://" + broker.getBrokerName();
<br> ActiveMQDestination dest = destination.getActiveMQDestination();
<br>@@ -266,14 +266,14 @@
<br> Connection connection = null;
<br> try {
<br>
<br>- connection = cf.createConnection(userName,password);
<br>+ connection = cf.createConnection(userName, password);
<br> Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
<br> MessageProducer producer = session.createProducer(dest);
<br>- ActiveMQTextMessage msg = (ActiveMQTextMessage)session.createTextMessage(body);
<br>+ ActiveMQTextMessage msg = (ActiveMQTextMessage) session.createTextMessage(body);
<br>
<br> for (Iterator iter = headers.entrySet().iterator(); iter.hasNext();) {
<br>- Map.Entry entry = (Map.Entry)iter.next();
<br>- msg.setObjectProperty((String)entry.getKey(), entry.getValue());
<br>+ Map.Entry entry = (Map.Entry) iter.next();
<br>+ msg.setObjectProperty((String) entry.getKey(), entry.getValue());
<br> }
<br>
<br> producer.setDeliveryMode(msg.getJMSDeliveryMode());
<br>@@ -292,30 +292,28 @@
<br>
<br> public int getMaxAuditDepth() {
<br> return destination.getMaxAuditDepth();
<br>- }
<br>+ }
<br>+
<br>+ public int getMaxProducersToAudit() {
<br>+ return destination.getMaxProducersToAudit();
<br>+ }
<br>+
<br>+ public boolean isEnableAudit() {
<br>+ return destination.isEnableAudit();
<br>+ }
<br>+
<br>+ public void setEnableAudit(boolean enableAudit) {
<br>+ destination.setEnableAudit(enableAudit);
<br>+ }
<br>+
<br>+ public void setMaxAuditDepth(int maxAuditDepth) {
<br>+ destination.setMaxAuditDepth(maxAuditDepth);
<br>+ }
<br>
<br>- public int getMaxProducersToAudit() {
<br>- return destination.getMaxProducersToAudit();
<br>- }
<br>-
<br>- public boolean isEnableAudit() {
<br>- return destination.isEnableAudit();
<br>- }
<br>-
<br>-
<br>- public void setEnableAudit(boolean enableAudit) {
<br>- destination.setEnableAudit(enableAudit);
<br>- }
<br>-
<br>- public void setMaxAuditDepth(int maxAuditDepth) {
<br>- destination.setMaxAuditDepth(maxAuditDepth);
<br>- }
<br>-
<br>- public void setMaxProducersToAudit(int maxProducersToAudit) {
<br>- destination.setMaxProducersToAudit(maxProducersToAudit);
<br>- }
<br>+ public void setMaxProducersToAudit(int maxProducersToAudit) {
<br>+ destination.setMaxProducersToAudit(maxProducersToAudit);
<br>+ }
<br>
<br>-
<br> public float getMemoryUsagePortion() {
<br> return destination.getMemoryUsage().getUsagePortion();
<br> }
<br>@@ -325,31 +323,52 @@
<br> }
<br>
<br> public boolean isProducerFlowControl() {
<br>- return destination.isProducerFlowControl();
<br>+ return destination.isProducerFlowControl();
<br> }
<br>-
<br>+
<br> public void setMemoryUsagePortion(float value) {
<br> destination.getMemoryUsage().setUsagePortion(value);
<br> }
<br>
<br> public void setProducerFlowControl(boolean producerFlowControl) {
<br>- destination.setProducerFlowControl(producerFlowControl);
<br>+ destination.setProducerFlowControl(producerFlowControl);
<br>+ }
<br>+
<br>+ /**
<br>+ * Set's the interval at which warnings about producers being blocked by
<br>+ * resource usage will be triggered. Values of 0 or less will disable
<br>+ * warnings
<br>+ *
<br>+ * @param blockedProducerWarningInterval the interval at which warning about
<br>+ * blocked producers will be triggered.
<br>+ */
<br>+ public void setBlockedProducerWarningInterval(long blockedProducerWarningInterval) {
<br>+ destination.setBlockedProducerWarningInterval(blockedProducerWarningInterval);
<br>+ }
<br>+
<br>+ /**
<br>+ *
<br>+ * @return the interval at which warning about blocked producers will be
<br>+ * triggered.
<br>+ */
<br>+ public long getBlockedProducerWarningInterval() {
<br>+ return destination.getBlockedProducerWarningInterval();
<br> }
<br>
<br> public int getMaxPageSize() {
<br> return destination.getMaxPageSize();
<br> }
<br>-
<br>+
<br> public void setMaxPageSize(int pageSize) {
<br> destination.setMaxPageSize(pageSize);
<br> }
<br>-
<br>+
<br> public boolean isUseCache() {
<br> return destination.isUseCache();
<br> }
<br>
<br> public void setUseCache(boolean value) {
<br>- destination.setUseCache(value);
<br>+ destination.setUseCache(value);
<br> }
<br>
<br> public ObjectName[] getSubscriptions() throws IOException, MalformedObjectNameException {
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationViewMBean.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationViewMBean.java?rev=884234&r1=884233&r2=884234&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationViewMBean.java?rev=884234&r1=884233&r2=884234&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationViewMBean.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/DestinationViewMBean.java Wed Nov 25 19:35:09 2009
<br>@@ -248,12 +248,31 @@
<br> */
<br> @MBeanInfo("Producers are flow controlled")
<br> boolean isProducerFlowControl();
<br>+
<br> /**
<br> * @param producerFlowControl the producerFlowControl to set
<br> */
<br> public void setProducerFlowControl(@MBeanInfo("producerFlowControl") boolean producerFlowControl);
<br>
<br> /**
<br>+ * Set's the interval at which warnings about producers being blocked by
<br>+ * resource usage will be triggered. Values of 0 or less will disable
<br>+ * warnings
<br>+ *
<br>+ * @param blockedProducerWarningInterval the interval at which warning about
<br>+ * blocked producers will be triggered.
<br>+ */
<br>+ public void setBlockedProducerWarningInterval(@MBeanInfo("blockedProducerWarningInterval") long blockedProducerWarningInterval);
<br>+
<br>+ /**
<br>+ *
<br>+ * @return the interval at which warning about blocked producers will be
<br>+ * triggered.
<br>+ */
<br>+ @MBeanInfo("Blocked Producer Warning Interval")
<br>+ public long getBlockedProducerWarningInterval();
<br>+
<br>+ /**
<br> * @return the maxProducersToAudit
<br> */
<br> @MBeanInfo("Maximum number of producers to audit")
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/BaseDestination.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/BaseDestination.java?rev=884234&r1=884233&r2=884234&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/BaseDestination.java?rev=884234&r1=884233&r2=884234&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/BaseDestination.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/BaseDestination.java Wed Nov 25 19:35:09 2009
<br>@@ -40,18 +40,21 @@
<br> */
<br> public abstract class BaseDestination implements Destination {
<br> /**
<br>- * The maximum number of messages to page in to the destination from persistent storage
<br>+ * The maximum number of messages to page in to the destination from
<br>+ * persistent storage
<br> */
<br> public static final int MAX_PAGE_SIZE = 200;
<br> public static final int MAX_BROWSE_PAGE_SIZE = MAX_PAGE_SIZE * 2;
<br>- public static final long EXPIRE_MESSAGE_PERIOD = 30*1000;
<br>+ public static final long EXPIRE_MESSAGE_PERIOD = 30 * 1000;
<br> protected final ActiveMQDestination destination;
<br> protected final Broker broker;
<br> protected final MessageStore store;
<br> protected SystemUsage systemUsage;
<br> protected MemoryUsage memoryUsage;
<br> private boolean producerFlowControl = true;
<br>- protected boolean warnOnProducerFlowControl = true;
<br>+ protected boolean warnOnProducerFlowControl = true;
<br>+ protected long blockedProducerWarningInterval = DEFAULT_BLOCKED_PRODUCER_WARNING_INTERVAL;
<br>+
<br> private int maxProducersToAudit = 1024;
<br> private int maxAuditDepth = 2048;
<br> private boolean enableAudit = true;
<br>@@ -82,8 +85,7 @@
<br> * @param parentStats
<br> * @throws Exception
<br> */
<br>- public BaseDestination(BrokerService brokerService, MessageStore store, ActiveMQDestination destination,
<br>- DestinationStatistics parentStats) throws Exception {
<br>+ public BaseDestination(BrokerService brokerService, MessageStore store, ActiveMQDestination destination, DestinationStatistics parentStats) throws Exception {
<br> this.brokerService = brokerService;
<br> this.broker = brokerService.getBroker();
<br> this.store = store;
<br>@@ -118,14 +120,34 @@
<br> }
<br>
<br> /**
<br>- * @param producerFlowControl
<br>- * the producerFlowControl to set
<br>+ * @param producerFlowControl the producerFlowControl to set
<br> */
<br> public void setProducerFlowControl(boolean producerFlowControl) {
<br> this.producerFlowControl = producerFlowControl;
<br> }
<br>
<br> /**
<br>+ * Set's the interval at which warnings about producers being blocked by
<br>+ * resource usage will be triggered. Values of 0 or less will disable
<br>+ * warnings
<br>+ *
<br>+ * @param blockedProducerWarningInterval the interval at which warning about
<br>+ * blocked producers will be triggered.
<br>+ */
<br>+ public void setBlockedProducerWarningInterval(long blockedProducerWarningInterval) {
<br>+ this.blockedProducerWarningInterval = blockedProducerWarningInterval;
<br>+ }
<br>+
<br>+ /**
<br>+ *
<br>+ * @return the interval at which warning about blocked producers will be
<br>+ * triggered.
<br>+ */
<br>+ public long getBlockedProducerWarningInterval() {
<br>+ return blockedProducerWarningInterval;
<br>+ }
<br>+
<br>+ /**
<br> * @return the maxProducersToAudit
<br> */
<br> public int getMaxProducersToAudit() {
<br>@@ -133,8 +155,7 @@
<br> }
<br>
<br> /**
<br>- * @param maxProducersToAudit
<br>- * the maxProducersToAudit to set
<br>+ * @param maxProducersToAudit the maxProducersToAudit to set
<br> */
<br> public void setMaxProducersToAudit(int maxProducersToAudit) {
<br> this.maxProducersToAudit = maxProducersToAudit;
<br>@@ -148,8 +169,7 @@
<br> }
<br>
<br> /**
<br>- * @param maxAuditDepth
<br>- * the maxAuditDepth to set
<br>+ * @param maxAuditDepth the maxAuditDepth to set
<br> */
<br> public void setMaxAuditDepth(int maxAuditDepth) {
<br> this.maxAuditDepth = maxAuditDepth;
<br>@@ -163,8 +183,7 @@
<br> }
<br>
<br> /**
<br>- * @param enableAudit
<br>- * the enableAudit to set
<br>+ * @param enableAudit the enableAudit to set
<br> */
<br> public void setEnableAudit(boolean enableAudit) {
<br> this.enableAudit = enableAudit;
<br>@@ -199,8 +218,7 @@
<br> }
<br>
<br> public final boolean isActive() {
<br>- return destinationStatistics.getConsumers().getCount() != 0
<br>- || destinationStatistics.getProducers().getCount() != 0;
<br>+ return destinationStatistics.getConsumers().getCount() != 0 || destinationStatistics.getProducers().getCount() != 0;
<br> }
<br>
<br> public int getMaxPageSize() {
<br>@@ -218,13 +236,13 @@
<br> public void setMaxBrowsePageSize(int maxPageSize) {
<br> this.maxBrowsePageSize = maxPageSize;
<br> }
<br>-
<br>+
<br> public int getMaxExpirePageSize() {
<br> return this.maxExpirePageSize;
<br> }
<br>
<br> public void setMaxExpirePageSize(int maxPageSize) {
<br>- this.maxExpirePageSize = maxPageSize;
<br>+ this.maxExpirePageSize = maxPageSize;
<br> }
<br>
<br> public void setExpireMessagesPeriod(long expireMessagesPeriod) {
<br>@@ -234,7 +252,7 @@
<br> public long getExpireMessagesPeriod() {
<br> return expireMessagesPeriod;
<br> }
<br>-
<br>+
<br> public boolean isUseCache() {
<br> return useCache;
<br> }
<br>@@ -271,8 +289,7 @@
<br> }
<br>
<br> /**
<br>- * @param advisoryForSlowConsumers
<br>- * the advisoryForSlowConsumers to set
<br>+ * @param advisoryForSlowConsumers the advisoryForSlowConsumers to set
<br> */
<br> public void setAdvisoryForSlowConsumers(boolean advisoryForSlowConsumers) {
<br> this.advisoryForSlowConsumers = advisoryForSlowConsumers;
<br>@@ -286,8 +303,8 @@
<br> }
<br>
<br> /**
<br>- * @param advisoryForDiscardingMessages
<br>- * the advisoryForDiscardingMessages to set
<br>+ * @param advisoryForDiscardingMessages the advisoryForDiscardingMessages to
<br>+ * set
<br> */
<br> public void setAdvisoryForDiscardingMessages(boolean advisoryForDiscardingMessages) {
<br> this.advisoryForDiscardingMessages = advisoryForDiscardingMessages;
<br>@@ -301,8 +318,7 @@
<br> }
<br>
<br> /**
<br>- * @param advisoryWhenFull
<br>- * the advisoryWhenFull to set
<br>+ * @param advisoryWhenFull the advisoryWhenFull to set
<br> */
<br> public void setAdvisoryWhenFull(boolean advisoryWhenFull) {
<br> this.advisoryWhenFull = advisoryWhenFull;
<br>@@ -316,8 +332,7 @@
<br> }
<br>
<br> /**
<br>- * @param advisoryForDelivery
<br>- * the advisoryForDelivery to set
<br>+ * @param advisoryForDelivery the advisoryForDelivery to set
<br> */
<br> public void setAdvisoryForDelivery(boolean advisoryForDelivery) {
<br> this.advisoryForDelivery = advisoryForDelivery;
<br>@@ -331,8 +346,7 @@
<br> }
<br>
<br> /**
<br>- * @param advisoryForConsumed
<br>- * the advisoryForConsumed to set
<br>+ * @param advisoryForConsumed the advisoryForConsumed to set
<br> */
<br> public void setAdvisoryForConsumed(boolean advisoryForConsumed) {
<br> this.advisoryForConsumed = advisoryForConsumed;
<br>@@ -346,13 +360,12 @@
<br> }
<br>
<br> /**
<br>- * @param advisdoryForFastProducers
<br>- * the advisdoryForFastProducers to set
<br>+ * @param advisdoryForFastProducers the advisdoryForFastProducers to set
<br> */
<br> public void setAdvisdoryForFastProducers(boolean advisdoryForFastProducers) {
<br> this.advisdoryForFastProducers = advisdoryForFastProducers;
<br> }
<br>-
<br>+
<br> public boolean isSendAdvisoryIfNoConsumers() {
<br> return sendAdvisoryIfNoConsumers;
<br> }
<br>@@ -376,14 +389,14 @@
<br> public void setDeadLetterStrategy(DeadLetterStrategy deadLetterStrategy) {
<br> this.deadLetterStrategy = deadLetterStrategy;
<br> }
<br>-
<br>+
<br> public int getCursorMemoryHighWaterMark() {
<br>- return this.cursorMemoryHighWaterMark;
<br>- }
<br>+ return this.cursorMemoryHighWaterMark;
<br>+ }
<br>
<br>- public void setCursorMemoryHighWaterMark(int cursorMemoryHighWaterMark) {
<br>- this.cursorMemoryHighWaterMark = cursorMemoryHighWaterMark;
<br>- }
<br>+ public void setCursorMemoryHighWaterMark(int cursorMemoryHighWaterMark) {
<br>+ this.cursorMemoryHighWaterMark = cursorMemoryHighWaterMark;
<br>+ }
<br>
<br> /**
<br> * called when message is consumed
<br>@@ -410,8 +423,8 @@
<br> }
<br>
<br> /**
<br>- * Called when a message is discarded - e.g. running low on memory This will happen only if the policy is enabled -
<br>- * e.g. non durable topics
<br>+ * Called when a message is discarded - e.g. running low on memory This will
<br>+ * happen only if the policy is enabled - e.g. non durable topics
<br> *
<br> * @param context
<br> * @param messageReference
<br>@@ -460,19 +473,19 @@
<br>
<br> public void dispose(ConnectionContext context) throws IOException {
<br> if (this.store != null) {
<br>- this.store.removeAllMessages(context);
<br>+ this.store.removeAllMessages(context);
<br> this.store.dispose(context);
<br> }
<br> this.destinationStatistics.setParent(null);
<br> this.memoryUsage.stop();
<br> }
<br>-
<br>+
<br> /**
<br> * Provides a hook to allow messages with no consumer to be processed in
<br> * some way - such as to send to a dead letter queue or something..
<br> */
<br> protected void onMessageWithNoConsumers(ConnectionContext context, Message msg) throws Exception {
<br>- if (!msg.isPersistent()) {
<br>+ if (!msg.isPersistent()) {
<br> if (isSendAdvisoryIfNoConsumers()) {
<br> // allow messages with no consumers to be dispatched to a dead
<br> // letter queue
<br>@@ -489,12 +502,12 @@
<br> if (message.getOriginalTransactionId() != null) {
<br> message.setOriginalTransactionId(message.getTransactionId());
<br> }
<br>-
<br>+
<br> ActiveMQTopic advisoryTopic;
<br> if (destination.isQueue()) {
<br>- advisoryTopic = AdvisorySupport.getNoQueueConsumersAdvisoryTopic(destination);
<br>+ advisoryTopic = AdvisorySupport.getNoQueueConsumersAdvisoryTopic(destination);
<br> } else {
<br>- advisoryTopic = AdvisorySupport.getNoTopicConsumersAdvisoryTopic(destination);
<br>+ advisoryTopic = AdvisorySupport.getNoTopicConsumersAdvisoryTopic(destination);
<br> }
<br> message.setDestination(advisoryTopic);
<br> message.setTransactionId(null);
<br>@@ -517,8 +530,9 @@
<br> }
<br> }
<br> }
<br>-
<br>- public void processDispatchNotification(
<br>- MessageDispatchNotification messageDispatchNotification) throws Exception {
<br>+
<br>+ public void processDispatchNotification(MessageDispatchNotification messageDispatchNotification) throws Exception {
<br> }
<br>+
<br>+
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Destination.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Destination.java?rev=884234&r1=884233&r2=884234&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Destination.java?rev=884234&r1=884233&r2=884234&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Destination.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Destination.java Wed Nov 25 19:35:09 2009
<br>@@ -41,10 +41,12 @@
<br> public interface Destination extends Service, Task {
<br>
<br> public static final DeadLetterStrategy DEFAULT_DEAD_LETTER_STRATEGY = new SharedDeadLetterStrategy();
<br>+ public static final long DEFAULT_BLOCKED_PRODUCER_WARNING_INTERVAL = 30000;
<br>+
<br> void addSubscription(ConnectionContext context, Subscription sub) throws Exception;
<br>
<br> void removeSubscription(ConnectionContext context, Subscription sub, long lastDeliveredSequenceId) throws Exception;
<br>-
<br>+
<br> void addProducer(ConnectionContext context, ProducerInfo info) throws Exception;
<br>
<br> void removeProducer(ConnectionContext context, ProducerInfo info) throws Exception;
<br>@@ -70,122 +72,146 @@
<br> String getName();
<br>
<br> MessageStore getMessageStore();
<br>-
<br>+
<br> boolean isProducerFlowControl();
<br>-
<br>+
<br> void setProducerFlowControl(boolean value);
<br>-
<br>+
<br>+ /**
<br>+ * Set's the interval at which warnings about producers being blocked by
<br>+ * resource usage will be triggered. Values of 0 or less will disable
<br>+ * warnings
<br>+ *
<br>+ * @param blockedProducerWarningInterval the interval at which warning about
<br>+ * blocked producers will be triggered.
<br>+ */
<br>+ public void setBlockedProducerWarningInterval(long blockedProducerWarningInterval);
<br>+
<br>+ /**
<br>+ *
<br>+ * @return the interval at which warning about blocked producers will be
<br>+ * triggered.
<br>+ */
<br>+ public long getBlockedProducerWarningInterval();
<br>+
<br> int getMaxProducersToAudit();
<br>-
<br>+
<br> void setMaxProducersToAudit(int maxProducersToAudit);
<br>-
<br>+
<br> int getMaxAuditDepth();
<br>-
<br>+
<br> void setMaxAuditDepth(int maxAuditDepth);
<br>-
<br>+
<br> boolean isEnableAudit();
<br>-
<br>+
<br> void setEnableAudit(boolean enableAudit);
<br>-
<br>- boolean isActive();
<br>-
<br>+
<br>+ boolean isActive();
<br>+
<br> int getMaxPageSize();
<br>-
<br>+
<br> public void setMaxPageSize(int maxPageSize);
<br>-
<br>+
<br> public int getMaxBrowsePageSize();
<br>
<br> public void setMaxBrowsePageSize(int maxPageSize);
<br>-
<br>+
<br> public boolean isUseCache();
<br>-
<br>+
<br> public void setUseCache(boolean useCache);
<br>-
<br>+
<br> public int getMinimumMessageSize();
<br>
<br> public void setMinimumMessageSize(int minimumMessageSize);
<br>-
<br>+
<br> public int getCursorMemoryHighWaterMark();
<br>
<br>- public void setCursorMemoryHighWaterMark(int cursorMemoryHighWaterMark);
<br>-
<br>+ public void setCursorMemoryHighWaterMark(int cursorMemoryHighWaterMark);
<br>+
<br> /**
<br>- * optionally called by a Subscriber - to inform the Destination its
<br>- * ready for more messages
<br>+ * optionally called by a Subscriber - to inform the Destination its ready
<br>+ * for more messages
<br> */
<br> public void wakeup();
<br>-
<br>+
<br> /**
<br> * @return true if lazyDispatch is enabled
<br> */
<br> public boolean isLazyDispatch();
<br>-
<br>-
<br>+
<br> /**
<br> * set the lazy dispatch - default is false
<br>+ *
<br> * @param value
<br> */
<br> public void setLazyDispatch(boolean value);
<br>
<br>-
<br> /**
<br> * Inform the Destination a message has expired
<br>+ *
<br> * @param context
<br>- * @param subs
<br>+ * @param subs
<br> * @param node
<br> */
<br>- void messageExpired(ConnectionContext context, Subscription subs,MessageReference node);
<br>+ void messageExpired(ConnectionContext context, Subscription subs, MessageReference node);
<br>
<br> /**
<br> * called when message is consumed
<br>+ *
<br> * @param context
<br> * @param messageReference
<br> */
<br>- void messageConsumed(ConnectionContext context, MessageReference messageReference);
<br>-
<br>+ void messageConsumed(ConnectionContext context, MessageReference messageReference);
<br>+
<br> /**
<br> * Called when message is delivered to the broker
<br>+ *
<br> * @param context
<br> * @param messageReference
<br> */
<br>- void messageDelivered(ConnectionContext context, MessageReference messageReference);
<br>-
<br>+ void messageDelivered(ConnectionContext context, MessageReference messageReference);
<br>+
<br> /**
<br>- * Called when a message is discarded - e.g. running low on memory
<br>- * This will happen only if the policy is enabled - e.g. non durable topics
<br>+ * Called when a message is discarded - e.g. running low on memory This will
<br>+ * happen only if the policy is enabled - e.g. non durable topics
<br>+ *
<br> * @param context
<br> * @param messageReference
<br> */
<br>- void messageDiscarded(ConnectionContext context, MessageReference messageReference);
<br>-
<br>+ void messageDiscarded(ConnectionContext context, MessageReference messageReference);
<br>+
<br> /**
<br> * Called when there is a slow consumer
<br>+ *
<br> * @param context
<br> * @param subs
<br> */
<br>- void slowConsumer(ConnectionContext context, Subscription subs);
<br>-
<br>+ void slowConsumer(ConnectionContext context, Subscription subs);
<br>+
<br> /**
<br> * Called to notify a producer is too fast
<br>+ *
<br> * @param context
<br> * @param producerInfo
<br> */
<br>- void fastProducer(ConnectionContext context,ProducerInfo producerInfo);
<br>-
<br>+ void fastProducer(ConnectionContext context, ProducerInfo producerInfo);
<br>+
<br> /**
<br> * Called when a Usage reaches a limit
<br>+ *
<br> * @param context
<br> * @param usage
<br> */
<br>- void isFull(ConnectionContext context,Usage usage);
<br>+ void isFull(ConnectionContext context, Usage usage);
<br>
<br> List<Subscription> getConsumers();
<br>
<br> /**
<br>- * called on Queues in slave mode to allow dispatch to follow subscription choice of master
<br>+ * called on Queues in slave mode to allow dispatch to follow subscription
<br>+ * choice of master
<br>+ *
<br> * @param messageDispatchNotification
<br> * @throws Exception
<br> */
<br>- void processDispatchNotification(
<br>- MessageDispatchNotification messageDispatchNotification) throws Exception;
<br>+ void processDispatchNotification(MessageDispatchNotification messageDispatchNotification) throws Exception;
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/DestinationFilter.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/DestinationFilter.java?rev=884234&r1=884233&r2=884234&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/DestinationFilter.java?rev=884234&r1=884233&r2=884234&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/DestinationFilter.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/DestinationFilter.java Wed Nov 25 19:35:09 2009
<br>@@ -45,8 +45,7 @@
<br> this.next = next;
<br> }
<br>
<br>- public void acknowledge(ConnectionContext context, Subscription sub, MessageAck ack, MessageReference node)
<br>- throws IOException {
<br>+ public void acknowledge(ConnectionContext context, Subscription sub, MessageAck ack, MessageReference node) throws IOException {
<br> next.acknowledge(context, sub, ack, node);
<br> }
<br>
<br>@@ -108,13 +107,13 @@
<br>
<br> /**
<br> * Sends a message to the given destination which may be a wildcard
<br>+ *
<br> * @param context broker context
<br> * @param message message to send
<br> * @param destination possibly wildcard destination to send the message to
<br> * @throws Exception on error
<br> */
<br>- protected void send(ProducerBrokerExchange context, Message message, ActiveMQDestination destination)
<br>- throws Exception {
<br>+ protected void send(ProducerBrokerExchange context, Message message, ActiveMQDestination destination) throws Exception {
<br> Broker broker = context.getConnectionContext().getBroker();
<br> Set<Destination> destinations = broker.getDestinations(destination);
<br>
<br>@@ -130,24 +129,30 @@
<br> public boolean isProducerFlowControl() {
<br> return next.isProducerFlowControl();
<br> }
<br>-
<br>- public void setProducerFlowControl(boolean value){
<br>+
<br>+ public void setProducerFlowControl(boolean value) {
<br> next.setProducerFlowControl(value);
<br> }
<br>
<br>- public void addProducer(ConnectionContext context, ProducerInfo info)
<br>- throws Exception {
<br>+ public void setBlockedProducerWarningInterval(long blockedProducerWarningInterval) {
<br>+ next.setBlockedProducerWarningInterval(blockedProducerWarningInterval);
<br>+ }
<br>+
<br>+ public long getBlockedProducerWarningInterval() {
<br>+ return next.getBlockedProducerWarningInterval();
<br>+ }
<br>+
<br>+ public void addProducer(ConnectionContext context, ProducerInfo info) throws Exception {
<br> next.addProducer(context, info);
<br>-
<br>+
<br> }
<br>
<br>- public void removeProducer(ConnectionContext context, ProducerInfo info)
<br>- throws Exception {
<br>- next.removeProducer(context, info);
<br>+ public void removeProducer(ConnectionContext context, ProducerInfo info) throws Exception {
<br>+ next.removeProducer(context, info);
<br> }
<br>
<br> public int getMaxAuditDepth() {
<br>- return next.getMaxAuditDepth();
<br>+ return next.getMaxAuditDepth();
<br> }
<br>
<br> public int getMaxProducersToAudit() {
<br>@@ -157,20 +162,19 @@
<br> public boolean isEnableAudit() {
<br> return next.isEnableAudit();
<br> }
<br>-
<br>+
<br> public void setEnableAudit(boolean enableAudit) {
<br> next.setEnableAudit(enableAudit);
<br> }
<br>
<br> public void setMaxAuditDepth(int maxAuditDepth) {
<br>- next.setMaxAuditDepth(maxAuditDepth);
<br>+ next.setMaxAuditDepth(maxAuditDepth);
<br> }
<br>
<br>-
<br> public void setMaxProducersToAudit(int maxProducersToAudit) {
<br>- next.setMaxProducersToAudit(maxProducersToAudit);
<br>+ next.setMaxProducersToAudit(maxProducersToAudit);
<br> }
<br>-
<br>+
<br> public boolean isActive() {
<br> return next.isActive();
<br> }
<br>@@ -189,88 +193,81 @@
<br>
<br> public void setUseCache(boolean useCache) {
<br> next.setUseCache(useCache);
<br>- }
<br>-
<br>+ }
<br>+
<br> public int getMinimumMessageSize() {
<br> return next.getMinimumMessageSize();
<br> }
<br>
<br> public void setMinimumMessageSize(int minimumMessageSize) {
<br> next.setMinimumMessageSize(minimumMessageSize);
<br>- }
<br>-
<br>+ }
<br>+
<br> public void wakeup() {
<br> next.wakeup();
<br> }
<br>
<br> public boolean isLazyDispatch() {
<br>- return next.isLazyDispatch();
<br>+ return next.isLazyDispatch();
<br> }
<br>
<br> public void setLazyDispatch(boolean value) {
<br>- next.setLazyDispatch(value);
<br>+ next.setLazyDispatch(value);
<br> }
<br>
<br> public void messageExpired(ConnectionContext context, PrefetchSubscription prefetchSubscription, MessageReference node) {
<br>- next.messageExpired(context, prefetchSubscription, node);
<br>+ next.messageExpired(context, prefetchSubscription, node);
<br> }
<br>
<br>- public boolean iterate() {
<br>- return next.iterate();
<br>- }
<br>+ public boolean iterate() {
<br>+ return next.iterate();
<br>+ }
<br>
<br>- public void fastProducer(ConnectionContext context,ProducerInfo producerInfo) {
<br>- next.fastProducer(context, producerInfo);
<br>+ public void fastProducer(ConnectionContext context, ProducerInfo producerInfo) {
<br>+ next.fastProducer(context, producerInfo);
<br> }
<br>
<br>-
<br> public void isFull(ConnectionContext context, Usage usage) {
<br>- next.isFull(context, usage);
<br>+ next.isFull(context, usage);
<br> }
<br>
<br>-
<br>- public void messageConsumed(ConnectionContext context,MessageReference messageReference) {
<br>+ public void messageConsumed(ConnectionContext context, MessageReference messageReference) {
<br> next.messageConsumed(context, messageReference);
<br> }
<br>
<br>-
<br>- public void messageDelivered(ConnectionContext context,MessageReference messageReference) {
<br>+ public void messageDelivered(ConnectionContext context, MessageReference messageReference) {
<br> next.messageDelivered(context, messageReference);
<br> }
<br>
<br>-
<br>- public void messageDiscarded(ConnectionContext context,MessageReference messageReference) {
<br>+ public void messageDiscarded(ConnectionContext context, MessageReference messageReference) {
<br> next.messageDiscarded(context, messageReference);
<br> }
<br>
<br>-
<br> public void slowConsumer(ConnectionContext context, Subscription subs) {
<br>- next.slowConsumer(context, subs);
<br>+ next.slowConsumer(context, subs);
<br> }
<br>
<br>-
<br>- public void messageExpired(ConnectionContext context, Subscription subs,MessageReference node) {
<br>- next.messageExpired(context,subs, node);
<br>+ public void messageExpired(ConnectionContext context, Subscription subs, MessageReference node) {
<br>+ next.messageExpired(context, subs, node);
<br> }
<br>
<br> public int getMaxBrowsePageSize() {
<br>- return next.getMaxBrowsePageSize();
<br>+ return next.getMaxBrowsePageSize();
<br> }
<br>
<br> public void setMaxBrowsePageSize(int maxPageSize) {
<br> next.setMaxBrowsePageSize(maxPageSize);
<br> }
<br>
<br>- public void processDispatchNotification(
<br>- MessageDispatchNotification messageDispatchNotification) throws Exception {
<br>- next.processDispatchNotification(messageDispatchNotification);
<br>+ public void processDispatchNotification(MessageDispatchNotification messageDispatchNotification) throws Exception {
<br>+ next.processDispatchNotification(messageDispatchNotification);
<br> }
<br>
<br>- public int getCursorMemoryHighWaterMark() {
<br>- return next.getCursorMemoryHighWaterMark();
<br>- }
<br>-
<br>- public void setCursorMemoryHighWaterMark(int cursorMemoryHighWaterMark) {
<br>- next.setCursorMemoryHighWaterMark(cursorMemoryHighWaterMark);
<br>- }
<br>+ public int getCursorMemoryHighWaterMark() {
<br>+ return next.getCursorMemoryHighWaterMark();
<br>+ }
<br>+
<br>+ public void setCursorMemoryHighWaterMark(int cursorMemoryHighWaterMark) {
<br>+ next.setCursorMemoryHighWaterMark(cursorMemoryHighWaterMark);
<br>+ }
<br> }
<br><br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Commits-f23834.html" embed="fixTarget[23834]" target="_top" >ActiveMQ - Commits</a></p>
tag:old.nabble.com,2006:post-26518950
svn commit: r884234 [2/2] - in /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker: jmx/ region/ region/policy/
2009-11-25T11:35:10Z
2009-11-25T11:35:10Z
cmacnaug
Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java?rev=884234&r1=884233&r2=884234&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java?rev=884234&r1=884233&r2=884234&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java Wed Nov 25 19:35:09 2009
<br>@@ -75,7 +75,6 @@
<br> import org.apache.commons.logging.Log;
<br> import org.apache.commons.logging.LogFactory;
<br>
<br>-
<br> /**
<br> * The Queue is a List of MessageEntry objects that are dispatched to matching
<br> * subscriptions.
<br>@@ -85,10 +84,10 @@
<br> public class Queue extends BaseDestination implements Task, UsageListener {
<br> protected static final Log LOG = LogFactory.getLog(Queue.class);
<br> protected final TaskRunnerFactory taskFactory;
<br>- protected TaskRunner taskRunner;
<br>+ protected TaskRunner taskRunner;
<br> protected final List<Subscription> consumers = new ArrayList<Subscription>(50);
<br> protected PendingMessageCursor messages;
<br>- private final LinkedHashMap<MessageId,QueueMessageReference> pagedInMessages = new LinkedHashMap<MessageId,QueueMessageReference>();
<br>+ private final LinkedHashMap<MessageId, QueueMessageReference> pagedInMessages = new LinkedHashMap<MessageId, QueueMessageReference>();
<br> // Messages that are paged in but have not yet been targeted at a subscription
<br> private List<QueueMessageReference> pagedInPendingDispatch = new ArrayList<QueueMessageReference>(100);
<br> private MessageGroupMap messageGroupOwners;
<br>@@ -98,16 +97,16 @@
<br> private ExecutorService executor;
<br> protected final LinkedList<Runnable> messagesWaitingForSpace = new LinkedList<Runnable>();
<br> private final Object dispatchMutex = new Object();
<br>- private boolean useConsumerPriority=true;
<br>- private boolean strictOrderDispatch=false;
<br>+ private boolean useConsumerPriority = true;
<br>+ private boolean strictOrderDispatch = false;
<br> private QueueDispatchSelector dispatchSelector;
<br>- private boolean optimizedDispatch=false;
<br>+ private boolean optimizedDispatch = false;
<br> private boolean firstConsumer = false;
<br> private int timeBeforeDispatchStarts = 0;
<br> private int consumersBeforeDispatchStarts = 0;
<br> private CountDownLatch consumersBeforeStartsLatch;
<br> private AtomicLong pendingWakeups = new AtomicLong();
<br>-
<br>+
<br> private final Runnable sendMessagesWaitingForSpaceTask = new Runnable() {
<br> public void run() {
<br> asyncWakeup();
<br>@@ -115,25 +114,24 @@
<br> };
<br> private final Runnable expireMessagesTask = new Runnable() {
<br> public void run() {
<br>- expireMessages();
<br>+ expireMessages();
<br> }
<br> };
<br> private final Object iteratingMutex = new Object() {};
<br> private static final Scheduler scheduler = Scheduler.getInstance();
<br>-
<br>- private static final Comparator<Subscription>orderedCompare = new Comparator<Subscription>() {
<br>+
<br>+ private static final Comparator<Subscription> orderedCompare = new Comparator<Subscription>() {
<br>
<br> public int compare(Subscription s1, Subscription s2) {
<br> //We want the list sorted in descending order
<br> return s2.getConsumerInfo().getPriority() - s1.getConsumerInfo().getPriority();
<br>- }
<br>+ }
<br> };
<br>-
<br>- public Queue(BrokerService brokerService, final ActiveMQDestination destination, MessageStore store,DestinationStatistics parentStats,
<br>- TaskRunnerFactory taskFactory) throws Exception {
<br>+
<br>+ public Queue(BrokerService brokerService, final ActiveMQDestination destination, MessageStore store, DestinationStatistics parentStats, TaskRunnerFactory taskFactory) throws Exception {
<br> super(brokerService, store, destination, parentStats);
<br>- this.taskFactory=taskFactory;
<br>- this.dispatchSelector=new QueueDispatchSelector(destination);
<br>+ this.taskFactory = taskFactory;
<br>+ this.dispatchSelector = new QueueDispatchSelector(destination);
<br> }
<br>
<br> public List<Subscription> getConsumers() {
<br>@@ -145,13 +143,13 @@
<br> // make the queue easily visible in the debugger from its task runner threads
<br> final class QueueThread extends Thread {
<br> final Queue queue;
<br>- public QueueThread(Runnable runnable, String name,
<br>- Queue queue) {
<br>+
<br>+ public QueueThread(Runnable runnable, String name, Queue queue) {
<br> super(runnable, name);
<br> this.queue = queue;
<br> }
<br> }
<br>-
<br>+
<br> public void initialize() throws Exception {
<br> if (this.messages == null) {
<br> if (destination.isTemporary() || broker == null || store == null) {
<br>@@ -168,10 +166,9 @@
<br> this.systemUsage = brokerService.getSystemUsage();
<br> memoryUsage.setParent(systemUsage.getMemoryUsage());
<br> }
<br>-
<br>- this.taskRunner =
<br>- taskFactory.createTaskRunner(this, "Queue:" + destination.getPhysicalName());
<br>-
<br>+
<br>+ this.taskRunner = taskFactory.createTaskRunner(this, "Queue:" + destination.getPhysicalName());
<br>+
<br> super.initialize();
<br> if (store != null) {
<br> // Restore the persistent messages.
<br>@@ -217,12 +214,12 @@
<br> public boolean hasSpace() {
<br> return true;
<br> }
<br>-
<br>+
<br> public boolean isDuplicate(MessageId id) {
<br> return false;
<br> }
<br> });
<br>- }else {
<br>+ } else {
<br> int messageCount = store.getMessageCount();
<br> destinationStatistics.getMessages().setCount(messageCount);
<br> }
<br>@@ -230,22 +227,20 @@
<br> }
<br>
<br> /*
<br>- * Holder for subscription and pagedInMessages as a browser
<br>- * needs access to existing messages in the queue that have
<br>- * already been dispatched
<br>+ * Holder for subscription and pagedInMessages as a browser needs access to
<br>+ * existing messages in the queue that have already been dispatched
<br> */
<br> class BrowserDispatch {
<br> ArrayList<QueueMessageReference> messages;
<br> QueueBrowserSubscription browser;
<br>-
<br>- public BrowserDispatch(QueueBrowserSubscription browserSubscription,
<br>- Collection<QueueMessageReference> values) {
<br>-
<br>- messages = new ArrayList<QueueMessageReference>(values);
<br>+
<br>+ public BrowserDispatch(QueueBrowserSubscription browserSubscription, Collection<QueueMessageReference> values) {
<br>+
<br>+ messages = new ArrayList<QueueMessageReference>(values);
<br> browser = browserSubscription;
<br> browser.incrementQueueRef();
<br> }
<br>-
<br>+
<br> void done() {
<br> try {
<br> browser.decrementQueueRef();
<br>@@ -258,57 +253,57 @@
<br> return browser;
<br> }
<br> }
<br>-
<br>+
<br> LinkedList<BrowserDispatch> browserDispatches = new LinkedList<BrowserDispatch>();
<br>
<br> public void addSubscription(ConnectionContext context, Subscription sub) throws Exception {
<br> // synchronize with dispatch method so that no new messages are sent
<br> // while setting up a subscription. avoid out of order messages,
<br> // duplicates, etc.
<br>- synchronized(dispatchMutex) {
<br>-
<br>+ synchronized (dispatchMutex) {
<br>+
<br> sub.add(context, this);
<br> destinationStatistics.getConsumers().increment();
<br>
<br> // needs to be synchronized - so no contention with dispatching
<br> synchronized (consumers) {
<br>-
<br>- // set a flag if this is a first consumer
<br>- if (consumers.size() == 0) {
<br>- firstConsumer = true;
<br>- if (consumersBeforeDispatchStarts != 0) {
<br>- consumersBeforeStartsLatch = new CountDownLatch(consumersBeforeDispatchStarts - 1);
<br>- }
<br>- } else {
<br>- if (consumersBeforeStartsLatch != null) {
<br>- consumersBeforeStartsLatch.countDown();
<br>- }
<br>- }
<br>-
<br>+
<br>+ // set a flag if this is a first consumer
<br>+ if (consumers.size() == 0) {
<br>+ firstConsumer = true;
<br>+ if (consumersBeforeDispatchStarts != 0) {
<br>+ consumersBeforeStartsLatch = new CountDownLatch(consumersBeforeDispatchStarts - 1);
<br>+ }
<br>+ } else {
<br>+ if (consumersBeforeStartsLatch != null) {
<br>+ consumersBeforeStartsLatch.countDown();
<br>+ }
<br>+ }
<br>+
<br> addToConsumerList(sub);
<br> if (sub.getConsumerInfo().isExclusive()) {
<br> Subscription exclusiveConsumer = dispatchSelector.getExclusiveConsumer();
<br>- if(exclusiveConsumer==null) {
<br>- exclusiveConsumer=sub;
<br>- }else if (sub.getConsumerInfo().getPriority() > exclusiveConsumer.getConsumerInfo().getPriority()){
<br>- exclusiveConsumer=sub;
<br>+ if (exclusiveConsumer == null) {
<br>+ exclusiveConsumer = sub;
<br>+ } else if (sub.getConsumerInfo().getPriority() > exclusiveConsumer.getConsumerInfo().getPriority()) {
<br>+ exclusiveConsumer = sub;
<br> }
<br> dispatchSelector.setExclusiveConsumer(exclusiveConsumer);
<br> }
<br> }
<br>-
<br>- if (sub instanceof QueueBrowserSubscription ) {
<br>+
<br>+ if (sub instanceof QueueBrowserSubscription) {
<br> QueueBrowserSubscription browserSubscription = (QueueBrowserSubscription) sub;
<br>-
<br>+
<br> // do again in iterate to ensure new messages are dispatched
<br> pageInMessages(false);
<br>-
<br>- synchronized (pagedInMessages) {
<br>- if (!pagedInMessages.isEmpty()) {
<br>- BrowserDispatch browserDispatch = new BrowserDispatch(browserSubscription, pagedInMessages.values());
<br>- browserDispatches.addLast(browserDispatch);
<br>- }
<br>- }
<br>+
<br>+ synchronized (pagedInMessages) {
<br>+ if (!pagedInMessages.isEmpty()) {
<br>+ BrowserDispatch browserDispatch = new BrowserDispatch(browserSubscription, pagedInMessages.values());
<br>+ browserDispatches.addLast(browserDispatch);
<br>+ }
<br>+ }
<br> }
<br> if (!(this.optimizedDispatch || isSlave())) {
<br> wakeup();
<br>@@ -321,30 +316,23 @@
<br> }
<br> }
<br>
<br>- public void removeSubscription(ConnectionContext context, Subscription sub, long lastDeiveredSequenceId)
<br>- throws Exception {
<br>+ public void removeSubscription(ConnectionContext context, Subscription sub, long lastDeiveredSequenceId) throws Exception {
<br> destinationStatistics.getConsumers().decrement();
<br> // synchronize with dispatch method so that no new messages are sent
<br> // while removing up a subscription.
<br>- synchronized(dispatchMutex) {
<br>+ synchronized (dispatchMutex) {
<br> if (LOG.isDebugEnabled()) {
<br>- LOG.debug("remove sub: " + sub + ", lastDeliveredSeqId: " + lastDeiveredSequenceId
<br>- + ", dequeues: " + getDestinationStatistics().getDequeues().getCount()
<br>- + ", dispatched: " + getDestinationStatistics().getDispatched().getCount()
<br>- + ", inflight: " + getDestinationStatistics().getInflight().getCount());
<br>+ LOG.debug("remove sub: " + sub + ", lastDeliveredSeqId: " + lastDeiveredSequenceId + ", dequeues: " + getDestinationStatistics().getDequeues().getCount() + ", dispatched: "
<br>+ + getDestinationStatistics().getDispatched().getCount() + ", inflight: " + getDestinationStatistics().getInflight().getCount());
<br> }
<br> synchronized (consumers) {
<br> removeFromConsumerList(sub);
<br> if (sub.getConsumerInfo().isExclusive()) {
<br>- Subscription exclusiveConsumer = dispatchSelector
<br>- .getExclusiveConsumer();
<br>+ Subscription exclusiveConsumer = dispatchSelector.getExclusiveConsumer();
<br> if (exclusiveConsumer == sub) {
<br> exclusiveConsumer = null;
<br> for (Subscription s : consumers) {
<br>- if (s.getConsumerInfo().isExclusive()
<br>- && (exclusiveConsumer == null
<br>- || s.getConsumerInfo().getPriority() > exclusiveConsumer
<br>- .getConsumerInfo().getPriority())) {
<br>+ if (s.getConsumerInfo().isExclusive() && (exclusiveConsumer == null || s.getConsumerInfo().getPriority() > exclusiveConsumer.getConsumerInfo().getPriority())) {
<br> exclusiveConsumer = s;
<br>
<br> }
<br>@@ -354,12 +342,12 @@
<br> }
<br> ConsumerId consumerId = sub.getConsumerInfo().getConsumerId();
<br> getMessageGroupOwners().removeConsumer(consumerId);
<br>-
<br>+
<br> // redeliver inflight messages
<br> List<QueueMessageReference> list = new ArrayList<QueueMessageReference>();
<br> for (MessageReference ref : sub.remove(context, this)) {
<br>- QueueMessageReference qmr = (QueueMessageReference)ref;
<br>- if( qmr.getLockOwner()==sub ) {
<br>+ QueueMessageReference qmr = (QueueMessageReference) ref;
<br>+ if (qmr.getLockOwner() == sub) {
<br> qmr.unlock();
<br> // only increment redelivery if it was delivered or we have no delivery information
<br> if (lastDeiveredSequenceId == 0 || qmr.getMessageId().getBrokerSequenceId() <= lastDeiveredSequenceId) {
<br>@@ -368,7 +356,7 @@
<br> }
<br> list.add(qmr);
<br> }
<br>-
<br>+
<br> if (!list.isEmpty()) {
<br> doDispatch(list);
<br> }
<br>@@ -400,32 +388,33 @@
<br> }
<br> return;
<br> }
<br>- if(memoryUsage.isFull()) {
<br>+ if (memoryUsage.isFull()) {
<br> isFull(context, memoryUsage);
<br> fastProducer(context, producerInfo);
<br> if (isProducerFlowControl() && context.isProducerFlowControl()) {
<br>- if(warnOnProducerFlowControl) {
<br>+ if (warnOnProducerFlowControl) {
<br> warnOnProducerFlowControl = false;
<br>- LOG.info("Usage Manager memory limit reached on " +getActiveMQDestination().getQualifiedName() + ". Producers will be throttled to the rate at which messages are removed from this destination to prevent flooding it." +
<br>- " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br>+ LOG.info("Usage Manager Memory Limit reached on " + getActiveMQDestination().getQualifiedName()
<br>+ + ". Producers will be throttled to the rate at which messages are removed from this destination to prevent flooding it."
<br>+ + " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br> }
<br>-
<br>+
<br> if (systemUsage.isSendFailIfNoSpace()) {
<br>- throw new javax.jms.ResourceAllocationException("Usage Manager memory limit reached. Stopping producer (" + message.getProducerId() + ") to prevent flooding " +getActiveMQDestination().getQualifiedName() + "." +
<br>- " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br>+ throw new javax.jms.ResourceAllocationException("Usage Manager Memory Limit reached. Stopping producer (" + message.getProducerId() + ") to prevent flooding "
<br>+ + getActiveMQDestination().getQualifiedName() + "." + " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br> }
<br>-
<br>+
<br> // We can avoid blocking due to low usage if the producer is sending
<br> // a sync message or
<br> // if it is using a producer window
<br> if (producerInfo.getWindowSize() > 0 || message.isResponseRequired()) {
<br> // copy the exchange state since the context will be modified while we are waiting
<br> // for space.
<br>- final ProducerBrokerExchange producerExchangeCopy = producerExchange.copy();
<br>+ final ProducerBrokerExchange producerExchangeCopy = producerExchange.copy();
<br> synchronized (messagesWaitingForSpace) {
<br> messagesWaitingForSpace.add(new Runnable() {
<br> public void run() {
<br>-
<br>+
<br> try {
<br> // While waiting for space to free up... the
<br> // message may have expired.
<br>@@ -436,7 +425,7 @@
<br> } else {
<br> doMessageSend(producerExchangeCopy, message);
<br> }
<br>-
<br>+
<br> if (sendProducerAck) {
<br> ProducerAck ack = new ProducerAck(producerInfo.getProducerId(), message.getSize());
<br> context.getConnection().dispatchAsync(ack);
<br>@@ -445,7 +434,7 @@
<br> response.setCorrelationId(message.getCommandId());
<br> context.getConnection().dispatchAsync(response);
<br> }
<br>-
<br>+
<br> } catch (Exception e) {
<br> if (!sendProducerAck && !context.isInRecoveryMode()) {
<br> ExceptionResponse response = new ExceptionResponse(e);
<br>@@ -455,7 +444,7 @@
<br> }
<br> }
<br> });
<br>-
<br>+
<br> // If the user manager is not full, then the task will not
<br> // get called..
<br> if (!memoryUsage.notifyCallbackWhenNotFull(sendMessagesWaitingForSpaceTask)) {
<br>@@ -465,18 +454,14 @@
<br> context.setDontSendReponse(true);
<br> return;
<br> }
<br>-
<br>+
<br> } else {
<br>-
<br>- // Producer flow control cannot be used, so we have do the flow
<br>- // control at the broker
<br>- // by blocking this thread until there is space available.
<br>- while (!memoryUsage.waitForSpace(1000)) {
<br>- if (context.getStopping().get()) {
<br>- throw new IOException("Connection closed, send aborted.");
<br>- }
<br>+
<br>+ if (memoryUsage.isFull()) {
<br>+ waitForSpace(context, memoryUsage, "Usage Manager Memory Limit is full. Producer (" + message.getProducerId() + ") stopped to prevent flooding "
<br>+ + getActiveMQDestination().getQualifiedName() + "." + " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br> }
<br>-
<br>+
<br> // The usage manager could have delayed us by the time
<br> // we unblock the message could have expired..
<br> if (message.isExpired()) {
<br>@@ -501,19 +486,15 @@
<br> synchronized (sendLock) {
<br> if (store != null && message.isPersistent()) {
<br> if (systemUsage.getStoreUsage().isFull()) {
<br>- final String logMessage = "Usage Manager Store is Full. Stopping producer (" + message.getProducerId() + ") to prevent flooding " + getActiveMQDestination().getQualifiedName() + "." +
<br>- " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info";
<br>- LOG.info(logMessage);
<br>+
<br>+ String logMessage = "Usage Manager Store is Full. Producer (" + message.getProducerId() + ") stopped to prevent flooding " + getActiveMQDestination().getQualifiedName() + "."
<br>+ + " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info";
<br>+
<br> if (systemUsage.isSendFailIfNoSpace()) {
<br> throw new javax.jms.ResourceAllocationException(logMessage);
<br> }
<br>- }
<br>- while (!systemUsage.getStoreUsage().waitForSpace(1000)) {
<br>- if (context.getStopping().get()) {
<br>- throw new IOException(
<br>- "Connection closed, send aborted.");
<br>- }
<br>- LOG.debug(this + ", waiting for store space... msg: " + message);
<br>+
<br>+ waitForSpace(context, systemUsage.getStoreUsage(), logMessage);
<br> }
<br> message.getMessageId().setBrokerSequenceId(getDestinationSequenceId());
<br> store.addMessage(context, message);
<br>@@ -552,12 +533,12 @@
<br> sendMessage(context, message);
<br> }
<br> }
<br>-
<br>+
<br> private void expireMessages() {
<br> if (LOG.isDebugEnabled()) {
<br> LOG.debug("Expiring messages ..");
<br> }
<br>-
<br>+
<br> // just track the insertion count
<br> List<Message> browsedMessages = new AbstractList<Message>() {
<br> int size = 0;
<br>@@ -581,9 +562,9 @@
<br> asyncWakeup();
<br> }
<br>
<br>- public void gc(){
<br>+ public void gc() {
<br> }
<br>-
<br>+
<br> public void acknowledge(ConnectionContext context, Subscription sub, MessageAck ack, MessageReference node) throws IOException {
<br> messageConsumed(context, node);
<br> if (store != null && node.isPersistent()) {
<br>@@ -616,8 +597,8 @@
<br> synchronized (messages) {
<br> size = messages.size();
<br> }
<br>- return "Queue: destination=" + destination.getPhysicalName() + ", subscriptions=" + consumers.size() + ", memory=" + memoryUsage.getPercentUsage() + "%, size=" + size
<br>- + ", in flight groups=" + messageGroupOwners;
<br>+ return "Queue: destination=" + destination.getPhysicalName() + ", subscriptions=" + consumers.size() + ", memory=" + memoryUsage.getPercentUsage() + "%, size=" + size + ", in flight groups="
<br>+ + messageGroupOwners;
<br> }
<br>
<br> public void start() throws Exception {
<br>@@ -632,25 +613,25 @@
<br> doPageIn(false);
<br> }
<br>
<br>- public void stop() throws Exception{
<br>+ public void stop() throws Exception {
<br> if (taskRunner != null) {
<br> taskRunner.shutdown();
<br> }
<br> if (this.executor != null) {
<br> this.executor.shutdownNow();
<br> }
<br>-
<br>+
<br> scheduler.cancel(expireMessagesTask);
<br>-
<br>+
<br> if (messages != null) {
<br> messages.stop();
<br> }
<br>-
<br>+
<br> systemUsage.getMemoryUsage().removeUsageListener(this);
<br> if (memoryUsage != null) {
<br> memoryUsage.stop();
<br> }
<br>- if (store!=null) {
<br>+ if (store != null) {
<br> store.stop();
<br> }
<br> }
<br>@@ -661,7 +642,6 @@
<br> return destination;
<br> }
<br>
<br>-
<br> public MessageGroupMap getMessageGroupOwners() {
<br> if (messageGroupOwners == null) {
<br> messageGroupOwners = getMessageGroupMapFactory().createMessageGroupMap();
<br>@@ -692,7 +672,7 @@
<br> public void setMessages(PendingMessageCursor messages) {
<br> this.messages = messages;
<br> }
<br>-
<br>+
<br> public boolean isUseConsumerPriority() {
<br> return useConsumerPriority;
<br> }
<br>@@ -708,7 +688,6 @@
<br> public void setStrictOrderDispatch(boolean strictOrderDispatch) {
<br> this.strictOrderDispatch = strictOrderDispatch;
<br> }
<br>-
<br>
<br> public boolean isOptimizedDispatch() {
<br> return optimizedDispatch;
<br>@@ -717,21 +696,22 @@
<br> public void setOptimizedDispatch(boolean optimizedDispatch) {
<br> this.optimizedDispatch = optimizedDispatch;
<br> }
<br>- public int getTimeBeforeDispatchStarts() {
<br>- return timeBeforeDispatchStarts;
<br>- }
<br>-
<br>- public void setTimeBeforeDispatchStarts(int timeBeforeDispatchStarts) {
<br>- this.timeBeforeDispatchStarts = timeBeforeDispatchStarts;
<br>- }
<br>-
<br>- public int getConsumersBeforeDispatchStarts() {
<br>- return consumersBeforeDispatchStarts;
<br>- }
<br>-
<br>- public void setConsumersBeforeDispatchStarts(int consumersBeforeDispatchStarts) {
<br>- this.consumersBeforeDispatchStarts = consumersBeforeDispatchStarts;
<br>- }
<br>+
<br>+ public int getTimeBeforeDispatchStarts() {
<br>+ return timeBeforeDispatchStarts;
<br>+ }
<br>+
<br>+ public void setTimeBeforeDispatchStarts(int timeBeforeDispatchStarts) {
<br>+ this.timeBeforeDispatchStarts = timeBeforeDispatchStarts;
<br>+ }
<br>+
<br>+ public int getConsumersBeforeDispatchStarts() {
<br>+ return consumersBeforeDispatchStarts;
<br>+ }
<br>+
<br>+ public void setConsumersBeforeDispatchStarts(int consumersBeforeDispatchStarts) {
<br>+ this.consumersBeforeDispatchStarts = consumersBeforeDispatchStarts;
<br>+ }
<br>
<br> // Implementation methods
<br> // -------------------------------------------------------------------------
<br>@@ -740,19 +720,18 @@
<br> return result;
<br> }
<br>
<br>- public Message[] browse() {
<br>+ public Message[] browse() {
<br> List<Message> l = new ArrayList<Message>();
<br> doBrowse(l, getMaxBrowsePageSize());
<br> return l.toArray(new Message[l.size()]);
<br> }
<br>-
<br>-
<br>+
<br> public void doBrowse(List<Message> l, int max) {
<br> final ConnectionContext connectionContext = createConnectionContext();
<br> try {
<br> pageInMessages(false);
<br> List<MessageReference> toExpire = new ArrayList<MessageReference>();
<br>- synchronized(dispatchMutex) {
<br>+ synchronized (dispatchMutex) {
<br> synchronized (pagedInPendingDispatch) {
<br> addAll(pagedInPendingDispatch, l, max, toExpire);
<br> for (MessageReference ref : toExpire) {
<br>@@ -775,17 +754,16 @@
<br> }
<br> }
<br> }
<br>-
<br>+
<br> if (l.size() < getMaxBrowsePageSize()) {
<br> synchronized (messages) {
<br> try {
<br> messages.reset();
<br> while (messages.hasNext() && l.size() < max) {
<br>- MessageReference node = messages.next();
<br>+ MessageReference node = messages.next();
<br> if (node.isExpired()) {
<br> if (broker.isExpired(node)) {
<br>- messageExpired(connectionContext,
<br>- createMessageReference(node.getMessage()));
<br>+ messageExpired(connectionContext, createMessageReference(node.getMessage()));
<br> }
<br> messages.remove();
<br> } else {
<br>@@ -800,16 +778,14 @@
<br> }
<br> }
<br> }
<br>- }
<br>+ }
<br> } catch (Exception e) {
<br> LOG.error("Problem retrieving message for browse", e);
<br>- }
<br>+ }
<br> }
<br>
<br>- private void addAll(Collection<QueueMessageReference> refs,
<br>- List<Message> l, int maxBrowsePageSize, List<MessageReference> toExpire) throws Exception {
<br>- for (Iterator<QueueMessageReference> i = refs.iterator(); i.hasNext()
<br>- && l.size() < getMaxBrowsePageSize();) {
<br>+ private void addAll(Collection<QueueMessageReference> refs, List<Message> l, int maxBrowsePageSize, List<MessageReference> toExpire) throws Exception {
<br>+ for (Iterator<QueueMessageReference> i = refs.iterator(); i.hasNext() && l.size() < getMaxBrowsePageSize();) {
<br> QueueMessageReference ref = i.next();
<br> if (ref.isExpired()) {
<br> toExpire.add(ref);
<br>@@ -843,8 +819,7 @@
<br> break;
<br> }
<br> } catch (IOException e) {
<br>- LOG.error("got an exception retrieving message "
<br>- + id);
<br>+ LOG.error("got an exception retrieving message " + id);
<br> }
<br> }
<br> } finally {
<br>@@ -857,10 +832,10 @@
<br> return null;
<br> }
<br>
<br>- public void purge() throws Exception {
<br>+ public void purge() throws Exception {
<br> ConnectionContext c = createConnectionContext();
<br> List<MessageReference> list = null;
<br>- do {
<br>+ do {
<br> doPageIn(true);
<br> synchronized (pagedInMessages) {
<br> list = new ArrayList<MessageReference>(pagedInMessages.values());
<br>@@ -869,11 +844,11 @@
<br> for (MessageReference ref : list) {
<br> try {
<br> QueueMessageReference r = (QueueMessageReference) ref;
<br>- removeMessage(c,(IndirectMessageReference) r);
<br>+ removeMessage(c, (IndirectMessageReference) r);
<br> } catch (IOException e) {
<br> }
<br> }
<br>-
<br>+
<br> } while (!pagedInMessages.isEmpty() || this.destinationStatistics.getMessages().getCount() > 0);
<br> gc();
<br> this.destinationStatistics.getMessages().setCount(0);
<br>@@ -921,15 +896,14 @@
<br> synchronized (pagedInMessages) {
<br> set.addAll(pagedInMessages.values());
<br> }
<br>- List <MessageReference>list = new ArrayList<MessageReference>(set);
<br>+ List<MessageReference> list = new ArrayList<MessageReference>(set);
<br> for (MessageReference ref : list) {
<br> IndirectMessageReference r = (IndirectMessageReference) ref;
<br> if (filter.evaluate(context, r)) {
<br>
<br> removeMessage(context, r);
<br> set.remove(r);
<br>- if (++movedCounter >= maximumMessages
<br>- && maximumMessages > 0) {
<br>+ if (++movedCounter >= maximumMessages && maximumMessages > 0) {
<br> return movedCounter;
<br> }
<br> }
<br>@@ -975,24 +949,23 @@
<br> int count = 0;
<br> Set<MessageReference> set = new CopyOnWriteArraySet<MessageReference>();
<br> do {
<br>- int oldMaxSize=getMaxPageSize();
<br>+ int oldMaxSize = getMaxPageSize();
<br> setMaxPageSize((int) this.destinationStatistics.getMessages().getCount());
<br> doPageIn(true);
<br> setMaxPageSize(oldMaxSize);
<br> synchronized (pagedInMessages) {
<br> set.addAll(pagedInMessages.values());
<br> }
<br>- List <MessageReference>list = new ArrayList<MessageReference>(set);
<br>+ List<MessageReference> list = new ArrayList<MessageReference>(set);
<br> for (MessageReference ref : list) {
<br> IndirectMessageReference r = (IndirectMessageReference) ref;
<br> if (filter.evaluate(context, r)) {
<br>-
<br>- r.incrementReferenceCount();
<br>+
<br>+ r.incrementReferenceCount();
<br> try {
<br> Message m = r.getMessage();
<br> BrokerSupport.resend(context, m, dest);
<br>- if (++movedCounter >= maximumMessages
<br>- && maximumMessages > 0) {
<br>+ if (++movedCounter >= maximumMessages && maximumMessages > 0) {
<br> return movedCounter;
<br> }
<br> } finally {
<br>@@ -1004,15 +977,16 @@
<br> } while (count < this.destinationStatistics.getMessages().getCount());
<br> return movedCounter;
<br> }
<br>-
<br>+
<br> /**
<br> * Move a message
<br>+ *
<br> * @param context connection context
<br> * @param m message
<br> * @param dest ActiveMQDestination
<br> * @throws Exception
<br> */
<br>- public boolean moveMessageTo(ConnectionContext context,Message m,ActiveMQDestination dest) throws Exception {
<br>+ public boolean moveMessageTo(ConnectionContext context, Message m, ActiveMQDestination dest) throws Exception {
<br> QueueMessageReference r = createMessageReference(m);
<br> BrokerSupport.resend(context, m, dest);
<br> removeMessage(context, r);
<br>@@ -1035,7 +1009,7 @@
<br> * @return the number of messages removed
<br> */
<br> public int moveMatchingMessagesTo(ConnectionContext context, String selector, ActiveMQDestination dest) throws Exception {
<br>- return moveMatchingMessagesTo(context, selector, dest,Integer.MAX_VALUE);
<br>+ return moveMatchingMessagesTo(context, selector, dest, Integer.MAX_VALUE);
<br> }
<br>
<br> /**
<br>@@ -1050,9 +1024,7 @@
<br> * Moves the messages matching the given filter up to the maximum number of
<br> * matched messages
<br> */
<br>- public int moveMatchingMessagesTo(ConnectionContext context,
<br>- MessageReferenceFilter filter, ActiveMQDestination dest,
<br>- int maximumMessages) throws Exception {
<br>+ public int moveMatchingMessagesTo(ConnectionContext context, MessageReferenceFilter filter, ActiveMQDestination dest, int maximumMessages) throws Exception {
<br> int movedCounter = 0;
<br> Set<MessageReference> set = new CopyOnWriteArraySet<MessageReference>();
<br> do {
<br>@@ -1067,20 +1039,18 @@
<br> // We should only move messages that can be locked.
<br> moveMessageTo(context, ref.getMessage(), dest);
<br> set.remove(r);
<br>- if (++movedCounter >= maximumMessages
<br>- && maximumMessages > 0) {
<br>+ if (++movedCounter >= maximumMessages && maximumMessages > 0) {
<br> return movedCounter;
<br> }
<br> }
<br> }
<br>- } while (set.size() < this.destinationStatistics.getMessages().getCount()
<br>- && set.size() < maximumMessages);
<br>+ } while (set.size() < this.destinationStatistics.getMessages().getCount() && set.size() < maximumMessages);
<br> return movedCounter;
<br> }
<br>-
<br>+
<br> BrowserDispatch getNextBrowserDispatch() {
<br> synchronized (pagedInMessages) {
<br>- if( browserDispatches.isEmpty() ) {
<br>+ if (browserDispatches.isEmpty()) {
<br> return null;
<br> }
<br> return browserDispatches.removeFirst();
<br>@@ -1093,93 +1063,93 @@
<br> * @see org.apache.activemq.thread.Task#iterate()
<br> */
<br> public boolean iterate() {
<br>- boolean pageInMoreMessages = false;
<br>- synchronized(iteratingMutex) {
<br>-
<br>+ boolean pageInMoreMessages = false;
<br>+ synchronized (iteratingMutex) {
<br>+
<br> // do early to allow dispatch of these waiting messages
<br>- synchronized(messagesWaitingForSpace) {
<br>+ synchronized (messagesWaitingForSpace) {
<br> while (!messagesWaitingForSpace.isEmpty() && !memoryUsage.isFull()) {
<br> Runnable op = messagesWaitingForSpace.removeFirst();
<br> op.run();
<br> }
<br> }
<br>-
<br>+
<br> BrowserDispatch rd;
<br>- while ((rd = getNextBrowserDispatch()) != null) {
<br>- pageInMoreMessages = true;
<br>-
<br>- try {
<br>- MessageEvaluationContext msgContext = new NonCachedMessageEvaluationContext();
<br>- msgContext.setDestination(destination);
<br>-
<br>- QueueBrowserSubscription browser = rd.getBrowser();
<br>- for (QueueMessageReference node : rd.messages) {
<br>- if (!node.isAcked()) {
<br>- msgContext.setMessageReference(node);
<br>- if (browser.matches(node, msgContext)) {
<br>- browser.add(node);
<br>- }
<br>- }
<br>- }
<br>-
<br>+ while ((rd = getNextBrowserDispatch()) != null) {
<br>+ pageInMoreMessages = true;
<br>+
<br>+ try {
<br>+ MessageEvaluationContext msgContext = new NonCachedMessageEvaluationContext();
<br>+ msgContext.setDestination(destination);
<br>+
<br>+ QueueBrowserSubscription browser = rd.getBrowser();
<br>+ for (QueueMessageReference node : rd.messages) {
<br>+ if (!node.isAcked()) {
<br>+ msgContext.setMessageReference(node);
<br>+ if (browser.matches(node, msgContext)) {
<br>+ browser.add(node);
<br>+ }
<br>+ }
<br>+ }
<br>+
<br> rd.done();
<br>
<br>- } catch (Exception e) {
<br>- LOG.warn("exception on dispatch to browser: " + rd.getBrowser(), e);
<br>- }
<br>- }
<br>-
<br>- if (firstConsumer) {
<br>- firstConsumer = false;
<br>- try {
<br>- if (consumersBeforeDispatchStarts > 0) {
<br>- int timeout = 1000; // wait one second by default if consumer count isn't reached
<br>- if (timeBeforeDispatchStarts > 0) {
<br>- timeout = timeBeforeDispatchStarts;
<br>- }
<br>- if (consumersBeforeStartsLatch.await(timeout, TimeUnit.MILLISECONDS)) {
<br>- if (LOG.isDebugEnabled()) {
<br>- LOG.debug(consumers.size() + " consumers subscribed. Starting dispatch.");
<br>- }
<br>- } else {
<br>- if (LOG.isDebugEnabled()) {
<br>- LOG.debug(timeout + " ms elapsed and " + consumers.size() + " consumers subscribed. Starting dispatch.");
<br>- }
<br>- }
<br>- }
<br>- if (timeBeforeDispatchStarts > 0 && consumersBeforeDispatchStarts <= 0) {
<br>- iteratingMutex.wait(timeBeforeDispatchStarts);
<br>- if (LOG.isDebugEnabled()) {
<br>- LOG.debug(timeBeforeDispatchStarts + " ms elapsed. Starting dispatch.");
<br>- }
<br>- }
<br>- } catch (Exception e) {
<br>- LOG.error(e);
<br>- }
<br>- }
<br>-
<br>- synchronized (messages) {
<br>- pageInMoreMessages |= !messages.isEmpty();
<br>- }
<br>-
<br>- // Kinda ugly.. but I think dispatchLock is the only mutex protecting the
<br>- // pagedInPendingDispatch variable.
<br>- synchronized(dispatchMutex) {
<br>- pageInMoreMessages |= !pagedInPendingDispatch.isEmpty();
<br>- }
<br>-
<br>- // Perhaps we should page always into the pagedInPendingDispatch list if
<br>- // !messages.isEmpty(), and then if !pagedInPendingDispatch.isEmpty()
<br>- // then we do a dispatch.
<br>- if (pageInMoreMessages) {
<br>- try {
<br>- pageInMessages(false);
<br>-
<br>- } catch (Throwable e) {
<br>- LOG.error("Failed to page in more queue messages ", e);
<br>+ } catch (Exception e) {
<br>+ LOG.warn("exception on dispatch to browser: " + rd.getBrowser(), e);
<br>+ }
<br>+ }
<br>+
<br>+ if (firstConsumer) {
<br>+ firstConsumer = false;
<br>+ try {
<br>+ if (consumersBeforeDispatchStarts > 0) {
<br>+ int timeout = 1000; // wait one second by default if consumer count isn't reached
<br>+ if (timeBeforeDispatchStarts > 0) {
<br>+ timeout = timeBeforeDispatchStarts;
<br>+ }
<br>+ if (consumersBeforeStartsLatch.await(timeout, TimeUnit.MILLISECONDS)) {
<br>+ if (LOG.isDebugEnabled()) {
<br>+ LOG.debug(consumers.size() + " consumers subscribed. Starting dispatch.");
<br>+ }
<br>+ } else {
<br>+ if (LOG.isDebugEnabled()) {
<br>+ LOG.debug(timeout + " ms elapsed and " + consumers.size() + " consumers subscribed. Starting dispatch.");
<br>+ }
<br>+ }
<br>+ }
<br>+ if (timeBeforeDispatchStarts > 0 && consumersBeforeDispatchStarts <= 0) {
<br>+ iteratingMutex.wait(timeBeforeDispatchStarts);
<br>+ if (LOG.isDebugEnabled()) {
<br>+ LOG.debug(timeBeforeDispatchStarts + " ms elapsed. Starting dispatch.");
<br>+ }
<br>+ }
<br>+ } catch (Exception e) {
<br>+ LOG.error(e);
<br>+ }
<br>+ }
<br>+
<br>+ synchronized (messages) {
<br>+ pageInMoreMessages |= !messages.isEmpty();
<br>+ }
<br>+
<br>+ // Kinda ugly.. but I think dispatchLock is the only mutex protecting the
<br>+ // pagedInPendingDispatch variable.
<br>+ synchronized (dispatchMutex) {
<br>+ pageInMoreMessages |= !pagedInPendingDispatch.isEmpty();
<br>+ }
<br>+
<br>+ // Perhaps we should page always into the pagedInPendingDispatch list if
<br>+ // !messages.isEmpty(), and then if !pagedInPendingDispatch.isEmpty()
<br>+ // then we do a dispatch.
<br>+ if (pageInMoreMessages) {
<br>+ try {
<br>+ pageInMessages(false);
<br>+
<br>+ } catch (Throwable e) {
<br>+ LOG.error("Failed to page in more queue messages ", e);
<br> }
<br>- }
<br>- return pendingWakeups.decrementAndGet() > 0;
<br>+ }
<br>+ return pendingWakeups.decrementAndGet() > 0;
<br> }
<br> }
<br>
<br>@@ -1188,8 +1158,9 @@
<br> public boolean evaluate(ConnectionContext context, MessageReference r) {
<br> return messageId.equals(r.getMessageId().toString());
<br> }
<br>+
<br> public String toString() {
<br>- return "MessageIdFilter: "+messageId;
<br>+ return "MessageIdFilter: " + messageId;
<br> }
<br> };
<br> }
<br>@@ -1213,22 +1184,22 @@
<br>
<br> protected void removeMessage(ConnectionContext c, QueueMessageReference r) throws IOException {
<br> removeMessage(c, null, r);
<br>- synchronized(dispatchMutex) {
<br>+ synchronized (dispatchMutex) {
<br> synchronized (pagedInPendingDispatch) {
<br> pagedInPendingDispatch.remove(r);
<br> }
<br> }
<br> }
<br>-
<br>- protected void removeMessage(ConnectionContext c, Subscription subs,QueueMessageReference r) throws IOException {
<br>+
<br>+ protected void removeMessage(ConnectionContext c, Subscription subs, QueueMessageReference r) throws IOException {
<br> MessageAck ack = new MessageAck();
<br> ack.setAckType(MessageAck.STANDARD_ACK_TYPE);
<br> ack.setDestination(destination);
<br> ack.setMessageID(r.getMessageId());
<br> removeMessage(c, subs, r, ack);
<br> }
<br>-
<br>- protected void removeMessage(ConnectionContext context,Subscription sub,final QueueMessageReference reference,MessageAck ack) throws IOException {
<br>+
<br>+ protected void removeMessage(ConnectionContext context, Subscription sub, final QueueMessageReference reference, MessageAck ack) throws IOException {
<br> reference.setAcked(true);
<br> // This sends the ack the the journal..
<br> if (!ack.isInTransaction()) {
<br>@@ -1240,13 +1211,13 @@
<br> acknowledge(context, sub, ack, reference);
<br> } finally {
<br> context.getTransaction().addSynchronization(new Synchronization() {
<br>-
<br>+
<br> public void afterCommit() throws Exception {
<br> getDestinationStatistics().getDequeues().increment();
<br> dropMessage(reference);
<br> wakeup();
<br> }
<br>-
<br>+
<br> public void afterRollback() throws Exception {
<br> reference.setAcked(false);
<br> }
<br>@@ -1255,38 +1226,38 @@
<br> }
<br> if (ack.isPoisonAck()) {
<br> // message gone to DLQ, is ok to allow redelivery
<br>- synchronized(messages) {
<br>+ synchronized (messages) {
<br> messages.rollback(reference.getMessageId());
<br> }
<br> }
<br>
<br> }
<br>-
<br>+
<br> private void dropMessage(QueueMessageReference reference) {
<br> reference.drop();
<br> destinationStatistics.getMessages().decrement();
<br>- synchronized(pagedInMessages) {
<br>+ synchronized (pagedInMessages) {
<br> pagedInMessages.remove(reference.getMessageId());
<br> }
<br> }
<br>-
<br>- public void messageExpired(ConnectionContext context,MessageReference reference) {
<br>- messageExpired(context,null,reference);
<br>+
<br>+ public void messageExpired(ConnectionContext context, MessageReference reference) {
<br>+ messageExpired(context, null, reference);
<br> }
<br>-
<br>- public void messageExpired(ConnectionContext context,Subscription subs, MessageReference reference) {
<br>+
<br>+ public void messageExpired(ConnectionContext context, Subscription subs, MessageReference reference) {
<br> if (LOG.isDebugEnabled()) {
<br> LOG.debug("message expired: " + reference);
<br> }
<br> broker.messageExpired(context, reference);
<br> destinationStatistics.getExpired().increment();
<br> try {
<br>- removeMessage(context,subs,(QueueMessageReference)reference);
<br>+ removeMessage(context, subs, (QueueMessageReference) reference);
<br> } catch (IOException e) {
<br>- LOG.error("Failed to remove expired Message from the store ",e);
<br>+ LOG.error("Failed to remove expired Message from the store ", e);
<br> }
<br> }
<br>-
<br>+
<br> protected ConnectionContext createConnectionContext() {
<br> ConnectionContext answer = new ConnectionContext(new NonCachedMessageEvaluationContext());
<br> answer.setBroker(this.broker);
<br>@@ -1296,17 +1267,18 @@
<br>
<br> final void sendMessage(final ConnectionContext context, Message msg) throws Exception {
<br> if (!msg.isPersistent() && messages.getSystemUsage() != null) {
<br>- if (systemUsage.getTempUsage().isFull()) {
<br>- final String logMessage = "Usage Manager Temp Store is Full. Stopping producer (" + msg.getProducerId() + ") to prevent flooding " + getActiveMQDestination().getQualifiedName() + "." +
<br>- " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info";
<br>- LOG.info(logMessage);
<br>+ if (systemUsage.getTempUsage().isFull()) {
<br>+ final String logMessage = "Usage Manager Temp Store is Full. Stopping producer (" + msg.getProducerId() + ") to prevent flooding " + getActiveMQDestination().getQualifiedName() + "."
<br>+ + " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info";
<br> if (systemUsage.isSendFailIfNoSpace()) {
<br> throw new javax.jms.ResourceAllocationException(logMessage);
<br> }
<br>+
<br>+ waitForSpace(context, messages.getSystemUsage().getTempUsage(), logMessage);
<br> }
<br>- messages.getSystemUsage().getTempUsage().waitForSpace();
<br>+
<br> }
<br>- synchronized(messages) {
<br>+ synchronized (messages) {
<br> messages.addMessageLast(msg);
<br> }
<br> destinationStatistics.getEnqueues().increment();
<br>@@ -1319,7 +1291,7 @@
<br> }
<br> wakeup();
<br> }
<br>-
<br>+
<br> public void wakeup() {
<br> if (optimizedDispatch || isSlave()) {
<br> iterate();
<br>@@ -1332,12 +1304,12 @@
<br> private void asyncWakeup() {
<br> try {
<br> pendingWakeups.incrementAndGet();
<br>- this.taskRunner.wakeup();
<br>+ this.taskRunner.wakeup();
<br> } catch (InterruptedException e) {
<br> LOG.warn("Async task tunner failed to wakeup ", e);
<br> }
<br> }
<br>-
<br>+
<br> private boolean isSlave() {
<br> return broker.getBrokerService().isSlave();
<br> }
<br>@@ -1345,14 +1317,13 @@
<br> private List<QueueMessageReference> doPageIn(boolean force) throws Exception {
<br> List<QueueMessageReference> result = null;
<br> List<QueueMessageReference> resultList = null;
<br>- synchronized(dispatchMutex) {
<br>+ synchronized (dispatchMutex) {
<br> int toPageIn = Math.min(getMaxPageSize(), messages.size());
<br> if (LOG.isDebugEnabled()) {
<br>- LOG.debug(destination.getPhysicalName() + " toPageIn: " + toPageIn + ", Inflight: "
<br>- + destinationStatistics.getInflight().getCount()
<br>- + ", pagedInMessages.size " + pagedInMessages.size());
<br>+ LOG.debug(destination.getPhysicalName() + " toPageIn: " + toPageIn + ", Inflight: " + destinationStatistics.getInflight().getCount() + ", pagedInMessages.size "
<br>+ + pagedInMessages.size());
<br> }
<br>-
<br>+
<br> if (isLazyDispatch() && !force) {
<br> // Only page in the minimum number of messages which can be dispatched immediately.
<br> toPageIn = Math.min(getConsumerMessageCountBeforeFull(), toPageIn);
<br>@@ -1376,7 +1347,7 @@
<br> } else {
<br> result.add(ref);
<br> count++;
<br>- }
<br>+ }
<br> }
<br> } finally {
<br> messages.release();
<br>@@ -1385,7 +1356,7 @@
<br> // Only add new messages, not already pagedIn to avoid multiple dispatch attempts
<br> synchronized (pagedInMessages) {
<br> resultList = new ArrayList<QueueMessageReference>(result.size());
<br>- for(QueueMessageReference ref : result) {
<br>+ for (QueueMessageReference ref : result) {
<br> if (!pagedInMessages.containsKey(ref.getMessageId())) {
<br> pagedInMessages.put(ref.getMessageId(), ref);
<br> resultList.add(ref);
<br>@@ -1402,8 +1373,8 @@
<br>
<br> private void doDispatch(List<QueueMessageReference> list) throws Exception {
<br> boolean doWakeUp = false;
<br>- synchronized(dispatchMutex) {
<br>-
<br>+ synchronized (dispatchMutex) {
<br>+
<br> synchronized (pagedInPendingDispatch) {
<br> if (!pagedInPendingDispatch.isEmpty()) {
<br> // Try to first dispatch anything that had not been
<br>@@ -1425,20 +1396,20 @@
<br> }
<br> }
<br> }
<br>- }
<br>+ }
<br> if (doWakeUp) {
<br> // avoid lock order contention
<br> asyncWakeup();
<br> }
<br> }
<br>-
<br>+
<br> /**
<br> * @return list of messages that could get dispatched to consumers if they
<br> * were not full.
<br> */
<br> private List<QueueMessageReference> doActualDispatch(List<QueueMessageReference> list) throws Exception {
<br> List<Subscription> consumers;
<br>-
<br>+
<br> synchronized (this.consumers) {
<br> if (this.consumers.isEmpty() || isSlave()) {
<br> // slave dispatch happens in processDispatchNotification
<br>@@ -1449,15 +1420,15 @@
<br>
<br> List<QueueMessageReference> rc = new ArrayList<QueueMessageReference>(list.size());
<br> Set<Subscription> fullConsumers = new HashSet<Subscription>(this.consumers.size());
<br>-
<br>+
<br> for (MessageReference node : list) {
<br> Subscription target = null;
<br>- int interestCount=0;
<br>+ int interestCount = 0;
<br> for (Subscription s : consumers) {
<br>- if (s instanceof QueueBrowserSubscription) {
<br>- interestCount++;
<br>- continue;
<br>- }
<br>+ if (s instanceof QueueBrowserSubscription) {
<br>+ interestCount++;
<br>+ continue;
<br>+ }
<br> if (dispatchSelector.canSelect(s, node)) {
<br> if (!fullConsumers.contains(s)) {
<br> if (!s.isFull()) {
<br>@@ -1472,23 +1443,22 @@
<br> }
<br> interestCount++;
<br> } else {
<br>- // makes sure it gets dispatched again
<br>- if (!node.isDropped() && !((QueueMessageReference)node).isAcked() && (!node.isDropped() || s.getConsumerInfo().isBrowser())) {
<br>- interestCount++;
<br>- }
<br>+ // makes sure it gets dispatched again
<br>+ if (!node.isDropped() && !((QueueMessageReference) node).isAcked() && (!node.isDropped() || s.getConsumerInfo().isBrowser())) {
<br>+ interestCount++;
<br>+ }
<br> }
<br> }
<br>-
<br>- if ((target == null && interestCount>0) || consumers.size() == 0) {
<br>+
<br>+ if ((target == null && interestCount > 0) || consumers.size() == 0) {
<br> // This means all subs were full or that there are no consumers...
<br>- rc.add((QueueMessageReference)node);
<br>+ rc.add((QueueMessageReference) node);
<br> }
<br>
<br> // If it got dispatched, rotate the consumer list to get round robin distribution.
<br>- if (target != null && !strictOrderDispatch && consumers.size() > 1 &&
<br>- !dispatchSelector.isExclusiveConsumer(target)) {
<br>+ if (target != null && !strictOrderDispatch && consumers.size() > 1 && !dispatchSelector.isExclusiveConsumer(target)) {
<br> synchronized (this.consumers) {
<br>- if( removeFromConsumerList(target) ) {
<br>+ if (removeFromConsumerList(target)) {
<br> addToConsumerList(target);
<br> consumers = new ArrayList<Subscription>(this.consumers);
<br> }
<br>@@ -1496,15 +1466,13 @@
<br> }
<br> }
<br>
<br>-
<br> return rc;
<br> }
<br>
<br>-
<br> protected void pageInMessages(boolean force) throws Exception {
<br>- doDispatch(doPageIn(force));
<br>+ doDispatch(doPageIn(force));
<br> }
<br>-
<br>+
<br> private void addToConsumerList(Subscription sub) {
<br> if (useConsumerPriority) {
<br> consumers.add(sub);
<br>@@ -1513,42 +1481,43 @@
<br> consumers.add(sub);
<br> }
<br> }
<br>-
<br>+
<br> private boolean removeFromConsumerList(Subscription sub) {
<br> return consumers.remove(sub);
<br> }
<br>-
<br>+
<br> private int getConsumerMessageCountBeforeFull() throws Exception {
<br> int total = 0;
<br> boolean zeroPrefetch = false;
<br> synchronized (consumers) {
<br> for (Subscription s : consumers) {
<br>- zeroPrefetch |= s.getPrefetchSize() == 0;
<br>- int countBeforeFull = s.countBeforeFull();
<br>+ zeroPrefetch |= s.getPrefetchSize() == 0;
<br>+ int countBeforeFull = s.countBeforeFull();
<br> total += countBeforeFull;
<br> }
<br> }
<br>- if (total==0 && zeroPrefetch){
<br>- total=1;
<br>+ if (total == 0 && zeroPrefetch) {
<br>+ total = 1;
<br> }
<br> return total;
<br> }
<br>
<br>- /*
<br>- * In slave mode, dispatch is ignored till we get this notification as the dispatch
<br>- * process is non deterministic between master and slave.
<br>- * On a notification, the actual dispatch to the subscription (as chosen by the master)
<br>- * is completed.
<br>- * (non-Javadoc)
<br>- * @see org.apache.activemq.broker.region.BaseDestination#processDispatchNotification(org.apache.activemq.command.MessageDispatchNotification)
<br>+ /*
<br>+ * In slave mode, dispatch is ignored till we get this notification as the
<br>+ * dispatch process is non deterministic between master and slave. On a
<br>+ * notification, the actual dispatch to the subscription (as chosen by the
<br>+ * master) is completed. (non-Javadoc)
<br>+ *
<br>+ * @see
<br>+ * org.apache.activemq.broker.region.BaseDestination#processDispatchNotification
<br>+ * (org.apache.activemq.command.MessageDispatchNotification)
<br> */
<br>- public void processDispatchNotification(
<br>- MessageDispatchNotification messageDispatchNotification) throws Exception {
<br>+ public void processDispatchNotification(MessageDispatchNotification messageDispatchNotification) throws Exception {
<br> // do dispatch
<br> Subscription sub = getMatchingSubscription(messageDispatchNotification);
<br> if (sub != null) {
<br> MessageReference message = getMatchingMessage(messageDispatchNotification);
<br>- sub.add(message);
<br>+ sub.add(message);
<br> sub.processMessageDispatchNotification(messageDispatchNotification);
<br> }
<br> }
<br>@@ -1556,25 +1525,25 @@
<br> private QueueMessageReference getMatchingMessage(MessageDispatchNotification messageDispatchNotification) throws Exception {
<br> QueueMessageReference message = null;
<br> MessageId messageId = messageDispatchNotification.getMessageId();
<br>-
<br>- synchronized(dispatchMutex) {
<br>+
<br>+ synchronized (dispatchMutex) {
<br> synchronized (pagedInPendingDispatch) {
<br>- for(QueueMessageReference ref : pagedInPendingDispatch) {
<br>- if (messageId.equals(ref.getMessageId())) {
<br>- message = ref;
<br>- pagedInPendingDispatch.remove(ref);
<br>- break;
<br>- }
<br>- }
<br>+ for (QueueMessageReference ref : pagedInPendingDispatch) {
<br>+ if (messageId.equals(ref.getMessageId())) {
<br>+ message = ref;
<br>+ pagedInPendingDispatch.remove(ref);
<br>+ break;
<br>+ }
<br>+ }
<br> }
<br>-
<br>+
<br> if (message == null) {
<br> synchronized (pagedInMessages) {
<br> message = pagedInMessages.get(messageId);
<br> }
<br> }
<br>-
<br>- if (message == null) {
<br>+
<br>+ if (message == null) {
<br> synchronized (messages) {
<br> try {
<br> messages.setMaxBatchSize(getMaxPageSize());
<br>@@ -1593,28 +1562,25 @@
<br> }
<br> }
<br> }
<br>-
<br>+
<br> if (message == null) {
<br> Message msg = loadMessage(messageId);
<br> if (msg != null) {
<br> message = this.createMessageReference(msg);
<br> }
<br>- }
<br>-
<br>- }
<br>+ }
<br>+
<br>+ }
<br> if (message == null) {
<br>- throw new JMSException(
<br>- "Slave broker out of sync with master - Message: "
<br>- + messageDispatchNotification.getMessageId()
<br>- + " on " + messageDispatchNotification.getDestination()
<br>- + " does not exist among pending(" + pagedInPendingDispatch.size() + ") for subscription: "
<br>- + messageDispatchNotification.getConsumerId());
<br>+ throw new JMSException("Slave broker out of sync with master - Message: " + messageDispatchNotification.getMessageId() + " on " + messageDispatchNotification.getDestination()
<br>+ + " does not exist among pending(" + pagedInPendingDispatch.size() + ") for subscription: " + messageDispatchNotification.getConsumerId());
<br> }
<br> return message;
<br> }
<br>
<br> /**
<br> * Find a consumer that matches the id in the message dispatch notification
<br>+ *
<br> * @param messageDispatchNotification
<br> * @return sub or null if the subscription has been removed before dispatch
<br> * @throws JMSException
<br>@@ -1637,4 +1603,20 @@
<br> asyncWakeup();
<br> }
<br> }
<br>+
<br>+ private final void waitForSpace(ConnectionContext context, Usage<?> usage, String warning) throws IOException, InterruptedException {
<br>+ long start = System.currentTimeMillis();
<br>+ long nextWarn = start + blockedProducerWarningInterval;
<br>+ while (!usage.waitForSpace(1000)) {
<br>+ if (context.getStopping().get()) {
<br>+ throw new IOException("Connection closed, send aborted.");
<br>+ }
<br>+
<br>+ long now = System.currentTimeMillis();
<br>+ if (now >= nextWarn) {
<br>+ LOG.info(warning + " (blocking for: " + (now - start) / 1000 + "s)");
<br>+ nextWarn = now + blockedProducerWarningInterval;
<br>+ }
<br>+ }
<br>+ }
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Topic.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Topic.java?rev=884234&r1=884233&r2=884234&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Topic.java?rev=884234&r1=884233&r2=884234&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Topic.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Topic.java Wed Nov 25 19:35:09 2009
<br>@@ -41,6 +41,7 @@
<br> import org.apache.activemq.thread.TaskRunnerFactory;
<br> import org.apache.activemq.thread.Valve;
<br> import org.apache.activemq.transaction.Synchronization;
<br>+import org.apache.activemq.usage.Usage;
<br> import org.apache.activemq.util.SubscriptionKey;
<br> import org.apache.commons.logging.Log;
<br> import org.apache.commons.logging.LogFactory;
<br>@@ -59,11 +60,11 @@
<br> *
<br> * @version $Revision: 1.21 $
<br> */
<br>-public class Topic extends BaseDestination implements Task{
<br>+public class Topic extends BaseDestination implements Task {
<br> protected static final Log LOG = LogFactory.getLog(Topic.class);
<br> private final TopicMessageStore topicStore;
<br> protected final CopyOnWriteArrayList<Subscription> consumers = new CopyOnWriteArrayList<Subscription>();
<br>- protected final Valve dispatchValve = new Valve(true);
<br>+ protected final Valve dispatchValve = new Valve(true);
<br> private DispatchPolicy dispatchPolicy = new SimpleDispatchPolicy();
<br> private SubscriptionRecoveryPolicy subscriptionRecoveryPolicy;
<br> private final ConcurrentHashMap<SubscriptionKey, DurableTopicSubscription> durableSubcribers = new ConcurrentHashMap<SubscriptionKey, DurableTopicSubscription>();
<br>@@ -71,24 +72,22 @@
<br> private final LinkedList<Runnable> messagesWaitingForSpace = new LinkedList<Runnable>();
<br> private final Runnable sendMessagesWaitingForSpaceTask = new Runnable() {
<br> public void run() {
<br>- try {
<br>- Topic.this.taskRunner.wakeup();
<br>- } catch (InterruptedException e) {
<br>- }
<br>+ try {
<br>+ Topic.this.taskRunner.wakeup();
<br>+ } catch (InterruptedException e) {
<br>+ }
<br> };
<br> };
<br>-
<br>
<br>- public Topic(BrokerService brokerService, ActiveMQDestination destination, TopicMessageStore store, DestinationStatistics parentStats,
<br>- TaskRunnerFactory taskFactory) throws Exception {
<br>+ public Topic(BrokerService brokerService, ActiveMQDestination destination, TopicMessageStore store, DestinationStatistics parentStats, TaskRunnerFactory taskFactory) throws Exception {
<br> super(brokerService, store, destination, parentStats);
<br>- this.topicStore=store;
<br>+ this.topicStore = store;
<br> //set default subscription recovery policy
<br>- subscriptionRecoveryPolicy= new NoSubscriptionRecoveryPolicy();
<br>+ subscriptionRecoveryPolicy = new NoSubscriptionRecoveryPolicy();
<br> this.taskRunner = taskFactory.createTaskRunner(this, "Topic " + destination.getPhysicalName());
<br> }
<br>-
<br>- public void initialize() throws Exception{
<br>+
<br>+ public void initialize() throws Exception {
<br> super.initialize();
<br> if (store != null) {
<br> int messageCount = store.getMessageCount();
<br>@@ -140,7 +139,7 @@
<br> }
<br> } else {
<br> sub.add(context, this);
<br>- DurableTopicSubscription dsub = (DurableTopicSubscription)sub;
<br>+ DurableTopicSubscription dsub = (DurableTopicSubscription) sub;
<br> durableSubcribers.put(dsub.getSubscriptionKey(), dsub);
<br> }
<br> }
<br>@@ -171,7 +170,7 @@
<br> // we are recovering a subscription to avoid out of order messages.
<br> dispatchValve.turnOff();
<br> try {
<br>-
<br>+
<br> if (topicStore == null) {
<br> return;
<br> }
<br>@@ -195,21 +194,20 @@
<br> }
<br> }
<br> // Do we need to create the subscription?
<br>- if(info==null){
<br>- info=new SubscriptionInfo();
<br>+ if (info == null) {
<br>+ info = new SubscriptionInfo();
<br> info.setClientId(clientId);
<br> info.setSelector(selector);
<br> info.setSubscriptionName(subscriptionName);
<br>- info.setDestination(getActiveMQDestination());
<br>+ info.setDestination(getActiveMQDestination());
<br> // This destination is an actual destination id.
<br>- info.setSubscribedDestination(subscription.getConsumerInfo().getDestination());
<br>+ info.setSubscribedDestination(subscription.getConsumerInfo().getDestination());
<br> // This destination might be a pattern
<br> synchronized (consumers) {
<br> consumers.add(subscription);
<br>- topicStore.addSubsciption(info,subscription.getConsumerInfo().isRetroactive());
<br>+ topicStore.addSubsciption(info, subscription.getConsumerInfo().isRetroactive());
<br> }
<br> }
<br>-
<br>
<br> final MessageEvaluationContext msgContext = new NonCachedMessageEvaluationContext();
<br> msgContext.setDestination(destination);
<br>@@ -223,7 +221,7 @@
<br> subscription.add(message);
<br> }
<br> } catch (IOException e) {
<br>- LOG.error("Failed to recover this message " + message);
<br>+ LOG.error("Failed to recover this message " + message);
<br> }
<br> return true;
<br> }
<br>@@ -235,7 +233,7 @@
<br> public boolean hasSpace() {
<br> return true;
<br> }
<br>-
<br>+
<br> public boolean isDuplicate(MessageId id) {
<br> return false;
<br> }
<br>@@ -277,23 +275,24 @@
<br> return;
<br> }
<br>
<br>- if(memoryUsage.isFull()) {
<br>+ if (memoryUsage.isFull()) {
<br> isFull(context, memoryUsage);
<br> fastProducer(context, producerInfo);
<br>-
<br>+
<br> if (isProducerFlowControl() && context.isProducerFlowControl()) {
<br>-
<br>- if(warnOnProducerFlowControl) {
<br>+
<br>+ if (warnOnProducerFlowControl) {
<br> warnOnProducerFlowControl = false;
<br>- LOG.info("Usage Manager memory limit reached for " +getActiveMQDestination().getQualifiedName() + ". Producers will be throttled to the rate at which messages are removed from this destination to prevent flooding it." +
<br>- " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br>+ LOG.info("Usage Manager memory limit reached for " + getActiveMQDestination().getQualifiedName()
<br>+ + ". Producers will be throttled to the rate at which messages are removed from this destination to prevent flooding it."
<br>+ + " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br> }
<br>-
<br>+
<br> if (systemUsage.isSendFailIfNoSpace()) {
<br>- throw new javax.jms.ResourceAllocationException("Usage Manager memory limit reached. Stopping producer (" + message.getProducerId() + ") to prevent flooding " +getActiveMQDestination().getQualifiedName() + "." +
<br>- " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br>+ throw new javax.jms.ResourceAllocationException("Usage Manager memory limit reached. Stopping producer (" + message.getProducerId() + ") to prevent flooding "
<br>+ + getActiveMQDestination().getQualifiedName() + "." + " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br> }
<br>-
<br>+
<br> // We can avoid blocking due to low usage if the producer is sending
<br> // a sync message or
<br> // if it is using a producer window
<br>@@ -301,9 +300,9 @@
<br> synchronized (messagesWaitingForSpace) {
<br> messagesWaitingForSpace.add(new Runnable() {
<br> public void run() {
<br>-
<br>+
<br> try {
<br>-
<br>+
<br> // While waiting for space to free up... the
<br> // message may have expired.
<br> if (message.isExpired()) {
<br>@@ -312,7 +311,7 @@
<br> } else {
<br> doMessageSend(producerExchange, message);
<br> }
<br>-
<br>+
<br> if (sendProducerAck) {
<br> ProducerAck ack = new ProducerAck(producerInfo.getProducerId(), message.getSize());
<br> context.getConnection().dispatchAsync(ack);
<br>@@ -321,7 +320,7 @@
<br> response.setCorrelationId(message.getCommandId());
<br> context.getConnection().dispatchAsync(response);
<br> }
<br>-
<br>+
<br> } catch (Exception e) {
<br> if (!sendProducerAck && !context.isInRecoveryMode()) {
<br> ExceptionResponse response = new ExceptionResponse(e);
<br>@@ -329,10 +328,10 @@
<br> context.getConnection().dispatchAsync(response);
<br> }
<br> }
<br>-
<br>+
<br> }
<br> });
<br>-
<br>+
<br> // If the user manager is not full, then the task will not
<br> // get called..
<br> if (!memoryUsage.notifyCallbackWhenNotFull(sendMessagesWaitingForSpaceTask)) {
<br>@@ -342,24 +341,32 @@
<br> context.setDontSendReponse(true);
<br> return;
<br> }
<br>-
<br>+
<br> } else {
<br>-
<br> // Producer flow control cannot be used, so we have do the flow
<br> // control at the broker
<br> // by blocking this thread until there is space available.
<br>- int count = 0;
<br>- while (!memoryUsage.waitForSpace(1000)) {
<br>- if (context.getStopping().get()) {
<br>- throw new IOException("Connection closed, send aborted.");
<br>- }
<br>- if (count > 2 && context.isInTransaction()) {
<br>- count =0;
<br>- int size = context.getTransaction().size();
<br>- LOG.warn("Waiting for space to send transacted message - transaction elements = " + size + " need more space to commit. Message = " + message);
<br>+
<br>+ if (memoryUsage.isFull()) {
<br>+ if (context.isInTransaction()) {
<br>+
<br>+ int count = 0;
<br>+ while (!memoryUsage.waitForSpace(1000)) {
<br>+ if (context.getStopping().get()) {
<br>+ throw new IOException("Connection closed, send aborted.");
<br>+ }
<br>+ if (count > 2 && context.isInTransaction()) {
<br>+ count = 0;
<br>+ int size = context.getTransaction().size();
<br>+ LOG.warn("Waiting for space to send transacted message - transaction elements = " + size + " need more space to commit. Message = " + message);
<br>+ }
<br>+ }
<br>+ } else {
<br>+ waitForSpace(context, memoryUsage, "Usage Manager memory limit reached. Stopping producer (" + message.getProducerId() + ") to prevent flooding "
<br>+ + getActiveMQDestination().getQualifiedName() + "." + " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info");
<br> }
<br> }
<br>-
<br>+
<br> // The usage manager could have delayed us by the time
<br> // we unblock the message could have expired..
<br> if (message.isExpired()) {
<br>@@ -382,35 +389,28 @@
<br> }
<br>
<br> /**
<br>- * do send the message - this needs to be synchronized to ensure messages are stored AND dispatched in
<br>- * the right order
<br>+ * do send the message - this needs to be synchronized to ensure messages
<br>+ * are stored AND dispatched in the right order
<br>+ *
<br> * @param producerExchange
<br> * @param message
<br> * @throws IOException
<br> * @throws Exception
<br> */
<br>- synchronized void doMessageSend(
<br>- final ProducerBrokerExchange producerExchange, final Message message)
<br>- throws IOException, Exception {
<br>- final ConnectionContext context = producerExchange
<br>- .getConnectionContext();
<br>+ synchronized void doMessageSend(final ProducerBrokerExchange producerExchange, final Message message) throws IOException, Exception {
<br>+ final ConnectionContext context = producerExchange.getConnectionContext();
<br> message.setRegionDestination(this);
<br> message.getMessageId().setBrokerSequenceId(getDestinationSequenceId());
<br>
<br>- if (topicStore != null && message.isPersistent()
<br>- && !canOptimizeOutPersistence()) {
<br>+ if (topicStore != null && message.isPersistent() && !canOptimizeOutPersistence()) {
<br> if (systemUsage.getStoreUsage().isFull()) {
<br>- final String logMessage = "Usage Manager Store is Full. Stopping producer (" + message.getProducerId() + ") to prevent flooding " + getActiveMQDestination().getQualifiedName() + "." +
<br>- " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info";
<br>- LOG.info(logMessage);
<br>+ final String logMessage = "Usage Manager Store is Full. Stopping producer (" + message.getProducerId() + ") to prevent flooding " + getActiveMQDestination().getQualifiedName() + "."
<br>+ + " See <a href="http://activemq.apache.org/producer-flow-control.html" target="_top" rel="nofollow">http://activemq.apache.org/producer-flow-control.html</a> for more info";
<br> if (systemUsage.isSendFailIfNoSpace()) {
<br>- throw new javax.jms.ResourceAllocationException(logMessage);
<br>- }
<br>- }
<br>- while (!systemUsage.getStoreUsage().waitForSpace(1000)) {
<br>- if (context.getStopping().get()) {
<br>- throw new IOException("Connection closed, send aborted.");
<br>+ throw new javax.jms.ResourceAllocationException(logMessage);
<br> }
<br>+
<br>+ waitForSpace(context, systemUsage.getStoreUsage(), logMessage);
<br> }
<br> topicStore.addMessage(context, message);
<br> }
<br>@@ -457,14 +457,13 @@
<br>
<br> public void acknowledge(ConnectionContext context, Subscription sub, final MessageAck ack, final MessageReference node) throws IOException {
<br> if (topicStore != null && node.isPersistent()) {
<br>- DurableTopicSubscription dsub = (DurableTopicSubscription)sub;
<br>+ DurableTopicSubscription dsub = (DurableTopicSubscription) sub;
<br> SubscriptionKey key = dsub.getSubscriptionKey();
<br> topicStore.acknowledge(context, key.getClientId(), key.getSubscriptionName(), node.getMessageId());
<br> }
<br> messageConsumed(context, node);
<br> }
<br>
<br>-
<br> public void gc() {
<br> }
<br>
<br>@@ -488,7 +487,7 @@
<br> if (memoryUsage != null) {
<br> memoryUsage.stop();
<br> }
<br>- if(this.topicStore != null) {
<br>+ if (this.topicStore != null) {
<br> this.topicStore.stop();
<br> }
<br> }
<br>@@ -510,7 +509,7 @@
<br> public boolean hasSpace() {
<br> return true;
<br> }
<br>-
<br>+
<br> public boolean isDuplicate(MessageId id) {
<br> return false;
<br> }
<br>@@ -527,9 +526,9 @@
<br> }
<br> return result.toArray(new Message[result.size()]);
<br> }
<br>-
<br>+
<br> public boolean iterate() {
<br>- synchronized(messagesWaitingForSpace) {
<br>+ synchronized (messagesWaitingForSpace) {
<br> while (!memoryUsage.isFull() && !messagesWaitingForSpace.isEmpty()) {
<br> Runnable op = messagesWaitingForSpace.removeFirst();
<br> op.run();
<br>@@ -538,12 +537,9 @@
<br> return false;
<br> }
<br>
<br>-
<br> // Properties
<br> // -------------------------------------------------------------------------
<br>
<br>-
<br>-
<br> public DispatchPolicy getDispatchPolicy() {
<br> return dispatchPolicy;
<br> }
<br>@@ -560,17 +556,16 @@
<br> this.subscriptionRecoveryPolicy = subscriptionRecoveryPolicy;
<br> }
<br>
<br>-
<br> // Implementation methods
<br> // -------------------------------------------------------------------------
<br>-
<br>+
<br> public final void wakeup() {
<br> }
<br>-
<br>+
<br> protected void dispatch(final ConnectionContext context, Message message) throws Exception {
<br> destinationStatistics.getMessages().increment();
<br> destinationStatistics.getEnqueues().increment();
<br>- dispatchValve.increment();
<br>+ dispatchValve.increment();
<br> MessageEvaluationContext msgContext = null;
<br> try {
<br> if (!subscriptionRecoveryPolicy.add(context, message)) {
<br>@@ -587,17 +582,17 @@
<br> msgContext.setMessageReference(message);
<br> if (!dispatchPolicy.dispatch(message, msgContext, consumers)) {
<br> onMessageWithNoConsumers(context, message);
<br>- }
<br>-
<br>+ }
<br>+
<br> } finally {
<br> dispatchValve.decrement();
<br>- if(msgContext != null) {
<br>+ if (msgContext != null) {
<br> msgContext.clear();
<br> }
<br> }
<br> }
<br>-
<br>- public void messageExpired(ConnectionContext context,Subscription subs, MessageReference reference) {
<br>+
<br>+ public void messageExpired(ConnectionContext context, Subscription subs, MessageReference reference) {
<br> broker.messageExpired(context, reference);
<br> destinationStatistics.getMessages().decrement();
<br> destinationStatistics.getEnqueues().decrement();
<br>@@ -609,9 +604,24 @@
<br> try {
<br> acknowledge(context, subs, ack, reference);
<br> } catch (IOException e) {
<br>- LOG.error("Failed to remove expired Message from the store ",e);
<br>+ LOG.error("Failed to remove expired Message from the store ", e);
<br> }
<br> }
<br>
<br>+ private final void waitForSpace(ConnectionContext context, Usage<?> usage, String warning) throws IOException, InterruptedException {
<br>+ long start = System.currentTimeMillis();
<br>+ long nextWarn = start + blockedProducerWarningInterval;
<br>+ while (!usage.waitForSpace(1000)) {
<br>+ if (context.getStopping().get()) {
<br>+ throw new IOException("Connection closed, send aborted.");
<br>+ }
<br>+
<br>+ long now = System.currentTimeMillis();
<br>+ if (now >= nextWarn) {
<br>+ LOG.info(warning + " (blocking for: " + (now - start) / 1000 + "s)");
<br>+ nextWarn = now + blockedProducerWarningInterval;
<br>+ }
<br>+ }
<br>+ }
<br>
<br> }
<br><br>Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/policy/PolicyEntry.java
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/policy/PolicyEntry.java?rev=884234&r1=884233&r2=884234&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/policy/PolicyEntry.java?rev=884234&r1=884233&r2=884234&view=diff</a><br>==============================================================================
<br>--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/policy/PolicyEntry.java (original)
<br>+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/policy/PolicyEntry.java Wed Nov 25 19:35:09 2009
<br>@@ -60,6 +60,7 @@
<br> private int maxQueueAuditDepth=2048;
<br> private boolean enableAudit=true;
<br> private boolean producerFlowControl = true;
<br>+ private long blockedProducerWarningInterval = Destination.DEFAULT_BLOCKED_PRODUCER_WARNING_INTERVAL;
<br> private boolean optimizedDispatch=false;
<br> private int maxPageSize=BaseDestination.MAX_PAGE_SIZE;
<br> private int maxBrowsePageSize=BaseDestination.MAX_BROWSE_PAGE_SIZE;
<br>@@ -125,6 +126,7 @@
<br>
<br> public void baseConfiguration(BaseDestination destination) {
<br> destination.setProducerFlowControl(isProducerFlowControl());
<br>+ destination.setBlockedProducerWarningInterval(getBlockedProducerWarningInterval());
<br> destination.setEnableAudit(isEnableAudit());
<br> destination.setMaxAuditDepth(getMaxQueueAuditDepth());
<br> destination.setMaxProducersToAudit(getMaxProducersToAudit());
<br>@@ -373,6 +375,27 @@
<br> }
<br>
<br> /**
<br>+ * Set's the interval at which warnings about producers being blocked by
<br>+ * resource usage will be triggered. Values of 0 or less will disable
<br>+ * warnings
<br>+ *
<br>+ * @param blockedProducerWarningInterval the interval at which warning about
<br>+ * blocked producers will be triggered.
<br>+ */
<br>+ public void setBlockedProducerWarningInterval(long blockedProducerWarningInterval) {
<br>+ this.blockedProducerWarningInterval = blockedProducerWarningInterval;
<br>+ }
<br>+
<br>+ /**
<br>+ *
<br>+ * @return the interval at which warning about blocked producers will be
<br>+ * triggered.
<br>+ */
<br>+ public long getBlockedProducerWarningInterval() {
<br>+ return blockedProducerWarningInterval;
<br>+ }
<br>+
<br>+ /**
<br> * @return the maxProducersToAudit
<br> */
<br> public int getMaxProducersToAudit() {
<br><br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Commits-f23834.html" embed="fixTarget[23834]" target="_top" >ActiveMQ - Commits</a></p>
tag:old.nabble.com,2006:post-26518771
[jira] Closed: (AMQNET-195) public class AcdOrder : KeyedCollection<uint, object> when serialzable under mono cause deserialization error under windows
2009-11-25T11:23:52Z
2009-11-25T11:23:52Z
JIRA jira+amqnet@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQNET-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Timothy Bish closed AMQNET-195.
<br>-------------------------------
<br><br> Resolution: Incomplete
<br><br>No info provided to allow us to reproduce an error,
<br><div class='shrinkable-quote'><br>> public class AcdOrder : KeyedCollection<uint, object> when serialzable under mono cause deserialization error under windows
<br>> ---------------------------------------------------------------------------------------------------------------------------
<br>>
<br>> Key: AMQNET-195
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQNET-195" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-195</a><br>> Project: ActiveMQ .Net
<br>> Issue Type: Bug
<br>> Components: ActiveMQ
<br>> Affects Versions: 1.1.0
<br>> Environment: Mono 2.4, .NET 2.0
<br>> Reporter: Piotr Czabanski
<br>> Assignee: Jim Gomes
<br>>
<br>> Sending serialized object type KeyedCollection under Mono 2.4 on Linux cause deserialization error .
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26518735
Re: Creating message from byte[]
2009-11-25T11:20:41Z
2009-11-25T11:20:41Z
Timothy Bish
On Wed, 2009-11-25 at 09:12 -0800, jhakim wrote:
<br>> Thanks Tim. We are using ICSharpCode
<br>> (<a href="http://www.icsharpcode.net/OpenSource/SharpZipLib/" target="_top" rel="nofollow">http://www.icsharpcode.net/OpenSource/SharpZipLib/</a>) for end-to-end
<br>> compression between C#/Java clients using TIBCO EMS.
<br>>
<br>> In any case, does the native ActiveMQ compression provide end-to-end
<br>> compression between C#/Java clients? If not, how do we get C#/Java clients
<br>> to exchange compressed messages?
<br><br>The Java client can send and receive messages with compressed message
<br>bodies. The body is compressed using the Java Deflate classes which
<br>work with ZLib compression. In order to send and receive compressed
<br>messages from Java to .NET clients the .NET client needs to be able to
<br>handle Zlib compression as well. We didn't want to tie the user to a
<br>particular compression library with NMS.ActiveMQ so we provide an
<br>interface class that the user can implement to give us access to a
<br>Stream class that can compress or decompress the message body.
<br><br>If you grab the latest code from SVN you will find an interface called
<br>ICompressionPolicy in the NMS.ActiveMQ project. The default
<br>implementation uses the .NET gzip Stream classes so those aren't going
<br>to work if you want to send to a Java client, you'd need to provide a
<br>new policy class. If you take a look at the MessageCompressionTest.cs
<br>file in the NMS.ActiveMQ test/csharp/Commands folder you will see how
<br>this is done.
<br><br>Regards
<br>Tim.
<br><br><div class='shrinkable-quote'><br>>
<br>>
<br>> Timothy Bish wrote:
<br>> >
<br>> > On Tue, 2009-11-24 at 07:55 -0800, jhakim wrote:
<br>> >> I would like to create a large (40+ MB) MapMessage, get its byte[],
<br>> >> compress
<br>> >> the bytes, and send it across the wire as a BytesMessage. On the
<br>> >> receiving
<br>> >> side, I would like to read the byte[], uncompress, and create the
<br>> >> original
<br>> >> MapMessage from the byte[].
<br>> >>
<br>> >> We have been using this strategy with great success using TIBCO EMS. We
<br>> >> have
<br>> >> a mix of clients - Java and C#.
<br>> >>
<br>> >> As we look at ActiveMQ as an alternative to TIBCO EMS, I am wondering if
<br>> >> there is an API that would let us implement the same strategy.
<br>> >> Specifically,
<br>> >> is there an API to get the byte[] from a MapMessage and to create a
<br>> >> MapMessage from a byte[]?
<br>> >>
<br>> >> Thanks in advance.
<br>> >
<br>> > There's not a direct way of doing this via the NMS API but there are
<br>> > some tricks that can allow you to get the byte[] from a MapMessage if
<br>> > you really wanted to. There is another option that might be better that
<br>> > will be available in the NMS.AcitveMQ 1.2.0 release. You can now set a
<br>> > property on the Connection instance to enable compression and provide a
<br>> > CompressionPolicy instance that defines the compression method used to
<br>> > compress and decompress the body of a Message. By default NMS.ActiveMQ
<br>> > just uses the GZipStream built into .NET but if you want to actually
<br>> > trade messages between Java and .NET then you'd need to use something
<br>> > like the DotNetZip library which provides a ZlibStream class that can
<br>> > compress and decompress in a format that's compatible with the Java
<br>> > client's own compression format.
<br>> >
<br>> > Regards
<br>> > Tim.
<br>> >
<br>> > --
<br>> > Tim Bish
<br>> > <a href="http://fusesource.com" target="_top" rel="nofollow">http://fusesource.com</a><br>> > <a href="http://timbish.blogspot.com/" target="_top" rel="nofollow">http://timbish.blogspot.com/</a><br>> >
<br>> >
<br>> >
<br>> >
<br>> >
<br>>
</div>--
<br>Tim Bish
<br><a href="http://fusesource.com" target="_top" rel="nofollow">http://fusesource.com</a><br><a href="http://timbish.blogspot.com/" target="_top" rel="nofollow">http://timbish.blogspot.com/</a><br><br><br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>
tag:old.nabble.com,2006:post-26518158
Re: Best implementation for reply-request
2009-11-25T10:44:34Z
2009-11-25T10:44:34Z
bsnyder
On Wed, Nov 25, 2009 at 10:34 AM, Andres Rangel
<br><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26518158&i=0" target="_top" rel="nofollow">andresr@...</a>> wrote:
<div class='shrinkable-quote'><br>> Hi,
<br>>
<br>> We have currently running apache activemq 5.2 in a network of brokers
<br>>
<br>>
<br>>
<br>> It has close to 1500 producers and 1200 consumers.
<br>>
<br>> This producers have each one a temporary queue so that will be 1500
<br>> temp queues in the system.
<br>>
<br>>
<br>>
<br>> The reply-request is implemented using temporary queues.
<br>>
<br>>
<br>>
<br>>
<br>>
<br>> I would like to know if there's a performance hit by using temporary
<br>> queues instead of using another option.
<br>>
<br>>
<br>>
<br>> What do you guys think?
</div><br>There's more overhead involved with such constant creation/destruction
<br>of temp queues, but that's it. As long as the broker has been tuned to
<br>scale for handling such a large number of destinations, then you
<br>should be OK:
<br><br><a href="http://activemq.apache.org/scaling-queues.html" target="_top" rel="nofollow">http://activemq.apache.org/scaling-queues.html</a><br><br>Bruce
<br>--
<br>perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
<br>);'
<br><br>ActiveMQ in Action: <a href="http://bit.ly/2je6cQ" target="_top" rel="nofollow">http://bit.ly/2je6cQ</a><br>Blog: <a href="http://bruceblog.org/" target="_top" rel="nofollow">http://bruceblog.org/</a><br>Twitter: <a href="http://twitter.com/brucesnyder" target="_top" rel="nofollow">http://twitter.com/brucesnyder</a><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>
tag:old.nabble.com,2006:post-26517545
[jira] Commented: (AMQCPP-253) Problems with compiler aCC on HPUX
2009-11-25T10:01:52Z
2009-11-25T10:01:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQCPP-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56113#action_56113" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQCPP-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56113#action_56113</a> ]
<br><br>Brian McFarland commented on AMQCPP-253:
<br>----------------------------------------
<br><br>I get another round of compile issues after updating from SVN.
<br><br>Subversion properties:
<br>Revision/Author: 883794 tabish
<br>Last commit revision: 883703, 9:31:31 AM, 24 Nov 2009.
<br><br>Error messages:
<br><br>Error 19: "advisories/TempDestinationAdvisoryConsumer.cpp", line 77 # Unexpected '>'.
<br> amqMessage->getDataStructure().dynamicCast<DestinationInfo>();
<br> ^
<br>Error 902: "advisories/TempDestinationAdvisoryConsumer.cpp", line 77 # Template deduction
<br> with signature 'void (void (),activemq::commands::DestinationInfo)'.
<br> amqMessage->getDataStructure().dynamicCast<DestinationInfo>();
<br> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
<br>Error 226: "advisories/TempDestinationAdvisoryConsumer.cpp", line 76 # No appropriate func
<br> viable candidate was "decaf::lang::Pointer<activemq::commands::DestinationInfo,decaf::
<br> decaf::lang::Pointer<activemq::commands::DestinationInfo,decaf::lang::AtomicRefCounter
<br> Argument of type 'int' could not be converted to 'const
<br> decaf::lang::Pointer<activemq::commands::DestinationInfo,decaf::lang::AtomicRefCounter
<br> Pointer<DestinationInfo> info =
<br> ^^^^
<br><br><div class='shrinkable-quote'><br>> Problems with compiler aCC on HPUX
<br>> ----------------------------------
<br>>
<br>> Key: AMQCPP-253
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQCPP-253" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQCPP-253</a><br>> Project: ActiveMQ C++ Client
<br>> Issue Type: Improvement
<br>> Affects Versions: 3.0
<br>> Environment: HP-UX gemma1 B.11.23 U 9000/800
<br>> aCC: HP ANSI C++ B3910B A.03.77
<br>> Reporter: Wolfgang.Klein
<br>> Assignee: Timothy Bish
<br>> Priority: Minor
<br>> Fix For: 3.1
<br>>
<br>> Attachments: amq_cpp_30.tar, aq_cpp_make, TcpSocket.cpp
<br>>
<br>>
<br>> compile errors with native HP compiler
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26517070
Best implementation for reply-request
2009-11-25T09:34:08Z
2009-11-25T09:34:08Z
Andres Rangel-2
Hi,
<br><br>We have currently running apache activemq 5.2 in a network of brokers
<br><br>
<br><br>It has close to 1500 producers and 1200 consumers.
<br><br>This producers have each one a temporary queue so that will be 1500
<br>temp queues in the system.
<br><br>
<br><br>The reply-request is implemented using temporary queues.
<br><br>
<br><br>
<br><br>I would like to know if there's a performance hit by using temporary
<br>queues instead of using another option.
<br><br>
<br><br>What do you guys think?
<br><br>--
<br><br>Andres Rangel
<br><br>Sw Engineer
<br><br>Moniker.com
<br><br>
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>
tag:old.nabble.com,2006:post-26517002
[jira] Resolved: (AMQ-2088) Change the InactivityMonitor to clear its flag as soon as a few bytes are received on a connection rather than only after an entire message has been assembled.
2009-11-25T09:29:52Z
2009-11-25T09:29:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Hiram Chirino resolved AMQ-2088.
<br>--------------------------------
<br><br> Resolution: Fixed
<br><br>opened
<br>AMQ-2511 to track
<br><div class='shrinkable-quote'><br>> Change the InactivityMonitor to clear its flag as soon as a few bytes are received on a connection rather than only after an entire message has been assembled.
<br>> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
<br>>
<br>> Key: AMQ-2088
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2088" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2088</a><br>> Project: ActiveMQ
<br>> Issue Type: Improvement
<br>> Components: Transport
<br>> Affects Versions: 5.1.0
<br>> Reporter: Torsten Mielke
<br>> Assignee: Dejan Bosanac
<br>> Priority: Critical
<br>> Fix For: 5.3.0
<br>>
<br>>
<br>> On slow connections with larger messages to be exchanged, the inactivity monitor might kick in, drop the network connection and re-establish it again. This prevents two brokers from exchanging larger messages on a slow connection as the transmission always gets interrupted.
<br>> See the discussion of this on <a href="http://activemq.apache.org/slow-networks-drop-large-messages.html" target="_top" rel="nofollow">http://activemq.apache.org/slow-networks-drop-large-messages.html</a>.
<br>> The problem is that the InactivityMonitor always waits for a complete message to be assembled on an active connection before clearing its internal flag.
<br>> I propose to change the behavior of the InactivityMonitor so that it clears its flag already when a few bytes were received on a network connection rather than waiting for the entire message to be sent. This should work around the problem of connections being dropped and re-established periodically when receiving large messages.
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26516822
[jira] Created: (AMQ-2511) Regression: Inactivity monitor does not time out stale connections.
2009-11-25T09:23:52Z
2009-11-25T09:23:52Z
JIRA jira@apache.org
Regression: Inactivity monitor does not time out stale connections.
<br>-------------------------------------------------------------------
<br><br> Key: AMQ-2511
<br> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2511" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2511</a><br> Project: ActiveMQ
<br> Issue Type: Bug
<br> Components: Broker
<br> Affects Versions: 5.3.0
<br> Reporter: Hiram Chirino
<br> Assignee: Hiram Chirino
<br> Fix For: 5.4.0
<br><br><br>The fix @ AMQ-2088 cause a the Inactivity Monitor to regress.
<br><br>Now when a socket is waiting to read the next message, or is in the middle of receiving the next message it sets a flag that disable the inactivity monitor from timing out the connection. The problem is that if the connection gets hung, then it won't time out since the flag is set.
<br><br>I think a better approach would be for the wireformat to expose a counter which is incremented as data is read.
<br><br>That way between inactivity check intervals the inactivity monitor can check to see if that value has changed since it's last check.
<br><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26516750
[jira] Commented: (AMQ-2088) Change the InactivityMonitor to clear its flag as soon as a few bytes are received on a connection rather than only after an entire message has been assembled.
2009-11-25T09:19:52Z
2009-11-25T09:19:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56111#action_56111" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56111#action_56111</a> ]
<br><br>Hiram Chirino commented on AMQ-2088:
<br>------------------------------------
<br><br>I think a better approach would be for the wireformat to expose a counter which is incremented as data is read.
<br><br>That way between inactivity check intervals the inactivity monitor can check to see if that value has changed since it's last check.
<br><div class='shrinkable-quote'><br>> Change the InactivityMonitor to clear its flag as soon as a few bytes are received on a connection rather than only after an entire message has been assembled.
<br>> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
<br>>
<br>> Key: AMQ-2088
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2088" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2088</a><br>> Project: ActiveMQ
<br>> Issue Type: Improvement
<br>> Components: Transport
<br>> Affects Versions: 5.1.0
<br>> Reporter: Torsten Mielke
<br>> Assignee: Dejan Bosanac
<br>> Priority: Critical
<br>> Fix For: 5.3.0
<br>>
<br>>
<br>> On slow connections with larger messages to be exchanged, the inactivity monitor might kick in, drop the network connection and re-establish it again. This prevents two brokers from exchanging larger messages on a slow connection as the transmission always gets interrupted.
<br>> See the discussion of this on <a href="http://activemq.apache.org/slow-networks-drop-large-messages.html" target="_top" rel="nofollow">http://activemq.apache.org/slow-networks-drop-large-messages.html</a>.
<br>> The problem is that the InactivityMonitor always waits for a complete message to be assembled on an active connection before clearing its internal flag.
<br>> I propose to change the behavior of the InactivityMonitor so that it clears its flag already when a few bytes were received on a network connection rather than waiting for the entire message to be sent. This should work around the problem of connections being dropped and re-established periodically when receiving large messages.
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26516734
Re: xa jta activemq jboss
2009-11-25T09:19:05Z
2009-11-25T09:19:05Z
Gary Tully
is the problem that the
<br>ActiveMQInitialContextFactory returns a regular connection factory rather
<br>than an XA capable one. You may want to extend the
<br>ActiveMQInitialContextFactory to override the createConnectionFactory()
<br>method to return an XA variant or see if you can explicitly provide the
<br>connection factory reference.
<br>Either through configuration of by default the createConnectionFactory
<br>should be capable of returning an XA connection factory. I think by defaut
<br>it would make sense. Can you raise a JIRA for this an if you find that this
<br>is the root cause of your problem.
<br><br><br>2009/11/25 miten <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26516734&i=0" target="_top" rel="nofollow">Miten.Mehta@...</a>>
<br><div class='shrinkable-quote'><br>>
<br>> Hi,
<br>>
<br>> I am able to get things to work without global transaction. With JBOSS I
<br>> am
<br>> getting "javax.jms.JMSException: Session's XAResource has not been enlisted
<br>> in a distributed transaction."
<br>>
<br>> using the spring config as below:
<br>> =========================
<br>> <bean id="myMessageListener" class="jmsexample.ExampleListener" />
<br>> <bean id="jndiTemplate" class="org.springframework.jndi.JndiTemplate">
<br>> <property name="environment">
<br>> <props>
<br>> <prop key="java.naming.factory.initial">
<br>> org.apache.activemq.jndi.ActiveMQInitialContextFactory
<br>> </prop>
<br>> <prop key="queue.TEST.Q1">
<br>> TEST.Q1
<br>> </prop>
<br>> </props>
<br>> </property>
<br>> </bean>
<br>> <bean id="appJmsDestination"
<br>> class="org.springframework.jndi.JndiObjectFactoryBean">
<br>> <property name="jndiTemplate">
<br>> <ref bean="jndiTemplate"/>
<br>> </property>
<br>> <property name="jndiName" value="TEST.Q1"/>
<br>> </bean>
<br>> <bean id="connectionFactory"
<br>> class="org.apache.activemq.ActiveMQXAConnectionFactory">
<br>> <property name="brokerURL">
<br>> <value>tcp://localhost:61616</value>
<br>> </property>
<br>> </bean>
<br>>
<br>>
<br>> <bean id="jmsContainer"
<br>> class="org.springframework.jms.listener.DefaultMessageListenerContainer">
<br>> <property name="connectionFactory" ref="connectionFactory"/>
<br>> <property name="destination" ref="appJmsDestination"/>
<br>> <property name="messageListener" ref="myMessageListener" />
<br>>
<br>>
<br>> <property name="transactionManager" ref="transactionManager"/>
<br>>
<br>> </bean>
<br>>
<br>>
<br>> <bean id="jbossTransactionManager"
<br>>
<br>>
<br>> class="com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionManagerImple">
<br>> </bean>
<br>>
<br>> <bean id="jbossUserTransaction"
<br>>
<br>>
<br>> class="com.arjuna.ats.internal.jta.transaction.arjunacore.UserTransactionImple"/>
<br>>
<br>> <bean id="transactionManager"
<br>> class="org.springframework.transaction.jta.JtaTransactionManager">
<br>> <property name="transactionManager">
<br>> <ref bean="jbossTransactionManager" />
<br>> </property>
<br>> <property name="userTransaction">
<br>> <ref bean="jbossUserTransaction" />
<br>> </property>
<br>> </bean>
<br>>
<br>>
<br>> Regards,
<br>>
<br>> Miten.
<br>> --
<br>> View this message in context:
<br>> <a href="http://old.nabble.com/xa-jta-activemq-jboss-tp26515685p26515685.html" target="_top" rel="nofollow">http://old.nabble.com/xa-jta-activemq-jboss-tp26515685p26515685.html</a><br>> Sent from the ActiveMQ - User mailing list archive at Nabble.com.
<br>>
<br>>
</div><br><br>--
<br><a href="http://blog.garytully.com" target="_top" rel="nofollow">http://blog.garytully.com</a><br><br>Open Source Integration
<br><a href="http://fusesource.com" target="_top" rel="nofollow">http://fusesource.com</a><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>
tag:old.nabble.com,2006:post-26516713
[jira] Commented: (AMQNET-214) Individual Acknowledge only working on last message in queue
2009-11-25T09:17:52Z
2009-11-25T09:17:52Z
JIRA jira+amqnet@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQNET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56109#action_56109" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56109#action_56109</a> ]
<br><br>Palm Kevin commented on AMQNET-214:
<br>-----------------------------------
<br><br>Ok ... finally my patch is useless since you provide your own unit-test ...
<br>I confirm that this issue is fixed now
<br><div class='shrinkable-quote'><br>> Individual Acknowledge only working on last message in queue
<br>> ------------------------------------------------------------
<br>>
<br>> Key: AMQNET-214
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQNET-214" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-214</a><br>> Project: ActiveMQ .Net
<br>> Issue Type: Bug
<br>> Components: ActiveMQ
<br>> Affects Versions: 1.2.0
<br>> Reporter: Palm Kevin
<br>> Assignee: Timothy Bish
<br>> Priority: Critical
<br>> Fix For: 1.2.0
<br>>
<br>> Attachments: IndividualAckTest_FirstConsumed.patch
<br>>
<br>>
<br>> The new acknowldege-mode _IndividualAcknowledge_ seems not working correctly.
<br>> The _message.Acknowledge()_ does only work if called on last message of the queue!
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26516714
[jira] Reopened: (AMQ-2088) Change the InactivityMonitor to clear its flag as soon as a few bytes are received on a connection rather than only after an entire message has been assembled.
2009-11-25T09:17:52Z
2009-11-25T09:17:52Z
JIRA jira@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQ-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Hiram Chirino reopened AMQ-2088:
<br>--------------------------------
<br><br><br>This fix caused a regression on in the inactivity monitor.
<br><br>Now when a socket is waiting to read the next message, or is in the middle of receiving the next message it sets a flag that disable the inactivity monitor from timing out the connection. The problem is that if the connection gets hung, then it won't time out since the flag is set.
<br><div class='shrinkable-quote'><br>> Change the InactivityMonitor to clear its flag as soon as a few bytes are received on a connection rather than only after an entire message has been assembled.
<br>> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
<br>>
<br>> Key: AMQ-2088
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQ-2088" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQ-2088</a><br>> Project: ActiveMQ
<br>> Issue Type: Improvement
<br>> Components: Transport
<br>> Affects Versions: 5.1.0
<br>> Reporter: Torsten Mielke
<br>> Assignee: Dejan Bosanac
<br>> Priority: Critical
<br>> Fix For: 5.3.0
<br>>
<br>>
<br>> On slow connections with larger messages to be exchanged, the inactivity monitor might kick in, drop the network connection and re-establish it again. This prevents two brokers from exchanging larger messages on a slow connection as the transmission always gets interrupted.
<br>> See the discussion of this on <a href="http://activemq.apache.org/slow-networks-drop-large-messages.html" target="_top" rel="nofollow">http://activemq.apache.org/slow-networks-drop-large-messages.html</a>.
<br>> The problem is that the InactivityMonitor always waits for a complete message to be assembled on an active connection before clearing its internal flag.
<br>> I propose to change the behavior of the InactivityMonitor so that it clears its flag already when a few bytes were received on a network connection rather than waiting for the entire message to be sent. This should work around the problem of connections being dropped and re-established periodically when receiving large messages.
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26516611
Re: Creating message from byte[]
2009-11-25T09:12:58Z
2009-11-25T09:12:58Z
jhakim
Thanks Tim. We are using ICSharpCode (<a href="http://www.icsharpcode.net/OpenSource/SharpZipLib/" target="_top" rel="nofollow">http://www.icsharpcode.net/OpenSource/SharpZipLib/</a>) for end-to-end compression between C#/Java clients using TIBCO EMS.
<br><br>In any case, does the native ActiveMQ compression provide end-to-end compression between C#/Java clients? If not, how do we get C#/Java clients to exchange compressed messages?
<br>
<br><blockquote class="quote light-black dark-border-color"><div class="quote light-border-color">
<div class="quote-author" style="font-weight: bold;">Timothy Bish wrote:</div>
<div class="quote-message shrinkable-quote">On Tue, 2009-11-24 at 07:55 -0800, jhakim wrote:
<br>> I would like to create a large (40+ MB) MapMessage, get its byte[], compress
<br>> the bytes, and send it across the wire as a BytesMessage. On the receiving
<br>> side, I would like to read the byte[], uncompress, and create the original
<br>> MapMessage from the byte[].
<br>>
<br>> We have been using this strategy with great success using TIBCO EMS. We have
<br>> a mix of clients - Java and C#.
<br>>
<br>> As we look at ActiveMQ as an alternative to TIBCO EMS, I am wondering if
<br>> there is an API that would let us implement the same strategy. Specifically,
<br>> is there an API to get the byte[] from a MapMessage and to create a
<br>> MapMessage from a byte[]?
<br>>
<br>> Thanks in advance.
<br><br>There's not a direct way of doing this via the NMS API but there are
<br>some tricks that can allow you to get the byte[] from a MapMessage if
<br>you really wanted to. There is another option that might be better that
<br>will be available in the NMS.AcitveMQ 1.2.0 release. You can now set a
<br>property on the Connection instance to enable compression and provide a
<br>CompressionPolicy instance that defines the compression method used to
<br>compress and decompress the body of a Message. By default NMS.ActiveMQ
<br>just uses the GZipStream built into .NET but if you want to actually
<br>trade messages between Java and .NET then you'd need to use something
<br>like the DotNetZip library which provides a ZlibStream class that can
<br>compress and decompress in a format that's compatible with the Java
<br>client's own compression format.
<br><br>Regards
<br>Tim.
<br><br>--
<br>Tim Bish
<br><a href="http://fusesource.com" target="_top" rel="nofollow">http://fusesource.com</a><br><a href="http://timbish.blogspot.com/" target="_top" rel="nofollow">http://timbish.blogspot.com/</a><br><br><br></div>
</div></blockquote>
<p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>
tag:old.nabble.com,2006:post-26516335
[jira] Updated: (AMQNET-214) Individual Acknowledge only working on last message in queue
2009-11-25T08:57:52Z
2009-11-25T08:57:52Z
JIRA jira+amqnet@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQNET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Palm Kevin updated AMQNET-214:
<br>------------------------------
<br><br> Attachment: IndividualAckTest_FirstConsumed.patch
<br><br>In order to simplify your life, I attached a patch that contains the broken UnitTest
<br><div class='shrinkable-quote'><br>> Individual Acknowledge only working on last message in queue
<br>> ------------------------------------------------------------
<br>>
<br>> Key: AMQNET-214
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQNET-214" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-214</a><br>> Project: ActiveMQ .Net
<br>> Issue Type: Bug
<br>> Components: ActiveMQ
<br>> Affects Versions: 1.2.0
<br>> Reporter: Palm Kevin
<br>> Assignee: Timothy Bish
<br>> Priority: Critical
<br>> Fix For: 1.2.0
<br>>
<br>> Attachments: IndividualAckTest_FirstConsumed.patch
<br>>
<br>>
<br>> The new acknowldege-mode _IndividualAcknowledge_ seems not working correctly.
<br>> The _message.Acknowledge()_ does only work if called on last message of the queue!
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26516336
[jira] Resolved: (AMQNET-214) Individual Acknowledge only working on last message in queue
2009-11-25T08:57:52Z
2009-11-25T08:57:52Z
JIRA jira+amqnet@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQNET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel</a> ]
<br><br>Timothy Bish resolved AMQNET-214.
<br>---------------------------------
<br><br> Resolution: Fixed
<br><br>Resolved in trunk and the 1.2.x branch
<br><div class='shrinkable-quote'><br>> Individual Acknowledge only working on last message in queue
<br>> ------------------------------------------------------------
<br>>
<br>> Key: AMQNET-214
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQNET-214" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-214</a><br>> Project: ActiveMQ .Net
<br>> Issue Type: Bug
<br>> Components: ActiveMQ
<br>> Affects Versions: 1.2.0
<br>> Reporter: Palm Kevin
<br>> Assignee: Timothy Bish
<br>> Priority: Critical
<br>> Fix For: 1.2.0
<br>>
<br>> Attachments: IndividualAckTest_FirstConsumed.patch
<br>>
<br>>
<br>> The new acknowldege-mode _IndividualAcknowledge_ seems not working correctly.
<br>> The _message.Acknowledge()_ does only work if called on last message of the queue!
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26516280
svn commit: r884195 - in /activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src: main/csharp/MessageConsumer.cs test/csharp/IndividualAckTest.cs
2009-11-25T08:54:33Z
2009-11-25T08:54:33Z
tabish
Author: tabish
<br>Date: Wed Nov 25 16:54:33 2009
<br>New Revision: 884195
<br><br>URL: <a href="http://svn.apache.org/viewvc?rev=884195&view=rev" target="_top" rel="nofollow">http://svn.apache.org/viewvc?rev=884195&view=rev</a><br>Log:
<br><a href="https://issues.apache.org/activemq/browse/AMQNET-214" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-214</a><br><br>Fix the individual ack callback so that it searches the entire list of dispatched messages for the one to ack. Adds the users test case to the Individual Ack tests.
<br><br>Modified:
<br> activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/main/csharp/MessageConsumer.cs
<br> activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/test/csharp/IndividualAckTest.cs
<br><br>Modified: activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/main/csharp/MessageConsumer.cs
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/main/csharp/MessageConsumer.cs?rev=884195&r1=884194&r2=884195&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/main/csharp/MessageConsumer.cs?rev=884195&r1=884194&r2=884195&view=diff</a><br>==============================================================================
<br>--- activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/main/csharp/MessageConsumer.cs (original)
<br>+++ activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/main/csharp/MessageConsumer.cs Wed Nov 25 16:54:33 2009
<br>@@ -341,10 +341,14 @@
<br> this.dispatchedMessages.Remove(originalDispatch);
<br> break;
<br> }
<br>-
<br>- return;
<br> }
<br> }
<br>+
<br>+ if(dispatch == null)
<br>+ {
<br>+ Tracer.DebugFormat("Attempt to Ack MessageId[{0}] failed because the original dispatch is not in the Dispatch List", message.MessageId);
<br>+ return;
<br>+ }
<br>
<br> MessageAck ack = new MessageAck();
<br>
<br>@@ -354,6 +358,7 @@
<br> ack.LastMessageId = dispatch.Message.MessageId;
<br> ack.MessageCount = 1;
<br>
<br>+ Tracer.Debug("Sending Individual Ack for MessageId: " + ack.LastMessageId.ToString());
<br> this.session.Connection.Oneway(ack);
<br> }
<br>
<br><br>Modified: activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/test/csharp/IndividualAckTest.cs
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/test/csharp/IndividualAckTest.cs?rev=884195&r1=884194&r2=884195&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/test/csharp/IndividualAckTest.cs?rev=884195&r1=884194&r2=884195&view=diff</a><br>==============================================================================
<br>--- activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/test/csharp/IndividualAckTest.cs (original)
<br>+++ activemq/activemq-dotnet/Apache.NMS.ActiveMQ/branches/1.2.x/src/test/csharp/IndividualAckTest.cs Wed Nov 25 16:54:33 2009
<br>@@ -139,5 +139,49 @@
<br> session.Close();
<br> }
<br>
<br>+ [Test]
<br>+ public void TestIndividualAcknowledgeMultiMessages_AcknowledgeFirstTest()
<br>+ {
<br>+ ISession session = connection.CreateSession(AcknowledgementMode.IndividualAcknowledge);
<br>+
<br>+ // Push 2 messages to queue
<br>+ ITemporaryQueue queue = session.CreateTemporaryQueue();
<br>+ IMessageProducer producer = session.CreateProducer(queue);
<br>+
<br>+ ITextMessage msg = session.CreateTextMessage("test 1");
<br>+ producer.Send(msg, MsgDeliveryMode.Persistent, MsgPriority.Normal, TimeSpan.MinValue);
<br>+ msg = session.CreateTextMessage("test 2");
<br>+ producer.Send(msg, MsgDeliveryMode.Persistent, MsgPriority.Normal, TimeSpan.MinValue);
<br>+ producer.Close();
<br>+
<br>+ IMessageConsumer consumer = session.CreateConsumer(queue);
<br>+
<br>+ // Read the first message
<br>+ ITextMessage fetchedMessage1 = (ITextMessage) consumer.Receive(TimeSpan.FromMilliseconds(2000));
<br>+ Assert.IsNotNull(fetchedMessage1);
<br>+ Assert.AreEqual("test 1", fetchedMessage1.Text);
<br>+
<br>+ // Read the second message
<br>+ ITextMessage fetchedMessage2 = (ITextMessage) consumer.Receive(TimeSpan.FromMilliseconds(2000));
<br>+ Assert.IsNotNull(fetchedMessage2);
<br>+ Assert.AreEqual("test 2", fetchedMessage2.Text);
<br>+
<br>+ // Acknowledge first message
<br>+ fetchedMessage1.Acknowledge();
<br>+
<br>+ consumer.Close();
<br>+
<br>+ // Read first message a second time
<br>+ consumer = session.CreateConsumer(queue);
<br>+ fetchedMessage1 = (ITextMessage) consumer.Receive(TimeSpan.FromMilliseconds(2000));
<br>+ Assert.IsNotNull(fetchedMessage1);
<br>+ Assert.AreEqual("test 2", fetchedMessage1.Text);
<br>+
<br>+ // Try to read second message a second time
<br>+ fetchedMessage2 = (ITextMessage) consumer.Receive(TimeSpan.FromMilliseconds(2000));
<br>+ Assert.IsNull(fetchedMessage2);
<br>+ consumer.Close();
<br>+ }
<br>+
<br> }
<br> }
<br><br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Commits-f23834.html" embed="fixTarget[23834]" target="_top" >ActiveMQ - Commits</a></p>
tag:old.nabble.com,2006:post-26516215
svn commit: r884193 - in /activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src: main/csharp/MessageConsumer.cs test/csharp/IndividualAckTest.cs
2009-11-25T08:50:05Z
2009-11-25T08:50:05Z
tabish
Author: tabish
<br>Date: Wed Nov 25 16:50:05 2009
<br>New Revision: 884193
<br><br>URL: <a href="http://svn.apache.org/viewvc?rev=884193&view=rev" target="_top" rel="nofollow">http://svn.apache.org/viewvc?rev=884193&view=rev</a><br>Log:
<br><a href="https://issues.apache.org/activemq/browse/AMQNET-214" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-214</a><br><br>Fix the individual ack callback so that it searches the entire list of dispatched messages for the one to ack. Adds the users test case to the Individual Ack tests.
<br><br>Modified:
<br> activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/MessageConsumer.cs
<br> activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/test/csharp/IndividualAckTest.cs
<br><br>Modified: activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/MessageConsumer.cs
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/MessageConsumer.cs?rev=884193&r1=884192&r2=884193&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/MessageConsumer.cs?rev=884193&r1=884192&r2=884193&view=diff</a><br>==============================================================================
<br>--- activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/MessageConsumer.cs (original)
<br>+++ activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/MessageConsumer.cs Wed Nov 25 16:50:05 2009
<br>@@ -341,10 +341,14 @@
<br> this.dispatchedMessages.Remove(originalDispatch);
<br> break;
<br> }
<br>-
<br>- return;
<br> }
<br> }
<br>+
<br>+ if(dispatch == null)
<br>+ {
<br>+ Tracer.DebugFormat("Attempt to Ack MessageId[{0}] failed because the original dispatch is not in the Dispatch List", message.MessageId);
<br>+ return;
<br>+ }
<br>
<br> MessageAck ack = new MessageAck();
<br>
<br>@@ -354,6 +358,7 @@
<br> ack.LastMessageId = dispatch.Message.MessageId;
<br> ack.MessageCount = 1;
<br>
<br>+ Tracer.Debug("Sending Individual Ack for MessageId: " + ack.LastMessageId.ToString());
<br> this.session.Connection.Oneway(ack);
<br> }
<br>
<br><br>Modified: activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/test/csharp/IndividualAckTest.cs
<br>URL: <a href="http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/test/csharp/IndividualAckTest.cs?rev=884193&r1=884192&r2=884193&view=diff" target="_top" rel="nofollow">http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/test/csharp/IndividualAckTest.cs?rev=884193&r1=884192&r2=884193&view=diff</a><br>==============================================================================
<br>--- activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/test/csharp/IndividualAckTest.cs (original)
<br>+++ activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/test/csharp/IndividualAckTest.cs Wed Nov 25 16:50:05 2009
<br>@@ -139,5 +139,49 @@
<br> session.Close();
<br> }
<br>
<br>+ [Test]
<br>+ public void TestIndividualAcknowledgeMultiMessages_AcknowledgeFirstTest()
<br>+ {
<br>+ ISession session = connection.CreateSession(AcknowledgementMode.IndividualAcknowledge);
<br>+
<br>+ // Push 2 messages to queue
<br>+ ITemporaryQueue queue = session.CreateTemporaryQueue();
<br>+ IMessageProducer producer = session.CreateProducer(queue);
<br>+
<br>+ ITextMessage msg = session.CreateTextMessage("test 1");
<br>+ producer.Send(msg, MsgDeliveryMode.Persistent, MsgPriority.Normal, TimeSpan.MinValue);
<br>+ msg = session.CreateTextMessage("test 2");
<br>+ producer.Send(msg, MsgDeliveryMode.Persistent, MsgPriority.Normal, TimeSpan.MinValue);
<br>+ producer.Close();
<br>+
<br>+ IMessageConsumer consumer = session.CreateConsumer(queue);
<br>+
<br>+ // Read the first message
<br>+ ITextMessage fetchedMessage1 = (ITextMessage) consumer.Receive(TimeSpan.FromMilliseconds(2000));
<br>+ Assert.IsNotNull(fetchedMessage1);
<br>+ Assert.AreEqual("test 1", fetchedMessage1.Text);
<br>+
<br>+ // Read the second message
<br>+ ITextMessage fetchedMessage2 = (ITextMessage) consumer.Receive(TimeSpan.FromMilliseconds(2000));
<br>+ Assert.IsNotNull(fetchedMessage2);
<br>+ Assert.AreEqual("test 2", fetchedMessage2.Text);
<br>+
<br>+ // Acknowledge first message
<br>+ fetchedMessage1.Acknowledge();
<br>+
<br>+ consumer.Close();
<br>+
<br>+ // Read first message a second time
<br>+ consumer = session.CreateConsumer(queue);
<br>+ fetchedMessage1 = (ITextMessage) consumer.Receive(TimeSpan.FromMilliseconds(2000));
<br>+ Assert.IsNotNull(fetchedMessage1);
<br>+ Assert.AreEqual("test 2", fetchedMessage1.Text);
<br>+
<br>+ // Try to read second message a second time
<br>+ fetchedMessage2 = (ITextMessage) consumer.Receive(TimeSpan.FromMilliseconds(2000));
<br>+ Assert.IsNull(fetchedMessage2);
<br>+ consumer.Close();
<br>+ }
<br>+
<br> }
<br> }
<br><br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Commits-f23834.html" embed="fixTarget[23834]" target="_top" >ActiveMQ - Commits</a></p>
tag:old.nabble.com,2006:post-26515685
xa jta activemq jboss
2009-11-25T08:21:46Z
2009-11-25T08:21:46Z
miten
Hi,
<br><br>I am able to get things to work without global transaction. With JBOSS I am getting "javax.jms.JMSException: Session's XAResource has not been enlisted in a distributed transaction."
<br><br>using the spring config as below:
<br>=========================
<br><bean id="myMessageListener" class="jmsexample.ExampleListener" />
<br><bean id="jndiTemplate" class="org.springframework.jndi.JndiTemplate">
<br> <property name="environment">
<br> <props>
<br> <prop key="java.naming.factory.initial">
<br> org.apache.activemq.jndi.ActiveMQInitialContextFactory
<br> </prop>
<br> <prop key="queue.TEST.Q1">
<br> TEST.Q1
<br> </prop>
<br> </props>
<br> </property>
<br> </bean>
<br> <bean id="appJmsDestination"
<br> class="org.springframework.jndi.JndiObjectFactoryBean">
<br> <property name="jndiTemplate">
<br> <ref bean="jndiTemplate"/>
<br> </property>
<br> <property name="jndiName" value="TEST.Q1"/>
<br> </bean>
<br><bean id="connectionFactory"
<br> class="org.apache.activemq.ActiveMQXAConnectionFactory">
<br> <property name="brokerURL">
<br> <value>tcp://localhost:61616</value>
<br> </property>
<br> </bean>
<br><br><br><bean id="jmsContainer" class="org.springframework.jms.listener.DefaultMessageListenerContainer">
<br> <property name="connectionFactory" ref="connectionFactory"/>
<br> <property name="destination" ref="appJmsDestination"/>
<br> <property name="messageListener" ref="myMessageListener" />
<br>
<br>
<br> <property name="transactionManager" ref="transactionManager"/>
<br>
<br></bean>
<br><br>
<br> <bean id="jbossTransactionManager"
<br> class="com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionManagerImple">
<br> </bean>
<br><br> <bean id="jbossUserTransaction"
<br> class="com.arjuna.ats.internal.jta.transaction.arjunacore.UserTransactionImple"/>
<br><br> <bean id="transactionManager"
<br> class="org.springframework.transaction.jta.JtaTransactionManager">
<br> <property name="transactionManager">
<br> <ref bean="jbossTransactionManager" />
<br> </property>
<br> <property name="userTransaction">
<br> <ref bean="jbossUserTransaction" />
<br> </property>
<br> </bean>
<br><br><br>Regards,
<br><br>Miten.<p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>
tag:old.nabble.com,2006:post-26515357
Re: Active Consumers on TCP x HTTP
2009-11-25T08:02:43Z
2009-11-25T08:02:43Z
Uday Subbarayan-3
I am also in a similar situation...I need a HTTP producer but can't get it work yet!
<br><br>Uday.
<br><br>-------------------------
<br><br>I do not blog but e-write:
<br><br><a href="http://uds-web.blogspot.com" target="_top" rel="nofollow">http://uds-web.blogspot.com</a><br><br>--- On Wed, 11/25/09, jfaerman <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515357&i=0" target="_top" rel="nofollow">jfaerman@...</a>> wrote:
<br><br>From: jfaerman <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515357&i=1" target="_top" rel="nofollow">jfaerman@...</a>>
<br>Subject: Active Consumers on TCP x HTTP
<br>To: <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515357&i=2" target="_top" rel="nofollow">users@...</a>
<br>Date: Wednesday, November 25, 2009, 2:15 PM
<br><br><br>Hello,
<br><br>I need a queue with HTTP consumers.
<br>My problem is that when the JVM dies, the consumer remains active (i can see
<br>them active in the web console), thus preventing the new consumer from
<br>receiving messages.
<br>If i use TCP instead of HTTP, the dead consumers are inactivated correctly
<br>and everything works.
<br><br>Anyone been thru something like this or can suggest me a workaround?
<br><br>Tnx,
<br>Julio
<br>--
<br>View this message in context: <a href="http://old.nabble.com/Active-Consumers-on-TCP-x-HTTP-tp26513355p26513355.html" target="_top" rel="nofollow">http://old.nabble.com/Active-Consumers-on-TCP-x-HTTP-tp26513355p26513355.html</a><br>Sent from the ActiveMQ - User mailing list archive at Nabble.com.
<br><br><br><br><br> <p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>
tag:old.nabble.com,2006:post-26515339
[jira] Commented: (AMQNET-213) selector not working anymore
2009-11-25T08:01:52Z
2009-11-25T08:01:52Z
JIRA jira+amqnet@apache.org
<br> [ <a href="https://issues.apache.org/activemq/browse/AMQNET-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56104#action_56104" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56104#action_56104</a> ]
<br><br>Jim Gomes commented on AMQNET-213:
<br>----------------------------------
<br><br>This new behavior of needing to call connection.Start() caused me some trouble, too. I spent about a day or so tracking down what was wrong. Code that was working, suddenly stopped working. I think we need to clearly call out this behavior in the release notes for 1.2.0.
<br><div class='shrinkable-quote'><br>> selector not working anymore
<br>> ----------------------------
<br>>
<br>> Key: AMQNET-213
<br>> URL: <a href="https://issues.apache.org/activemq/browse/AMQNET-213" target="_top" rel="nofollow">https://issues.apache.org/activemq/browse/AMQNET-213</a><br>> Project: ActiveMQ .Net
<br>> Issue Type: Bug
<br>> Components: ActiveMQ
<br>> Affects Versions: 1.2.0
<br>> Reporter: Palm Kevin
<br>> Assignee: Jim Gomes
<br>>
<br>> When I try to commit a message (which connection and session already has been closed), then previously I executed this code:
<br>> {quote}
<br>> Public Sub Commit(ByVal message As IMessage)
<br>> Using connection As IConnection = Me.CreateIncomingConnection()
<br>> Using session As ISession = connection.CreateSession(AcknowledgementMode.AutoAcknowledge)
<br>> Dim consumer = session.CreateConsumer(message.NMSDestination, "NMSMessageID='" + message.NMSMessageId + "'")
<br>> Dim fetchedMessage = consumer.Receive(TimeSpan.FromMilliseconds(100))
<br>> If fetchedMessage Is Nothing Then _
<br>> Throw New Exception("Unable to commit message: cannot find message with id '" + message.NMSMessageId + "'")
<br>> consumer.Close()
<br>> End Using
<br>> End Using
<br>> End Sub
<br>> {quote}
<br>> Now, my code always throws the exception because the searched message cannot be found!
<br>> This code is *working with release 1.1.0*. but it *doens't work with Trunk*
</div><br>--
<br>This message is automatically generated by JIRA.
<br>-
<br>You can reply to this email to add a comment to the issue online.
<br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---Dev-f2355.html" embed="fixTarget[2355]" target="_top" >ActiveMQ - Dev</a></p>
tag:old.nabble.com,2006:post-26515320
Re: URI for Queue
2009-11-25T08:01:16Z
2009-11-25T08:01:16Z
Uday Subbarayan-3
Hi Dejan,
<br> This is also NOT working.(getting 404 resource not found) I am NOT using a servlet as a client. It's a POJO as a client to MQ.
<br><br>I am still trying to find the URI for the Queue!
<br><br>Thanks,
<br>Uday.
<br><br>-------------------------
<br><br>I do not blog but e-write:
<br><br><a href="http://uds-web.blogspot.com" target="_top" rel="nofollow">http://uds-web.blogspot.com</a><br><br>--- On Wed, 11/25/09, Dejan Bosanac <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515320&i=0" target="_top" rel="nofollow">dejan@...</a>> wrote:
<br><br>From: Dejan Bosanac <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515320&i=1" target="_top" rel="nofollow">dejan@...</a>>
<br>Subject: Re: URI for Queue
<br>To: <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515320&i=2" target="_top" rel="nofollow">users@...</a>
<br>Date: Wednesday, November 25, 2009, 8:12 AM
<br><br>Hi Uday,
<br><br>it all depends how you configure your servlet. In the demo app, distributed
<br>with the ActiveMQ, it is configured to listen to "messages/*" path, so the
<br>full path to your queue would be
<br><br><a href="http://host:port/demo/messages/myqueue" target="_top" rel="nofollow">http://host:port/demo/messages/myqueue</a><br><br>Regarding security, you can secure it like any other web app. I suggest you
<br>take a look at webapp/demo/WEB-INF/web.xml and appropriate articles on the
<br>web on how to secure Java web apps.
<br><br>Cheers
<br>--
<br>Dejan Bosanac - <a href="http://twitter.com/dejanb" target="_top" rel="nofollow">http://twitter.com/dejanb</a><br><br>Open Source Integration - <a href="http://fusesource.com/" target="_top" rel="nofollow">http://fusesource.com/</a><br>ActiveMQ in Action - <a href="http://www.manning.com/snyder/" target="_top" rel="nofollow">http://www.manning.com/snyder/</a><br>Blog - <a href="http://www.nighttale.net" target="_top" rel="nofollow">http://www.nighttale.net</a><br><br><br>On Tue, Nov 24, 2009 at 4:09 PM, Uday Subbarayan
<br><<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515320&i=3" target="_top" rel="nofollow">uday.subbarayan@...</a>>wrote:
<br><div class='shrinkable-quote'><br>> Thanks for the pointers. I checked them. I got the answer for my [1]. So,
<br>> if my queue name is 'myqueue', then URL is going to be <a href="http://host:port/queue/myqueue" target="_top" rel="nofollow">http://host:port/queue/myqueue</a>,
<br>> right?
<br>>
<br>> I am still looking for credentials stuff...I couldn't able to find it.
<br>>
<br>> I don't want to use JMS. The reason is that I like to put a std. load
<br>> balancer between client & ActiveMQ. I like HTTP.
<br>>
<br>> Thanks,
<br>> Uday.
<br>>
<br>> -------------------------
<br>>
<br>> I do not blog but e-write:
<br>>
<br>> <a href="http://uds-web.blogspot.com" target="_top" rel="nofollow">http://uds-web.blogspot.com</a><br>>
<br>> --- On Tue, 11/24/09, Dejan Bosanac <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515320&i=4" target="_top" rel="nofollow">dejan@...</a>> wrote:
<br>>
<br>> From: Dejan Bosanac <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515320&i=5" target="_top" rel="nofollow">dejan@...</a>>
<br>> Subject: Re: URI for Queue
<br>> To: <a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515320&i=6" target="_top" rel="nofollow">users@...</a>
<br>> Date: Tuesday, November 24, 2009, 8:35 AM
<br>>
<br>> Hi,
<br>>
<br>> take a look at this article for more info:
<br>> <a href="http://activemq.apache.org/rest.html" target="_top" rel="nofollow">http://activemq.apache.org/rest.html</a><br>> and be sure to check web demos <a href="http://activemq.apache.org/web-samples.html" target="_top" rel="nofollow">http://activemq.apache.org/web-samples.html</a><br>>
<br>> BTW. If you're using Java you'll have much better messaging experience
<br>> using
<br>> JMS API.
<br>>
<br>> Cheers
<br>> --
<br>> Dejan Bosanac - <a href="http://twitter.com/dejanb" target="_top" rel="nofollow">http://twitter.com/dejanb</a><br>>
<br>> Open Source Integration - <a href="http://fusesource.com/" target="_top" rel="nofollow">http://fusesource.com/</a><br>> ActiveMQ in Action - <a href="http://www.manning.com/snyder/" target="_top" rel="nofollow">http://www.manning.com/snyder/</a><br>> Blog - <a href="http://www.nighttale.net" target="_top" rel="nofollow">http://www.nighttale.net</a><br>>
<br>>
<br>> On Tue, Nov 24, 2009 at 5:56 AM, Uday Subbarayan
<br>> <<a href="http://old.nabble.com/user/SendEmail.jtp?type=post&post=26515320&i=7" target="_top" rel="nofollow">uday.subbarayan@...</a>>wrote:
<br>>
<br>> > Hi,
<br>> > I have installed ActiveMQ 5.3 and created a test queue called
<br>> 'mytest'.
<br>> > I want to HTTP POST to this queue from my java application(J2SE) directly
<br>> > using java.net.httpurlconnection.
<br>> >
<br>> > My questions are,
<br>> > [1] What is the URL for this queue?
<br>> > [2] What is the credentials(if any) to POST to this queue?
<br>> >
<br>> > Thanks,
<br>> > Uday.
<br>> >
<br>> > -------------------------
<br>> >
<br>> > I do not blog but e-write:
<br>> >
<br>> > <a href="http://uds-web.blogspot.com" target="_top" rel="nofollow">http://uds-web.blogspot.com</a><br>> >
<br>> >
<br>> >
<br>>
<br>>
<br>>
<br>>
<br>>
</div><br><br><br><p>From forum: <a href="http://old.nabble.com/ActiveMQ---User-f2356.html" embed="fixTarget[2356]" target="_top" >ActiveMQ - User</a></p>