Adblock Plugin

[Jonathan Marten-3]

Dear all,

Is this the appropriate list to ask about or post patches for the
adblock plugin (currently in KDE4 extragear)?

I've found this plugin very useful for a long time, but feel that it
could do with some attention.  In particular, making it possible to
add more than one entry at a time from the "Blockable items" dialogue,
update the list of blocked items as filters are added there, and allow
blocking of iframe's.  I've already implemented these and find the
blocker a lot more usable, should I post the patch here before
committing?

There are some other adblock bugs that I'd like to address,
https://bugs.kde.org/show_bug.cgi?id=189563 (default button action in
the KCM) and https://bugs.kde.org/show_bug.cgi?id=150934 (show which
filters have caused an item to be blocked).  The second of these would
be extremely useful, and I've already prototyped a tooltip GUI for it,
but getting the matched filter information would need some additions
to KHTMLSettings which would need care to remain BC.

Regards,
  Jonathan

--
Jonathan Marten                         http://www.keelhaul.demon.co.uk
Twickenham, UK                          jjm2@...

[Marcus Harrison]

The usual practice is to attach patches here for review before having them
committed, so I would do that. If the patches work and don't break anything
else, it's usually just a case of the reviewing developer giving it a nod and
merging it into trunk.

On Tuesday 07 July 2009 12:46:48 Jonathan Marten wrote:

> Dear all,
>
> Is this the appropriate list to ask about or post patches for the
> adblock plugin (currently in KDE4 extragear)?
>
> I've found this plugin very useful for a long time, but feel that it
> could do with some attention.  In particular, making it possible to
> add more than one entry at a time from the "Blockable items" dialogue,
> update the list of blocked items as filters are added there, and allow
> blocking of iframe's.  I've already implemented these and find the
> blocker a lot more usable, should I post the patch here before
> committing?
>
> There are some other adblock bugs that I'd like to address,
> https://bugs.kde.org/show_bug.cgi?id=189563 (default button action in
> the KCM) and https://bugs.kde.org/show_bug.cgi?id=150934 (show which
> filters have caused an item to be blocked).  The second of these would
> be extremely useful, and I've already prototyped a tooltip GUI for it,
> but getting the matched filter information would need some additions
> to KHTMLSettings which would need care to remain BC.
>
> Regards,
>   Jonathan

--
Marcus Harrison. Juggler, unicycler, website designer, potential software
developer, author, book enthusiast, philosopher, quantum theorist, skate-
boarder, goth, cellist. I have no professions.

Am Dienstag, 7. Juli 2009 schrieb Jonathan Marten:
> Is this the appropriate list to ask about or post patches for the
> adblock plugin (currently in KDE4 extragear)?

Yes. Additionally you can try to ask the maintainers of the adblock-plugin for
review.
>
> I've found this plugin very useful for a long time, but feel that it
> could do with some attention.  In particular, making it possible to
> add more than one entry at a time from the "Blockable items" dialogue,
> update the list of blocked items as filters are added there, and allow
> blocking of iframe's.  I've already implemented these and find the
> blocker a lot more usable, should I post the patch here before
> committing?

Excellent. Just post the patch on this list and wait for comments. I'm not
involved in the adblock code so I can't give you clearance. But I'll try to
review the khtml-specific parts if time permits. If nobody objects within,
say, two weeks from today, commit anyways.

Be aware that after having committed, you take the responsibility to fix bugs
and regressions caused by your commits.
>
> There are some other adblock bugs that I'd like to address,
> https://bugs.kde.org/show_bug.cgi?id=189563 (default button action in
> the KCM) and https://bugs.kde.org/show_bug.cgi?id=150934 (show which
> filters have caused an item to be blocked).  The second of these would
> be extremely useful, and I've already prototyped a tooltip GUI for it,
> but getting the matched filter information would need some additions
> to KHTMLSettings which would need care to remain BC.

Yes, please go ahead! Any improvement to the adblock-plugin is wholeheartedly
welcome.

mfg
        Leo

[Jonathan Marten-3]

Thanks for your information Leo.  Replies below...

On Tuesday 07 July 2009 17:16:30 Leo Savernik wrote:
> Yes. Additionally you can try to ask the maintainers of the adblock-plugin
> for review.

I'm not sure who the maintainers of that module are;  there is no MAINTAINERS
file in the plugin directory or anywhere above in extragear, and there seem
to have be no commits other than porting for a long time.  But if there is a
maintainer registered, then of course I'll ask them.

> Excellent. Just post the patch on this list and wait for comments. I'm not
> involved in the adblock code so I can't give you clearance. But I'll try to
> review the khtml-specific parts if time permits.

I haven't implemented the khtml stuff yet, having only just started to
investigate it again - I'd looked at it some time ago but was unable to work
out a BC way.  Now I've spotted a way round, so there is no need to wait for
KDE5 :-)  Any changes to khtml would go via reviewboard and kde-core-devel
anyway.

> If nobody objects within,
> say, two weeks from today, commit anyways.
> Be aware that after having committed, you take the responsibility to fix
> bugs and regressions caused by your commits.

Unfortunately there is no escaping from svn blame :-(

> Yes, please go ahead! Any improvement to the adblock-plugin is
> wholeheartedly welcome.

I'll tidy up and post the patch here.  Many thanks!

Regards, Jonathan

--
Jonathan Marten                         http://www.keelhaul.demon.co.uk
Twickenham, UK                          jjm2@...