Addition of suspend quirks for Sony VGN-B1VP to hal-info database

[M. Vefa Bicakci]

Hello,

I have gotten my hands onto a Sony VGN-B1VP laptop, and I noticed that
while resuming from suspend to RAM, the backlight of the screen would
not be switched back on. (I am using Ubuntu 9.04 on this laptop.) After
reading

http://people.freedesktop.org/~hughsient/quirk/quirk-suspend-index.html

I found out that the laptop needs either s3_bios or both s3_bios AND s3_mode
quirks. (I tested these both in console and in X.) Since s3_mode does not
work by itself, I think adding only the s3_bios quirk would be appropriate.

In case it is relevant, this laptop has an Intel graphics card. Here's
the output from lspci:

=== 8< ===
00:02.0 VGA compatible controller: Intel Corporation 82852/855GM Integrated Graphics Device (rev 02)
=== >8 ===

Here's what lshal prints about this laptop:

=== 8< ===
system.hardware.primary_video.product = 13698  (0x3582)  (int)
system.hardware.primary_video.vendor = 32902  (0x8086)  (int)
system.hardware.product = 'VGN-B1VP(GB)'  (string)
system.hardware.serial = 'XXXXXXXX-XXXXXXX'  (string)
system.hardware.uuid = 'XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX'  (string)
system.hardware.vendor = 'Sony Corporation'  (string)
system.hardware.version = 'J000L04A'  (string)
=== >8 ===

Please note that there is a "(GB)" in the product name. Is it mandatory
to include this suffix in the entry for the quirk database? I thought
that the "(GB)" has to do with the country where the product would be
sold. (This laptop was purchased in Turkey though.)

I assumed that not including "(GB)" is okay, so here's a patch for the quirk:

=== 8< ===
diff --git a/fdi/information/10freedesktop/20-video-quirk-pm-sony.fdi b/fdi/information/10freedesktop/20-video-quirk-pm-sony.fdi
index 7e876a2..3022821 100644
--- a/fdi/information/10freedesktop/20-video-quirk-pm-sony.fdi
+++ b/fdi/information/10freedesktop/20-video-quirk-pm-sony.fdi
@@ -5,7 +5,7 @@
       <match key="system.hardware.product" string="VGN-FS115Z">
         <merge key="power_management.quirk.s3_mode" type="bool">true</merge>
       </match>
-      <match key="system.hardware.product" contains_outof="VGN-FS730;PCG-FX405;VGN-C2S_G;VGN-B1XP;VGN-FE21B;VGN-B100B">
+      <match key="system.hardware.product" contains_outof="VGN-FS730;PCG-FX405;VGN-C2S_G;VGN-B1XP;VGN-FE21B;VGN-B100B;VGN-B1VP">
         <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
       </match>
       <match key="system.hardware.product" string_outof="VGN-FS115B;VGN-C140G;VGN-TX3XP_L;VGN-T250P;VGN-AR31S;PCV-RX612;VGN-FS485B;VGN-SZ61XN_C;VGN-TZ37;VGN-TZ170N;VGN-FS920;VGN-C240E;PCG-FX601;VGN-SR11M">
=== >8 ===

Regards,

M. Vefa Bicakci

_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal

[Martin Pitt-4]

Hello,

M. Vefa Bicakci [2009-09-01 16:09 +0300]:
> I found out that the laptop needs either s3_bios or both s3_bios AND s3_mode
> quirks. (I tested these both in console and in X.) Since s3_mode does not
> work by itself, I think adding only the s3_bios quirk would be appropriate.

Thanks for the patch! Applied to trunk.

Martin
--
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
_______________________________________________
hal mailing list
hal@...
http://lists.freedesktop.org/mailman/listinfo/hal