|

»

»

Additional file type support... rWatcher's patch

View: New views

10 Messages — Rating Filter: Alert me

	Additional file type support... rWatcher's patch by Tim Almdal :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message I've created ticket 801 to track the implementation of this. Currently, I put it in RC1, but I'm hesitant to leave it there as, I'm not sure we should be adding a lot of new functionality as we are focusing on getting the initial release complete. Website: http://www.timalmdal.com ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]
	Re: Additional file type support... rWatcher's patch by Andy Staudacher-3 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message I haven't had the time to review it, but you should be aware of the security aspect related to hosting arbitrary file types, e.g. opening up XSS attack vectors. I don't think it's up for discussion, but -1 for blindly supporting more file types in the core product. Even more so for other reasons (we need to support it, the UI needs to support it, etc.). As for making it easier for modules to add support for another format: If the patch is reasonably small, it's probably fine. We should talk about security though. - Andy On Thu, Sep 24, 2009 at 8:17 AM, Tim Almdal <tnalmdal@...> wrote: I've created ticket 801 to track the implementation of this. Currently, I put it in RC1, but I'm hesitant to leave it there as, I'm not sure we should be adding a lot of new functionality as we are focusing on getting the initial release complete. Website: http://www.timalmdal.com ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ] ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]
	Re: Additional file type support... rWatcher's patch by Tim Almdal :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Thanks, Andy That was one of the reasons, I put it into a ticket to track it, so we can get these issues out in the open. I think its a good thing to make it easier for module developers to support other file types. Having said that, I would not want us to support additional file types within core and what we deliver. So my approach to this ticket would be to use rWatcher's patch as a starting point and build the API that allows extensions, with out compromising the basic Gallery3 core package. The actual implementation of various file types would be left to -contrib modules. ----- Original Message ----- From: Andy Staudacher <andy.st@...> Date: Thursday, September 24, 2009 8:47 am Subject: Re: [Gallery-devel] Additional file type support... rWatcher's patch To: Tim Almdal <tnalmdal@...> Cc: "gallery-devel@..." <gallery-devel@...> > I haven't had the time to review it, but you should be aware of > the security > aspect related to hosting arbitrary file types, e.g. opening up > XSS attack > vectors. > I don't think it's up for discussion, but -1 for blindly > supporting more > file types in the core product. Even more so for other reasons > (we need to > support it, the UI needs to support it, etc.). > > As for making it easier for modules to add support for another > format: If > the patch is reasonably small, it's probably fine. We should > talk about > security though. > > - Andy > > On Thu, Sep 24, 2009 at 8:17 AM, Tim Almdal > <tnalmdal@...> wrote: > > > I've created ticket 801 to track the implementation of > this. Currently, I > > put it in RC1, but I'm hesitant to leave it there as, I'm not > sure we should > > be adding a lot of new functionality as we are focusing on > getting the > > initial release complete. > > > > Website: http://www.timalmdal.com > > > > > > > > --------------------------------------------------------------- > --------------- > > Come build with us! The BlackBerry® Developer Conference > in SF, CA > > is the only developer event you need to attend this year. > Jumpstart your > > developing skills, take BlackBerry mobile applications to > market and stay > > ahead of the curve. Join us from November 9-12, 2009. > Register now! > > http://p.sf.net/sfu/devconf > > __[ g a l l e r y - d e v e l ]_________________________ > > > > [ list info/archive --> http://gallery.sf.net/lists.php ] > > [ gallery info/FAQ/download --> http://gallery.sf.net ] > > > Website: http://www.timalmdal.com ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]
	Re: Additional file type support... rWatcher's patch by Bharat Mediratta :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message In the long term I'm ok with supporting other file types. But I think that they are not central to the product mission. Gallery3 is a photo album and it's primary mission is to host photos and movies. Anything we host should be viewable in the web browser. It's relatively easy to add support for different file types in the system, but we specifically chose not to do that because we could not build a good UI around it, and trying to support generic object types breaks some of our UX abstractions. The code looks good. But I think that we should hold off until 3.1 or so to attempt doing this. -Bharat Tim Almdal wrote: > Thanks, Andy > > That was one of the reasons, I put it into a ticket to track it, so we > can get these issues out in the open. > > I think its a good thing to make it easier for module developers to > support other file types. Having said that, I would not want us to > support additional file types within core and what we deliver. > > So my approach to this ticket would be to use rWatcher's patch as a > starting point and build the API that allows extensions, with out > compromising the basic Gallery3 core package. > > The actual implementation of various file types would be left to > -contrib modules. > > ----- Original Message ----- > From: Andy Staudacher <andy.st@...> > Date: Thursday, September 24, 2009 8:47 am > Subject: Re: [Gallery-devel] Additional file type support... rWatcher's > patch > To: Tim Almdal <tnalmdal@...> > Cc: "gallery-devel@..." > <gallery-devel@...> > > > I haven't had the time to review it, but you should be aware of > > the security > > aspect related to hosting arbitrary file types, e.g. opening up > > XSS attack > > vectors. > > I don't think it's up for discussion, but -1 for blindly > > supporting more > > file types in the core product. Even more so for other reasons > > (we need to > > support it, the UI needs to support it, etc.). > > > > As for making it easier for modules to add support for another > > format: If > > the patch is reasonably small, it's probably fine. We should > > talk about > > security though. > > > > - Andy > > > > On Thu, Sep 24, 2009 at 8:17 AM, Tim Almdal > > <tnalmdal@...> wrote: > > > > > I've created ticket 801 to track the implementation of > > this. Currently, I > > > put it in RC1, but I'm hesitant to leave it there as, I'm not > > sure we should > > > be adding a lot of new functionality as we are focusing on > > getting the > > > initial release complete. > > > > > > Website: http://www.timalmdal.com > > > > > > > > > > > > --------------------------------------------------------------- > > --------------- > > > Come build with us! The BlackBerry® Developer Conference > > in SF, CA > > > is the only developer event you need to attend this year. > > Jumpstart your > > > developing skills, take BlackBerry mobile applications to > > market and stay > > > ahead of the curve. Join us from November 9-12, 2009. > > Register now! > > > http://p.sf.net/sfu/devconf > > > __[ g a l l e r y - d e v e l ]_________________________ > > > > > > [ list info/archive --> http://gallery.sf.net/lists.php ] > > > [ gallery info/FAQ/download --> http://gallery.sf.net ] > > > > > > > Website: http://www.timalmdal.com > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > > > ------------------------------------------------------------------------ > > __[ g a l l e r y - d e v e l ]_________________________ > > [ list info/archive --> http://gallery.sf.net/lists.php ] > [ gallery info/FAQ/download --> http://gallery.sf.net ] ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]
	Re: Additional file type support... rWatcher's patch by Donald Webster :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message I'd really like to be able to upload RAW files, or at least deal with them during import of G2 even if it means nuking the RAW and going with the JPG. I have a number of RAW files in my G2 and dealing with them moving to G3 isn't going to be fun. I don't mind if all you guys (or someone else) support is uploaded RAW gets converted to JPG with dcraw and stored. AIM: fryfrog WWW: http://www.fryfrog.com On Sun, Sep 27, 2009 at 12:31 PM, Bharat Mediratta <bharat@...> wrote: > > In the long term I'm ok with supporting other file types. But I think > that they are not central to the product mission. Gallery3 is a photo > album and it's primary mission is to host photos and movies. Anything > we host should be viewable in the web browser. It's relatively easy to > add support for different file types in the system, but we specifically > chose not to do that because we could not build a good UI around it, and > trying to support generic object types breaks some of our UX abstractions. > > The code looks good. But I think that we should hold off until 3.1 or > so to attempt doing this. > > -Bharat > > Tim Almdal wrote: >> Thanks, Andy >> >> That was one of the reasons, I put it into a ticket to track it, so we >> can get these issues out in the open. >> >> I think its a good thing to make it easier for module developers to >> support other file types. Having said that, I would not want us to >> support additional file types within core and what we deliver. >> >> So my approach to this ticket would be to use rWatcher's patch as a >> starting point and build the API that allows extensions, with out >> compromising the basic Gallery3 core package. >> >> The actual implementation of various file types would be left to >> -contrib modules. >> >> ----- Original Message ----- >> From: Andy Staudacher <andy.st@...> >> Date: Thursday, September 24, 2009 8:47 am >> Subject: Re: [Gallery-devel] Additional file type support... rWatcher's >> patch >> To: Tim Almdal <tnalmdal@...> >> Cc: "gallery-devel@..." >> <gallery-devel@...> >> >> > I haven't had the time to review it, but you should be aware of >> > the security >> > aspect related to hosting arbitrary file types, e.g. opening up >> > XSS attack >> > vectors. >> > I don't think it's up for discussion, but -1 for blindly >> > supporting more >> > file types in the core product. Even more so for other reasons >> > (we need to >> > support it, the UI needs to support it, etc.). >> > >> > As for making it easier for modules to add support for another >> > format: If >> > the patch is reasonably small, it's probably fine. We should >> > talk about >> > security though. >> > >> > - Andy >> > >> > On Thu, Sep 24, 2009 at 8:17 AM, Tim Almdal >> > <tnalmdal@...> wrote: >> > >> > > I've created ticket 801 to track the implementation of >> > this. Currently, I >> > > put it in RC1, but I'm hesitant to leave it there as, I'm not >> > sure we should >> > > be adding a lot of new functionality as we are focusing on >> > getting the >> > > initial release complete. >> > > >> > > Website: http://www.timalmdal.com >> > > >> > > >> > > >> > > --------------------------------------------------------------- >> > --------------- >> > > Come build with us! The BlackBerry® Developer Conference >> > in SF, CA >> > > is the only developer event you need to attend this year. >> > Jumpstart your >> > > developing skills, take BlackBerry mobile applications to >> > market and stay >> > > ahead of the curve. Join us from November 9-12, 2009. >> > Register now! >> > > http://p.sf.net/sfu/devconf >> > > __[ g a l l e r y - d e v e l ]_________________________ >> > > >> > > [ list info/archive --> http://gallery.sf.net/lists.php ] >> > > [ gallery info/FAQ/download --> http://gallery.sf.net ] >> > > >> > >> >> Website: http://www.timalmdal.com >> >> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------------ >> Come build with us! The BlackBerry® Developer Conference in SF, CA >> is the only developer event you need to attend this year. Jumpstart your >> developing skills, take BlackBerry mobile applications to market and stay >> ahead of the curve. Join us from November 9-12, 2009. Register now! >> http://p.sf.net/sfu/devconf >> >> >> ------------------------------------------------------------------------ >> >> __[ g a l l e r y - d e v e l ]_________________________ >> >> [ list info/archive --> http://gallery.sf.net/lists.php ] >> [ gallery info/FAQ/download --> http://gallery.sf.net ] > > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > __[ g a l l e r y - d e v e l ]_________________________ > > [ list info/archive --> http://gallery.sf.net/lists.php ] > [ gallery info/FAQ/download --> http://gallery.sf.net ] > ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]
	Re: Additional file type support... rWatcher's patch by Bharat Mediratta :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Donald Webster wrote: > I'd really like to be able to upload RAW files, or at least deal with > them during import of G2 even if it means nuking the RAW and going > with the JPG. I have a number of RAW files in my G2 and dealing with > them moving to G3 isn't going to be fun. I don't mind if all you guys > (or someone else) support is uploaded RAW gets converted to JPG with > dcraw and stored. My tentative plan here was to have a raw module which uses dcraw to convert the photo at upload time, then discards the RAW and keeps a JPEG for the rest of the operations. We can add an event into the g2 import flow which allows the module to trigger at that time also. Undoubtedly this will make some folks unhappy, but what can ya do. ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]
	Re: Additional file type support... rWatcher's patch by Donald Webster :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message I heartily approve of your tentative plan and humbly suggest we also tentatively plan to goto the data center soon :) AIM: fryfrog WWW: http://www.fryfrog.com On Mon, Sep 28, 2009 at 11:02 AM, Bharat Mediratta <bharat@...> wrote: > Donald Webster wrote: >> >> I'd really like to be able to upload RAW files, or at least deal with >> them during import of G2 even if it means nuking the RAW and going >> with the JPG. I have a number of RAW files in my G2 and dealing with >> them moving to G3 isn't going to be fun. I don't mind if all you guys >> (or someone else) support is uploaded RAW gets converted to JPG with >> dcraw and stored. > > My tentative plan here was to have a raw module which uses dcraw to convert > the photo at upload time, then discards the RAW and keeps a JPEG for the > rest of the operations. > > We can add an event into the g2 import flow which allows the module to > trigger at that time also. Undoubtedly this will make some folks unhappy, > but what can ya do. > ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]
	Re: Additional file type support... rWatcher's patch by floridave :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Then could not the "trigger" be used by a 3rd party module to save the original, much like the 'keep original' module does? http://codex.gallery2.org/Gallery3:Modules:keeporiginal by rWatcher as well. Dave Dave At 12:02 PM 9/28/2009, Bharat Mediratta wrote: >Donald Webster wrote: > > I'd really like to be able to upload RAW files, or at least deal with > > them during import of G2 even if it means nuking the RAW and going > > with the JPG. I have a number of RAW files in my G2 and dealing with > > them moving to G3 isn't going to be fun. I don't mind if all you guys > > (or someone else) support is uploaded RAW gets converted to JPG with > > dcraw and stored. > >My tentative plan here was to have a raw module which uses dcraw to >convert the photo at upload time, then discards the RAW and keeps a JPEG >for the rest of the operations. > >We can add an event into the g2 import flow which allows the module to >trigger at that time also. Undoubtedly this will make some folks >unhappy, but what can ya do. > >------------------------------------------------------------------------------ >Come build with us! The BlackBerry® Developer Conference in SF, CA >is the only developer event you need to attend this year. Jumpstart your >developing skills, take BlackBerry mobile applications to market and stay >ahead of the curve. Join us from November 9-12, 2009. Register now! >http://p.sf.net/sfu/devconf >__[ g a l l e r y - d e v e l ]_________________________ > >[ list info/archive --> http://gallery.sf.net/lists.php ] >[ gallery info/FAQ/download --> http://gallery.sf.net ] ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]
	Re: Additional file type support... rWatcher's patch by Bharat Mediratta :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Donald Webster wrote: > I heartily approve of your tentative plan and humbly suggest we also > tentatively plan to goto the data center soon :) Do we need to go to the data center now that we've figured out that it's a firmware issue? Did WD ever get back to you on getting drives w/ the new firmware? ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]
	Re: Additional file type support... rWatcher's patch by Bharat Mediratta :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Dave Moore wrote: > Then could not the "trigger" be used by a 3rd party module to save > the original, much like the 'keep original' module does? > http://codex.gallery2.org/Gallery3:Modules:keeporiginal by rWatcher as well. Probably, but it depends on how we implement it. ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]