Akismet Plugin Changed?

[Michael Clark-14]

I am in the process of updating WordPress to 2.8.5 and noticed that
the akismet.php in the wordpress.tar.gz has changed, but the version
number is still 2.2.6. Under WP 2.8.4, there are 1,108 lines. In WP
2.8.5 there are 1,118 lines. A diff shows:

403,409d402
< // filter handler used to return a spam result to pre_comment_approved
< function akismet_result_spam( $approved ) {
< // bump the counter here instead of when the filter is added
to reduce the possibility of overcounting
< update_option( 'akismet_spam_count',
get_option('akismet_spam_count') + 1 );
< return 'spam';
< }
<
433,434c426,427
< // akismet_spam_count will be incremented later by
akismet_result_spam()
< add_filter('pre_comment_approved', 'akismet_result_spam');
---
>   add_filter('pre_comment_approved',
>create_function('$a', 'return \'spam\';'));
>   update_option( 'akismet_spam_count',
>get_option('akismet_spam_count') + 1 );
442,445c435,436
<
< if ( $post->post_type == 'post' && $diff > 30 &&
get_option( 'akismet_discard_month' ) == 'true' ) {
< // akismet_result_spam() won't be called so
bump the counter here
< update_option( 'akismet_spam_count',
get_option('akismet_spam_count') + 1 );
---
>
>   if ( $post->post_type == 'post' && $diff > 30 &&
>get_option( 'akismet_discard_month' ) == 'true' )
447d437
< }

The MD5 hash of the wp284 is:
e6d80085b5064047b7fb85b19cb9aa78  wp-content/plugins/akismet/akismet.php

And of the "new" version is:
456e43efa8df773bc6ed625f28f2a303  wp-content/plugins/akismet/akismet.php


Should the Akismet version be changed, assuming this is a valid
update to akismet.php? Mike


--

Michael Clark
http://www.PlanetMike.com

Listen to Christmas music 24 hours a day 7 days a week:
http://www.ChristmasMusic247.com

"Injustice anywhere is a threat to justice everywhere."
  - Martin Luther King Jr.
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

[Otto-19]

I believe that the release version of WordPress is connected to the
trunk version of Akismet. So whenever WordPress gets a new release
built, the latest version of Akismet is included, whether the version
number gets bumped or not.

The log for Akismet [1] shows that there's only been 3 or 4 changes in
the last 3 months. Probably not serious enough changes to warrant
releasing a new version number yet.

1. http://plugins.trac.wordpress.org/log/akismet/trunk

-Otto



On Wed, Oct 21, 2009 at 6:12 AM, Michael Clark
<dc153464a11bcf5aeb18180db28017fb.wp-hackers@...> wrote:

> I am in the process of updating WordPress to 2.8.5 and noticed that the
> akismet.php in the wordpress.tar.gz has changed, but the version number is
> still 2.2.6. Under WP 2.8.4, there are 1,108 lines. In WP 2.8.5 there are
> 1,118 lines. A diff shows:
>
> 403,409d402
> < // filter handler used to return a spam result to pre_comment_approved
> < function akismet_result_spam( $approved ) {
> <       // bump the counter here instead of when the filter is added to
> reduce the possibility of overcounting
> <       update_option( 'akismet_spam_count',
> get_option('akismet_spam_count') + 1 );
> <       return 'spam';
> < }
> <
> 433,434c426,427
> <               // akismet_spam_count will be incremented later by
> akismet_result_spam()
> <               add_filter('pre_comment_approved', 'akismet_result_spam');
> ---
>>
>>                add_filter('pre_comment_approved', create_function('$a',
>> 'return \'spam\';'));
>>                update_option( 'akismet_spam_count',
>> get_option('akismet_spam_count') + 1 );
>
> 442,445c435,436
> <
> <               if ( $post->post_type == 'post' && $diff > 30 && get_option(
> 'akismet_discard_month' ) == 'true' ) {
> <                       // akismet_result_spam() won't be called so bump the
> counter here
> <                       update_option( 'akismet_spam_count',
> get_option('akismet_spam_count') + 1 );
> ---
>>
>>                if ( $post->post_type == 'post' && $diff > 30 &&
>> get_option( 'akismet_discard_month' ) == 'true' )
>
> 447d437
> <               }
>
> The MD5 hash of the wp284 is:
> e6d80085b5064047b7fb85b19cb9aa78  wp-content/plugins/akismet/akismet.php
>
> And of the "new" version is:
> 456e43efa8df773bc6ed625f28f2a303  wp-content/plugins/akismet/akismet.php
>
>
> Should the Akismet version be changed, assuming this is a valid update to
> akismet.php? Mike
>
>
> --
>
> Michael Clark
> http://www.PlanetMike.com
>
> Listen to Christmas music 24 hours a day 7 days a week:
> http://www.ChristmasMusic247.com
>
> "Injustice anywhere is a threat to justice everywhere."
>  - Martin Luther King Jr.
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers
>

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers