Another ES5 harness bug

[Jeff Walden-6]

http://es5conform.codeplex.com/sourcecontrol/changeset/view/55693?projectName=ES5conform#816017

A number of tests include comments noting that the test function must be executed such that this is the global object.  As the harness is currently implemented, this isn't the case -- this is the test harness object itself.  This breaks a number of tests, of which the example following this email is representative.

Here's a patch to address this problem in the harness and to fix a few tests (only the ones I was immediately examining) to work correctly with it:

http://web.mit.edu/jwalden/www/es5-harness.diff

What needs to happen for this to be fixed upstream?

Jeff

--

Test 15.2.3.3-4-10

Description

Object.getOwnPropertyDescriptor returns data desc for functions on built-ins (Global.decodeURIComponent)

Testcase

function testcase() {
     var desc = Object.getOwnPropertyDescriptor(this, "decodeURIComponent");
     if (desc.value === this.decodeURIComponent &&
         desc.writable === true &&
         desc.enumerable === false && desc.configurable === true) {
         return true;
     }
}

Precondition

function prereq() {
     return fnExists(Object.getOwnPropertyDescriptor);
}

Path

../TestCases/chapter15/15.2/15.2.3/15.2.3.3/15.2.3.3-4-10.js
_______________________________________________
es-discuss mailing list
es-discuss@...
https://mail.mozilla.org/listinfo/es-discuss

[Raphael Speyer-2]

I've submitted a bunch of issues [1] and patches [2] for the ES5conform suite, including ones that address that exact issue [3], [4]. I haven't seen any sign that anyone's looking at them though.

Raphael

[1] http://es5conform.codeplex.com/WorkItem/AdvancedList.aspx
[2] http://es5conform.codeplex.com/SourceControl/PatchList.aspx
[3] http://es5conform.codeplex.com/WorkItem/View.aspx?WorkItemId=23542
[4] http://es5conform.codeplex.com/Project/Download/FileDownload.aspx?DownloadId=75673

On Wed, Sep 9, 2009 at 08:40, Jeff Walden <jwalden%2Bes@...> wrote:

http://es5conform.codeplex.com/sourcecontrol/changeset/view/55693?projectName=ES5conform#816017

A number of tests include comments noting that the test function must be executed such that this is the global object.  As the harness is currently implemented, this isn't the case -- this is the test harness object itself.  This breaks a number of tests, of which the example following this email is representative.

Here's a patch to address this problem in the harness and to fix a few tests (only the ones I was immediately examining) to work correctly with it:

http://web.mit.edu/jwalden/www/es5-harness.diff

What needs to happen for this to be fixed upstream?

Jeff

--

Test 15.2.3.3-4-10

Description

Object.getOwnPropertyDescriptor returns data desc for functions on built-ins (Global.decodeURIComponent)

Testcase

function testcase() {
   var desc = Object.getOwnPropertyDescriptor(this, "decodeURIComponent");
   if (desc.value === this.decodeURIComponent &&
       desc.writable === true &&
       desc.enumerable === false && desc.configurable === true) {
       return true;
   }
}

Precondition

function prereq() {
   return fnExists(Object.getOwnPropertyDescriptor);
}

Path

../TestCases/chapter15/15.2/15.2.3/15.2.3.3/15.2.3.3-4-10.js
_______________________________________________
es-discuss mailing list
es-discuss@...
https://mail.mozilla.org/listinfo/es-discuss

_______________________________________________
es-discuss mailing list
es-discuss@...
https://mail.mozilla.org/listinfo/es-discuss

[Allen Wirfs-Brock-2]

Some parts of this message have been removed. Learn more about Nabble's security policy.

I just discovered these this afternoon and also discovered that I wasn’t getting automatic notification when such things were posted.  I’ve fixed the latter problem and will look at these.  As I’ve already replay to Jeff Walden I suggest we move specific discussion of this topic to the conformance suite project’s discussion forum  which I will now be monitoring.

 

Allen

 

From: es-discuss-bounces@... [mailto:es-discuss-bounces@...] On Behalf Of Raphael Speyer
Sent: Tuesday, September 08, 2009 7:46 PM
To: Jeff Walden
Cc: es-discuss@...
Subject: Re: Another ES5 harness bug

 

I've submitted a bunch of issues [1] and patches [2] for the ES5conform suite, including ones that address that exact issue [3], [4]. I haven't seen any sign that anyone's looking at them though.

Raphael

[1] http://es5conform.codeplex.com/WorkItem/AdvancedList.aspx
[2] http://es5conform.codeplex.com/SourceControl/PatchList.aspx
[3] http://es5conform.codeplex.com/WorkItem/View.aspx?WorkItemId=23542
[4] http://es5conform.codeplex.com/Project/Download/FileDownload.aspx?DownloadId=75673

On Wed, Sep 9, 2009 at 08:40, Jeff Walden <jwalden%2Bes@...> wrote:

http://es5conform.codeplex.com/sourcecontrol/changeset/view/55693?projectName=ES5conform#816017

A number of tests include comments noting that the test function must be executed such that this is the global object.  As the harness is currently implemented, this isn't the case -- this is the test harness object itself.  This breaks a number of tests, of which the example following this email is representative.

Here's a patch to address this problem in the harness and to fix a few tests (only the ones I was immediately examining) to work correctly with it:

http://web.mit.edu/jwalden/www/es5-harness.diff

What needs to happen for this to be fixed upstream?

Jeff

--

Test 15.2.3.3-4-10

Description

Object.getOwnPropertyDescriptor returns data desc for functions on built-ins (Global.decodeURIComponent)

Testcase

function testcase() {
   var desc = Object.getOwnPropertyDescriptor(this, "decodeURIComponent");
   if (desc.value === this.decodeURIComponent &&
       desc.writable === true &&
       desc.enumerable === false && desc.configurable === true) {
       return true;
   }
}

Precondition

function prereq() {
   return fnExists(Object.getOwnPropertyDescriptor);
}

Path

../TestCases/chapter15/15.2/15.2.3/15.2.3.3/15.2.3.3-4-10.js
_______________________________________________
es-discuss mailing list
es-discuss@...
https://mail.mozilla.org/listinfo/es-discuss

 

_______________________________________________
es-discuss mailing list
es-discuss@...
https://mail.mozilla.org/listinfo/es-discuss