ApplicationInitializedEvent feedback

[Martijn Faassen-2]

Hi there,

Souheil, thanks very much for working on ApplicationInitializedEvent. A
few comments:

I don't understand why this event isn't triggered by Grok itself. What
in your mind would be triggering this event? grokui.admin?

I think Grok should have an API for installing an application that
grokui.admin and other potential installation tools can use. The
implementation in Grok *should* send the ApplicationInitializedEvent.
Grok just shouldn't subscribe to this event itself.

Another point is that at least the reference documentation should be
updated to talk to this event. I think also the developer's notes.

Regards,

Martijn

_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev

[Souheil CHELFOUH]

Hello,

Up to now, Grok doesn't handle anything in the life cycle of an application.
It has handlers for the ObjectAddedEvent, nothing else.
The whole creation process, currently, is left to grokui.admin, which
triggers the ObjectCreatedEvent (the ObjectAddedEvent being fired by
the container, while the application is persisted.)

So yes, in my mind, the event was to be trigged by grokui.admin, as
it's the only tool that handles the creation process. I'm not sure how
we could implement the full process in zope itself. From the top of my
head, i could think of something doing :  def
create_application(factory, container, name): ...

For the documentation, yes, it will be done. i'm currently working on
grokui.{admin,base} and I thought I'd wait to use it to be sure that
there will be no other changes. I was also thinking of adding a
IApplicationUpdatedEvent to deal with the update of utilities/indexes.

The test I wrote for the init event could be used as doc, as it's
quite explicit and detailed. I could copy that with minor changes to
the dev doc.

2009/10/9 Martijn Faassen <faassen@...>:

> Hi there,
>
> Souheil, thanks very much for working on ApplicationInitializedEvent. A
> few comments:
>
> I don't understand why this event isn't triggered by Grok itself. What
> in your mind would be triggering this event? grokui.admin?
>
> I think Grok should have an API for installing an application that
> grokui.admin and other potential installation tools can use. The
> implementation in Grok *should* send the ApplicationInitializedEvent.
> Grok just shouldn't subscribe to this event itself.
>
> Another point is that at least the reference documentation should be
> updated to talk to this event. I think also the developer's notes.
>
> Regards,
>
> Martijn
>
> _______________________________________________
> Grok-dev mailing list
> Grok-dev@...
> https://mail.zope.org/mailman/listinfo/grok-dev
>

_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev

[Martijn Faassen-2]

Hey,

Souheil CHELFOUH wrote:
> Up to now, Grok doesn't handle anything in the life cycle of an application.
> It has handlers for the ObjectAddedEvent, nothing else.
> The whole creation process, currently, is left to grokui.admin, which
> triggers the ObjectCreatedEvent (the ObjectAddedEvent being fired by
> the container, while the application is persisted.)
>
> So yes, in my mind, the event was to be trigged by grokui.admin, as
> it's the only tool that handles the creation process. I'm not sure how
> we could implement the full process in zope itself.

Yes, but I think part of application creation should be a responsibility
moved from grokui.admin to Grok. Besides, Grok does do something about
application creation already - that is, it can set things up for a site.
That isn't *exactly* application creation related behavior, but it's
very very close.

> From the top of my
> head, i could think of something doing :  def
> create_application(factory, container, name): ...
>
> For the documentation, yes, it will be done. i'm currently working on
> grokui.{admin,base} and I thought I'd wait to use it to be sure that
> there will be no other changes. I was also thinking of adding a
> IApplicationUpdatedEvent to deal with the update of utilities/indexes.

> The test I wrote for the init event could be used as doc, as it's
> quite explicit and detailed. I could copy that with minor changes to
> the dev doc.

What about going about it all the following way:

* you proceed with your work in grokui.base and grokui.admin and think
about application creation

* then once you got something working in grokui.admin we give it a
review and see whether we can move it into Grok itself (something along
the lines of create_application indeed). This would then send the event,
of course. :)

* once that's done, we can update the docs, saying what the official way
is to create an app in Grok and what events are sent.

This way you're not slowed done with your work in grokui.admin, and we
learn a bit about what application installation should look like.

Regards,

Martijn

_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev

[Martijn Faassen-2]

Hey,

Another piece of feedback: this needs to be mentioned in the CHANGES.txt.

Regards,

Martijn

_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev

[Souheil CHELFOUH]

It's commited already :)

2009/10/9 Martijn Faassen <faassen@...>:

> Hey,
>
> Another piece of feedback: this needs to be mentioned in the CHANGES.txt.
>
> Regards,
>
> Martijn
>
> _______________________________________________
> Grok-dev mailing list
> Grok-dev@...
> https://mail.zope.org/mailman/listinfo/grok-dev
>

_______________________________________________
Grok-dev mailing list
Grok-dev@...
https://mail.zope.org/mailman/listinfo/grok-dev