Nabble - AspectJ - users

Re: A transaction question

2009-11-08T01:09:42Z

The code is as below. The Main class is the starting point. AbstracTransaction is the aspect to capture EntityManager instance, which will create transaction covering the method executed e.g. process().

It seems like the the advice of `obtainEntityManager(..)&&cflow(..)' is not executed because the terminal does not output related information.

Whilst reading the AspectJ in Action, the percflow indicates that per-control-flow will create a new instance. So I suppose the specified percflow(scope()) would only cause an aspect instance created (because in the Main class process() is only executed once), wouldn't it?

Thanks for your help.

I appreciate it.

package example;

public abstract aspect AbstractTransaction percflow(scope()){

private EntityManager manager;

protected abstract pointcut tx(); // concreated joint point specified in AccountTransaction.aj

protected pointcut obtainEntityManager(EntityManager manager): call(public void example.AccountDao.setEntityManager(EntityManager)) && args(manager) ;

protected pointcut scope(): tx() && !cflowbelow(tx());

Object around(): scope(){
System.out.println("===========> EntityManager:"+manager); // null
Object result = proceed();
return result;
}

void around(EntityManager manager): obtainEntityManager(manager) && cflow(tx()){
this.manager = manager;
System.out.println(">>>>>>>>>>>>>>> EntityManager:"+this.manager); // seems not run because console does not print anything related to this line.
proceed(manager);
}
}

// concrete class specifying the join point to be captured.
package example;

public aspect AccountTransaction extends AbstractTransaction{

protected pointcut tx(): execution(* example.Main.process());
}

// main class want to be monitored
package example;

import example.EntityManager;

public class Main{
private AccountDao dao;
public static void main(String args[]){
AccountDao d = new AccountDao();
d.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
Main m = new Main(d);
m.process();
m.print();
}

public Main(AccountDao dao){
this.dao = dao;
}

void process(){
User u = new User("1", "Smith");
u.setAddress("7 Unkown Road, London, U.K.");
dao.save(u);
}
void print(){
dao.list();
}
}

Simone Gianni-2 wrote:

Hi Neo,
it should work, if you don't find the manager there it could be because
two different instances of AbstractTransaction aspect are intercepting
the two methods. This happens if you declared your aspect with a
specific instantiation rule.

By default, aspects are singletons. That means that there will be only
one instance of AbstractTransaction in your application (well, in your
classloader). Since this is sometimes a limit, AspectJ supports
different instantiation systems, like perthis, pertarget, percflow
etc... If you use one of these construct, then a new instance of your
aspect will be created for each "this", each "target" etc.. in this
case, when you use this.manager inside your aspect, it could be null
cause it is actually a different instance.

Could you post the complete aspect declaration, so that we can see which
instantiation rule you are using?

Hope this helps,
Simone

neo anderson wrote:
> Thank you very much. Now I am able to obtain EntityManager whilst method
> setEntityManager get called.
>
> But a new question: how can I assign the captured variable e.g.
> EntityManager to the variable in an Aspect? For instance,
>
> ... aspect AbstractionTransaction ...{
> private EntityManager manager;
> void around(EntityManager manager): obtainEntityManager(manager) &&
> cflow(tx()){
> System.out.println("manager:"+manager); // manager instance is not null
> this.manager = manager; // but assign to the member of
> aspect seemingly does not work
>
> proceed(manager);
> }
>
> }
>
> My AbstractTransaction aspect contains a variable manager and I would like
> to assign when the setEntityManager get called. Because in the example of
> Aspectj in Action, the method intercepted will return Connection, which is
> different from the method I have. Is there any chance to assign the variable
> so that I can apply entitymanager to the pointcut when scope() is executed?
> Or what is the right way to do this?
>
> Object around(): scope(){
> System.out.println("===========> EntityManager:"+manager); // after
> assigned, it is still null
> Object result = proceed();
> return result;
> }
>
> Sorry if this question is too newbie. I search on the internet and read
> again the book Aspectj in Action, but seems there is no such explain.
>
> Thanks for patiently answer my question.
>
> I appreciate it.
>
>
>
>
> Andy Clement wrote:
>
>> The method you are intercepting (setEntityManager) has a void return
>> type, so your advice should too. The proceed() call you are using
>> will ensure your replacement is passed to the setEntityManager call.
>>
>> Andy
>>
>> 2009/11/4 neo anderson <javadeveloper999@yahoo.co.uk>:
>>
>>> Hi Mark & Andy. Thanks for your reply. I really appreciate your help.
>>>
>>> I change to use args, but now it thorws message:
>>>
>>> [error] incompatible return type applying to method-call(void
>>> example.AccountDao.setEntityManager(example.EntityManager))
>>>
>>> [error] incompatible return type applying to method-call(void
>>> example.AccountDao.setEntityManager(example.EntityManager))
>>> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>>>
>>> [warning] advice defined in example.AbstractTransaction has not been
>>> applied
>>> [Xlint:adviceDidNotMatch]
>>>
>>> I check the syntax and read the example in e.g.
>>> http://books.google.com.tw/books?id=AKuBlJGl7iUC&pg=PA54&lpg=PA54&dq=aspectj+call+args&source=bl&ots=58KGnyCZiN&sig=5gNdHoekFrDXJne3pVe6UO5tiYQ&hl=zh-TW&ei=kNbxSqTEBumgjAfdnp2WAQ&sa=X&oi=book_result&ct=result&resnum=6&ved=0CB0Q6AEwBQ#v=onepage&q=4-2%20capturing%20the%20parameter%20values%20passed%20on%20a%20method%20call&f=false
>>>
>>> The way to capture the EntityManager looks correct.
>>>
>>> public pointcut(EntityManager manager): call(*
>>> AccountDao.setEntityManager(EntityManger)) && args(manager);
>>>
>>> Is there any place I may go wrong? I test to move the .aj files and
>>> compile
>>> .java source. Everthing works fine. I am confused.
>>>
>>> I appreciate any suggestion.
>>>
>>> Thank you very much.
>>>
>>>
>>> Mark Cooke-6 wrote:
>>>
>>>> Hi,
>>>> It's been a while since I've used AspectJ in anger but as no-one else
>>>> has
>>>> replied yet...
>>>>
>>>> I'd say you probably want "args(manager)" instead of "target(manager)"
>>>> in
>>>> the obtainEntityManager pointcut.
>>>> The target of the call will be an AccountDAO, not an EntityManager.
>>>>
>>>> See
>>>> http://www.eclipse.org/aspectj/doc/released/progguide/semantics-joinPoints.html
>>>>
>>>> HTH!
>>>> Mark.
>>>>
>>>> --- On Wed, 4/11/09, neo anderson <javadeveloper999@yahoo.co.uk> wrote:
>>>>
>>>>
>>>>> From: neo anderson <javadeveloper999@yahoo.co.uk>
>>>>> Subject: [aspectj-users] A transaction question
>>>>> To: aspectj-users@eclipse.org
>>>>> Date: Wednesday, 4 November, 2009, 12:09
>>>>>
>>>>> I am learning how to modulize transaction using aspectj,
>>>>> but encounter a
>>>>> problem that EntityManager I try to capture is always null.
>>>>> The compiler
>>>>> issues message saying that the advice can not be applied.
>>>>> as below:
>>>>>
>>>>> ... advice defined in example.AbstractTransaction has not
>>>>> been applied
>>>>> [Xlint:adviceDidNotMatch]
>>>>>
>>>>> What should I change so that I can capture the
>>>>> EntityManager while it is
>>>>> created (whilst calling to
>>>>> AccountDao.setEntityManager(..))?
>>>>>
>>>>> Thanks for help.
>>>>>
>>>>> Main.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class Main{
>>>>> public static void main(String args[]){
>>>>> Main m = new Main();
>>>>> m.process();
>>>>> }
>>>>> void process(){
>>>>> AccountDao dao = new
>>>>> AccountDao();
>>>>>
>>>>> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>>>>> User u = new
>>>>> User("1", "Smith");
>>>>> u.setAddress("123
>>>>> Test Road, London.");
>>>>> dao.save(u);
>>>>>
>>>>>
>>>>> dao.list();
>>>>> }
>>>>> }
>>>>>
>>>>> AccountDao.java
>>>>>
>>>>> package example;
>>>>>
>>>>> import java.util.List;
>>>>> import java.util.ArrayList;
>>>>>
>>>>>
>>>>> public class AccountDao{
>>>>>
>>>>> private EntityManager manager;
>>>>>
>>>>> private static List<User> database
>>>>> = new ArrayList<User>();
>>>>>
>>>>> public void
>>>>> setEntityManager(EntityManager manager){
>>>>> this.manager =
>>>>> manager;
>>>>> }
>>>>>
>>>>> public void save(User user){
>>>>>
>>>>> database.add(user);
>>>>> }
>>>>>
>>>>> public void list(){
>>>>> for(User u :
>>>>> database){
>>>>>
>>>>> System.out.println(">>>[AccountDao.java]"+u);
>>>>>
>>>>> }
>>>>> }
>>>>> }
>>>>>
>>>>> User.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class User{
>>>>> private String id;
>>>>> private String name;
>>>>> private String address;
>>>>> public User(String id, String name){
>>>>> this.id = id;
>>>>> this.name = name;
>>>>> }
>>>>>
>>>>> public String getId(){
>>>>> return this.id;
>>>>> }
>>>>>
>>>>> public String getName(){
>>>>> return this.name;
>>>>> }
>>>>>
>>>>> public String getAddress(){
>>>>> return this.address;
>>>>> }
>>>>>
>>>>> public void setAddress(String address){
>>>>> this.address =
>>>>> address;
>>>>> }
>>>>>
>>>>> public String toString(){
>>>>> return "<User
>>>>> [id:"+id+"][name:"+name+"][address:"+address+"]>";
>>>>> }
>>>>> }
>>>>>
>>>>>
>>>>> PersistenceCreator.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class PersistenceCreator{
>>>>> private static EntityManagerFactory
>>>>> factory;
>>>>>
>>>>> public static EntityManagerFactory
>>>>> createEntityManagerFactory(){
>>>>> if(null == factory)
>>>>>
>>>>> factory = new EntityManagerFactory();
>>>>> return factory;
>>>>> }
>>>>> }
>>>>>
>>>>> EntityManagerFactory.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class EntityManagerFactory{
>>>>>
>>>>> private static EntityManager manager;
>>>>>
>>>>> public static EntityManager
>>>>> createEntityManager(){
>>>>> if(null == manager){
>>>>>
>>>>> manager = new EntityManager();
>>>>> }
>>>>> return manager;
>>>>> }
>>>>> }
>>>>>
>>>>> EntityManager.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class EntityManager{
>>>>> }
>>>>>
>>>>> AbstractTransaction.aj
>>>>>
>>>>> package example;
>>>>>
>>>>> public abstract aspect AbstractTransaction
>>>>> percflow(scope()){
>>>>>
>>>>> private EntityManager manager;
>>>>>
>>>>> protected abstract pointcut tx();
>>>>>
>>>>> protected pointcut
>>>>> obtainEntityManager(EntityManager manager): call(*
>>>>> example.AccountDao.setEntityManager(EntityManager))
>>>>> && target(manager);
>>>>>
>>>>> protected pointcut scope(): tx()
>>>>> && !cflowbelow(tx());
>>>>>
>>>>> Object around(): scope(){
>>>>>
>>>>> System.out.println("EntityManager:"+manager);// always null
>>>>>
>>>>> Object result =
>>>>> proceed();
>>>>> return result;
>>>>> }
>>>>>
>>>>> EntityManager around(EntityManager
>>>>> manager): obtainEntityManager(manager)
>>>>> && cflow(tx()){
>>>>> if(null == manager){
>>>>>
>>>>> manager = proceed(manager);
>>>>>
>>>>> }
>>>>>
>>>>> return manager;
>>>>> }
>>>>> }
>>>>>
>>>>> AccountTransaction.aj
>>>>>
>>>>> package example;
>>>>>
>>>>> public aspect AccountTransaction extends
>>>>> AbstractTransaction{
>>>>>
>>>>> protected pointcut tx(): execution(*
>>>>> example.Main.process());
>>>>> }
>>>>> --
>>>>> View this message in context:
>>>>> http://old.nabble.com/A-transaction-question-tp26195112p26195112.html
>>>>> Sent from the AspectJ - users mailing list archive at
>>>>> Nabble.com.
>>>>>
>>>>> _______________________________________________
>>>>> aspectj-users mailing list
>>>>> aspectj-users@eclipse.org
>>>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> aspectj-users mailing list
>>>> aspectj-users@eclipse.org
>>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>>
>>>>
>>>>
>>> --
>>> View this message in context:
>>> http://old.nabble.com/A-transaction-question-tp26195112p26203290.html
>>> Sent from the AspectJ - users mailing list archive at Nabble.com.
>>>
>>> _______________________________________________
>>> aspectj-users mailing list
>>> aspectj-users@eclipse.org
>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>
>>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@eclipse.org
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
>>
>>
>
>

--
Simone Gianni CEO Semeru s.r.l. Apache Committer
http://www.simonegianni.it/

_______________________________________________
aspectj-users mailing list
aspectj-users@eclipse.org
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: A transaction question

2009-11-06T03:27:28Z

Hi Neo,
it should work, if you don't find the manager there it could be because
two different instances of AbstractTransaction aspect are intercepting
the two methods. This happens if you declared your aspect with a
specific instantiation rule.

By default, aspects are singletons. That means that there will be only
one instance of AbstractTransaction in your application (well, in your
classloader). Since this is sometimes a limit, AspectJ supports
different instantiation systems, like perthis, pertarget, percflow
etc... If you use one of these construct, then a new instance of your
aspect will be created for each "this", each "target" etc.. in this
case, when you use this.manager inside your aspect, it could be null
cause it is actually a different instance.

Could you post the complete aspect declaration, so that we can see which
instantiation rule you are using?

Hope this helps,
Simone

neo anderson wrote:

> Thank you very much. Now I am able to obtain EntityManager whilst method
> setEntityManager get called.
>
> But a new question: how can I assign the captured variable e.g.
> EntityManager to the variable in an Aspect? For instance,
>
> ... aspect AbstractionTransaction ...{
> private EntityManager manager;
> void around(EntityManager manager): obtainEntityManager(manager) &&
> cflow(tx()){
> System.out.println("manager:"+manager); // manager instance is not null
> this.manager = manager; // but assign to the member of
> aspect seemingly does not work
>
> proceed(manager);
> }
>
> }
>
> My AbstractTransaction aspect contains a variable manager and I would like
> to assign when the setEntityManager get called. Because in the example of
> Aspectj in Action, the method intercepted will return Connection, which is
> different from the method I have. Is there any chance to assign the variable
> so that I can apply entitymanager to the pointcut when scope() is executed?
> Or what is the right way to do this?
>
> Object around(): scope(){
> System.out.println("===========> EntityManager:"+manager); // after
> assigned, it is still null
> Object result = proceed();
> return result;
> }
>
> Sorry if this question is too newbie. I search on the internet and read
> again the book Aspectj in Action, but seems there is no such explain.
>
> Thanks for patiently answer my question.
>
> I appreciate it.
>
>
>
>
> Andy Clement wrote:
>
>> The method you are intercepting (setEntityManager) has a void return
>> type, so your advice should too. The proceed() call you are using
>> will ensure your replacement is passed to the setEntityManager call.
>>
>> Andy
>>
>> 2009/11/4 neo anderson <javadeveloper999@...>:
>>
>>> Hi Mark & Andy. Thanks for your reply. I really appreciate your help.
>>>
>>> I change to use args, but now it thorws message:
>>>
>>> [error] incompatible return type applying to method-call(void
>>> example.AccountDao.setEntityManager(example.EntityManager))
>>>
>>> [error] incompatible return type applying to method-call(void
>>> example.AccountDao.setEntityManager(example.EntityManager))
>>> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>>>
>>> [warning] advice defined in example.AbstractTransaction has not been
>>> applied
>>> [Xlint:adviceDidNotMatch]
>>>
>>> I check the syntax and read the example in e.g.
>>> http://books.google.com.tw/books?id=AKuBlJGl7iUC&pg=PA54&lpg=PA54&dq=aspectj+call+args&source=bl&ots=58KGnyCZiN&sig=5gNdHoekFrDXJne3pVe6UO5tiYQ&hl=zh-TW&ei=kNbxSqTEBumgjAfdnp2WAQ&sa=X&oi=book_result&ct=result&resnum=6&ved=0CB0Q6AEwBQ#v=onepage&q=4-2%20capturing%20the%20parameter%20values%20passed%20on%20a%20method%20call&f=false
>>>
>>> The way to capture the EntityManager looks correct.
>>>
>>> public pointcut(EntityManager manager): call(*
>>> AccountDao.setEntityManager(EntityManger)) && args(manager);
>>>
>>> Is there any place I may go wrong? I test to move the .aj files and
>>> compile
>>> .java source. Everthing works fine. I am confused.
>>>
>>> I appreciate any suggestion.
>>>
>>> Thank you very much.
>>>
>>>
>>> Mark Cooke-6 wrote:
>>>
>>>> Hi,
>>>> It's been a while since I've used AspectJ in anger but as no-one else
>>>> has
>>>> replied yet...
>>>>
>>>> I'd say you probably want "args(manager)" instead of "target(manager)"
>>>> in
>>>> the obtainEntityManager pointcut.
>>>> The target of the call will be an AccountDAO, not an EntityManager.
>>>>
>>>> See
>>>> http://www.eclipse.org/aspectj/doc/released/progguide/semantics-joinPoints.html
>>>>
>>>> HTH!
>>>> Mark.
>>>>
>>>> --- On Wed, 4/11/09, neo anderson <javadeveloper999@...> wrote:
>>>>
>>>>
>>>>> From: neo anderson <javadeveloper999@...>
>>>>> Subject: [aspectj-users] A transaction question
>>>>> To: aspectj-users@...
>>>>> Date: Wednesday, 4 November, 2009, 12:09
>>>>>
>>>>> I am learning how to modulize transaction using aspectj,
>>>>> but encounter a
>>>>> problem that EntityManager I try to capture is always null.
>>>>> The compiler
>>>>> issues message saying that the advice can not be applied.
>>>>> as below:
>>>>>
>>>>> ... advice defined in example.AbstractTransaction has not
>>>>> been applied
>>>>> [Xlint:adviceDidNotMatch]
>>>>>
>>>>> What should I change so that I can capture the
>>>>> EntityManager while it is
>>>>> created (whilst calling to
>>>>> AccountDao.setEntityManager(..))?
>>>>>
>>>>> Thanks for help.
>>>>>
>>>>> Main.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class Main{
>>>>> public static void main(String args[]){
>>>>> Main m = new Main();
>>>>> m.process();
>>>>> }
>>>>> void process(){
>>>>> AccountDao dao = new
>>>>> AccountDao();
>>>>>
>>>>> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>>>>> User u = new
>>>>> User("1", "Smith");
>>>>> u.setAddress("123
>>>>> Test Road, London.");
>>>>> dao.save(u);
>>>>>
>>>>>
>>>>> dao.list();
>>>>> }
>>>>> }
>>>>>
>>>>> AccountDao.java
>>>>>
>>>>> package example;
>>>>>
>>>>> import java.util.List;
>>>>> import java.util.ArrayList;
>>>>>
>>>>>
>>>>> public class AccountDao{
>>>>>
>>>>> private EntityManager manager;
>>>>>
>>>>> private static List<User> database
>>>>> = new ArrayList<User>();
>>>>>
>>>>> public void
>>>>> setEntityManager(EntityManager manager){
>>>>> this.manager =
>>>>> manager;
>>>>> }
>>>>>
>>>>> public void save(User user){
>>>>>
>>>>> database.add(user);
>>>>> }
>>>>>
>>>>> public void list(){
>>>>> for(User u :
>>>>> database){
>>>>>
>>>>> System.out.println(">>>[AccountDao.java]"+u);
>>>>>
>>>>> }
>>>>> }
>>>>> }
>>>>>
>>>>> User.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class User{
>>>>> private String id;
>>>>> private String name;
>>>>> private String address;
>>>>> public User(String id, String name){
>>>>> this.id = id;
>>>>> this.name = name;
>>>>> }
>>>>>
>>>>> public String getId(){
>>>>> return this.id;
>>>>> }
>>>>>
>>>>> public String getName(){
>>>>> return this.name;
>>>>> }
>>>>>
>>>>> public String getAddress(){
>>>>> return this.address;
>>>>> }
>>>>>
>>>>> public void setAddress(String address){
>>>>> this.address =
>>>>> address;
>>>>> }
>>>>>
>>>>> public String toString(){
>>>>> return "<User
>>>>> [id:"+id+"][name:"+name+"][address:"+address+"]>";
>>>>> }
>>>>> }
>>>>>
>>>>>
>>>>> PersistenceCreator.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class PersistenceCreator{
>>>>> private static EntityManagerFactory
>>>>> factory;
>>>>>
>>>>> public static EntityManagerFactory
>>>>> createEntityManagerFactory(){
>>>>> if(null == factory)
>>>>>
>>>>> factory = new EntityManagerFactory();
>>>>> return factory;
>>>>> }
>>>>> }
>>>>>
>>>>> EntityManagerFactory.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class EntityManagerFactory{
>>>>>
>>>>> private static EntityManager manager;
>>>>>
>>>>> public static EntityManager
>>>>> createEntityManager(){
>>>>> if(null == manager){
>>>>>
>>>>> manager = new EntityManager();
>>>>> }
>>>>> return manager;
>>>>> }
>>>>> }
>>>>>
>>>>> EntityManager.java
>>>>>
>>>>> package example;
>>>>>
>>>>> public class EntityManager{
>>>>> }
>>>>>
>>>>> AbstractTransaction.aj
>>>>>
>>>>> package example;
>>>>>
>>>>> public abstract aspect AbstractTransaction
>>>>> percflow(scope()){
>>>>>
>>>>> private EntityManager manager;
>>>>>
>>>>> protected abstract pointcut tx();
>>>>>
>>>>> protected pointcut
>>>>> obtainEntityManager(EntityManager manager): call(*
>>>>> example.AccountDao.setEntityManager(EntityManager))
>>>>> && target(manager);
>>>>>
>>>>> protected pointcut scope(): tx()
>>>>> && !cflowbelow(tx());
>>>>>
>>>>> Object around(): scope(){
>>>>>
>>>>> System.out.println("EntityManager:"+manager);// always null
>>>>>
>>>>> Object result =
>>>>> proceed();
>>>>> return result;
>>>>> }
>>>>>
>>>>> EntityManager around(EntityManager
>>>>> manager): obtainEntityManager(manager)
>>>>> && cflow(tx()){
>>>>> if(null == manager){
>>>>>
>>>>> manager = proceed(manager);
>>>>>
>>>>> }
>>>>>
>>>>> return manager;
>>>>> }
>>>>> }
>>>>>
>>>>> AccountTransaction.aj
>>>>>
>>>>> package example;
>>>>>
>>>>> public aspect AccountTransaction extends
>>>>> AbstractTransaction{
>>>>>
>>>>> protected pointcut tx(): execution(*
>>>>> example.Main.process());
>>>>> }
>>>>> --
>>>>> View this message in context:
>>>>> http://old.nabble.com/A-transaction-question-tp26195112p26195112.html
>>>>> Sent from the AspectJ - users mailing list archive at
>>>>> Nabble.com.
>>>>>
>>>>> _______________________________________________
>>>>> aspectj-users mailing list
>>>>> aspectj-users@...
>>>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> aspectj-users mailing list
>>>> aspectj-users@...
>>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>>
>>>>
>>>>
>>> --
>>> View this message in context:
>>> http://old.nabble.com/A-transaction-question-tp26195112p26203290.html
>>> Sent from the AspectJ - users mailing list archive at Nabble.com.
>>>
>>> _______________________________________________
>>> aspectj-users mailing list
>>> aspectj-users@...
>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>
>>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
>>
>>
>
>

--
Simone Gianni CEO Semeru s.r.l. Apache Committer
http://www.simonegianni.it/

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Newbie question about paramter exposure.

2009-11-06T03:16:12Z

I just found out that in Aspectj in Action, it explains the passing context from a join point to advice is as below:

The interpretation of context whilst using advice looks like

Object advice(String command): p(command){
...
}

1.) command passing in to pointcut p()
2.) the execution object command is passed to advice(String command)
3.) which then passes to the body {...}.

Just want to practise to see if I understand it correctly.

The point of interest

A.execute("ls -alh")

is reached.

That point of interest is specified in

execution(* example.A.execute(String)) && args(command);

So the parameter value being passed in (i.e. ls -alh) is bound to the command
parameter in the pointcut p(String command). Thus the value of `command' (in pointcut p(String command)) now can be replaced with "ls -alh" (whilst method's executing).

And because an advice around(String command) is attached to the pointcut p(String command), when the method execution join point occurs, it becomes

Object advice(String command): p("ls -alh"){
...
}

And then when advice is invoked

Object advice("ls -alh"): p("ls -alh"){
...
}

Am I correct to the above explanation?

I discover my problem is because after reading the book e.g. Aspectj in Action, I still do not understand very well about the flow that goes between joint points, pointcuts and advices. In a traditional method call, I understand (maybe not precisely) that in the class Main, when executing `new A().execute("ls -alh")', the value `ls -alh' will pass in to the execute() method of the class A; therefore, in the execute() function of the class A, the variable `command' can be replaced using the value `ls -alh' and gets printed using System.out.println() method in execution.

But concept of aop looks like not the same way; so it makes me confused.

Please correct me if anything goes wrong.

Thanks for your help.

I really appreciate it.

Andy Clement wrote:

Hi,

Your description is ok:

> therefore, execution of the method `new A().execute("ls -alh")' triggers the around() advice, which passes in a value `ls -lah' (as the variable command). That value `ls -alh' passes to
> pointcut p(), which also takes a variable named command. And that pointcut p() tries to capture the execution of a method specified as `* example.A.execute(String)' and its argument
> must be `command.'

let me write it another way to see if that helps. Think about the
events that occur when the program runs:
Main.main() starts executing
it calls the Main() constructor
it calls the process() method
Main.process() method starts executing
it calls the A() constructor
it calls the execute("ls -alh") method
A.execute("ls -alh") method starts executing *
it accesses the field System.out
it calls the method println()

all those are the joinpoints in your program flow and your pointcut is
choosing the one you are interested in. You have used 'execution(*
execute(String))' which has selected the one I've marked * above. In
your pointcut you've also said you are interested in the parameter
when the method executes, so you have used 'args' to bind it - so when
the program runs and your point of interest is reached, the parameter
value being passed in is bound to the command parameter in your
pointcut. You have chosen to have around() advice attached to that
pointcut so when the method-execution join point occurs, your around
advice is invoked with the bound parameter value. Unlike a regular
method call, the weaving infrastructure is looking after binding the
pointcut/advice parameter for you.

Andy

2009/10/27 Neo Anderson <javadeveloper999@yahoo.co.uk>:
> Hi
>
> I am newbie to aspectj and have a question regarding to the usage of parameters exposed in the pointcut, advice, etc. Following is the source code:
>
> package aspectj;
>
> public aspect P{
> public pointcut p(String command): execution(* example.A.execute(String)) && args(command);
>
> Object around(String command): p(command){
> System.out.println("around() advice : command:"+command);
> return proceed(command);
> }
> }
>
> package example;
>
> public class A{
> public void execute(String c){
> System.out.println("[A.java][execute] command:"+c);
> }
> }
>
> package example;
>
> public class Main{
>
> public static void main(String args[]){
> new Main().process();
> }
>
> void process(){
> new A().execute("ls -alh");
> }
>
> }
>
> The output :
>
> around() advice : command:ls -alh
> [A.java][execute] command:ls -alh
>
>
> Thought I can get the code worked, I do not know how to explain the parameter exposed in the pointcut (e.g. p(String command)) and advice (e.g. around(String command)).
>
> What I understand is that
>
> Since the execution flow is
>
> new A().execute("ls -lah") [Main.java] -> public void execute(String c) [A.java]
>
> therefore, execution of the method `new A().execute("ls -alh")' triggers the around() advice, which passes in a value `ls -lah' (as the variable command). That value `ls -alh' passes to pointcut p(), which also takes a variable named command. And that pointcut p() tries to capture the execution of a method specified as `* example.A.execute(String)' and its argument must be `command.'
>
> Is this explanation correct?
>
> I found out there is something not right for me, but I am not aware the part that I do not understand.
>
> I appreciate any advice.
>
> Thank you very much.
>
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@eclipse.org
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
_______________________________________________
aspectj-users mailing list
aspectj-users@eclipse.org
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: A transaction question

2009-11-06T02:21:24Z

Thank you very much. Now I am able to obtain EntityManager whilst method setEntityManager get called.

But a new question: how can I assign the captured variable e.g. EntityManager to the variable in an Aspect? For instance,

... aspect AbstractionTransaction ...{
private EntityManager manager;
void around(EntityManager manager): obtainEntityManager(manager) && cflow(tx()){
System.out.println("manager:"+manager); // manager instance is not null
this.manager = manager; // but assign to the member of aspect seemingly does not work

proceed(manager);
}

}

My AbstractTransaction aspect contains a variable manager and I would like to assign when the setEntityManager get called. Because in the example of Aspectj in Action, the method intercepted will return Connection, which is different from the method I have. Is there any chance to assign the variable so that I can apply entitymanager to the pointcut when scope() is executed? Or what is the right way to do this?

Object around(): scope(){
System.out.println("===========> EntityManager:"+manager); // after assigned, it is still null
Object result = proceed();
return result;
}

Sorry if this question is too newbie. I search on the internet and read again the book Aspectj in Action, but seems there is no such explain.

Thanks for patiently answer my question.

I appreciate it.

Andy Clement wrote:

The method you are intercepting (setEntityManager) has a void return
type, so your advice should too. The proceed() call you are using
will ensure your replacement is passed to the setEntityManager call.

Andy

2009/11/4 neo anderson <javadeveloper999@yahoo.co.uk>:
>
> Hi Mark & Andy. Thanks for your reply. I really appreciate your help.
>
> I change to use args, but now it thorws message:
>
> [error] incompatible return type applying to method-call(void
> example.AccountDao.setEntityManager(example.EntityManager))
>
> [error] incompatible return type applying to method-call(void
> example.AccountDao.setEntityManager(example.EntityManager))
> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>
> [warning] advice defined in example.AbstractTransaction has not been applied
> [Xlint:adviceDidNotMatch]
>
> I check the syntax and read the example in e.g.
> http://books.google.com.tw/books?id=AKuBlJGl7iUC&pg=PA54&lpg=PA54&dq=aspectj+call+args&source=bl&ots=58KGnyCZiN&sig=5gNdHoekFrDXJne3pVe6UO5tiYQ&hl=zh-TW&ei=kNbxSqTEBumgjAfdnp2WAQ&sa=X&oi=book_result&ct=result&resnum=6&ved=0CB0Q6AEwBQ#v=onepage&q=4-2%20capturing%20the%20parameter%20values%20passed%20on%20a%20method%20call&f=false
>
> The way to capture the EntityManager looks correct.
>
> public pointcut(EntityManager manager): call(*
> AccountDao.setEntityManager(EntityManger)) && args(manager);
>
> Is there any place I may go wrong? I test to move the .aj files and compile
> .java source. Everthing works fine. I am confused.
>
> I appreciate any suggestion.
>
> Thank you very much.
>
>
> Mark Cooke-6 wrote:
>>
>> Hi,
>> It's been a while since I've used AspectJ in anger but as no-one else has
>> replied yet...
>>
>> I'd say you probably want "args(manager)" instead of "target(manager)" in
>> the obtainEntityManager pointcut.
>> The target of the call will be an AccountDAO, not an EntityManager.
>>
>> See
>> http://www.eclipse.org/aspectj/doc/released/progguide/semantics-joinPoints.html
>>
>> HTH!
>> Mark.
>>
>> --- On Wed, 4/11/09, neo anderson <javadeveloper999@yahoo.co.uk> wrote:
>>
>>> From: neo anderson <javadeveloper999@yahoo.co.uk>
>>> Subject: [aspectj-users] A transaction question
>>> To: aspectj-users@eclipse.org
>>> Date: Wednesday, 4 November, 2009, 12:09
>>>
>>> I am learning how to modulize transaction using aspectj,
>>> but encounter a
>>> problem that EntityManager I try to capture is always null.
>>> The compiler
>>> issues message saying that the advice can not be applied.
>>> as below:
>>>
>>> ... advice defined in example.AbstractTransaction has not
>>> been applied
>>> [Xlint:adviceDidNotMatch]
>>>
>>> What should I change so that I can capture the
>>> EntityManager while it is
>>> created (whilst calling to
>>> AccountDao.setEntityManager(..))?
>>>
>>> Thanks for help.
>>>
>>> Main.java
>>>
>>> package example;
>>>
>>> public class Main{
>>>     public static void main(String args[]){
>>>         Main m = new Main();
>>>         m.process();
>>>     }
>>>     void process(){
>>>         AccountDao dao = new
>>> AccountDao();
>>>
>>> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>>>         User u = new
>>> User("1", "Smith");
>>>         u.setAddress("123
>>> Test Road, London.");
>>>         dao.save(u);
>>>
>>>
>>> dao.list();
>>>     }
>>> }
>>>
>>> AccountDao.java
>>>
>>> package example;
>>>
>>> import java.util.List;
>>> import java.util.ArrayList;
>>>
>>>
>>> public class AccountDao{
>>>
>>>     private EntityManager manager;
>>>
>>>     private static List<User> database
>>> = new ArrayList<User>();
>>>
>>>     public void
>>> setEntityManager(EntityManager manager){
>>>         this.manager =
>>> manager;
>>>     }
>>>
>>>     public void save(User user){
>>>
>>> database.add(user);
>>>     }
>>>
>>>     public void list(){
>>>         for(User u :
>>> database){
>>>
>>> System.out.println(">>>[AccountDao.java]"+u);
>>>
>>>         }
>>>     }
>>> }
>>>
>>> User.java
>>>
>>> package example;
>>>
>>> public class User{
>>>     private String id;
>>>     private String name;
>>>     private String address;
>>>     public User(String id, String name){
>>>         this.id = id;
>>>         this.name = name;
>>>     }
>>>
>>>     public String getId(){
>>>         return this.id;
>>>     }
>>>
>>>     public String getName(){
>>>         return this.name;
>>>     }
>>>
>>>     public String getAddress(){
>>>         return this.address;
>>>     }
>>>
>>>     public void setAddress(String address){
>>>         this.address =
>>> address;
>>>     }
>>>
>>>     public String toString(){
>>>         return "<User
>>> [id:"+id+"][name:"+name+"][address:"+address+"]>";
>>>     }
>>> }
>>>
>>>
>>> PersistenceCreator.java
>>>
>>> package example;
>>>
>>> public class PersistenceCreator{
>>>     private static EntityManagerFactory
>>> factory;
>>>
>>>     public static EntityManagerFactory
>>> createEntityManagerFactory(){
>>>         if(null == factory)
>>>
>>> factory = new EntityManagerFactory();
>>>         return factory;
>>>     }
>>> }
>>>
>>> EntityManagerFactory.java
>>>
>>> package example;
>>>
>>> public class EntityManagerFactory{
>>>
>>>     private static EntityManager manager;
>>>
>>>     public static EntityManager
>>> createEntityManager(){
>>>         if(null == manager){
>>>
>>> manager = new EntityManager();
>>>         }
>>>         return manager;
>>>     }
>>> }
>>>
>>> EntityManager.java
>>>
>>> package example;
>>>
>>> public class EntityManager{
>>> }
>>>
>>> AbstractTransaction.aj
>>>
>>> package example;
>>>
>>> public abstract aspect AbstractTransaction
>>> percflow(scope()){
>>>
>>>     private EntityManager manager;
>>>
>>>     protected abstract pointcut tx();
>>>
>>>     protected pointcut
>>> obtainEntityManager(EntityManager manager): call(*
>>> example.AccountDao.setEntityManager(EntityManager))
>>> && target(manager);
>>>
>>>     protected pointcut scope(): tx()
>>> && !cflowbelow(tx());
>>>
>>>     Object around(): scope(){
>>>
>>> System.out.println("EntityManager:"+manager);// always null
>>>
>>>         Object result =
>>> proceed();
>>>         return result;
>>>     }
>>>
>>>     EntityManager around(EntityManager
>>> manager): obtainEntityManager(manager)
>>> && cflow(tx()){
>>>         if(null == manager){
>>>
>>> manager = proceed(manager);
>>>
>>>         }
>>
>>>         return manager;
>>>     }
>>> }
>>>
>>> AccountTransaction.aj
>>>
>>> package example;
>>>
>>> public aspect AccountTransaction extends
>>> AbstractTransaction{
>>>
>>>     protected pointcut tx(): execution(*
>>> example.Main.process());
>>> }
>>> --
>>> View this message in context:
>>> http://old.nabble.com/A-transaction-question-tp26195112p26195112.html
>>> Sent from the AspectJ - users mailing list archive at
>>> Nabble.com.
>>>
>>> _______________________________________________
>>> aspectj-users mailing list
>>> aspectj-users@eclipse.org
>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>
>>
>>
>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@eclipse.org
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
>>
>
> --
> View this message in context: http://old.nabble.com/A-transaction-question-tp26195112p26203290.html
> Sent from the AspectJ - users mailing list archive at Nabble.com.
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@eclipse.org
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
_______________________________________________
aspectj-users mailing list
aspectj-users@eclipse.org
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: A transaction question

2009-11-04T11:42:49Z

The method you are intercepting (setEntityManager) has a void return
type, so your advice should too. The proceed() call you are using
will ensure your replacement is passed to the setEntityManager call.

Andy

2009/11/4 neo anderson <javadeveloper999@...>:

>
> Hi Mark & Andy. Thanks for your reply. I really appreciate your help.
>
> I change to use args, but now it thorws message:
>
> [error] incompatible return type applying to method-call(void
> example.AccountDao.setEntityManager(example.EntityManager))
>
> [error] incompatible return type applying to method-call(void
> example.AccountDao.setEntityManager(example.EntityManager))
> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>
> [warning] advice defined in example.AbstractTransaction has not been applied
> [Xlint:adviceDidNotMatch]
>
> I check the syntax and read the example in e.g.
> http://books.google.com.tw/books?id=AKuBlJGl7iUC&pg=PA54&lpg=PA54&dq=aspectj+call+args&source=bl&ots=58KGnyCZiN&sig=5gNdHoekFrDXJne3pVe6UO5tiYQ&hl=zh-TW&ei=kNbxSqTEBumgjAfdnp2WAQ&sa=X&oi=book_result&ct=result&resnum=6&ved=0CB0Q6AEwBQ#v=onepage&q=4-2%20capturing%20the%20parameter%20values%20passed%20on%20a%20method%20call&f=false
>
> The way to capture the EntityManager looks correct.
>
> public pointcut(EntityManager manager): call(*
> AccountDao.setEntityManager(EntityManger)) && args(manager);
>
> Is there any place I may go wrong? I test to move the .aj files and compile
> .java source. Everthing works fine. I am confused.
>
> I appreciate any suggestion.
>
> Thank you very much.
>
>
> Mark Cooke-6 wrote:
>>
>> Hi,
>> It's been a while since I've used AspectJ in anger but as no-one else has
>> replied yet...
>>
>> I'd say you probably want "args(manager)" instead of "target(manager)" in
>> the obtainEntityManager pointcut.
>> The target of the call will be an AccountDAO, not an EntityManager.
>>
>> See
>> http://www.eclipse.org/aspectj/doc/released/progguide/semantics-joinPoints.html
>>
>> HTH!
>> Mark.
>>
>> --- On Wed, 4/11/09, neo anderson <javadeveloper999@...> wrote:
>>
>>> From: neo anderson <javadeveloper999@...>
>>> Subject: [aspectj-users] A transaction question
>>> To: aspectj-users@...
>>> Date: Wednesday, 4 November, 2009, 12:09
>>>
>>> I am learning how to modulize transaction using aspectj,
>>> but encounter a
>>> problem that EntityManager I try to capture is always null.
>>> The compiler
>>> issues message saying that the advice can not be applied.
>>> as below:
>>>
>>> ... advice defined in example.AbstractTransaction has not
>>> been applied
>>> [Xlint:adviceDidNotMatch]
>>>
>>> What should I change so that I can capture the
>>> EntityManager while it is
>>> created (whilst calling to
>>> AccountDao.setEntityManager(..))?
>>>
>>> Thanks for help.
>>>
>>> Main.java
>>>
>>> package example;
>>>
>>> public class Main{
>>>     public static void main(String args[]){
>>>         Main m = new Main();
>>>         m.process();
>>>     }
>>>     void process(){
>>>         AccountDao dao = new
>>> AccountDao();
>>>
>>> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>>>         User u = new
>>> User("1", "Smith");
>>>         u.setAddress("123
>>> Test Road, London.");
>>>         dao.save(u);
>>>
>>>
>>> dao.list();
>>>     }
>>> }
>>>
>>> AccountDao.java
>>>
>>> package example;
>>>
>>> import java.util.List;
>>> import java.util.ArrayList;
>>>
>>>
>>> public class AccountDao{
>>>
>>>     private EntityManager manager;
>>>
>>>     private static List<User> database
>>> = new ArrayList<User>();
>>>
>>>     public void
>>> setEntityManager(EntityManager manager){
>>>         this.manager =
>>> manager;
>>>     }
>>>
>>>     public void save(User user){
>>>
>>> database.add(user);
>>>     }
>>>
>>>     public void list(){
>>>         for(User u :
>>> database){
>>>
>>> System.out.println(">>>[AccountDao.java]"+u);
>>>
>>>         }
>>>     }
>>> }
>>>
>>> User.java
>>>
>>> package example;
>>>
>>> public class User{
>>>     private String id;
>>>     private String name;
>>>     private String address;
>>>     public User(String id, String name){
>>>         this.id = id;
>>>         this.name = name;
>>>     }
>>>
>>>     public String getId(){
>>>         return this.id;
>>>     }
>>>
>>>     public String getName(){
>>>         return this.name;
>>>     }
>>>
>>>     public String getAddress(){
>>>         return this.address;
>>>     }
>>>
>>>     public void setAddress(String address){
>>>         this.address =
>>> address;
>>>     }
>>>
>>>     public String toString(){
>>>         return "<User
>>> [id:"+id+"][name:"+name+"][address:"+address+"]>";
>>>     }
>>> }
>>>
>>>
>>> PersistenceCreator.java
>>>
>>> package example;
>>>
>>> public class PersistenceCreator{
>>>     private static EntityManagerFactory
>>> factory;
>>>
>>>     public static EntityManagerFactory
>>> createEntityManagerFactory(){
>>>         if(null == factory)
>>>
>>> factory = new EntityManagerFactory();
>>>         return factory;
>>>     }
>>> }
>>>
>>> EntityManagerFactory.java
>>>
>>> package example;
>>>
>>> public class EntityManagerFactory{
>>>
>>>     private static EntityManager manager;
>>>
>>>     public static EntityManager
>>> createEntityManager(){
>>>         if(null == manager){
>>>
>>> manager = new EntityManager();
>>>         }
>>>         return manager;
>>>     }
>>> }
>>>
>>> EntityManager.java
>>>
>>> package example;
>>>
>>> public class EntityManager{
>>> }
>>>
>>> AbstractTransaction.aj
>>>
>>> package example;
>>>
>>> public abstract aspect AbstractTransaction
>>> percflow(scope()){
>>>
>>>     private EntityManager manager;
>>>
>>>     protected abstract pointcut tx();
>>>
>>>     protected pointcut
>>> obtainEntityManager(EntityManager manager): call(*
>>> example.AccountDao.setEntityManager(EntityManager))
>>> && target(manager);
>>>
>>>     protected pointcut scope(): tx()
>>> && !cflowbelow(tx());
>>>
>>>     Object around(): scope(){
>>>
>>> System.out.println("EntityManager:"+manager);// always null
>>>
>>>         Object result =
>>> proceed();
>>>         return result;
>>>     }
>>>
>>>     EntityManager around(EntityManager
>>> manager): obtainEntityManager(manager)
>>> && cflow(tx()){
>>>         if(null == manager){
>>>
>>> manager = proceed(manager);
>>>
>>>         }
>>
>>>         return manager;
>>>     }
>>> }
>>>
>>> AccountTransaction.aj
>>>
>>> package example;
>>>
>>> public aspect AccountTransaction extends
>>> AbstractTransaction{
>>>
>>>     protected pointcut tx(): execution(*
>>> example.Main.process());
>>> }
>>> --
>>> View this message in context:
>>> http://old.nabble.com/A-transaction-question-tp26195112p26195112.html
>>> Sent from the AspectJ - users mailing list archive at
>>> Nabble.com.
>>>
>>> _______________________________________________
>>> aspectj-users mailing list
>>> aspectj-users@...
>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>
>>
>>
>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
>>
>
> --
> View this message in context: http://old.nabble.com/A-transaction-question-tp26195112p26203290.html
> Sent from the AspectJ - users mailing list archive at Nabble.com.
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: A transaction question

2009-11-04T11:39:12Z

Hi Mark & Andy. Thanks for your reply. I really appreciate your help.

I change to use args, but now it thorws message:

[error] incompatible return type applying to method-call(void example.AccountDao.setEntityManager(example.EntityManager))

[error] incompatible return type applying to method-call(void example.AccountDao.setEntityManager(example.EntityManager))
dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());

[warning] advice defined in example.AbstractTransaction has not been applied [Xlint:adviceDidNotMatch]

I check the syntax and read the example in e.g. http://books.google.com.tw/books?id=AKuBlJGl7iUC&pg=PA54&lpg=PA54&dq=aspectj+call+args&source=bl&ots=58KGnyCZiN&sig=5gNdHoekFrDXJne3pVe6UO5tiYQ&hl=zh-TW&ei=kNbxSqTEBumgjAfdnp2WAQ&sa=X&oi=book_result&ct=result&resnum=6&ved=0CB0Q6AEwBQ#v=onepage&q=4-2%20capturing%20the%20parameter%20values%20passed%20on%20a%20method%20call&f=false

The way to capture the EntityManager looks correct.

public pointcut(EntityManager manager): call(* AccountDao.setEntityManager(EntityManger)) && args(manager);

Is there any place I may go wrong? I test to move the .aj files and compile .java source. Everthing works fine. I am confused.

I appreciate any suggestion.

Thank you very much.

Mark Cooke-6 wrote:

Hi,
It's been a while since I've used AspectJ in anger but as no-one else has replied yet...

I'd say you probably want "args(manager)" instead of "target(manager)" in the obtainEntityManager pointcut.
The target of the call will be an AccountDAO, not an EntityManager.

See http://www.eclipse.org/aspectj/doc/released/progguide/semantics-joinPoints.html

HTH!
Mark.

--- On Wed, 4/11/09, neo anderson <javadeveloper999@yahoo.co.uk> wrote:

> From: neo anderson <javadeveloper999@yahoo.co.uk>
> Subject: [aspectj-users] A transaction question
> To: aspectj-users@eclipse.org
> Date: Wednesday, 4 November, 2009, 12:09
>
> I am learning how to modulize transaction using aspectj,
> but encounter a
> problem that EntityManager I try to capture is always null.
> The compiler
> issues message saying that the advice can not be applied.
> as below:
>
> ... advice defined in example.AbstractTransaction has not
> been applied
> [Xlint:adviceDidNotMatch]
>
> What should I change so that I can capture the
> EntityManager while it is
> created (whilst calling to
> AccountDao.setEntityManager(..))?
>
> Thanks for help.
>
> Main.java
>
> package example;
>
> public class Main{
>     public static void main(String args[]){
>         Main m = new Main();
>         m.process();
>     }
>     void process(){
>         AccountDao dao = new
> AccountDao();
>
> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>         User u = new
> User("1", "Smith");
>         u.setAddress("123
> Test Road, London.");
>         dao.save(u);
>
>
> dao.list();
>     }
> }
>
> AccountDao.java
>
> package example;
>
> import java.util.List;
> import java.util.ArrayList;
>
>
> public class AccountDao{
>
>     private EntityManager manager;
>
>     private static List<User> database
> = new ArrayList<User>();
>
>     public void
> setEntityManager(EntityManager manager){
>         this.manager =
> manager;
>     }
>
>     public void save(User user){
>
> database.add(user);
>     }
>
>     public void list(){
>         for(User u :
> database){
>
> System.out.println(">>>[AccountDao.java]"+u);
>
>         }
>     }
> }
>
> User.java
>
> package example;
>
> public class User{
>     private String id;
>     private String name;
>     private String address;
>     public User(String id, String name){
>         this.id = id;
>         this.name = name;
>     }
>
>     public String getId(){
>         return this.id;
>     }
>
>     public String getName(){
>         return this.name;
>     }
>
>     public String getAddress(){
>         return this.address;
>     }
>
>     public void setAddress(String address){
>         this.address =
> address;
>     }
>
>     public String toString(){
>         return "<User
> [id:"+id+"][name:"+name+"][address:"+address+"]>";
>     }
> }
>
>
> PersistenceCreator.java
>
> package example;
>
> public class PersistenceCreator{
>     private static EntityManagerFactory
> factory;
>
>     public static EntityManagerFactory
> createEntityManagerFactory(){
>         if(null == factory)
>
> factory = new EntityManagerFactory();
>         return factory;
>     }
> }
>
> EntityManagerFactory.java
>
> package example;
>
> public class EntityManagerFactory{
>
>     private static EntityManager manager;
>
>     public static EntityManager
> createEntityManager(){
>         if(null == manager){
>
> manager = new EntityManager();
>         }
>         return manager;
>     }
> }
>
> EntityManager.java
>
> package example;
>
> public class EntityManager{
> }
>
> AbstractTransaction.aj
>
> package example;
>
> public abstract aspect AbstractTransaction
> percflow(scope()){
>
>     private EntityManager manager;
>
>     protected abstract pointcut tx();
>
>     protected pointcut
> obtainEntityManager(EntityManager manager): call(*
> example.AccountDao.setEntityManager(EntityManager))
> && target(manager);
>
>     protected pointcut scope(): tx()
> && !cflowbelow(tx());
>
>     Object around(): scope(){
>
> System.out.println("EntityManager:"+manager);// always null
>
>         Object result =
> proceed();
>         return result;
>     }
>
>     EntityManager around(EntityManager
> manager): obtainEntityManager(manager)
> && cflow(tx()){
>         if(null == manager){
>
> manager = proceed(manager);
>
>         }

>         return manager;
>     }
> }
>
> AccountTransaction.aj
>
> package example;
>
> public aspect AccountTransaction extends
> AbstractTransaction{
>
>     protected pointcut tx(): execution(*
> example.Main.process());
> }
> --
> View this message in context: http://old.nabble.com/A-transaction-question-tp26195112p26195112.html
> Sent from the AspectJ - users mailing list archive at
> Nabble.com.
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@eclipse.org
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

_______________________________________________
aspectj-users mailing list
aspectj-users@eclipse.org
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Intertype declarations results in too long names

2009-11-04T10:21:00Z

Huh, I would have sworn I had tried that in the past and it hadn't
worked. Thanks for the tip.

On Nov 2, 2009, at 5:53 PM, Andy Clement wrote:

>> but that adds in a declare statement
>
> Just to say, if you annotate the ITD, that will be on the introduced
> target method - you don't need an additional 'declare @method'.
>
>> From a Roo project:
> @javax.persistence.Id
>
> @javax
> .persistence
> .GeneratedValue(strategy=javax.persistence.GenerationType.AUTO)
> @javax.persistence.Column(name="id")
> private java.lang.Long Pet.id;
>
> cheers,
> Andy
>
> 2009/11/2 Dave Whittaker <dave@...>:
>> Just thought I'd throw in here with a case where I've ran into
>> problems with
>> this... JPA. If you have common fields you want to inject into an
>> entity
>> you might try to do something like
>>
>> private String CommonInterface.commonField
>>
>> And expect at runtime that will result in a db column named
>> common_field, or
>> whatever else your naming strategy comes up with. Sure you could
>> use the
>> @Column annotation and explicitly give it a name, but that adds in
>> a declare
>> statement and it is definitely a bit confusing when you first run
>> across the
>> issue. JPA is not the only framework to do this type of reflection
>> these
>> days, Seam's @In injection is another one that tries to determine a
>> value
>> based on the name of the field.
>>
>> Of course i imagine this was done to avoid naming collisions when you
>> receive fields from multiple ITDs and I'm not sure I see a better
>> solution.
>>
>> On Nov 2, 2009, at 5:03 PM, Andrew Eisenberg wrote:
>>
>>> Hi,
>>>
>>> The ajc$interField$mypack_mysubpack_MyAspect$id is internal and not
>>> expected to be directly referenced in the source code. It is only
>>> needed for the byte code (i.e., you should not be concerned with
>>> it).
>>> All you need to know is that the declaration declares an Integer
>>> field
>>> 'id' on MyClass that is private to the aspect (ie- it is not
>>> accessible anywhere outside the aspect).
>>>
>>> Unless you require knowledge about the byte code, the byte code name
>>> should not be of concern to you. However, if you do require
>>> knowledge
>>> about the byte code, please explain what that is and perhaps we can
>>> help you.
>>>
>>> --a
>>>
>>> On Mon, Nov 2, 2009 at 2:45 PM, db <dbconrado@...> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> I have an intertype declaration like this:
>>>>
>>>> private Integer MyClass.id;
>>>>
>>>> but, when it was compiled/weaved, this attribute receive the name:
>>>> ajc$interField$mypack_mysubpack_MyAspect$id.
>>>> I want MyClass receive an id attribute and not a ajc$...$id
>>>> attribute.
>>>> How to do it?
>>>>
>>>> Thanks!
>>>>
>>>> PS: Sorry for my poor English. It isn't my native language :).
>>>>
>>>> _______________________________________________
>>>> aspectj-users mailing list
>>>> aspectj-users@...
>>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>>
>>>>
>>> _______________________________________________
>>> aspectj-users mailing list
>>> aspectj-users@...
>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: A transaction question

2009-11-04T08:33:01Z

Hi,
It's been a while since I've used AspectJ in anger but as no-one else has replied yet...

I'd say you probably want "args(manager)" instead of "target(manager)" in the obtainEntityManager pointcut.
The target of the call will be an AccountDAO, not an EntityManager.

See http://www.eclipse.org/aspectj/doc/released/progguide/semantics-joinPoints.html

HTH!
Mark.

--- On Wed, 4/11/09, neo anderson <javadeveloper999@...> wrote:

> From: neo anderson <javadeveloper999@...>
> Subject: [aspectj-users] A transaction question
> To: aspectj-users@...
> Date: Wednesday, 4 November, 2009, 12:09
>
> I am learning how to modulize transaction using aspectj,
> but encounter a
> problem that EntityManager I try to capture is always null.
> The compiler
> issues message saying that the advice can not be applied.
> as below:
>
> ... advice defined in example.AbstractTransaction has not
> been applied
> [Xlint:adviceDidNotMatch]
>
> What should I change so that I can capture the
> EntityManager while it is
> created (whilst calling to
> AccountDao.setEntityManager(..))?
>
> Thanks for help.
>
> Main.java
>
> package example;
>
> public class Main{
>     public static void main(String args[]){
>         Main m = new Main();
>         m.process();
>     }
>     void process(){
>         AccountDao dao = new
> AccountDao();
>
> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
>         User u = new
> User("1", "Smith");
>         u.setAddress("123
> Test Road, London.");
>         dao.save(u);
>
>
> dao.list();
>     }
> }
>
> AccountDao.java
>
> package example;
>
> import java.util.List;
> import java.util.ArrayList;
>
>
> public class AccountDao{
>
>     private EntityManager manager;
>
>     private static List<User> database
> = new ArrayList<User>();
>
>     public void
> setEntityManager(EntityManager manager){
>         this.manager =
> manager;
>     }
>
>     public void save(User user){
>
> database.add(user);
>     }
>
>     public void list(){
>         for(User u :
> database){
>
> System.out.println(">>>[AccountDao.java]"+u);
>
>         }
>     }
> }
>
> User.java
>
> package example;
>
> public class User{
>     private String id;
>     private String name;
>     private String address;
>     public User(String id, String name){
>         this.id = id;
>         this.name = name;
>     }
>
>     public String getId(){
>         return this.id;
>     }
>
>     public String getName(){
>         return this.name;
>     }
>
>     public String getAddress(){
>         return this.address;
>     }
>
>     public void setAddress(String address){
>         this.address =
> address;
>     }
>
>     public String toString(){
>         return "<User
> [id:"+id+"][name:"+name+"][address:"+address+"]>";
>     }
> }
>
>
> PersistenceCreator.java
>
> package example;
>
> public class PersistenceCreator{
>     private static EntityManagerFactory
> factory;
>
>     public static EntityManagerFactory
> createEntityManagerFactory(){
>         if(null == factory)
>
> factory = new EntityManagerFactory();
>         return factory;
>     }
> }
>
> EntityManagerFactory.java
>
> package example;
>
> public class EntityManagerFactory{
>
>     private static EntityManager manager;
>
>     public static EntityManager
> createEntityManager(){
>         if(null == manager){
>
> manager = new EntityManager();
>         }
>         return manager;
>     }
> }
>
> EntityManager.java
>
> package example;
>
> public class EntityManager{
> }
>
> AbstractTransaction.aj
>
> package example;
>
> public abstract aspect AbstractTransaction
> percflow(scope()){
>
>     private EntityManager manager;
>
>     protected abstract pointcut tx();
>
>     protected pointcut
> obtainEntityManager(EntityManager manager): call(*
> example.AccountDao.setEntityManager(EntityManager))
> && target(manager);
>
>     protected pointcut scope(): tx()
> && !cflowbelow(tx());
>
>     Object around(): scope(){
>
> System.out.println("EntityManager:"+manager);// always null
>
>         Object result =
> proceed();
>         return result;
>     }
>
>     EntityManager around(EntityManager
> manager): obtainEntityManager(manager)
> && cflow(tx()){
>         if(null == manager){
>
> manager = proceed(manager);
>
>         }

>         return manager;
>     }
> }
>
> AccountTransaction.aj
>
> package example;
>
> public aspect AccountTransaction extends
> AbstractTransaction{
>
>     protected pointcut tx(): execution(*
> example.Main.process());
> }
> --
> View this message in context: http://old.nabble.com/A-transaction-question-tp26195112p26195112.html
> Sent from the AspectJ - users mailing list archive at
> Nabble.com.
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: A transaction question

2009-11-04T08:03:11Z

Just a quick observation:

protected pointcut obtainEntityManager(EntityManager manager): call(*
example.AccountDao.setEntityManager(EntityManager)) && target(manager);

shouldn't that be:

protected pointcut obtainEntityManager(EntityManager manager): call(*
example.AccountDao.setEntityManager(EntityManager)) && args(manager);

As the EntityManager is the argument to the method call and not the
target of the call (the target of the call being AccountDao)?

Andy

2009/11/4 neo anderson <javadeveloper999@...>:

>
> I am learning how to modulize transaction using aspectj, but encounter a
> problem that EntityManager I try to capture is always null. The compiler
> issues message saying that the advice can not be applied. as below:
>
> ... advice defined in example.AbstractTransaction has not been applied
> [Xlint:adviceDidNotMatch]
>
> What should I change so that I can capture the EntityManager while it is
> created (whilst calling to AccountDao.setEntityManager(..))?
>
> Thanks for help.
>
> Main.java
>
> package example;
>
> public class Main{
> public static void main(String args[]){
> Main m = new Main();
> m.process();
> }
> void process(){
> AccountDao dao = new AccountDao();
>
> dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
> User u = new User("1", "Smith");
> u.setAddress("123 Test Road, London.");
> dao.save(u);
>
> dao.list();
> }
> }
>
> AccountDao.java
>
> package example;
>
> import java.util.List;
> import java.util.ArrayList;
>
>
> public class AccountDao{
>
> private EntityManager manager;
>
> private static List<User> database = new ArrayList<User>();
>
> public void setEntityManager(EntityManager manager){
> this.manager = manager;
> }
>
> public void save(User user){
> database.add(user);
> }
>
> public void list(){
> for(User u : database){
> System.out.println(">>>[AccountDao.java]"+u);
> }
> }
> }
>
> User.java
>
> package example;
>
> public class User{
> private String id;
> private String name;
> private String address;
> public User(String id, String name){
> this.id = id;
> this.name = name;
> }
>
> public String getId(){
> return this.id;
> }
>
> public String getName(){
> return this.name;
> }
>
> public String getAddress(){
> return this.address;
> }
>
> public void setAddress(String address){
> this.address = address;
> }
>
> public String toString(){
> return "<User [id:"+id+"][name:"+name+"][address:"+address+"]>";
> }
> }
>
>
> PersistenceCreator.java
>
> package example;
>
> public class PersistenceCreator{
> private static EntityManagerFactory factory;
>
> public static EntityManagerFactory createEntityManagerFactory(){
> if(null == factory)
> factory = new EntityManagerFactory();
> return factory;
> }
> }
>
> EntityManagerFactory.java
>
> package example;
>
> public class EntityManagerFactory{
>
> private static EntityManager manager;
>
> public static EntityManager createEntityManager(){
> if(null == manager){
> manager = new EntityManager();
> }
> return manager;
> }
> }
>
> EntityManager.java
>
> package example;
>
> public class EntityManager{
> }
>
> AbstractTransaction.aj
>
> package example;
>
> public abstract aspect AbstractTransaction percflow(scope()){
>
> private EntityManager manager;
>
> protected abstract pointcut tx();
>
> protected pointcut obtainEntityManager(EntityManager manager): call(*
> example.AccountDao.setEntityManager(EntityManager)) && target(manager);
>
> protected pointcut scope(): tx() && !cflowbelow(tx());
>
> Object around(): scope(){
> System.out.println("EntityManager:"+manager);// always null
> Object result = proceed();
> return result;
> }
>
> EntityManager around(EntityManager manager): obtainEntityManager(manager)
> && cflow(tx()){
> if(null == manager){
> manager = proceed(manager);
>
> }
> return manager;
> }
> }
>
> AccountTransaction.aj
>
> package example;
>
> public aspect AccountTransaction extends AbstractTransaction{
>
> protected pointcut tx(): execution(* example.Main.process());
> }
> --
> View this message in context: http://old.nabble.com/A-transaction-question-tp26195112p26195112.html
> Sent from the AspectJ - users mailing list archive at Nabble.com.
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Problems with inter type declaring @PersistenceContext annotated EntityManager attribute in interface

2009-11-04T07:22:25Z

Hi all,

I have an aspect like that:

declare parents: MyClass1 || MyClass2 implements HasEntityManager;

@PersistenceContext
private EntityManager HasEntityManager.entityManager;

However, when I start my app in Glassfish, I get:

SEVERE: Injection method name must start with "set"
symbol: javax.persistence.PersistenceContext
location: public static void edu.tcc.t2.infra.RepositoryJPA.ajc$interFieldInit$edu_tcc_t2_infra_RepositoryJPA$edu_tcc_t2_infra_HasEntityManager$entityManager(edu.tcc.t2.infra.HasEntityManager)

I'm using field-based annotation, so, it couldn't happen.
Anyone knows how to solve it?

Thanks.

PS: MyClass1 and MyClass2 are JSF managed beans.

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

A transaction question

2009-11-04T04:09:41Z

I am learning how to modulize transaction using aspectj, but encounter a problem that EntityManager I try to capture is always null. The compiler issues message saying that the advice can not be applied. as below:

... advice defined in example.AbstractTransaction has not been applied [Xlint:adviceDidNotMatch]

What should I change so that I can capture the EntityManager while it is created (whilst calling to AccountDao.setEntityManager(..))?

Thanks for help.

Main.java

package example;

public class Main{
public static void main(String args[]){
Main m = new Main();
m.process();
}
void process(){
AccountDao dao = new AccountDao();
dao.setEntityManager(PersistenceCreator.createEntityManagerFactory().createEntityManager());
User u = new User("1", "Smith");
u.setAddress("123 Test Road, London.");
dao.save(u);

dao.list();
}
}

AccountDao.java

package example;

import java.util.List;
import java.util.ArrayList;

public class AccountDao{

private EntityManager manager;

private static List<User> database = new ArrayList<User>();

public void setEntityManager(EntityManager manager){
this.manager = manager;
}

public void save(User user){
database.add(user);
}

public void list(){
for(User u : database){
System.out.println(">>>[AccountDao.java]"+u);
}
}
}

User.java

package example;

public class User{
private String id;
private String name;
private String address;
public User(String id, String name){
this.id = id;
this.name = name;
}

public String getId(){
return this.id;
}

public String getName(){
return this.name;
}

public String getAddress(){
return this.address;
}

public void setAddress(String address){
this.address = address;
}

public String toString(){
return "<User [id:"+id+"][name:"+name+"][address:"+address+"]>";
}
}

PersistenceCreator.java

package example;

public class PersistenceCreator{
private static EntityManagerFactory factory;

public static EntityManagerFactory createEntityManagerFactory(){
if(null == factory)
factory = new EntityManagerFactory();
return factory;
}
}

EntityManagerFactory.java

package example;

public class EntityManagerFactory{

private static EntityManager manager;

public static EntityManager createEntityManager(){
if(null == manager){
manager = new EntityManager();
}
return manager;
}
}

EntityManager.java

package example;

public class EntityManager{
}

AbstractTransaction.aj

package example;

public abstract aspect AbstractTransaction percflow(scope()){

private EntityManager manager;

protected abstract pointcut tx();

protected pointcut obtainEntityManager(EntityManager manager): call(* example.AccountDao.setEntityManager(EntityManager)) && target(manager);

protected pointcut scope(): tx() && !cflowbelow(tx());

Object around(): scope(){
System.out.println("EntityManager:"+manager);// always null
Object result = proceed();
return result;
}

EntityManager around(EntityManager manager): obtainEntityManager(manager) && cflow(tx()){
if(null == manager){
manager = proceed(manager);

}
return manager;
}
}

AccountTransaction.aj

package example;

public aspect AccountTransaction extends AbstractTransaction{

protected pointcut tx(): execution(* example.Main.process());
}

RE: FW: NoSuchMethodError: aspectOf()

2009-11-03T07:53:40Z

Hi Andy,
Thank you for the detailed explanation. My aspect works now.
Thanks,
Roger
-----Original Message-----
From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
Sent: Sunday, November 01, 2009 7:49 PM
To: aspectj-users@...
Subject: Re: [aspectj-users] FW: NoSuchMethodError: aspectOf()

Hi Roger,

There are three paths to think about with AspectJ:

classpath: for resolving references found in any of the code the compiler/weaver are processing. This path is not searched for aspects, and the contents of it are not woven and not copied to the output folder.
inpath: input .class files for weaving. Contents of this path *are* woven and *are* copied to the output folder, it is also searched for aspects.
aspectpath: input aspect .class files for weaving. Contents of this path are not woven and are not copied to the output folder, but it is searched for aspects.

Your annotation style aspect is compiled by javac and then passed in via aspectpath. Unfortunately as I have written above, the contents of aspect path are not woven - so your aspect is never 'finished off'.

You have a few options:
1) compile the aspect with iajc rather than javac.
2) after compiling with javac, add a step to pass it through iajc to finish it off.
3) pass it on inpath to your existing iajc call.

Each has pros/cons. (1) you may have written the aspect using annotations in the first place to avoid using iajc initially. (2) adds extra compile step to your process. (3) the woven aspect will go into the output folder. So the aspect class files will be 'mixed up' with your woven application.

cheers,
Andy

2009/10/31 Roger Huang <rhuang@...>:

> Hi Andy,
>
> Thank you very much for looking at my problem.
>
> Yes I included the aspect in my call to iajc.
>
> Below is a portion of my build.xml (target Pdm.war) and the output of
> "ant Pdm.war".
>
> Login.java is my aspect expressed in @AspectJ notation.
>
>
>
>             <target name="Pdm.war" depends="prepare">
>
>                         
>
>                         <javac
>
>                                     srcdir   ="${dir.dm}/src"
>
>                                     destdir
> ="${dir.build}/java/classes">
>
>                                     <classpath>
>
>                                                 <fileset dir="${dir.dm}/lib"
> includes="*.jar"/>
>
>                                                 <fileset
> dir="${dir.dm}/lib/crystal">
>
>                                                             <include
> name="CrystalCommon2.jar"/>
>
>                                                             <include
> name="CrystalReportsRuntime.jar"/>
>
>                                                 </fileset>
>
>                                                 <fileset
> file="${dir.build}/servlet.jar"/>
>
>                                     </classpath>
>
>                         </javac>
>
>
>
>                         
>
>                         <jar
>
>                                     basedir
> ="${dir.build}/java/classes"
>
>
> destfile="${dir.build}/java/DMCoreConcerns.jar"
>
>                         />
>
>
>
>                         
>
>                         <javac
>
>                                     srcdir
> ="${dir.dm}/src-aspects-aspectj"
>
>                                     destdir ="${dir.build}/aspects/classes/"
>
>                                     debug ="true"
>>
>
>                                     <classpath>
>
>                                                 <fileset
> dir="${log4j.dir}">
>
>                                                             <include
> name="log4j-1.2.8.jar"/>
>
>                                                 </fileset>
>
>                                                 <pathelement
> location="${dir.build}/java/DMCoreConcerns.jar"/>
>
>                                     </classpath>
>
>                         </javac>
>
>                         
>
>                         <jar
>
>                                     basedir
> ="${dir.build}/aspects/classes"
>
>
> destfile="${dir.build}/aspects/DMAspects.jar"
>
>                         />
>
>                         
>
>                         <aspectj:iajc
>
>                                     inpath
> ="${dir.build}/java/classes"
>
>                                     aspectPath
> ="${dir.build}/aspects/DMAspects.jar"
>
>                                     destDir
> ="${dir.build}/WEB-INF/classes"
>
>                                     classpath
> ="${aspectj.lib.dir}/aspectjrt.jar"
>
>                                     source             ="1.5"
>
>                                     XlintFile
> ="${dir.build}/xlint.properties"
>
>                                     verbose           ="true"
>
>                                     showWeaveInfo="true"
>
>                         />
>
>                         
>
>                         <jar jarfile="${dir.dist}/PdmWar/Pdm.war">
>
>                                     <fileset
> dir="${dir.dm}/WebFiles"/>
>
>                                     <zipfileset dir="${dir.dm}/lib"
> prefix="WEB-INF/lib">
>
>                                                 <include
> name="*.jar"/>
>
>                                                 <include
> name="*.zip"/>
>
>                                                 <exclude
> name="sapjco.*"/>
>
>                                     </zipfileset>
>
>                                     <zipfileset
> dir="${dir.dm}/lib/crystal"            prefix="WEB-INF/lib"/>
>
>                                     <zipfileset dir="${dir.dm}/config"
>                  prefix="WEB-INF/classes"/>
>
>                                     <zipfileset dir="${dir.mappingFiles}"
> prefix="WEB-INF/classes">
>
>                                                 <patternset
> refid="bundledMappingFiles"/>
>
>                                                 <include
> name="DST*.xsd"/>
>
>                                     </zipfileset>
>
>                                     <zipfileset dir="${dir.dm}/PropertyFile"
> prefix="WEB-INF/classes"/>
>
>                                     <zipfileset dir="${dir.dm}/src"
>                        prefix="WEB-INF/classes"
> includes="**/*.properties"/>
>
>                                     <fileset            dir="${dir.build}"
>                                 includes="WEB-INF/"/>
>
>                                     <fileset
> dir="${dir.build}/aspects"       includes="DMAspects.jar"/>
>
>                                     <zipfileset
> dir="${dir.build}/aspects/classes" prefix="WEB-INF/classes"/>
>
>                         </jar>
>
>             </target>
>
> Buildfile: build.xml
>
>      [echo] Release build for Windows XP.
>
>
>
> init:
>
>
>
> prepare:
>
>
>
> Pdm.war:
>
> [aspectj:iajc] ajc [-d, C:\DataManager\Trunk\build\WEB-INF\classes,
> -source, 1.5, -Xlintfile, C:\DataManager\Trunk\build\xlint.properties,
> -verbose, -showWeaveInfo, -classpath, C:\Program
> Files\aspectj1.6\lib\aspectjrt.jar,
> -aspectpath, C:\DataManager\Trunk\build\aspects\DMAspects.jar,
> -inpath, C:\DataManager\Trunk\build\java\classes]
>
> [aspectj:iajc] info directory classpath entry does not exist:
> C:\Program Files\Java\jdk1.5.0_20\jre\lib\i18n.jar
>
> [aspectj:iajc] info directory classpath entry does not exist:
> C:\Program Files\Java\jdk1.5.0_20\jre\lib\sunrsasign.jar
>
> [aspectj:iajc] info zipfile classpath entry does not exist: C:\Program
> Files\Java\jdk1.5.0_20\jre\classes
>
> [aspectj:iajc] info Pipelining compilation
>
> [aspectj:iajc] info weaver operating in reweavable mode. Need to
> verify any required types exist.
>
> ...
>
>
>
> [aspectj:iajc] weaveinfo Join point
> 'method-call(com.foo.athens.beans.LoginData
> com.foo.athens.dao.LoginDAO.login(com.foo.athens.beans.LoginData))' in
> Type 'com.foo.athens.action.LoginAction' (no debug info available)
> advised by before advice from 'com.foo.logging.Login'
> (DMAspects.jar!Login.class(from
> Login.java))
>
> [aspectj:iajc] weaveinfo Join point
> 'method-call(com.foo.athens.beans.LoginData
> com.foo.athens.dao.LoginDAO.login(com.foo.athens.beans.LoginData))' in
> Type 'com.foo.athens.action.LoginAction' (no debug info available)
> advised by after advice from 'com.foo.logging.Login'
> (DMAspects.jar!Login.class(from
> Login.java))
>
> [aspectj:iajc] weaveinfo Join point
> 'method-call(com.foo.athens.beans.LoginData
> com.foo.athens.dao.LoginDAO.login(com.foo.athens.beans.LoginData))' in
> Type 'com.foo.athens.action.LoginAction' (no debug info available)
> advised by afterThrowing advice from 'com.foo.logging.Login'
> (DMAspects.jar!Login.class(from Login.java))
>
> [aspectj:iajc] info woven class com.foo.athens.action.LoginAction
> (from
> C:\DataManager\Trunk\build\java\classes\com\foo\athens\action\LoginAct
> ion.class)
>
> ...
>
> [aspectj:iajc] info Compiler took 3813ms
>
> [jar] Building jar:
> C:\DataManager\Trunk\Install\DataManager\PdmWar\Pdm.war
>
>
>
> BUILD SUCCESSFUL
>
> Total time: 9 seconds
>
>
>
>
>
> Thanks,
>
> Roger Huang
>
>
>
> -----Original Message-----
> From: aspectj-users-bounces@...
> [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
> Sent: Friday, October 30, 2009 5:32 PM
> To: aspectj-users@...
> Subject: Re: [aspectj-users] FW: NoSuchMethodError: aspectOf()
>
>
>
> Hi Roger,
>
>
>
> Are you definetly including the aspect itself in the call to iajc?
>
> Annotation style aspects (when @Pointcut/etc are used) can be compiled
>
> with javac, but they must be given to the weaver at some point in
>
> order for the missing methods to be added - for example 'aspectOf()'.
>
>
>
> cheers,
>
> Andy
>
>
>
> 2009/10/30 Roger Huang <rhuang@...>:
>
>> Any ideas why I am get the NoSuchMethodError below?
>
>>
>
>>
>
>>
>
>> The method specified by the pointcut is in
>
>> com.foo.action.LoginAction.execute.
>
>>
>
>> The aspect is defined in com.foo.logging.Login.   (see below)
>
>>
>
>> My code which is being advised does not call the aspect's aspectOf()
>> method.
>
>>
>
>>
>
>>
>
>> I use build-time bytecode weaving using the ant <iajc> task.
>
>>
>
>>
>
>>
>
>> The app is a Struts-based web app.
>
>>
>
>>
>
>>
>
>>
>
>>
>
>> Dev environment:
>
>>
>
>> Java 1.5
>
>>
>
>> Ant 1.7.1
>
>>
>
>> AspectJ 1.6.6
>
>>
>
>>
>
>>
>
>> Thanks,
>
>>
>
>> Roger
>
>>
>
>>
>
>>
>
>>
>
>>
>
>> javax.servlet.ServletException: Servlet execution threw an exception
>
>>
>
>>
>> com.hyperformix.athens.filter.AthensLoginFilter.doFilter(Unknown
>
>> Source)
>
>>
>
>> root cause
>
>>
>
>> java.lang.NoSuchMethodError:
>
>> com.foo.logging.Login.aspectOf()Lcom/foo/logging/Login;
>
>>
>
>>         com.foo.action.LoginAction.execute(Unknown Source)
>
>>
>
>>
>
>>
>> org.apache.struts.action.RequestProcessor.processActionPerform(Reques
>> tProcessor.java:421)
>
>>
>
>>
>
>>
>> org.apache.struts.action.RequestProcessor.process(RequestProcessor.ja
>> va:226)
>
>>
>
>>
>
>> org.apache.struts.action.ActionServlet.process(ActionServlet.java:116
>> 4)
>
>>
>
>>
>
>> org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:415)
>
>>
>
>>         javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
>
>>
>
>>         javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
>
>>
>
>>         com.foo.athens.filter.AthensLoginFilter.doFilter(Unknown
>> Source)
>
>>
>
>>
>
>>
>
>>
>
>>
>
>>
>
>>
>
>>
>
>>
>
>> @Aspect
>
>>
>
>> public class Login {
>
>>
>
>>
>
>>
>
>>                 static Logger log =
>> Logger.getLogger(Login.class.getName());
>
>>
>
>>                 String userName;
>
>>
>
>>                 String roleName;
>
>>
>
>>
>
>>
>
>>                 @Pointcut("call (* com.foo.LoginDAO.login(com.foo.
>> Data) )
>
>> && args(data)")
>
>>
>
>>                 public void login(Data data) {}
>
>>
>
>>
>
>>
>
>>                 @Before("login(data)")
>
>>
>
>>                 public void loginBefore(Data data)
>
>>
>
>>                 {
>
>>
>
>>                                 userName = data.getUserName();
>
>>
>
>>                                 roleName = data.getRoleName();
>
>>
>
>>                                 BasicConfigurator.configure();
>
>>
>
>>                                 log.info("User " + userName + " with
>> role "
>
>> + roleName + " about to login");
>
>>
>
>>                 }
>
>>
>
>>
>
>>
>
>> }
>
>>
>
>> Roger Huang
>
>>
>
>>
>
>>
>
>> _______________________________________________
>
>> aspectj-users mailing list
>
>> aspectj-users@...
>
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
>>
>
>>
>
> _______________________________________________
>
> aspectj-users mailing list
>
> aspectj-users@...
>
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Intertype declarations results in too long names

2009-11-02T15:36:51Z

Hi all,

Thanks!

I want to declare an id attribute in a persistent class (to be used by JPA). But the generated attribute has a long name and mysql doesn't accept it.

I completely forgot the @Column annotation! :) I can use @Column(name="id") to solve the problem.

Thanks again! :)

--db

On Mon, Nov 2, 2009 at 8:53 PM, Andy Clement <andrew.clement@...> wrote:

> but that adds in a declare statement

Just to say, if you annotate the ITD, that will be on the introduced
target method - you don't need an additional 'declare @method'.

>From a Roo project:
@javax.persistence.Id
@javax.persistence.GeneratedValue(strategy=javax.persistence.GenerationType.AUTO)
@javax.persistence.Column(name="id")
private java.lang.Long Pet.id;

cheers,
Andy

2009/11/2 Dave Whittaker <dave@...>:

> Just thought I'd throw in here with a case where I've ran into problems with
> this... JPA. If you have common fields you want to inject into an entity
> you might try to do something like
>
> private String CommonInterface.commonField
>
> And expect at runtime that will result in a db column named common_field, or
> whatever else your naming strategy comes up with. Sure you could use the
> @Column annotation and explicitly give it a name, but that adds in a declare
> statement and it is definitely a bit confusing when you first run across the
> issue. JPA is not the only framework to do this type of reflection these
> days, Seam's @In injection is another one that tries to determine a value
> based on the name of the field.
>
> Of course i imagine this was done to avoid naming collisions when you
> receive fields from multiple ITDs and I'm not sure I see a better solution.
>
> On Nov 2, 2009, at 5:03 PM, Andrew Eisenberg wrote:
>
>> Hi,
>>
>> The ajc$interField$mypack_mysubpack_MyAspect$id is internal and not
>> expected to be directly referenced in the source code. It is only
>> needed for the byte code (i.e., you should not be concerned with it).
>> All you need to know is that the declaration declares an Integer field
>> 'id' on MyClass that is private to the aspect (ie- it is not
>> accessible anywhere outside the aspect).
>>
>> Unless you require knowledge about the byte code, the byte code name
>> should not be of concern to you. However, if you do require knowledge
>> about the byte code, please explain what that is and perhaps we can
>> help you.
>>
>> --a
>>
>> On Mon, Nov 2, 2009 at 2:45 PM, db <dbconrado@...> wrote:
>>>
>>> Hi All,
>>>
>>> I have an intertype declaration like this:
>>>
>>> private Integer MyClass.id;
>>>
>>> but, when it was compiled/weaved, this attribute receive the name:
>>> ajc$interField$mypack_mysubpack_MyAspect$id.
>>> I want MyClass receive an id attribute and not a ajc$...$id attribute.
>>> How to do it?
>>>
>>> Thanks!
>>>
>>> PS: Sorry for my poor English. It isn't my native language :).
>>>
>>> _______________________________________________
>>> aspectj-users mailing list
>>> aspectj-users@...
>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>
>>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Intertype declarations results in too long names

2009-11-02T14:53:20Z

> but that adds in a declare statement

Just to say, if you annotate the ITD, that will be on the introduced
target method - you don't need an additional 'declare @method'.

>From a Roo project:
@javax.persistence.Id
@javax.persistence.GeneratedValue(strategy=javax.persistence.GenerationType.AUTO)
@javax.persistence.Column(name="id")
private java.lang.Long Pet.id;

cheers,
Andy

2009/11/2 Dave Whittaker <dave@...>:

> Just thought I'd throw in here with a case where I've ran into problems with
> this... JPA. If you have common fields you want to inject into an entity
> you might try to do something like
>
> private String CommonInterface.commonField
>
> And expect at runtime that will result in a db column named common_field, or
> whatever else your naming strategy comes up with. Sure you could use the
> @Column annotation and explicitly give it a name, but that adds in a declare
> statement and it is definitely a bit confusing when you first run across the
> issue. JPA is not the only framework to do this type of reflection these
> days, Seam's @In injection is another one that tries to determine a value
> based on the name of the field.
>
> Of course i imagine this was done to avoid naming collisions when you
> receive fields from multiple ITDs and I'm not sure I see a better solution.
>
> On Nov 2, 2009, at 5:03 PM, Andrew Eisenberg wrote:
>
>> Hi,
>>
>> The ajc$interField$mypack_mysubpack_MyAspect$id is internal and not
>> expected to be directly referenced in the source code. It is only
>> needed for the byte code (i.e., you should not be concerned with it).
>> All you need to know is that the declaration declares an Integer field
>> 'id' on MyClass that is private to the aspect (ie- it is not
>> accessible anywhere outside the aspect).
>>
>> Unless you require knowledge about the byte code, the byte code name
>> should not be of concern to you. However, if you do require knowledge
>> about the byte code, please explain what that is and perhaps we can
>> help you.
>>
>> --a
>>
>> On Mon, Nov 2, 2009 at 2:45 PM, db <dbconrado@...> wrote:
>>>
>>> Hi All,
>>>
>>> I have an intertype declaration like this:
>>>
>>> private Integer MyClass.id;
>>>
>>> but, when it was compiled/weaved, this attribute receive the name:
>>> ajc$interField$mypack_mysubpack_MyAspect$id.
>>> I want MyClass receive an id attribute and not a ajc$...$id attribute.
>>> How to do it?
>>>
>>> Thanks!
>>>
>>> PS: Sorry for my poor English. It isn't my native language :).
>>>
>>> _______________________________________________
>>> aspectj-users mailing list
>>> aspectj-users@...
>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>
>>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Intertype declarations results in too long names

2009-11-02T14:38:51Z

Just thought I'd throw in here with a case where I've ran into
problems with this... JPA. If you have common fields you want to
inject into an entity you might try to do something like

private String CommonInterface.commonField

And expect at runtime that will result in a db column named
common_field, or whatever else your naming strategy comes up with.
Sure you could use the @Column annotation and explicitly give it a
name, but that adds in a declare statement and it is definitely a bit
confusing when you first run across the issue. JPA is not the only
framework to do this type of reflection these days, Seam's @In
injection is another one that tries to determine a value based on the
name of the field.

Of course i imagine this was done to avoid naming collisions when you
receive fields from multiple ITDs and I'm not sure I see a better
solution.

On Nov 2, 2009, at 5:03 PM, Andrew Eisenberg wrote:

> Hi,
>
> The ajc$interField$mypack_mysubpack_MyAspect$id is internal and not
> expected to be directly referenced in the source code. It is only
> needed for the byte code (i.e., you should not be concerned with it).
> All you need to know is that the declaration declares an Integer field
> 'id' on MyClass that is private to the aspect (ie- it is not
> accessible anywhere outside the aspect).
>
> Unless you require knowledge about the byte code, the byte code name
> should not be of concern to you. However, if you do require knowledge
> about the byte code, please explain what that is and perhaps we can
> help you.
>
> --a
>
> On Mon, Nov 2, 2009 at 2:45 PM, db <dbconrado@...> wrote:
>> Hi All,
>>
>> I have an intertype declaration like this:
>>
>> private Integer MyClass.id;
>>
>> but, when it was compiled/weaved, this attribute receive the name:
>> ajc$interField$mypack_mysubpack_MyAspect$id.
>> I want MyClass receive an id attribute and not a ajc$...$id
>> attribute.
>> How to do it?
>>
>> Thanks!
>>
>> PS: Sorry for my poor English. It isn't my native language :).
>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
>>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Intertype declarations results in too long names

2009-11-02T14:12:05Z

The name for a public intertype declaration is not mangled - can you
use public in your case?

Andy

2009/11/2 Andrew Eisenberg <andrew@...>:

> Hi,
>
> The ajc$interField$mypack_mysubpack_MyAspect$id is internal and not
> expected to be directly referenced in the source code. It is only
> needed for the byte code (i.e., you should not be concerned with it).
> All you need to know is that the declaration declares an Integer field
> 'id' on MyClass that is private to the aspect (ie- it is not
> accessible anywhere outside the aspect).
>
> Unless you require knowledge about the byte code, the byte code name
> should not be of concern to you. However, if you do require knowledge
> about the byte code, please explain what that is and perhaps we can
> help you.
>
> --a
>
> On Mon, Nov 2, 2009 at 2:45 PM, db <dbconrado@...> wrote:
>> Hi All,
>>
>> I have an intertype declaration like this:
>>
>> private Integer MyClass.id;
>>
>> but, when it was compiled/weaved, this attribute receive the name:
>> ajc$interField$mypack_mysubpack_MyAspect$id.
>> I want MyClass receive an id attribute and not a ajc$...$id attribute.
>> How to do it?
>>
>> Thanks!
>>
>> PS: Sorry for my poor English. It isn't my native language :).
>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
>>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Intertype declarations results in too long names

2009-11-02T14:07:17Z

If you need access to the value, make sure to introduced the getId()
method in your aspect as well:

public Integer YourThingy.getId() { return id; }

-matthew

On Mon, Nov 2, 2009 at 2:03 PM, Andrew Eisenberg <andrew@...> wrote:

> Hi,
>
> The ajc$interField$mypack_mysubpack_MyAspect$id is internal and not
> expected to be directly referenced in the source code. It is only
> needed for the byte code (i.e., you should not be concerned with it).
> All you need to know is that the declaration declares an Integer field
> 'id' on MyClass that is private to the aspect (ie- it is not
> accessible anywhere outside the aspect).
>
> Unless you require knowledge about the byte code, the byte code name
> should not be of concern to you. However, if you do require knowledge
> about the byte code, please explain what that is and perhaps we can
> help you.
>
> --a
>
> On Mon, Nov 2, 2009 at 2:45 PM, db <dbconrado@...> wrote:
>> Hi All,
>>
>> I have an intertype declaration like this:
>>
>> private Integer MyClass.id;
>>
>> but, when it was compiled/weaved, this attribute receive the name:
>> ajc$interField$mypack_mysubpack_MyAspect$id.
>> I want MyClass receive an id attribute and not a ajc$...$id attribute.
>> How to do it?
>>
>> Thanks!
>>
>> PS: Sorry for my poor English. It isn't my native language :).
>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
>>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

--
mailto:matthew@...
skype:matthewadams12
yahoo:matthewadams
aol:matthewadams12
google-talk:matthewadams12@...
msn:matthew@...
http://matthewadams.me
http://www.linkedin.com/in/matthewadams
_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Intertype declarations results in too long names

2009-11-02T14:03:00Z

Hi,

The ajc$interField$mypack_mysubpack_MyAspect$id is internal and not
expected to be directly referenced in the source code. It is only
needed for the byte code (i.e., you should not be concerned with it).
All you need to know is that the declaration declares an Integer field
'id' on MyClass that is private to the aspect (ie- it is not
accessible anywhere outside the aspect).

Unless you require knowledge about the byte code, the byte code name
should not be of concern to you. However, if you do require knowledge
about the byte code, please explain what that is and perhaps we can
help you.

--a

On Mon, Nov 2, 2009 at 2:45 PM, db <dbconrado@...> wrote:

> Hi All,
>
> I have an intertype declaration like this:
>
> private Integer MyClass.id;
>
> but, when it was compiled/weaved, this attribute receive the name:
> ajc$interField$mypack_mysubpack_MyAspect$id.
> I want MyClass receive an id attribute and not a ajc$...$id attribute.
> How to do it?
>
> Thanks!
>
> PS: Sorry for my poor English. It isn't my native language :).
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Intertype declarations results in too long names

2009-11-02T13:45:10Z

Hi All,

I have an intertype declaration like this:

private Integer MyClass.id;

but, when it was compiled/weaved, this attribute receive the name: ajc$interField$mypack_mysubpack_MyAspect$id.
I want MyClass receive an id attribute and not a ajc$...$id attribute.
How to do it?

Thanks!

PS: Sorry for my poor English. It isn't my native language :).

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: FW: NoSuchMethodError: aspectOf()

2009-11-01T17:49:08Z

Hi Roger,

There are three paths to think about with AspectJ:

classpath: for resolving references found in any of the code the
compiler/weaver are processing. This path is not searched for
aspects, and the contents of it are not woven and not copied to the
output folder.
inpath: input .class files for weaving. Contents of this path *are*
woven and *are* copied to the output folder, it is also searched for
aspects.
aspectpath: input aspect .class files for weaving. Contents of this
path are not woven and are not copied to the output folder, but it is
searched for aspects.

Your annotation style aspect is compiled by javac and then passed in
via aspectpath. Unfortunately as I have written above, the contents
of aspect path are not woven - so your aspect is never 'finished off'.

You have a few options:
1) compile the aspect with iajc rather than javac.
2) after compiling with javac, add a step to pass it through iajc to
finish it off.
3) pass it on inpath to your existing iajc call.

Each has pros/cons. (1) you may have written the aspect using
annotations in the first place to avoid using iajc initially. (2) adds
extra compile step to your process. (3) the woven aspect will go into
the output folder. So the aspect class files will be 'mixed up' with
your woven application.

cheers,
Andy

2009/10/31 Roger Huang <rhuang@...>:

> Hi Andy,
>
> Thank you very much for looking at my problem.
>
> Yes I included the aspect in my call to iajc.
>
> Below is a portion of my build.xml (target Pdm.war) and the output of “ant
> Pdm.war”.
>
> Login.java is my aspect expressed in @AspectJ notation.
>
>
>
>             <target name="Pdm.war" depends="prepare">
>
>                         
>
>                         <javac
>
>                                     srcdir   ="${dir.dm}/src"
>
>                                     destdir ="${dir.build}/java/classes">
>
>                                     <classpath>
>
>                                                 <fileset dir="${dir.dm}/lib"
> includes="*.jar"/>
>
>                                                 <fileset
> dir="${dir.dm}/lib/crystal">
>
>                                                             <include
> name="CrystalCommon2.jar"/>
>
>                                                             <include
> name="CrystalReportsRuntime.jar"/>
>
>                                                 </fileset>
>
>                                                 <fileset
> file="${dir.build}/servlet.jar"/>
>
>                                     </classpath>
>
>                         </javac>
>
>
>
>                         
>
>                         <jar
>
>                                     basedir
> ="${dir.build}/java/classes"
>
>
> destfile="${dir.build}/java/DMCoreConcerns.jar"
>
>                         />
>
>
>
>                         
>
>                         <javac
>
>                                     srcdir
> ="${dir.dm}/src-aspects-aspectj"
>
>                                     destdir ="${dir.build}/aspects/classes/"
>
>                                     debug ="true"
>>
>
>                                     <classpath>
>
>                                                 <fileset dir="${log4j.dir}">
>
>                                                             <include
> name="log4j-1.2.8.jar"/>
>
>                                                 </fileset>
>
>                                                 <pathelement
> location="${dir.build}/java/DMCoreConcerns.jar"/>
>
>                                     </classpath>
>
>                         </javac>
>
>                         
>
>                         <jar
>
>                                     basedir
> ="${dir.build}/aspects/classes"
>
>
> destfile="${dir.build}/aspects/DMAspects.jar"
>
>                         />
>
>                         
>
>                         <aspectj:iajc
>
>                                     inpath
> ="${dir.build}/java/classes"
>
>                                     aspectPath
> ="${dir.build}/aspects/DMAspects.jar"
>
>                                     destDir
> ="${dir.build}/WEB-INF/classes"
>
>                                     classpath
> ="${aspectj.lib.dir}/aspectjrt.jar"
>
>                                     source             ="1.5"
>
>                                     XlintFile
> ="${dir.build}/xlint.properties"
>
>                                     verbose           ="true"
>
>                                     showWeaveInfo="true"
>
>                         />
>
>                         
>
>                         <jar jarfile="${dir.dist}/PdmWar/Pdm.war">
>
>                                     <fileset
> dir="${dir.dm}/WebFiles"/>
>
>                                     <zipfileset dir="${dir.dm}/lib"
> prefix="WEB-INF/lib">
>
>                                                 <include name="*.jar"/>
>
>                                                 <include name="*.zip"/>
>
>                                                 <exclude name="sapjco.*"/>
>
>                                     </zipfileset>
>
>                                     <zipfileset
> dir="${dir.dm}/lib/crystal"            prefix="WEB-INF/lib"/>
>
>                                     <zipfileset dir="${dir.dm}/config"
>                  prefix="WEB-INF/classes"/>
>
>                                     <zipfileset dir="${dir.mappingFiles}"
> prefix="WEB-INF/classes">
>
>                                                 <patternset
> refid="bundledMappingFiles"/>
>
>                                                 <include name="DST*.xsd"/>
>
>                                     </zipfileset>
>
>                                     <zipfileset dir="${dir.dm}/PropertyFile"
> prefix="WEB-INF/classes"/>
>
>                                     <zipfileset dir="${dir.dm}/src"
>                        prefix="WEB-INF/classes" includes="**/*.properties"/>
>
>                                     <fileset            dir="${dir.build}"
>                                 includes="WEB-INF/"/>
>
>                                     <fileset
> dir="${dir.build}/aspects"       includes="DMAspects.jar"/>
>
>                                     <zipfileset
> dir="${dir.build}/aspects/classes" prefix="WEB-INF/classes"/>
>
>                         </jar>
>
>             </target>
>
> Buildfile: build.xml
>
>      [echo] Release build for Windows XP.
>
>
>
> init:
>
>
>
> prepare:
>
>
>
> Pdm.war:
>
> [aspectj:iajc] ajc [-d, C:\DataManager\Trunk\build\WEB-INF\classes, -source,
> 1.5, -Xlintfile, C:\DataManager\Trunk\build\xlint.properties, -verbose,
> -showWeaveInfo, -classpath, C:\Program Files\aspectj1.6\lib\aspectjrt.jar,
> -aspectpath, C:\DataManager\Trunk\build\aspects\DMAspects.jar, -inpath,
> C:\DataManager\Trunk\build\java\classes]
>
> [aspectj:iajc] info directory classpath entry does not exist: C:\Program
> Files\Java\jdk1.5.0_20\jre\lib\i18n.jar
>
> [aspectj:iajc] info directory classpath entry does not exist: C:\Program
> Files\Java\jdk1.5.0_20\jre\lib\sunrsasign.jar
>
> [aspectj:iajc] info zipfile classpath entry does not exist: C:\Program
> Files\Java\jdk1.5.0_20\jre\classes
>
> [aspectj:iajc] info Pipelining compilation
>
> [aspectj:iajc] info weaver operating in reweavable mode. Need to verify any
> required types exist.
>
> …
>
>
>
> [aspectj:iajc] weaveinfo Join point
> 'method-call(com.foo.athens.beans.LoginData
> com.foo.athens.dao.LoginDAO.login(com.foo.athens.beans.LoginData))' in Type
> 'com.foo.athens.action.LoginAction' (no debug info available) advised by
> before advice from 'com.foo.logging.Login' (DMAspects.jar!Login.class(from
> Login.java))
>
> [aspectj:iajc] weaveinfo Join point
> 'method-call(com.foo.athens.beans.LoginData
> com.foo.athens.dao.LoginDAO.login(com.foo.athens.beans.LoginData))' in Type
> 'com.foo.athens.action.LoginAction' (no debug info available) advised by
> after advice from 'com.foo.logging.Login' (DMAspects.jar!Login.class(from
> Login.java))
>
> [aspectj:iajc] weaveinfo Join point
> 'method-call(com.foo.athens.beans.LoginData
> com.foo.athens.dao.LoginDAO.login(com.foo.athens.beans.LoginData))' in Type
> 'com.foo.athens.action.LoginAction' (no debug info available) advised by
> afterThrowing advice from 'com.foo.logging.Login'
> (DMAspects.jar!Login.class(from Login.java))
>
> [aspectj:iajc] info woven class com.foo.athens.action.LoginAction (from
> C:\DataManager\Trunk\build\java\classes\com\foo\athens\action\LoginAction.class)
>
> …
>
> [aspectj:iajc] info Compiler took 3813ms
>
> [jar] Building jar: C:\DataManager\Trunk\Install\DataManager\PdmWar\Pdm.war
>
>
>
> BUILD SUCCESSFUL
>
> Total time: 9 seconds
>
>
>
>
>
> Thanks,
>
> Roger Huang
>
>
>
> -----Original Message-----
> From: aspectj-users-bounces@...
> [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
> Sent: Friday, October 30, 2009 5:32 PM
> To: aspectj-users@...
> Subject: Re: [aspectj-users] FW: NoSuchMethodError: aspectOf()
>
>
>
> Hi Roger,
>
>
>
> Are you definetly including the aspect itself in the call to iajc?
>
> Annotation style aspects (when @Pointcut/etc are used) can be compiled
>
> with javac, but they must be given to the weaver at some point in
>
> order for the missing methods to be added - for example 'aspectOf()'.
>
>
>
> cheers,
>
> Andy
>
>
>
> 2009/10/30 Roger Huang <rhuang@...>:
>
>> Any ideas why I am get the NoSuchMethodError below?
>
>>
>
>>
>
>>
>
>> The method specified by the pointcut is in
>
>> com.foo.action.LoginAction.execute.
>
>>
>
>> The aspect is defined in com.foo.logging.Login.   (see below)
>
>>
>
>> My code which is being advised does not call the aspect’s aspectOf()
>> method.
>
>>
>
>>
>
>>
>
>> I use build-time bytecode weaving using the ant <iajc> task.
>
>>
>
>>
>
>>
>
>> The app is a Struts-based web app.
>
>>
>
>>
>
>>
>
>>
>
>>
>
>> Dev environment:
>
>>
>
>> Java 1.5
>
>>
>
>> Ant 1.7.1
>
>>
>
>> AspectJ 1.6.6
>
>>
>
>>
>
>>
>
>> Thanks,
>
>>
>
>> Roger
>
>>
>
>>
>
>>
>
>>
>
>>
>
>> javax.servlet.ServletException: Servlet execution threw an exception
>
>>
>
>>         com.hyperformix.athens.filter.AthensLoginFilter.doFilter(Unknown
>
>> Source)
>
>>
>
>> root cause
>
>>
>
>> java.lang.NoSuchMethodError:
>
>> com.foo.logging.Login.aspectOf()Lcom/foo/logging/Login;
>
>>
>
>>         com.foo.action.LoginAction.execute(Unknown Source)
>
>>
>
>>
>
>>
>> org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)
>
>>
>
>>
>
>>
>> org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)
>
>>
>
>>
>
>> org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)
>
>>
>
>>
>
>> org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:415)
>
>>
>
>>         javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
>
>>
>
>>         javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
>
>>
>
>>         com.foo.athens.filter.AthensLoginFilter.doFilter(Unknown Source)
>
>>
>
>>
>
>>
>
>>
>
>>
>
>>
>
>>
>
>>
>
>>
>
>> @Aspect
>
>>
>
>> public class Login {
>
>>
>
>>
>
>>
>
>>                 static Logger log =
>> Logger.getLogger(Login.class.getName());
>
>>
>
>>                 String userName;
>
>>
>
>>                 String roleName;
>
>>
>
>>
>
>>
>
>>                 @Pointcut("call (* com.foo.LoginDAO.login(com.foo. Data) )
>
>> && args(data)")
>
>>
>
>>                 public void login(Data data) {}
>
>>
>
>>
>
>>
>
>>                 @Before("login(data)")
>
>>
>
>>                 public void loginBefore(Data data)
>
>>
>
>>                 {
>
>>
>
>>                                 userName = data.getUserName();
>
>>
>
>>                                 roleName = data.getRoleName();
>
>>
>
>>                                 BasicConfigurator.configure();
>
>>
>
>>                                 log.info("User " + userName + " with role
>> "
>
>> + roleName + " about to login");
>
>>
>
>>                 }
>
>>
>
>>
>
>>
>
>> }
>
>>
>
>> Roger Huang
>
>>
>
>>
>
>>
>
>> _______________________________________________
>
>> aspectj-users mailing list
>
>> aspectj-users@...
>
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
>>
>
>>
>
> _______________________________________________
>
> aspectj-users mailing list
>
> aspectj-users@...
>
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

RE: FW: NoSuchMethodError: aspectOf()

2009-10-31T11:58:44Z

Hi Andy,

Thank you very much for looking at my problem.

Yes I included the aspect in my call to iajc.

Below is a portion of my build.xml (target Pdm.war) and the output of “ant Pdm.war”.

<javac

srcdir ="${dir.dm}/src"

destdir ="${dir.build}/java/classes">

</fileset>

</classpath>

</javac>

<jar

basedir ="${dir.build}/java/classes"

destfile="${dir.build}/java/DMCoreConcerns.jar"

<javac

srcdir ="${dir.dm}/src-aspects-aspectj"

destdir ="${dir.build}/aspects/classes/"

debug ="true" >

</fileset>

</classpath>

</javac>

<jar

basedir ="${dir.build}/aspects/classes"

destfile="${dir.build}/aspects/DMAspects.jar"

<aspectj:iajc

inpath ="${dir.build}/java/classes"

aspectPath ="${dir.build}/aspects/DMAspects.jar"

destDir ="${dir.build}/WEB-INF/classes"

classpath ="${aspectj.lib.dir}/aspectjrt.jar"

source ="1.5"

XlintFile ="${dir.build}/xlint.properties"

verbose ="true"

showWeaveInfo="true"

</zipfileset>

</zipfileset>

</jar>

</target>

Buildfile: build.xml

[echo] Release build for Windows XP.

init:

prepare:

Pdm.war:

[aspectj:iajc] ajc [-d, C:\DataManager\Trunk\build\WEB-INF\classes, -source, 1.5, -Xlintfile, C:\DataManager\Trunk\build\xlint.properties, -verbose, -showWeaveInfo, -classpath, C:\Program Files\aspectj1.6\lib\aspectjrt.jar, -aspectpath, C:\DataManager\Trunk\build\aspects\DMAspects.jar, -inpath, C:\DataManager\Trunk\build\java\classes]

[aspectj:iajc] info directory classpath entry does not exist: C:\Program Files\Java\jdk1.5.0_20\jre\lib\i18n.jar

[aspectj:iajc] info directory classpath entry does not exist: C:\Program Files\Java\jdk1.5.0_20\jre\lib\sunrsasign.jar

[aspectj:iajc] info zipfile classpath entry does not exist: C:\Program Files\Java\jdk1.5.0_20\jre\classes

[aspectj:iajc] info Pipelining compilation

[aspectj:iajc] info weaver operating in reweavable mode. Need to verify any required types exist.

…

[aspectj:iajc] weaveinfo Join point 'method-call(com.foo.athens.beans.LoginData com.foo.athens.dao.LoginDAO.login(com.foo.athens.beans.LoginData))' in Type 'com.foo.athens.action.LoginAction' (no debug info available) advised by before advice from 'com.foo.logging.Login' (DMAspects.jar!Login.class(from Login.java))

[aspectj:iajc] weaveinfo Join point 'method-call(com.foo.athens.beans.LoginData com.foo.athens.dao.LoginDAO.login(com.foo.athens.beans.LoginData))' in Type 'com.foo.athens.action.LoginAction' (no debug info available) advised by after advice from 'com.foo.logging.Login' (DMAspects.jar!Login.class(from Login.java))

[aspectj:iajc] weaveinfo Join point 'method-call(com.foo.athens.beans.LoginData com.foo.athens.dao.LoginDAO.login(com.foo.athens.beans.LoginData))' in Type 'com.foo.athens.action.LoginAction' (no debug info available) advised by afterThrowing advice from 'com.foo.logging.Login' (DMAspects.jar!Login.class(from Login.java))

[aspectj:iajc] info woven class com.foo.athens.action.LoginAction (from C:\DataManager\Trunk\build\java\classes\com\foo\athens\action\LoginAction.class)

…

[aspectj:iajc] info Compiler took 3813ms

[jar] Building jar: C:\DataManager\Trunk\Install\DataManager\PdmWar\Pdm.war

BUILD SUCCESSFUL

Total time: 9 seconds

Thanks,

Roger Huang

-----Original Message-----
From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
Sent: Friday, October 30, 2009 5:32 PM
To: aspectj-users@...
Subject: Re: [aspectj-users] FW: NoSuchMethodError: aspectOf()

Hi Roger,

Are you definetly including the aspect itself in the call to iajc?

Annotation style aspects (when @Pointcut/etc are used) can be compiled

with javac, but they must be given to the weaver at some point in

order for the missing methods to be added - for example 'aspectOf()'.

cheers,

Andy

2009/10/30 Roger Huang <rhuang@...>:

> Any ideas why I am get the NoSuchMethodError below?

> The method specified by the pointcut is in

> com.foo.action.LoginAction.execute.

> The aspect is defined in com.foo.logging.Login. (see below)

> My code which is being advised does not call the aspect’s aspectOf() method.

> I use build-time bytecode weaving using the ant <iajc> task.

> The app is a Struts-based web app.

> Dev environment:

> Java 1.5

> Ant 1.7.1

> AspectJ 1.6.6

> Thanks,

> Roger

> javax.servlet.ServletException: Servlet execution threw an exception

> com.hyperformix.athens.filter.AthensLoginFilter.doFilter(Unknown

> Source)

> root cause

> java.lang.NoSuchMethodError:

> com.foo.logging.Login.aspectOf()Lcom/foo/logging/Login;

> com.foo.action.LoginAction.execute(Unknown Source)

> org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)

> org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)

> org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)

> org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:415)

> javax.servlet.http.HttpServlet.service(HttpServlet.java:710)

> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

> com.foo.athens.filter.AthensLoginFilter.doFilter(Unknown Source)

> @Aspect

> public class Login {

> static Logger log = Logger.getLogger(Login.class.getName());

> String userName;

> String roleName;

> @Pointcut("call (* com.foo.LoginDAO.login(com.foo. Data) )

> && args(data)")

> public void login(Data data) {}

> @Before("login(data)")

> public void loginBefore(Data data)

> {

> userName = data.getUserName();

> roleName = data.getRoleName();

> BasicConfigurator.configure();

> log.info("User " + userName + " with role "

> + roleName + " about to login");

> }

> Roger Huang

> _______________________________________________

> aspectj-users mailing list

> aspectj-users@...

> https://dev.eclipse.org/mailman/listinfo/aspectj-users

_______________________________________________

aspectj-users mailing list

aspectj-users@...

https://dev.eclipse.org/mailman/listinfo/aspectj-users

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: FW: NoSuchMethodError: aspectOf()

2009-10-30T15:31:48Z

Hi Roger,

Are you definetly including the aspect itself in the call to iajc?
Annotation style aspects (when @Pointcut/etc are used) can be compiled
with javac, but they must be given to the weaver at some point in
order for the missing methods to be added - for example 'aspectOf()'.

cheers,
Andy

2009/10/30 Roger Huang <rhuang@...>:

> Any ideas why I am get the NoSuchMethodError below?
>
>
>
> The method specified by the pointcut is in
> com.foo.action.LoginAction.execute.
>
> The aspect is defined in com.foo.logging.Login.   (see below)
>
> My code which is being advised does not call the aspect’s aspectOf() method.
>
>
>
> I use build-time bytecode weaving using the ant <iajc> task.
>
>
>
> The app is a Struts-based web app.
>
>
>
>
>
> Dev environment:
>
> Java 1.5
>
> Ant 1.7.1
>
> AspectJ 1.6.6
>
>
>
> Thanks,
>
> Roger
>
>
>
>
>
> javax.servlet.ServletException: Servlet execution threw an exception
>
>         com.hyperformix.athens.filter.AthensLoginFilter.doFilter(Unknown
> Source)
>
> root cause
>
> java.lang.NoSuchMethodError:
> com.foo.logging.Login.aspectOf()Lcom/foo/logging/Login;
>
>         com.foo.action.LoginAction.execute(Unknown Source)
>
>
> org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)
>
>
> org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)
>
>
> org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)
>
>
> org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:415)
>
>         javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
>
>         javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
>
>         com.foo.athens.filter.AthensLoginFilter.doFilter(Unknown Source)
>
>
>
>
>
>
>
>
>
> @Aspect
>
> public class Login {
>
>
>
>                 static Logger log = Logger.getLogger(Login.class.getName());
>
>                 String userName;
>
>                 String roleName;
>
>
>
>                 @Pointcut("call (* com.foo.LoginDAO.login(com.foo. Data) )
> && args(data)")
>
>                 public void login(Data data) {}
>
>
>
>                 @Before("login(data)")
>
>                 public void loginBefore(Data data)
>
>                 {
>
>                                 userName = data.getUserName();
>
>                                 roleName = data.getRoleName();
>
>                                 BasicConfigurator.configure();
>
>                                 log.info("User " + userName + " with role "
> + roleName + " about to login");
>
>                 }
>
>
>
> }
>
> Roger Huang
>
>
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

FW: NoSuchMethodError: aspectOf()

2009-10-30T15:17:18Z

Any ideas why I am get the NoSuchMethodError below?

The method specified by the pointcut is in com.foo.action.LoginAction.execute.

The aspect is defined in com.foo.logging.Login. (see below)

My code which is being advised does not call the aspect’s aspectOf() method.

I use build-time bytecode weaving using the ant <iajc> task.

The app is a Struts-based web app.

Dev environment:

Java 1.5

Ant 1.7.1

AspectJ 1.6.6

Thanks,

Roger

javax.servlet.ServletException: Servlet execution threw an exception

com.hyperformix.athens.filter.AthensLoginFilter.doFilter(Unknown Source)

root cause

java.lang.NoSuchMethodError: com.foo.logging.Login.aspectOf()Lcom/foo/logging/Login;

com.foo.action.LoginAction.execute(Unknown Source)

org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:421)

org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:226)

org.apache.struts.action.ActionServlet.process(ActionServlet.java:1164)

org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:415)

javax.servlet.http.HttpServlet.service(HttpServlet.java:710)

javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

com.foo.athens.filter.AthensLoginFilter.doFilter(Unknown Source)

@Aspect

public class Login {

static Logger log = Logger.getLogger(Login.class.getName());

String userName;

String roleName;

@Pointcut("call (* com.foo.LoginDAO.login(com.foo. Data) ) && args(data)")

public void login(Data data) {}

@Before("login(data)")

public void loginBefore(Data data)

{

userName = data.getUserName();

roleName = data.getRoleName();

BasicConfigurator.configure();

log.info("User " + userName + " with role " + roleName + " about to login");

}

Roger Huang

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Constructor ITD question: introduce no-arg ctor instead of letting JDO/JPA enhancer do it?

2009-10-28T08:05:37Z

Hi Simone,

I'm aware of the fact that you can't use type patterns when declaring
an ITD. I had already tried injecting a no-arg constructor to a
marker interface and using declare parents, and that didn't work. The
aspect I tried is:

import javax.persistence.Entity;
public aspect NoArgConstructorMixin {
public static interface HasNoArgConstructor {}
declare parents : ((@Entity *)) implements HasNoArgConstructor;
public HasNoArgConstructor.new() {}
}

The ajc compiler error is:
error at public HasNoArgConstructor.new() {}
^^^^^^^^^^^^^^^^^^^^^^^
C:\dev\svnrepos\itsj\linx2\trunk\case\case-model\src\main\aspect\org\piercecountywa\linx\casemanagement\model\aspects\NoArgConstructorMixin.aj:11:0::0
can't define constructors on interfaces

This is what I expect -- constructors don't make sense on interfaces.
Am I doing something wrong in the definition of the aspect?

I've also confirmed that it's not an OpenJPA enhancer error, because
the field initialization code is not placed into the introduced class;
it's in the aspect. If ajc were to introduce the field **with its
initialization code**, it would work. If we manually add a no-arg
constructor then decompile the class, we can see ajc's post-construct
after advice that initialized the introduced fields.

Thanks,
Matthew

On Wed, Oct 28, 2009 at 6:18 AM, Simone Gianni <simoneg@...> wrote:

> Hi Matthew,
>
>
> Matthew Adams wrote:
>>
>> =====================
>> // DOES NOT COMPILE
>> public aspect NoArgConstructorMixin {
>> public ((@Entity *) && !hasmethod(* new())).new() { // can't
>> introduce constructors with this syntax
>> // how do I ensure fields are initialized in here? call super()?
>> }
>> }
>> =====================
>>
>
> you cannot use type patterns when declaring an ITD. The syntax of ITD
> expects a simple type, not a pattern.
>
> So you can write :
>
> public String SomeClass.toString() { ... }
>
> But you cannot write :
>
> public String ((@Entity *)).toString() { ... }
>
> Instead you have to do as you have already done with the Intro interface :
> declare an empty marker interface, then tell AspectJ to inject methods to
> that interface, then use declare parents to place the interface using a type
> pattern.
>
> You should be able to declare also constructors this way.
>
> I'm also using ApsectJ + OpenJPA enhancer, and I'm not facing the problem
> this problem, but probably I don't have fields initialized calling a static
> method. Since OpenJPA enhances the class AFTER ajc (for me too), it should
> see all the fields and methods that ajc has added to the entity classes
> correctly (it surely does for property).
>
> If the OpenJPA introduced constructor does not take into account the fields
> added by AspectJ then maybe you're hitting a bug in the OpenJPA enhancer.
>
> Hope this helps,
> Simone
>
> --
> Simone Gianni CEO Semeru s.r.l. Apache Committer
> http://www.simonegianni.it/
>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

Re: Constructor ITD question: introduce no-arg ctor instead of letting JDO/JPA enhancer do it?

2009-10-28T06:18:48Z

Hi Matthew,

Matthew Adams wrote:

> =====================
> // DOES NOT COMPILE
> public aspect NoArgConstructorMixin {
> public ((@Entity *) && !hasmethod(* new())).new() { // can't
> introduce constructors with this syntax
> // how do I ensure fields are initialized in here? call super()?
> }
> }
> =====================
>

you cannot use type patterns when declaring an ITD. The syntax of ITD
expects a simple type, not a pattern.

So you can write :

public String SomeClass.toString() { ... }

But you cannot write :

public String ((@Entity *)).toString() { ... }

Instead you have to do as you have already done with the Intro interface
: declare an empty marker interface, then tell AspectJ to inject methods
to that interface, then use declare parents to place the interface using
a type pattern.

You should be able to declare also constructors this way.

I'm also using ApsectJ + OpenJPA enhancer, and I'm not facing the
problem this problem, but probably I don't have fields initialized
calling a static method. Since OpenJPA enhances the class AFTER ajc (for
me too), it should see all the fields and methods that ajc has added to
the entity classes correctly (it surely does for property).

If the OpenJPA introduced constructor does not take into account the
fields added by AspectJ then maybe you're hitting a bug in the OpenJPA
enhancer.

Hope this helps,
Simone

--
Simone Gianni CEO Semeru s.r.l. Apache Committer
http://www.simonegianni.it/

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: Mixin not recognized

2009-10-28T06:07:07Z

Hi Simeon,
it seems like Eclipse is opening your aspect with the plain Java editor
instead of the AspectJ editor. I usually use .aj extension for aspects
to have Eclipse open them with the right editor. Otherwise, right click
on the file and select the AspectJ editor to open the file.

The fact that errors does not appear in the problems view is because
Eclipse uses two different approaches for finding errors : one is based
on builders, and is what the problems view and the package explorer
decorations report, which are reported during project build; the other
is the inline editor problems, that are computed as you type. In this
case, there are no "real" errors, so the AspectJ builder does not report
any error to the problem view, but the editor is the java one and does
not understands AspectJ syntax, reporting these "inline" errors.

Hope this helps,
Simone

Leyzerzon, Simeon wrote:

> I'm trying to create a mixin inside an AJ project in MyEclipse:
>
> public interface IDaoMixin {
>
> public static aspect Impl {
> ....
> }
>
> public void setJdbcTemplate(JdbcTemplate template);
>
> }
>
> and it gives me the following:
>
> Multiple markers at this line
> - Syntax error on token "aspect", class
> expected
> - aspect cannot be resolved to a type
> - The interface IDaoMixin cannot define an
> initializer
>
> What ccould be a problem here? What's interesting, is that the Problems view in Eclipse doesn't register a problem, it only appears inside the editor.
>
> Here's the .project file:
>
> <?xml version="1.0" encoding="UTF-8"?>
> <projectDescription>
> <name>GlobalMarketAnalytics</name>
> <comment></comment>
> <projects>
> </projects>
> <buildSpec>
> <buildCommand>
> <name>org.eclipse.ajdt.core.ajbuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>com.genuitec.eclipse.ast.deploy.core.DeploymentBuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> <buildCommand>
> <name>com.genuitec.eclipse.springframework.springbuilder</name>
> <arguments>
> </arguments>
> </buildCommand>
> </buildSpec>
> <natures>
> <nature>org.eclipse.ajdt.ui.ajnature</nature>
> <nature>com.genuitec.eclipse.springframework.springnature</nature>
> <nature>com.genuitec.eclipse.ast.deploy.core.deploymentnature</nature>
> <nature>org.eclipse.jdt.core.javanature</nature>
> </natures>
> </projectDescription>
>
> Thank you in advance.
> Simeon
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

Mixin not recognized

2009-10-27T19:41:45Z

I'm trying to create a mixin inside an AJ project in MyEclipse:

public interface IDaoMixin {

public static aspect Impl {
....
}

public void setJdbcTemplate(JdbcTemplate template);

}

and it gives me the following:

Multiple markers at this line
- Syntax error on token "aspect", class
expected
- aspect cannot be resolved to a type
- The interface IDaoMixin cannot define an
initializer

What ccould be a problem here? What's interesting, is that the Problems view in Eclipse doesn't register a problem, it only appears inside the editor.

Here's the .project file:

<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
<name>GlobalMarketAnalytics</name>
<comment></comment>
<projects>
</projects>
<buildSpec>
<buildCommand>
<name>org.eclipse.ajdt.core.ajbuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>com.genuitec.eclipse.ast.deploy.core.DeploymentBuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>com.genuitec.eclipse.springframework.springbuilder</name>
<arguments>
</arguments>
</buildCommand>
</buildSpec>
<natures>
<nature>org.eclipse.ajdt.ui.ajnature</nature>
<nature>com.genuitec.eclipse.springframework.springnature</nature>
<nature>com.genuitec.eclipse.ast.deploy.core.deploymentnature</nature>
<nature>org.eclipse.jdt.core.javanature</nature>
</natures>
</projectDescription>

Thank you in advance.
Simeon
_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

RE: declare @method syntax - is composite signature allowed??

2009-10-27T18:55:19Z

To anwser your question:

>> public * *..I*Dao+.getSql*(..) != public * *..I*Dao+.getSql(..).

> seems odd. I wonder what set of join points are matched by each variant and how they overlap.

These are the join points for each individual declaration:

1. declare @method: public * *..I*Dao+.set*(..): @NonCacheable;

SavingsDao.setSql1(String)
SavingsDao.setSql2(String)
SavingsDao.setSql3(String)
SavingsDao.setSql4(String)
SavingsDao.setSql5(String)
SavingsDao.setSql6(String)
SavingsDao.setSql7(String)
SavingsBaseDao.setJdbcTemplate(JdbcTemplate)
SavingsBaseDao.setSql(String)
IGmaMbrChartDao.setSql(String)
IGmaFilterDao.setSql(String)
GmaMbrDao.setSql(String)
GmaMbrChartDao.setSql(String)
GmaHeadCountReportDao.setSql(String)
GmaFilterDao.setSql(String)
GmaFilterDao.setData(IDataBuffer)
DetailsSummaryGmaDao.setSql1(String)
ExpenseDao.setSql1(String)
ExpenseDao.setSql2(String)
ExpenseDao.setSql3(String)
ExpenseDao.setSql4(String)
ExpenseDao.setSql5(String)
ExpenseBaseDao.setJdbcTemplate(JdbcTemplate)
ExpenseBaseDao.setSql(String)

2. declare @method: public * *..I*Dao+.getSql*(..): @NonCacheable;

ExpenseDao.getSql1()
ExpenseDao.getSql2()
ExpenseDao.getSql3()
ExpenseDao.getSql4()
ExpenseDao.getSql5()

3. declare @method: public * *..I*Dao+.getSql(..): @NonCacheable;

SavingsBaseDao.getSql()
IGmaMbrChartDao.getSql()
GmaMbrDao.getSql()
GmaMbrChartDao.getSql()
GmaHeadCountReportDao.getSql()
GmaFilterDao.getSql()
ExpenseBaseDao.getSql()

4. declare @method: public * *..I*Dao+.getJdbc*(..): @NonCacheable;

SavingsBaseDao.getJdbcTemplate()
ExpenseBaseDao.getJdbcTemplate()

5. declare @method: !@NonCacheable public * *..I*Dao+.*(..):
@Cacheable(modelId="fooModel");

SavingsDao.getSavingsChartDataBuffer(String,String,String,String,String,String,String)
SavingsDao.getDAPGridDataBuffer(String,String,String,String,String,String,String)
ISavingsDao.getSavingsChartDataBuffer(String,String,String,String,String,String,String)
ISavingsDao.getDAPGridDataBuffer(String,String,String,String,String,String,String)
SummaryGmaDao.getSummaryDatagridsDaoBuffer(String,String,String,String,String,String,String,String)
ISummaryGmaDao.getSummaryDatagridsDaoBuffer(String,String,String,String,String,String,String,String)
IGmaMbrReportDao.getMBRReportDataBuffer(MBRReportObject)
IGmaMbrReportDao.isMBRReportExist(MBRReportObject)
IGmaMbrReportDao.deleteMBRReport(MBRReportObject)
IGmaMbrReportDao.insertMBRReport(MBRReportObject)
IGmaMbrDao.getGmaExpenseMbrDataBuffer(String,String,String,String,String,String,String,String)
IGmaMbrChartDao.getGmaExpenseMbrDataBuffer(String,String,String,String,String,String,String,String,String,String,String,String)
IGmaMbrChartDao.getGmaExpenseMbrMetaDataBuffer(String,String,String,String,String,String,String,String,String,String,String,String)
IGmaHeadCountReportDao.getHeadCountReportDataBuffer(HeadCountReportObject)
IGmaHeadCountReportDao.isHeadCountReportExist(HeadCountReportObject)
IGmaHeadCountReportDao.deleteHeadCountReport(HeadCountReportObject)
IGmaHeadCountReportDao.insertHeadCountReport(HeadCountReportObject)
IGmaFilterDao.getGmaFilterDataBuffer(String,String,String,String,String,String)
IGmaChartFilterDao.getGmaChartFilterDataBuffer(String,String,String)
IGmaChartFilterDao.getHCChartsDaoBuffer(String,String,String,String,String,String,String,String)
IGmaChartFilterDao.getHCLineChartsDaoBuffer(String,String,String,String,String,String,String,String)
IGmaChartFilterDao.getRegionDrillChartsDaoBuffer(String,String,String,String,String,String,String,String)
IGmaChartFilterDao.getRegionTrendDrillChartsDaoBuffer(String,String,String,String,String,String,String,String)
IExecutiveSummaryGmaDao.getExecutiveSummaryDatagridsDaoBuffer(String,String,String,String,String,String,String,String)
IDetailsSummaryGmaDao.getDetailsSummaryGridDaoBuffer(String,String,String,int,int,String,String,String,String,String,String,String)
GmaMbrReportDao.getMBRReportDataBuffer(MBRReportObject)
GmaMbrReportDao.isMBRReportExist(MBRReportObject)
GmaMbrReportDao.deleteMBRReport(MBRReportObject)
GmaMbrReportDao.insertMBRReport(MBRReportObject)
GmaMbrDao.getGmaExpenseMbrDataBuffer(String,String,String,String,String,String,String,String)
GmaMbrChartDao.getGmaExpenseMbrDataBuffer(String,String,String,String,String,String,String,String,String,String,String,String)
GmaMbrChartDao.getGmaExpenseMbrMetaDataBuffer(String,String,String,String,String,String,String,String,String,String,String,String)
GmaHeadCountReportDao.deleteHeadCountReport(HeadCountReportObject)
GmaHeadCountReportDao.getHeadCountReportDataBuffer(HeadCountReportObject)
GmaHeadCountReportDao.insertHeadCountReport(HeadCountReportObject)
GmaHeadCountReportDao.isHeadCountReportExist(HeadCountReportObject)
GmaFilterDao.getGmaFilterDataBuffer(String,String,String,String,String,String)
GmaChartFilterDao.getGmaChartFilterDataBuffer(String,String,String)
GmaChartFilterDao.getHCChartsDaoBuffer(String,String,String,String,String,String,String,String)
GmaChartFilterDao.getHCLineChartsDaoBuffer(String,String,String,String,String,String,String,String)
GmaChartFilterDao.getRegionDrillChartsDaoBuffer(String,String,String,String,String,String,String,String)
GmaChartFilterDao.getRegionTrendDrillChartsDaoBuffer(String,String,String,String,String,String,String,String)
FooGmaDao.getExecutiveSummaryDatagridsDaoBuffer(String,String,String,String,String,String,String,String)
ExecutiveSummaryGmaDao.getExecutiveSummaryDatagridsDaoBuffer(String,String,String,String,String,String,String,String)
DetailsSummaryGmaDao.getDetailsSummaryGridDaoBuffer(String,String,String,int,int,String,String,String,String,String,String,String)
IExpenseDao.getExpenseChartDataBuffer(String,String,String,String,String,String)
IExpenseDao.getExpenseTreeGridDataBuffer(String,String,String,String,String,String,int)
IExpenseDao.getExpensePopUpGridDataBuffer(String,String,String,String,String,int,int,String,String)
IExpenseDao.getExpenseDetailGridDataBuffer(String,String,String,String,String,int,int)
IExpenseDao.getExpenseFilterDataBuffer(String)
ExpenseDao.getExpenseFilterDataBuffer(String)
ExpenseDao.getExpenseChartDataBuffer(String,String,String,String,String,String)
ExpenseDao.getExpenseTreeGridDataBuffer(String,String,String,String,String,String,int)
ExpenseDao.getExpensePopUpGridDataBuffer(String,String,String,String,String,int,int,String,String)
ExpenseDao.getExpenseDetailGridDataBuffer(String,String,String,String,String,int,int)

Simeon

-----Original Message-----
From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Leyzerzon, Simeon [ICG-IT]
Sent: Tuesday, October 27, 2009 5:17 PM
To: 'aspectj-users@...'
Subject: RE: [aspectj-users] declare @method syntax - is composite signature allowed??

It would be easier to investigate if each of the declaration allowed for some identifier, otherwise they look the same in Eclipse AJDT. Apologies in advance if this already exists and I'm just anaware of it, this is really my first stab in the new territory. I could create a sample project and perhaps post it if that'd help looking into what's going on. What'd you suggest?

Once again, appreciate your help!!
Simeon

-----Original Message-----
From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
Sent: Tuesday, October 27, 2009 3:44 PM
To: aspectj-users@...
Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??

The algorithm used in situations like this is a kind of iterate to a fixed point - starting with what you specify. However I doubt we make guarantees if the declare @methods interact with each other and are specified in different source aspects.

> public * *..I*Dao+.getSql*(..) != public * *..I*Dao+.getSql(..).

seems odd. I wonder what set of join points are matched by each variant and how they overlap.

Andy

2009/10/27 Leyzerzon, Simeon <simeon.leyzerzon@...>:

> Ah, looks like the following properly excludes the getSql() calls:
>
> public aspect CachingIntroduction {
>
> declare @method: public * *..I*Dao+.set*(..): @NonCacheable;
> declare @method: public * *..I*Dao+.getSql*(..): @NonCacheable;
> declare @method: public * *..I*Dao+.getSql(..): @NonCacheable;
> declare @method: !@NonCacheable public * *..I*Dao+.*(..):
> @Cacheable(modelId="fooModel");
>
> }
>
> so apparently in this case public * *..I*Dao+.getSql*(..) != public * *..I*Dao+.getSql(..).
>
> I'm not sure it's by design on not ;)
>
> Thanks,
> Simeon
>
> -----Original Message-----
> From: aspectj-users-bounces@...
> [mailto:aspectj-users-bounces@...] On Behalf Of Leyzerzon,
> Simeon [ICG-IT]
> Sent: Tuesday, October 27, 2009 2:55 PM
> To: 'aspectj-users@...'
> Subject: RE: [aspectj-users] declare @method syntax - is composite signature allowed??
>
> Andy,
>
> No, I haven't defined another marker interface as you correctly spotted so that's what was breaking it. So NPE is gone, my bad.
>
> But now, after the following aspect:
>
> public aspect CachingIntroduction {
>
> declare @method: public * *..I*Dao+.set*(..): @NonCacheable;
> declare @method: public * *..I*Dao+.getSql*(..): @NonCacheable;
> declare @method: !@NonCacheable public * *..I*Dao+.*(..):
> @Cacheable(modelId="fooModel");
>
> }
>
> is applied to something like this class:
>
>
> public class ExpenseBaseDao implements IGmaBaseDao {
>
> ...
>
> public String getSql() {
> return sql;
> }
> ...
> }
>
> in the CrossRef view I'm seeing
>
>
>
> both for getSql:
>
> CachingIntroduction.declare @method:
> !@com.citi.gdos.smart.applib.service.cache.NonCacheable public *
> *..I*Dao+.*(..) : @Cacheable(modelId = "fooModel")
> CachingIntroduction.declare @method: public *
> *..I*Dao+.getSql*(..) : @NonCacheable
>
> Does it mean getSql() is annotated as both @Cacheable and @NonCacheable, could I apply some precedence here?
>
> Thanks,
> Simeon
>
> -----Original Message-----
> From: aspectj-users-bounces@...
> [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
> Sent: Tuesday, October 27, 2009 11:29 AM
> To: aspectj-users@...
> Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??
>
> Hey,
>
> Any NPE from the compiler is a bug. I presume you have defined the
> Setter annotation? (ie. it must exist as a definition in order to
> succeed)
>
> I raised this problem as
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=293457
>
> Due to it failing in the hierarchy building code, it may behave better on the command line where the model does not get constructed.
>
> cheers,
> Andy
>
> 2009/10/27 Leyzerzon, Simeon <simeon.leyzerzon@...>:
>> Hi Andy,
>>
>> Thanks for responding. I tried the approach you are suggesting, unfortunately I'm getting the following:
>>
>> java.lang.NullPointerException
>> at
>> org.aspectj.ajdt.internal.core.builder.AsmHierarchyBuilder.visit(AsmH
>> i
>> erarchyBuilder.java:548) at
>> org.aspectj.org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.t
>> r
>> averse(MethodDeclaration.java:214)
>> at
>> org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.tra
>> v
>> erse(TypeDeclaration.java:1246) at
>> org.aspectj.org.eclipse.jdt.internal.compiler.ast.CompilationUnitDecl
>> a ration.traverse(Compilatio ... oBuildJob.run(AutoBuildJob.java:238)
>> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
>>
>> Compile error: NullPointerException thrown: null
>>
>>
>> Here's the aspect I'm using:
>>
>> package com.citi.gdos.smart.applib.service.cache;
>>
>> import org.springmodules.cache.annotations.Cacheable;
>>
>> public aspect CachingIntroduction {
>>
>> declare @method: public * *..I*Dao+.set*(..): @Setter; declare @method: !@Setter public * *..I*Dao+.*(..):
>> @Cacheable(modelId="fooModel");
>>
>> }
>>
>>
>> Am I doing something wrong? Do I need a nightly build perhaps for this to work?
>>
>> Thanks,
>> Simeon
>>
>> -----Original Message-----
>> From: aspectj-users-bounces@...
>> [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
>> Sent: Tuesday, October 27, 2009 9:58 AM
>> To: aspectj-users@...
>> Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??
>>
>> Hi Simeon,
>>
>> This restriction you've uncovered was actually only recently raised as this enhancement:
>>
>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=287613
>>
>> To support it I need to change the serialized form of the attributes - I try not to do this often but for other reasons (optimization) I may be changing the format in 1.6.7 so I will be looking at it in that timeframe.
>>
>>> declare @method :
>>> public * *..I*Dao+.*(..) && !public * *..I*Dao+.set*(..):
>>> @Cacheable(modelId="fooModel");
>>
>> a clunky approach might be:
>>
>> declare @method: public * *..I*Dao+.set*(..): @Setter; declare @method: !@Setter public * *..I*Dao+.*(..):
>> @Cacheable(modelId="fooModel");
>>
>> but I know that's not great...
>>
>> Andy
>>
>> 2009/10/26 Leyzerzon, Simeon <simeon.leyzerzon@...>:
>>> I have a hierarchy of DAO classes into which I'm introducing an @Cacheable annotation via something like this:
>>>
>>> declare @method :
>>> public * *..I*Dao+.*(..) :
>>> @Cacheable(modelId="fooModel");
>>>
>>> The problem is, we need to filter out more than is specified by this one signature pattern, and I'm not sure that a composite pattern is allowed in this type of expression. When I tried something like this:
>>>
>>> declare @method :
>>> public * *..I*Dao+.*(..) && !public * *..I*Dao+.set*(..):
>>> @Cacheable(modelId="fooModel");
>>>
>>> I'm getting compile errors saying:
>>>
>>> Syntax error on token "&&", ";" expected
>>>
>>> I also tried to define composite pointcuts representing the joint points I'm interested in (basically I want to exclude 'jdbcTemplate' and 'slq' Spring specific setters from the places where annotation is introduced) but declaration syntax doesn't seem to like it either.
>>>
>>> What would be a good approach in the use case I described?
>>>
>>> I'm using compile time weaving via Ant. AspectJ version is 1.6
>>>
>>> Thank you in advance,
>>> Simeon
>>>
>>> _______________________________________________
>>> aspectj-users mailing list
>>> aspectj-users@...
>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users
_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users
_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Constructor ITD question: introduce no-arg ctor instead of letting JDO/JPA enhancer do it?

2009-10-27T14:33:11Z

I'm having some trouble getting around a problem I'm having with field
initialization and a persistence enhancer (OpenJPA's, but any JDO or
JPA enhancer will suffer this problem). The build process is to first
compile with ajc, then enhance, which adds a no-arg constructor.
Problem is, since the enhancer adds the constructor **after** ajc
compilation, introduced fields are not initialized.

Is there a way to introduce a constructor to any class with a given
annotation that doesn't already have a no-arg constructor of any
visibility such that field initialization takes place? This would
prevent the enhancer from adding a no-arg constructor after aspect
compilation.

JPA Example where a UUID field is being introduced with its field
initialization inlined:

=====================
@Entity
public class Foo {
@Id protected Long id;
// ...
}
=====================
public interface HasUuid { UUID getUuid(); }
=====================
public aspect HasUuidMixin {
public static interface Intro extends HasUuid {}
declare parents: (@Entity *) implements Intro;
private UUID Intro.uuid = UUID.randomUUID();
public UUID Intro.getUuid() { return uuid; }
}
=====================
// DOES NOT COMPILE
public aspect NoArgConstructorMixin {
public ((@Entity *) && !hasmethod(* new())).new() { // can't
introduce constructors with this syntax
// how do I ensure fields are initialized in here? call super()?
}
}
=====================

Thanks,
Matthew
_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

RE: declare @method syntax - is composite signature allowed??

2009-10-27T14:17:26Z

It would be easier to investigate if each of the declaration allowed for some identifier, otherwise they look the same in Eclipse AJDT. Apologies in advance if this already exists and I'm just anaware of it, this is really my first stab in the new territory. I could create a sample project and perhaps post it if that'd help looking into what's going on. What'd you suggest?

Once again, appreciate your help!!
Simeon

-----Original Message-----
From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
Sent: Tuesday, October 27, 2009 3:44 PM
To: aspectj-users@...
Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??

The algorithm used in situations like this is a kind of iterate to a fixed point - starting with what you specify. However I doubt we make guarantees if the declare @methods interact with each other and are specified in different source aspects.

> public * *..I*Dao+.getSql*(..) != public * *..I*Dao+.getSql(..).

seems odd. I wonder what set of join points are matched by each variant and how they overlap.

Andy

2009/10/27 Leyzerzon, Simeon <simeon.leyzerzon@...>:

Re: declare @method syntax - is composite signature allowed??

2009-10-27T12:43:40Z

The algorithm used in situations like this is a kind of iterate to a
fixed point - starting with what you specify. However I doubt we make
guarantees if the declare @methods interact with each other and are
specified in different source aspects.

> public * *..I*Dao+.getSql*(..) != public * *..I*Dao+.getSql(..).

seems odd. I wonder what set of join points are matched by each
variant and how they overlap.

Andy

2009/10/27 Leyzerzon, Simeon <simeon.leyzerzon@...>:

> Ah, looks like the following properly excludes the getSql() calls:
>
> public aspect CachingIntroduction {
>
> declare @method: public * *..I*Dao+.set*(..): @NonCacheable;
> declare @method: public * *..I*Dao+.getSql*(..): @NonCacheable;
> declare @method: public * *..I*Dao+.getSql(..): @NonCacheable;
> declare @method: !@NonCacheable public * *..I*Dao+.*(..):
> @Cacheable(modelId="fooModel");
>
> }
>
> so apparently in this case public * *..I*Dao+.getSql*(..) != public * *..I*Dao+.getSql(..).
>
> I'm not sure it's by design on not ;)
>
> Thanks,
> Simeon
>
> -----Original Message-----
> From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Leyzerzon, Simeon [ICG-IT]
> Sent: Tuesday, October 27, 2009 2:55 PM
> To: 'aspectj-users@...'
> Subject: RE: [aspectj-users] declare @method syntax - is composite signature allowed??
>
> Andy,
>
> No, I haven't defined another marker interface as you correctly spotted so that's what was breaking it. So NPE is gone, my bad.
>
> But now, after the following aspect:
>
> public aspect CachingIntroduction {
>
> declare @method: public * *..I*Dao+.set*(..): @NonCacheable;
> declare @method: public * *..I*Dao+.getSql*(..): @NonCacheable;
> declare @method: !@NonCacheable public * *..I*Dao+.*(..):
> @Cacheable(modelId="fooModel");
>
> }
>
> is applied to something like this class:
>
>
> public class ExpenseBaseDao implements IGmaBaseDao {
>
> ...
>
> public String getSql() {
> return sql;
> }
> ...
> }
>
> in the CrossRef view I'm seeing
>
>
>
> both for getSql:
>
> CachingIntroduction.declare @method: !@com.citi.gdos.smart.applib.service.cache.NonCacheable public * *..I*Dao+.*(..) : @Cacheable(modelId = "fooModel")
> CachingIntroduction.declare @method: public * *..I*Dao+.getSql*(..) : @NonCacheable
>
> Does it mean getSql() is annotated as both @Cacheable and @NonCacheable, could I apply some precedence here?
>
> Thanks,
> Simeon
>
> -----Original Message-----
> From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
> Sent: Tuesday, October 27, 2009 11:29 AM
> To: aspectj-users@...
> Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??
>
> Hey,
>
> Any NPE from the compiler is a bug. I presume you have defined the Setter annotation? (ie. it must exist as a definition in order to
> succeed)
>
> I raised this problem as https://bugs.eclipse.org/bugs/show_bug.cgi?id=293457
>
> Due to it failing in the hierarchy building code, it may behave better on the command line where the model does not get constructed.
>
> cheers,
> Andy
>
> 2009/10/27 Leyzerzon, Simeon <simeon.leyzerzon@...>:
>> Hi Andy,
>>
>> Thanks for responding. I tried the approach you are suggesting, unfortunately I'm getting the following:
>>
>> java.lang.NullPointerException
>> at
>> org.aspectj.ajdt.internal.core.builder.AsmHierarchyBuilder.visit(AsmHi
>> erarchyBuilder.java:548) at
>> org.aspectj.org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.tr
>> averse(MethodDeclaration.java:214)
>> at
>> org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.trav
>> erse(TypeDeclaration.java:1246) at
>> org.aspectj.org.eclipse.jdt.internal.compiler.ast.CompilationUnitDecla
>> ration.traverse(Compilatio ... oBuildJob.run(AutoBuildJob.java:238)
>> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
>>
>> Compile error: NullPointerException thrown: null
>>
>>
>> Here's the aspect I'm using:
>>
>> package com.citi.gdos.smart.applib.service.cache;
>>
>> import org.springmodules.cache.annotations.Cacheable;
>>
>> public aspect CachingIntroduction {
>>
>> declare @method: public * *..I*Dao+.set*(..): @Setter; declare @method: !@Setter public * *..I*Dao+.*(..):
>> @Cacheable(modelId="fooModel");
>>
>> }
>>
>>
>> Am I doing something wrong? Do I need a nightly build perhaps for this to work?
>>
>> Thanks,
>> Simeon
>>
>> -----Original Message-----
>> From: aspectj-users-bounces@...
>> [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
>> Sent: Tuesday, October 27, 2009 9:58 AM
>> To: aspectj-users@...
>> Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??
>>
>> Hi Simeon,
>>
>> This restriction you've uncovered was actually only recently raised as this enhancement:
>>
>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=287613
>>
>> To support it I need to change the serialized form of the attributes - I try not to do this often but for other reasons (optimization) I may be changing the format in 1.6.7 so I will be looking at it in that timeframe.
>>
>>> declare @method :
>>> public * *..I*Dao+.*(..) && !public * *..I*Dao+.set*(..):
>>> @Cacheable(modelId="fooModel");
>>
>> a clunky approach might be:
>>
>> declare @method: public * *..I*Dao+.set*(..): @Setter; declare @method: !@Setter public * *..I*Dao+.*(..):
>> @Cacheable(modelId="fooModel");
>>
>> but I know that's not great...
>>
>> Andy
>>
>> 2009/10/26 Leyzerzon, Simeon <simeon.leyzerzon@...>:
>>> I have a hierarchy of DAO classes into which I'm introducing an @Cacheable annotation via something like this:
>>>
>>> declare @method :
>>> public * *..I*Dao+.*(..) :
>>> @Cacheable(modelId="fooModel");
>>>
>>> The problem is, we need to filter out more than is specified by this one signature pattern, and I'm not sure that a composite pattern is allowed in this type of expression. When I tried something like this:
>>>
>>> declare @method :
>>> public * *..I*Dao+.*(..) && !public * *..I*Dao+.set*(..):
>>> @Cacheable(modelId="fooModel");
>>>
>>> I'm getting compile errors saying:
>>>
>>> Syntax error on token "&&", ";" expected
>>>
>>> I also tried to define composite pointcuts representing the joint points I'm interested in (basically I want to exclude 'jdbcTemplate' and 'slq' Spring specific setters from the places where annotation is introduced) but declaration syntax doesn't seem to like it either.
>>>
>>> What would be a good approach in the use case I described?
>>>
>>> I'm using compile time weaving via Ant. AspectJ version is 1.6
>>>
>>> Thank you in advance,
>>> Simeon
>>>
>>> _______________________________________________
>>> aspectj-users mailing list
>>> aspectj-users@...
>>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users

RE: declare @method syntax - is composite signature allowed??

2009-10-27T12:12:56Z

Ah, looks like the following properly excludes the getSql() calls:

public aspect CachingIntroduction {

declare @method: public * *..I*Dao+.set*(..): @NonCacheable;
declare @method: public * *..I*Dao+.getSql*(..): @NonCacheable;
declare @method: public * *..I*Dao+.getSql(..): @NonCacheable;
declare @method: !@NonCacheable public * *..I*Dao+.*(..):
@Cacheable(modelId="fooModel");

}

so apparently in this case public * *..I*Dao+.getSql*(..) != public * *..I*Dao+.getSql(..).

I'm not sure it's by design on not ;)

Thanks,
Simeon

-----Original Message-----
From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Leyzerzon, Simeon [ICG-IT]
Sent: Tuesday, October 27, 2009 2:55 PM
To: 'aspectj-users@...'
Subject: RE: [aspectj-users] declare @method syntax - is composite signature allowed??

Andy,

No, I haven't defined another marker interface as you correctly spotted so that's what was breaking it. So NPE is gone, my bad.

But now, after the following aspect:

public aspect CachingIntroduction {

declare @method: public * *..I*Dao+.set*(..): @NonCacheable;
declare @method: public * *..I*Dao+.getSql*(..): @NonCacheable;
declare @method: !@NonCacheable public * *..I*Dao+.*(..):
@Cacheable(modelId="fooModel");

}

is applied to something like this class:

public class ExpenseBaseDao implements IGmaBaseDao {

...

public String getSql() {
return sql;
}
...
}

in the CrossRef view I'm seeing

both for getSql:

CachingIntroduction.declare @method: !@com.citi.gdos.smart.applib.service.cache.NonCacheable public * *..I*Dao+.*(..) : @Cacheable(modelId = "fooModel")
CachingIntroduction.declare @method: public * *..I*Dao+.getSql*(..) : @NonCacheable

Does it mean getSql() is annotated as both @Cacheable and @NonCacheable, could I apply some precedence here?

Thanks,
Simeon

-----Original Message-----
From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
Sent: Tuesday, October 27, 2009 11:29 AM
To: aspectj-users@...
Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??

Hey,

Any NPE from the compiler is a bug. I presume you have defined the Setter annotation? (ie. it must exist as a definition in order to
succeed)

I raised this problem as https://bugs.eclipse.org/bugs/show_bug.cgi?id=293457

Due to it failing in the hierarchy building code, it may behave better on the command line where the model does not get constructed.

cheers,
Andy

2009/10/27 Leyzerzon, Simeon <simeon.leyzerzon@...>:

> Hi Andy,
>
> Thanks for responding. I tried the approach you are suggesting, unfortunately I'm getting the following:
>
> java.lang.NullPointerException
> at
> org.aspectj.ajdt.internal.core.builder.AsmHierarchyBuilder.visit(AsmHi
> erarchyBuilder.java:548) at
> org.aspectj.org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.tr
> averse(MethodDeclaration.java:214)
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.trav
> erse(TypeDeclaration.java:1246) at
> org.aspectj.org.eclipse.jdt.internal.compiler.ast.CompilationUnitDecla
> ration.traverse(Compilatio ... oBuildJob.run(AutoBuildJob.java:238)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
>
> Compile error: NullPointerException thrown: null
>
>
> Here's the aspect I'm using:
>
> package com.citi.gdos.smart.applib.service.cache;
>
> import org.springmodules.cache.annotations.Cacheable;
>
> public aspect CachingIntroduction {
>
> declare @method: public * *..I*Dao+.set*(..): @Setter; declare @method: !@Setter public * *..I*Dao+.*(..):
> @Cacheable(modelId="fooModel");
>
> }
>
>
> Am I doing something wrong? Do I need a nightly build perhaps for this to work?
>
> Thanks,
> Simeon
>
> -----Original Message-----
> From: aspectj-users-bounces@...
> [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
> Sent: Tuesday, October 27, 2009 9:58 AM
> To: aspectj-users@...
> Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??
>
> Hi Simeon,
>
> This restriction you've uncovered was actually only recently raised as this enhancement:
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=287613
>
> To support it I need to change the serialized form of the attributes - I try not to do this often but for other reasons (optimization) I may be changing the format in 1.6.7 so I will be looking at it in that timeframe.
>
>> declare @method :
>> public * *..I*Dao+.*(..) && !public * *..I*Dao+.set*(..):
>> @Cacheable(modelId="fooModel");
>
> a clunky approach might be:
>
> declare @method: public * *..I*Dao+.set*(..): @Setter; declare @method: !@Setter public * *..I*Dao+.*(..):
> @Cacheable(modelId="fooModel");
>
> but I know that's not great...
>
> Andy
>
> 2009/10/26 Leyzerzon, Simeon <simeon.leyzerzon@...>:
>> I have a hierarchy of DAO classes into which I'm introducing an @Cacheable annotation via something like this:
>>
>> declare @method :
>> public * *..I*Dao+.*(..) :
>> @Cacheable(modelId="fooModel");
>>
>> The problem is, we need to filter out more than is specified by this one signature pattern, and I'm not sure that a composite pattern is allowed in this type of expression. When I tried something like this:
>>
>> declare @method :
>> public * *..I*Dao+.*(..) && !public * *..I*Dao+.set*(..):
>> @Cacheable(modelId="fooModel");
>>
>> I'm getting compile errors saying:
>>
>> Syntax error on token "&&", ";" expected
>>
>> I also tried to define composite pointcuts representing the joint points I'm interested in (basically I want to exclude 'jdbcTemplate' and 'slq' Spring specific setters from the places where annotation is introduced) but declaration syntax doesn't seem to like it either.
>>
>> What would be a good approach in the use case I described?
>>
>> I'm using compile time weaving via Ant. AspectJ version is 1.6
>>
>> Thank you in advance,
>> Simeon
>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

RE: declare @method syntax - is composite signature allowed??

2009-10-27T11:55:17Z

Andy,

No, I haven't defined another marker interface as you correctly spotted so that's what was breaking it. So NPE is gone, my bad.

But now, after the following aspect:

public aspect CachingIntroduction {

declare @method: public * *..I*Dao+.set*(..): @NonCacheable;
declare @method: public * *..I*Dao+.getSql*(..): @NonCacheable;
declare @method: !@NonCacheable public * *..I*Dao+.*(..):
@Cacheable(modelId="fooModel");

}

is applied to something like this class:

public class ExpenseBaseDao implements IGmaBaseDao {

...

public String getSql() {
return sql;
}
...
}

in the CrossRef view I'm seeing

both for getSql:

CachingIntroduction.declare @method: !@com.citi.gdos.smart.applib.service.cache.NonCacheable public * *..I*Dao+.*(..) : @Cacheable(modelId = "fooModel")
CachingIntroduction.declare @method: public * *..I*Dao+.getSql*(..) : @NonCacheable

Does it mean getSql() is annotated as both @Cacheable and @NonCacheable, could I apply some precedence here?

Thanks,
Simeon

-----Original Message-----
From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
Sent: Tuesday, October 27, 2009 11:29 AM
To: aspectj-users@...
Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??

Hey,

Any NPE from the compiler is a bug. I presume you have defined the Setter annotation? (ie. it must exist as a definition in order to
succeed)

I raised this problem as https://bugs.eclipse.org/bugs/show_bug.cgi?id=293457

Due to it failing in the hierarchy building code, it may behave better on the command line where the model does not get constructed.

cheers,
Andy

2009/10/27 Leyzerzon, Simeon <simeon.leyzerzon@...>:

Re: Newbie question about paramter exposure.

2009-10-27T10:23:27Z

Just want to practise to see if I understand it correctly.

The point of interest

A.execute("ls -alh")

is reached.

That point of interest is specified in

execution(* example.A.execute(String)) && args(command);

So the parameter value being passed in (i.e. ls -alh) is bound to the command
parameter in the pointcut p(String command). Thus the value of `command' (in pointcut p(String command)) now can be replaced with "ls -alh" (whilst method's executing).

And because an advice around(String command) is attached to the pointcut p(String command), when the method execution join point occurs, it becomes

Object advice(String command): p("ls -alh"){
...
}

And then when advice is invoked

Object advice("ls -alh"): p("ls -alh"){
...
}

Am I correct to the above explanation?

I discover my problem is because after reading the book e.g. Aspectj in Action, I still do not understand very well about the flow that goes between joint points, pointcuts and advices. In a traditional method call, I understand (maybe not precisely) that in the class Main, when executing `new A().execute("ls -alh")', the value `ls -alh' will pass in to the execute() method of the class A; therefore, in the execute() function of the class A, the variable `command' can be replaced using the value `ls -alh' and gets printed using System.out.println() method in execution.

But concept of aop looks like not the same way; so it makes me confused.

Please correct me if anything goes wrong.

Thanks for your help.

I really appreciate it.

Andy Clement wrote:

Hi,

Your description is ok:

> therefore, execution of the method `new A().execute("ls -alh")' triggers the around() advice, which passes in a value `ls -lah' (as the variable command). That value `ls -alh' passes to
> pointcut p(), which also takes a variable named command. And that pointcut p() tries to capture the execution of a method specified as `* example.A.execute(String)' and its argument
> must be `command.'

let me write it another way to see if that helps. Think about the
events that occur when the program runs:
Main.main() starts executing
it calls the Main() constructor
it calls the process() method
Main.process() method starts executing
it calls the A() constructor
it calls the execute("ls -alh") method
A.execute("ls -alh") method starts executing *
it accesses the field System.out
it calls the method println()

all those are the joinpoints in your program flow and your pointcut is
choosing the one you are interested in. You have used 'execution(*
execute(String))' which has selected the one I've marked * above. In
your pointcut you've also said you are interested in the parameter
when the method executes, so you have used 'args' to bind it - so when
the program runs and your point of interest is reached, the parameter
value being passed in is bound to the command parameter in your
pointcut. You have chosen to have around() advice attached to that
pointcut so when the method-execution join point occurs, your around
advice is invoked with the bound parameter value. Unlike a regular
method call, the weaving infrastructure is looking after binding the
pointcut/advice parameter for you.

Andy

2009/10/27 Neo Anderson <javadeveloper999@yahoo.co.uk>:
> Hi
>
> I am newbie to aspectj and have a question regarding to the usage of parameters exposed in the pointcut, advice, etc. Following is the source code:
>
> package aspectj;
>
> public aspect P{
> public pointcut p(String command): execution(* example.A.execute(String)) && args(command);
>
> Object around(String command): p(command){
> System.out.println("around() advice : command:"+command);
> return proceed(command);
> }
> }
>
> package example;
>
> public class A{
> public void execute(String c){
> System.out.println("[A.java][execute] command:"+c);
> }
> }
>
> package example;
>
> public class Main{
>
> public static void main(String args[]){
> new Main().process();
> }
>
> void process(){
> new A().execute("ls -alh");
> }
>
> }
>
> The output :
>
> around() advice : command:ls -alh
> [A.java][execute] command:ls -alh
>
>
> Thought I can get the code worked, I do not know how to explain the parameter exposed in the pointcut (e.g. p(String command)) and advice (e.g. around(String command)).
>
> What I understand is that
>
> Since the execution flow is
>
> new A().execute("ls -lah") [Main.java] -> public void execute(String c) [A.java]
>
> therefore, execution of the method `new A().execute("ls -alh")' triggers the around() advice, which passes in a value `ls -lah' (as the variable command). That value `ls -alh' passes to pointcut p(), which also takes a variable named command. And that pointcut p() tries to capture the execution of a method specified as `* example.A.execute(String)' and its argument must be `command.'
>
> Is this explanation correct?
>
> I found out there is something not right for me, but I am not aware the part that I do not understand.
>
> I appreciate any advice.
>
> Thank you very much.
>
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@eclipse.org
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
_______________________________________________
aspectj-users mailing list
aspectj-users@eclipse.org
https://dev.eclipse.org/mailman/listinfo/aspectj-users

Re: declare @method syntax - is composite signature allowed??

2009-10-27T08:29:03Z

Hey,

Any NPE from the compiler is a bug. I presume you have defined the
Setter annotation? (ie. it must exist as a definition in order to
succeed)

I raised this problem as https://bugs.eclipse.org/bugs/show_bug.cgi?id=293457

Due to it failing in the hierarchy building code, it may behave better
on the command line where the model does not get constructed.

cheers,
Andy

2009/10/27 Leyzerzon, Simeon <simeon.leyzerzon@...>:

> Hi Andy,
>
> Thanks for responding. I tried the approach you are suggesting, unfortunately I'm getting the following:
>
> java.lang.NullPointerException
> at org.aspectj.ajdt.internal.core.builder.AsmHierarchyBuilder.visit(AsmHierarchyBuilder.java:548)
> at org.aspectj.org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.traverse(MethodDeclaration.java:214)
> at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse(TypeDeclaration.java:1246)
> at org.aspectj.org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse(Compilatio ... oBuildJob.run(AutoBuildJob.java:238)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
>
> Compile error: NullPointerException thrown: null
>
>
> Here's the aspect I'm using:
>
> package com.citi.gdos.smart.applib.service.cache;
>
> import org.springmodules.cache.annotations.Cacheable;
>
> public aspect CachingIntroduction {
>
> declare @method: public * *..I*Dao+.set*(..): @Setter; declare @method: !@Setter public * *..I*Dao+.*(..):
> @Cacheable(modelId="fooModel");
>
> }
>
>
> Am I doing something wrong? Do I need a nightly build perhaps for this to work?
>
> Thanks,
> Simeon
>
> -----Original Message-----
> From: aspectj-users-bounces@... [mailto:aspectj-users-bounces@...] On Behalf Of Andy Clement
> Sent: Tuesday, October 27, 2009 9:58 AM
> To: aspectj-users@...
> Subject: Re: [aspectj-users] declare @method syntax - is composite signature allowed??
>
> Hi Simeon,
>
> This restriction you've uncovered was actually only recently raised as this enhancement:
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=287613
>
> To support it I need to change the serialized form of the attributes - I try not to do this often but for other reasons (optimization) I may be changing the format in 1.6.7 so I will be looking at it in that timeframe.
>
>> declare @method :
>> public * *..I*Dao+.*(..) && !public * *..I*Dao+.set*(..):
>> @Cacheable(modelId="fooModel");
>
> a clunky approach might be:
>
> declare @method: public * *..I*Dao+.set*(..): @Setter; declare @method: !@Setter public * *..I*Dao+.*(..):
> @Cacheable(modelId="fooModel");
>
> but I know that's not great...
>
> Andy
>
> 2009/10/26 Leyzerzon, Simeon <simeon.leyzerzon@...>:
>> I have a hierarchy of DAO classes into which I'm introducing an @Cacheable annotation via something like this:
>>
>> declare @method :
>> public * *..I*Dao+.*(..) :
>> @Cacheable(modelId="fooModel");
>>
>> The problem is, we need to filter out more than is specified by this one signature pattern, and I'm not sure that a composite pattern is allowed in this type of expression. When I tried something like this:
>>
>> declare @method :
>> public * *..I*Dao+.*(..) && !public * *..I*Dao+.set*(..):
>> @Cacheable(modelId="fooModel");
>>
>> I'm getting compile errors saying:
>>
>> Syntax error on token "&&", ";" expected
>>
>> I also tried to define composite pointcuts representing the joint points I'm interested in (basically I want to exclude 'jdbcTemplate' and 'slq' Spring specific setters from the places where annotation is introduced) but declaration syntax doesn't seem to like it either.
>>
>> What would be a good approach in the use case I described?
>>
>> I'm using compile time weaving via Ant. AspectJ version is 1.6
>>
>> Thank you in advance,
>> Simeon
>>
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@...
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@...
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>

_______________________________________________
aspectj-users mailing list
aspectj-users@...
https://dev.eclipse.org/mailman/listinfo/aspectj-users