|
»
Blob savepoints leaving garbage?
|
View:
New views
4 Messages
—
Rating Filter:
Alert me
|
 |
Blob savepoints leaving garbage?
by Christian Theune-2
::
Rate this Message:
Hi,
I think I didn't totally grasp the way that blob savepoints work correctly. At one of our installations we have lots of .spb files left around. Looking at the code I don't see where .spb files get cleaned up again on savepoint aborts. On the bushy branch I found that having the TmpStore create directory structures is probably a bad idea. I propose to have it create a directory `savepoints` in the temporary directory and create files called `oidrepr-tidrepr.spb`. Comments? Christian -- Christian Theune · ct@... gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1 Zope and Plone consulting and development _______________________________________________ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@... http://mail.zope.org/mailman/listinfo/zodb-dev |
|
|
Re: Blob savepoints leaving garbage?
by Christian Theune-2
::
Rate this Message:
On Thu, Jun 26, 2008 at 08:32:25PM +0200, Christian Theune wrote:
> Hi, > > I think I didn't totally grasp the way that blob savepoints work correctly. At > one of our installations we have lots of .spb files left around. > > Looking at the code I don't see where .spb files get cleaned up again on > savepoint aborts. I reviewed the savepoint tests and see that they don't check for cleanup: neither on rollback, nor on abort. > On the bushy branch I found that having the TmpStore create directory > structures is probably a bad idea. I propose to have it create a directory > `savepoints` in the temporary directory and create files called > `oidrepr-tidrepr.spb`. I implemented this on the branch and it seems to work well. I find it easier to inspect on the filesystem than having savepoint state being distributed over the whole structure. Christian -- Christian Theune · ct@... gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1 Zope and Plone consulting and development _______________________________________________ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@... http://mail.zope.org/mailman/listinfo/zodb-dev |
|
|
Re: Blob savepoints leaving garbage?
by Tres Seaver
::
Rate this Message:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1 Christian Theune wrote: > On Thu, Jun 26, 2008 at 08:32:25PM +0200, Christian Theune wrote: >> Hi, >> >> I think I didn't totally grasp the way that blob savepoints work correctly. At >> one of our installations we have lots of .spb files left around. >> >> Looking at the code I don't see where .spb files get cleaned up again on >> savepoint aborts. > > I reviewed the savepoint tests and see that they don't check for cleanup: > neither on rollback, nor on abort. > >> On the bushy branch I found that having the TmpStore create directory >> structures is probably a bad idea. I propose to have it create a directory >> `savepoints` in the temporary directory and create files called >> `oidrepr-tidrepr.spb`. > > I implemented this on the branch and it seems to work well. I find it easier > to inspect on the filesystem than having savepoint state being distributed > over the whole structure. Did a fix for the leaked saveepoint stuff ever get committed? https://bugs.launchpad.net/zodb/+bug/323067 Can we safely remove anything under tmp/savepoints, assuming that we know there is not a transaction running? Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 tseaver@... Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKV2O4+gerLs4ltQ4RAjo9AJ0W4ShPfPl7SXCKjQNDm7rNc2ZrGQCglbvL N3WVI/IeVhocIWWNGPnmfDw= =h36T -----END PGP SIGNATURE----- _______________________________________________ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@... http://mail.zope.org/mailman/listinfo/zodb-dev |
|
|
Re: Blob savepoints leaving garbage?
by Jim Fulton
::
Rate this Message:
On Fri, Jul 10, 2009 at 11:52 AM, Tres Seaver<tseaver@...> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Christian Theune wrote: >> On Thu, Jun 26, 2008 at 08:32:25PM +0200, Christian Theune wrote: >>> Hi, >>> >>> I think I didn't totally grasp the way that blob savepoints work correctly. At >>> one of our installations we have lots of .spb files left around. >>> >>> Looking at the code I don't see where .spb files get cleaned up again on >>> savepoint aborts. >> >> I reviewed the savepoint tests and see that they don't check for cleanup: >> neither on rollback, nor on abort. >> >>> On the bushy branch I found that having the TmpStore create directory >>> structures is probably a bad idea. I propose to have it create a directory >>> `savepoints` in the temporary directory and create files called >>> `oidrepr-tidrepr.spb`. >> >> I implemented this on the branch and it seems to work well. I find it easier >> to inspect on the filesystem than having savepoint state being distributed >> over the whole structure. > > Did a fix for the leaked saveepoint stuff ever get committed? I just committed the fix to the trunk and the fix will be in 3.9. > > https://bugs.launchpad.net/zodb/+bug/323067 > > Can we safely remove anything under tmp/savepoints, assuming that we > know there is not a transaction running? Yes. Jim -- Jim Fulton _______________________________________________ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@... http://mail.zope.org/mailman/listinfo/zodb-dev |
| Free embeddable forum powered by Nabble | Forum Help |
