Bug? Alt+O on commit dialog no longer OKs it

[Peter Mounce-4]

Using TSVN v1.6.0, b15855, on x64 Windows Server 2008, coming from TSVN 1.5.9 release-version.  I have rebooted since installing.

When I bring up the commit dialog, I used to be able to submit it with Alt+o, because the OK button had an accelerator-key attached to it (I think that's the term; don't know for sure).

Now, if I hit Alt+o, this doesn't happen - nothing (noticeable) happens, in fact.

If I hold down Alt, then the R in Recent Messages is still underlined.  The O in OK is not.

I have not changed any settings since upgrading.  I've had a look in the settings pane for a new setting, but haven't seen anything that's likely to affect this.

I don't know how to find out which locale the TSVN binary is using (perhaps the & fell off the string, if it's in a resource file...?).

If you need any more information, please cc me; I'm not subscribed to the list.  Happy to provide any further information.

Best regards
Pete

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1429302

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[David Balazic-2]

There was a message about this recently. Check the archive.

The basic idea is :
the OK button in dialogs has a keyboard shortcut by default,
so the additional alt-O is unneccessary.

The shortcut for OK is : ENTER (or if ENTER is used by some
other GUI element in the dialog, then ctrl-ENTER).

Similarly , ESC is the shortcut for "Cancel".

Regards,
David

> -----Original Message-----
> From: Peter Mounce [mailto:pete@...]
> Sent: Thursday, March 26, 2009 1:21 PM
> To: users@...
> Subject: Bug? Alt+O on commit dialog no longer OKs it
>
> Using TSVN v1.6.0, b15855, on x64 Windows Server 2008, coming
> from TSVN 1.5.9 release-version.  I have rebooted since installing.
>
> When I bring up the commit dialog, I used to be able to
> submit it with Alt+o, because the OK button had an
> accelerator-key attached to it (I think that's the term;
> don't know for sure).
>
> Now, if I hit Alt+o, this doesn't happen - nothing
> (noticeable) happens, in fact.
>
> If I hold down Alt, then the R in Recent Messages is still
> underlined.  The O in OK is not.
>
> I have not changed any settings since upgrading.  I've had a
> look in the settings pane for a new setting, but haven't seen
> anything that's likely to affect this.
>
> I don't know how to find out which locale the TSVN binary is
> using (perhaps the & fell off the string, if it's in a
> resource file...?).
>
> If you need any more information, please cc me; I'm not
> subscribed to the list.  Happy to provide any further information.
>
> Best regards
> Pete
>
> ------------------------------------------------------
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061
> &dsMessageId=1429302
>
> To unsubscribe from this discussion, e-mail:
> [users-unsubscribe@...].
>

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1429663

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Jean-Marc van Leerdam]

Hi,

On 26/03/2009, Peter Mounce <pete@...> wrote:

> Using TSVN v1.6.0, b15855, on x64 Windows Server 2008, coming from TSVN
> 1.5.9 release-version.  I have rebooted since installing.
>
> When I bring up the commit dialog, I used to be able to submit it with
> Alt+o, because the OK button had an accelerator-key attached to it (I think
> that's the term; don't know for sure).
>
> Now, if I hit Alt+o, this doesn't happen - nothing (noticeable) happens, in
> fact.
>

There should not be an accelerator key associated with OK, as the
[Ctrl]-[Enter] key is already available (or [Enter] on dialogs without
multiline input).

I think this has been changed since 1.6.0

--
Regards,

Jean-Marc
--
       ___
  @@  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1429698

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Lübbe Onken-4]

Jean-Marc van Leerdam wrote:
> There should not be an accelerator key associated with OK, as the
> [Ctrl]-[Enter] key is already available (or [Enter] on dialogs without
> multiline input).
>
> I think this has been changed since 1.6.0

Yes, but the resource file(s) still contain &OK and &Cancel, so this
hasn't been changed consistently. But it is also possible that these
relics are from the Windows libraries that we include as well.

Cheers
- Lübbe

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net  PGP Key ID 0x23F511AB

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1429915

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[webpost]

Ctrl+Enter does work when in multiline comment fields etc (never knew that) but Alt+O seems much more intitive and more easily discoverable.

> Jean-Marc van Leerdam wrote:
> > There should not be an accelerator key associated with OK, as the
> > [Ctrl]-[Enter] key is already available (or [Enter] on dialogs without
> > multiline input).
> >
> > I think this has been changed since 1.6.0
>
> Yes, but the resource file(s) still contain &OK and &Cancel, so this
> hasn't been changed consistently. But it is also possible that these
> relics are from the Windows libraries that we include as well.
>
> Cheers
> - Lübbe
>
> --
>        ___
>   oo  // \\      "De Chelonian Mobile"
>  (_,\/ \_/ \     TortoiseSVN
>    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
>    /_/   \_\     http://tortoisesvn.net  PGP Key ID 0x23F511AB

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1585589

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Jack C. Holt]

This discussion was also had in
http://groups.google.com/group/tortoisesvn/browse_thread/thread/c96e617acf6ce1fd/55deecb5a2bad214?hl=en&lnk=gst&q=alt+o#55deecb5a2bad214

And I'm tired of knocking my head against the "Windows conventions
brickwall."

On Apr 7, 4:09 pm, webp...@... wrote:

> Ctrl+Enter does work when in multiline comment fields etc (never knew that) butAlt+Oseems much more intitive and more easily discoverable.
>
>
>
> > Jean-Marc van Leerdam wrote:
> > > There should not be an accelerator key associated with OK, as the
> > > [Ctrl]-[Enter] key is already available (or [Enter] on dialogs without
> > > multiline input).
>
> > > I think this has been changed since 1.6.0
>
> > Yes, but the resource file(s) still contain &OK and &Cancel, so this
> > hasn't been changed consistently. But it is also possible that these
> > relics are from the Windows libraries that we include as well.
>
> > Cheers
> > - Lübbe
>
> > --
> >        ___
> >   oo  // \\      "De Chelonian Mobile"
> >  (_,\/ \_/ \     TortoiseSVN
> >    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
> >    /_/   \_\    http://tortoisesvn.net PGP Key ID 0x23F511AB
>
> ------------------------------------------------------http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMess...
>
> To unsubscribe from this discussion, e-mail: [users-unsubscr...@...].

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1615480

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[webpost]

It seems as thought there have been a number of searches, discussions, emails, etc regarding this issue, and it comes down to usability. If other users like myself are willing to spend time searching for a solution to this "bug," doesn't it indicate our appreciation of TSVN and how it used to work?

Please, for the sake of the untold number of users who now feel the need to click the "OK" button because of lack of knowledge of the "Ctrl+Enter" hotkey, add the "Alt+O" hotkey and underlining back in. Or let me know how and I'll do it myself.

Thanks to all the developers for TSVN, which is by far the best version control system I have ever used!

Sincerely,
Pat Kujawa

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2262848

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Jean-Marc van Leerdam]

Hi,

2009/5/14  <webpost@...>:
> It seems as thought there have been a number of searches, discussions, emails, etc regarding this issue, and it comes down to usability. If other users like myself are willing to spend time searching for a solution to this "bug," doesn't it indicate our appreciation of TSVN and how it used to work?
>
> Please, for the sake of the untold number of users who now feel the need to click the "OK" button because of lack of knowledge of the "Ctrl+Enter" hotkey, add the "Alt+O" hotkey and underlining back in. Or let me know how and I'll do it myself.
>

The <sarcasm>incorrect, not needed but frequently asked for
superfluous</sarcasm> Alt-O has been reintroduced into TSVN some days
ago. The nightly builds and next 1.6.x release will support them.

And if all translators honor them, so will the non-English versions... ;-)

--
Regards,

Jean-Marc
--
.       ___
.  @@  // \\      "De Chelonian Mobile"
. (_,\/ \_/ \     TortoiseSVN
.   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
.   /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2266561

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Lübbe Onken-4]

Jean-Marc van Leerdam wrote:
> The <sarcasm>incorrect, not needed but frequently asked for
> superfluous</sarcasm> Alt-O has been reintroduced into TSVN some days
> ago. The nightly builds and next 1.6.x release will support them.
>
> And if all translators honor them, so will the non-English versions... ;-)

This will probably work automagically, because &OK and &Cancel were
still in the resource files due to some libraries that we include.

Cheers
- Lübbe

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net  PGP Key ID 0x23F511AB

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2267708

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Jean-Marc van Leerdam]

Hi Lübbe,

2009/5/15 Lübbe Onken <luebbe.tortoisesvn@...>:

> Jean-Marc van Leerdam wrote:
>> The <sarcasm>incorrect, not needed but frequently asked for
>> superfluous</sarcasm> Alt-O has been reintroduced into TSVN some days
>> ago. The nightly builds and next 1.6.x release will support them.
>>
>> And if all translators honor them, so will the non-English versions... ;-)
>
> This will probably work automagically, because &OK and &Cancel were
> still in the resource files due to some libraries that we include.
>

Sure, if we (translators) play nice and use & in the translations of
these resources ;-)

--
Regards,

Jean-Marc
--
.       ___
.  @@  // \\      "De Chelonian Mobile"
. (_,\/ \_/ \     TortoiseSVN
.   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
.   /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2267745

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Johan Appelgren]

On Fri, May 15, 2009 at 7:21 AM, Jean-Marc van Leerdam
<j.m.van.leerdam@...> wrote:

> Hi,
>
> 2009/5/14  <webpost@...>:
>> It seems as thought there have been a number of searches, discussions, emails, etc regarding this issue, and it comes down to usability. If other users like myself are willing to spend time searching for a solution to this "bug," doesn't it indicate our appreciation of TSVN and how it used to work?
>>
>> Please, for the sake of the untold number of users who now feel the need to click the "OK" button because of lack of knowledge of the "Ctrl+Enter" hotkey, add the "Alt+O" hotkey and underlining back in. Or let me know how and I'll do it myself.
>>
>
> The <sarcasm>incorrect, not needed but frequently asked for
> superfluous</sarcasm> Alt-O has been reintroduced into TSVN some days
> ago. The nightly builds and next 1.6.x release will support them.
>
> And if all translators honor them, so will the non-English versions... ;-)

So now that there is one OK button that has an accelerator key, will
we now get users complaining about that it is missing on all the other
OK buttons in TSVN? And why is no one complaining about the
discoverability of the Enter and Esc key shortscuts for every other OK
and Cancel button in Windows? ;) ;) ;)

/Johan

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2267858

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Jean-Marc van Leerdam]

Hi Johan,

2009/5/15 Johan Appelgren <johan.appelgren@...>:
> So now that there is one OK button that has an accelerator key, will
> we now get users complaining about that it is missing on all the other
> OK buttons in TSVN? And why is no one complaining about the
> discoverability of the Enter and Esc key shortscuts for every other OK
> and Cancel button in Windows? ;) ;) ;)

From the commit email:

Author: steveking
Date: 2009-05-12 09:47:47-0700
New Revision: 16355

Modified:
  trunk/src/Resources/TortoiseProcENG.rc

Log:
Reintroduce the accelerators for the OK buttons in all dialogs where
there's an edit box that accepts returns.

--
Regards,

Jean-Marc
--
.       ___
.  @@  // \\      "De Chelonian Mobile"
. (_,\/ \_/ \     TortoiseSVN
.   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
.   /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2268108

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Jack C. Holt]

Thank you.  In hindsight it appears that if we had just the status quo
alone, it would have saved us all a lot of grief and wasted time.

On May 15, 1:08 am, Jean-Marc van Leerdam <j.m.van.leer...@...>
wrote:

> Hi Johan,
>
> 2009/5/15 Johan Appelgren <johan.appelg...@...>:
>
> > So now that there is one OK button that has an accelerator key, will
> > we now get users complaining about that it is missing on all the other
> > OK buttons in TSVN? And why is no one complaining about the
> > discoverability of the Enter and Esc key shortscuts for every other OK
> > and Cancel button in Windows? ;) ;) ;)
>
> From the commit email:
>
> Author: steveking
> Date: 2009-05-12 09:47:47-0700
> New Revision: 16355
>
> Modified:
>   trunk/src/Resources/TortoiseProcENG.rc
>
> Log:
> Reintroduce the accelerators for the OK buttons in all dialogs where
> there's an edit box that accepts returns.
>
> --
> Regards,
>
> Jean-Marc
> --
> .       ___
> .  @@  // \\      "De Chelonian Mobile"
> . (_,\/ \_/ \     TortoiseSVN
> .   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
> .   /_/   \_\    http://tortoisesvn.net
>
> ------------------------------------------------------http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMess...
>
> To unsubscribe from this discussion, e-mail: [users-unsubscr...@...].

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2271648

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].