« Return to Thread: Bug#399682: openct: cm4000 driver fails with "cm4000: setting parameters failed"

Bug#399682: openct: cm4000 driver fails with "cm4000: setting parameters failed"

by Eric Dorland :: Rate this Message:

Reply (Restricted by the Administrator) | Reply to Author | View in Thread

* Jan Niehusmann (jan@...) wrote:

> Package: openct
> Version: 0.6.10-1
> Severity: normal
> Tags: patch
>
> The cm4000 driver fails to load because the initialization routine calls
> ifd_sevice_set_parameters which in turn tries to call
> dev->ops->set_params(). This function is currently only defined for
> serial and usb devices, but not for pcmcia devices.
>
> The proper fix may be implementing the set_params function for cm4000,
> but the following patch does work for now (and in fact only reverts a
> recent regression in openct):
Has this been discussed upstream at all?
 

> Only in openct-0.6.10-orig/src/ifd: .ifd-cm4000.c.swp
> diff -ur openct-0.6.10-orig/src/ifd/ifd-cm4000.c openct-0.6.10/src/ifd/ifd-cm4000.c
> --- openct-0.6.10-orig/src/ifd/ifd-cm4000.c 2006-09-12 22:55:14.000000000 +0200
> +++ openct-0.6.10/src/ifd/ifd-cm4000.c 2006-11-21 11:13:25.000000000 +0100
> @@ -42,11 +42,16 @@
>  
>   params = dev->settings;
>   params.usb.interface = 0;
> + /* ifd_sevice_set_parameters does not work for cm4000, as dev->ops->set_params
> + * is not defined.
> +
>   if (ifd_device_set_parameters(dev, ¶ms) < 0) {
>   ct_error("cm4000: setting parameters failed", device_name);
>   ifd_device_close(dev);
>   return -1;
>   }
> +
> + */
>  
>   return 0;
>  }
>
--
Eric Dorland <eric@...>
ICQ: #61138586, Jabber: hooty@...
1024D/16D970C6 097C 4861 9934 27A0 8E1C  2B0A 61E9 8ECF 16D9 70C6



signature.asc (196 bytes) Download Attachment

 « Return to Thread: Bug#399682: openct: cm4000 driver fails with "cm4000: setting parameters failed"