Bug#545895: debbugs: should drop '\r' characters from bug report subjects

[Francesco Poli (t1000)]

Package: debbugs
Version: 2.4.2~exp0
Severity: normal

Hi!

I think I found a bug in the BTS, hence I am reporting it against
the experimental version of debbugs (which I believe is the closest
version to what is used in the BTS, right?).

The following example use of apt-listbugs shows the problem:

  $ apt-listbugs list gstreamer0.10-plugins-good
  Reading package fields... Done
  Reading package status... Done
  Retrieving bug reports... Done
  Parsing Found/Fixed information... Done
  serious bugs of gstreamer0.10-plugins-good (-> ) <marked as done in some version>
   (Fixed: gstreamer0.10-plugins-good/0.10.8-4.1).1 unistallable due to .mo
  serious bugs of gstreamer0.10-plugins-good (-> ) <unfixed>
   #532352 - gstreamer0.10-plugins-good: CVE-2009-1932 integer overflows
  Summary:
   gstreamer0.10-plugins-good(2 bugs)


This is wrongly displayed!
You cannot even see the first bug number!

The problem is that the first bug report includes a '\r' character in
its subject and thus messes up with apt-listbugs description line
building...

I have already worked around this problem in apt-listbugs with
a modification in the BTS SOAP reply parsing code.  This modification
will be included in the next release of apt-listbugs (version 0.1.1)
and is visible on the public git repository:

http://git.debian.org/?p=apt-listbugs/apt-listbugs.git;a=commitdiff;h=0ca67de284c11926221959a0ee0237dd0c3bd84d

With this modification, the above command gives the following
correct output:

  $ apt-listbugs list gstreamer0.10-plugins-good
  Reading package fields... Done
  Reading package status... Done
  Retrieving bug reports... Done
  Parsing Found/Fixed information... Done
  serious bugs of gstreamer0.10-plugins-good (-> ) <marked as done in some version>
   #515836 - gstreamer0.10-plugins-good: 0.10.8-4.1 unistallable due to .mo  (Fixed: gstreamer0.10-plugins-good/0.10.8-4.1)
  serious bugs of gstreamer0.10-plugins-good (-> ) <unfixed>
   #532352 - gstreamer0.10-plugins-good: CVE-2009-1932 integer overflows
  Summary:
   gstreamer0.10-plugins-good(2 bugs)


However, the other apt-listbugs co-maintainer (Ryan Niebur) and I
think that this is a bug in the BTS and should be fixed there.

The BTS should drop '\r' characters from bug report subjects, so that
any tool which queries the BTS via its SOAP interface won't get
malformed subjects and won't mess up while trying to display them.

I hope that you agree with this analysis and that this bug is not
to difficult to fix.

Thanks for your time.



--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Ryan Niebur]

On Wed, Sep 09, 2009 at 10:28:45PM +0200, Francesco Poli (t1000) wrote:

> Package: debbugs
> Version: 2.4.2~exp0
> Severity: normal
>
> Hi!
>
> I think I found a bug in the BTS, hence I am reporting it against
> the experimental version of debbugs (which I believe is the closest
> version to what is used in the BTS, right?).
>
> The following example use of apt-listbugs shows the problem:
>

so that the problem can be more easily reproduced/seen, attached is a
minimal Perl script that shows this problem.

$ ./545895.pl
$VAR1 = "gstreamer0.10-plugins-good: 0.10.8-4.1 unistallable due to .mo \r";
$

Cheers,
Ryan

--
_________________________
Ryan Niebur
ryanryan52@...

---

#!/usr/bin/perl

use SOAP::Lite;
use Data::Dump::Streamer;

my $soap = SOAP::Lite->uri('Debbugs/SOAP')->proxy('http://bugs.debian.org/cgi-bin/soap.cgi');
Dump($soap->get_status(515836)->result()->{515836}->{subject});

---

[Don Armstrong]

clone 545895 -1
retitle -1  process does not properly fold multi-line subjects or remove \r
retitle 545895 strip \r in read_bug temporarily, and fix existing bug reports
thanks

On Wed, 09 Sep 2009, Ryan Niebur wrote:
> On Wed, Sep 09, 2009 at 10:28:45PM +0200, Francesco Poli (t1000) wrote:
> > I think I found a bug in the BTS, hence I am reporting it against
> > the experimental version of debbugs (which I believe is the closest
> > version to what is used in the BTS, right?).

That's fine; it's actually a problem in all of the debbugs versions,
though.

> so that the problem can be more easily reproduced/seen, attached is a
> minimal Perl script that shows this problem.
>
> $ ./545895.pl
> $VAR1 = "gstreamer0.10-plugins-good: 0.10.8-4.1 unistallable due to .mo \r";

Right, this is actually an issue in scripts/process; the real fix for
it is going to be stuck behind me refactoring process entirely, but
I'll whip up a quick fix for it temporarily.

\r or \n should never be in the Subject: field of summary, so the BTS
should never have to bother with them; it also should be folding
multi-line subjects too, which it isn't doing properly.

There are about 40 or so unarchived bugs with this issue; I'll try to
go through and fix them all sometime in the near future.


Don Armstrong

--
Whatever you do will be insignificant, but it is very important that
you do it.
 -- Mohandas Karamchand Gandhi

http://www.donarmstrong.com              http://rzlab.ucr.edu



--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Debian Bug Tracking System]

Processing commands for control@...:

> clone 545895 -1
Bug#545895: debbugs: should drop '\r' characters from bug report subjects
Bug 545895 cloned as bug 545945.

> retitle -1  process does not properly fold multi-line subjects or remove \r
Bug #545945 [debbugs] debbugs: should drop '\r' characters from bug report subjects
Changed Bug title to 'process does not properly fold multi-line subjects or remove \r' from 'debbugs: should drop '\r' characters from bug report subjects'
> retitle 545895 strip \r in read_bug temporarily, and fix existing bug reports
Bug #545895 [debbugs] debbugs: should drop '\r' characters from bug report subjects
Changed Bug title to 'strip \r in read_bug temporarily, and fix existing bug reports' from 'debbugs: should drop '\r' characters from bug report subjects'
> thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


--
To UNSUBSCRIBE, email to debian-debbugs-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...