Bug#549596: lintian: Do not tag copyright-refers-to-symlink-license usr/share/common-licenses/GPL when debian/copyright contains "License: Artistic or GPL-1+"

View: New views
7 Messages — Rating Filter:   Alert me  

Bug#549596: lintian: Do not tag copyright-refers-to-symlink-license usr/share/common-licenses/GPL when debian/copyright contains "License: Artistic or GPL-1+"

by Salvatore Bonaccorso-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Package: lintian
Version: 2.2.17
Severity: wishlist

Hi

Currently when debian/copyright contains

License: Artistic or GPL-1+

but not using License-Alias: Perl, and
the License-text only referencing to /usr/share/common-licenses/GPL
lintian will report pedantic

copyright-refers-to-symlink-license usr/share/common-licenses/GPL

but not if "License-Alias: Perl" is present. License-Alias does not
appear anymore in the current DEP5 proposal [1].

 [1] http://dep.debian.net/deps/dep5/

In /usr/share/lintian/checks/copyright-file currently is as of version
2.2.17:

---(snip)---------------------------------------------------------------
# Allow generic GPL references for packages licensed under the same terms as
# Perl for now.  Perl references GPL version 1, which isn't in
# common-licenses.
#
# Avoid complaining about referring to a versionless license file if the word
# "version" appears nowhere in the copyright file.  This won't catch all of
# our false positives for GPL references that don't include a specific version
# number, but it will get the obvious ones.
if (m,(usr/share/common-licenses/(L?GPL|GFDL))([^-]),i && !m,as Perl itself,i
    && !m,License-Alias:\s+Perl,) {
    my ($ref, $license, $separator) = ($1, $2, $3);
    if ($separator =~ /[\d\w]/) {
        tag 'copyright-refers-to-nonexistent-license-file', "$ref$separator";
    } elsif (m,\b(?:any|or)\s+later(?:\s+version)?\b,i
             || m,License: $license-[\d\.]+\+,i) {
        tag "copyright-refers-to-symlink-license", $ref;
    } else {
        tag "copyright-refers-to-versionless-license-file", $ref
            if /\bversion\b/;
    }
}
------------------------------------------------------------------------

would it be possible here, that since License-Alias is not anymore in
DEP5, to include to not report copyright-refers-to-symlink-license
also if "License: Artistic or GPL-1+" is present?

Would it be possible to have somethin like (not tested yet!)
---(patch)--------------------------------------------------------------
--- lintian-2.2.17.orig/checks/copyright-file 2009-10-04 19:01:38.000000000 +0200
+++ lintian-2.2.17/checks/copyright-file 2009-10-04 19:04:43.000000000 +0200
@@ -161,7 +161,8 @@
 # our false positives for GPL references that don't include a specific version
 # number, but it will get the obvious ones.
 if (m,(usr/share/common-licenses/(L?GPL|GFDL))([^-]),i && !m,as Perl itself,i
-    && !m,License-Alias:\s+Perl,) {
+    && !m,License-Alias:\s+Perl,
+    && !m,License:\s+Artistic\s+or\s+GPL-1\+,) {
     my ($ref, $license, $separator) = ($1, $2, $3);
     if ($separator =~ /[\d\w]/) {
  tag 'copyright-refers-to-nonexistent-license-file', "$ref$separator";
------------------------------------------------------------------------

Bests
Salvatore

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



--
To UNSUBSCRIBE, email to debian-perl-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...


Re: Bug#549596: lintian: Do not tag copyright-refers-to-symlink-license usr/share/common-licenses/GPL when debian/copyright contains "License: Artistic or GPL-1+"

by Salvatore Bonaccorso-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi
On Sun, Oct 04, 2009 at 07:07:49PM +0200, Salvatore Bonaccorso wrote:
> Package: lintian
> Version: 2.2.17
> Severity: wishlist

I cc'ed the debian-perl list for #549596, if someone wants to give a comment
or a better proposal to this, since it is surely not a optimal proposal ;-)

Bests
Salvatore


signature.asc (853 bytes) Download Attachment

Re: Bug#549596: lintian: Do not tag copyright-refers-to-symlink-license usr/share/common-licenses/GPL when debian/copyright contains "License: Artistic or GPL-1+"

by Jonathan Yu :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Another potential solution, and one I favour, is to simply provide a
GPL-1 file (so that a version can be specified rather than simply
symlinking).

On Sun, Oct 4, 2009 at 1:35 PM, Salvatore Bonaccorso
<salvatore.bonaccorso@...> wrote:

> Hi
> On Sun, Oct 04, 2009 at 07:07:49PM +0200, Salvatore Bonaccorso wrote:
>> Package: lintian
>> Version: 2.2.17
>> Severity: wishlist
>
> I cc'ed the debian-perl list for #549596, if someone wants to give a comment
> or a better proposal to this, since it is surely not a optimal proposal ;-)
>
> Bests
> Salvatore
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iQIcBAEBCAAGBQJKyNz9AAoJEHidbwV/2GP+qbIQAMLZ8SOLOwOAvhwjLTNep/7M
> ObrMuNJiebyWEc3amnCQcNO2eCtrrqOW6oJe35KU4laaRO6/Sfel/yVshjhjYX3v
> bcAMGGvv6XmZzVE9Pz7f/kpjhm45pR9gU/zmje6uANT6ZW5lY8uXU3KzHM34N61k
> Vzu2+7CQqtUMrk+5wnPLfozLDf7QkQfHxF2Z2KBNjmj5/nZ6Oe1v3GzVS8987cGz
> TsMe80j9jFCBrOi+x3/2xlcxxzjyvZRK35ODVXub5PAb6FUMxqgpcvL8kOTlQ7Gp
> R2ArIZB7A+OARXEX32p1NZGnZ9DA0ot0hrmLpsFb/p941yjeUgED3vxNSDzDG0bw
> /ENK3Yg4JfHWTGO3Lz7l02aIwlDAyvGo4WPDW/gUfdXXpzW4j/MSUnsyMaNqhFS/
> IlEzMutV2FQS4WYkvHU32A0LKEgBQpE7DPu7pLw2Si0zplTX/PO9VmDKG34IEDFu
> UVllPKDvafezKql+WpDXBXXhBk3w9lu5pwx7eJXIB5p/X3USm9+gFQV/mjPF31B0
> zhkmm3QtL0ZF1CYcsBtvLdH1S7g/YrWv9dqyiY4rXKHo04llcDDbgP0b+adP5pD+
> UIfEphWrwjEmPQCiWhPvaw9gEkNqEmuOgySVYk+Bw9f/vJSb0ryxM2nNBJxuTYGR
> YdNXiEQCwTM0bO0CYCW0
> =OT59
> -----END PGP SIGNATURE-----
>
>


--
To UNSUBSCRIBE, email to debian-perl-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...


Re: Bug#549596: lintian: Do not tag copyright-refers-to-symlink-license usr/share/common-licenses/GPL when debian/copyright contains "License: Artistic or GPL-1+"

by Charles Plessy-12 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Le Sun, Oct 04, 2009 at 07:07:49PM +0200, Salvatore Bonaccorso a écrit :
>
> License-Alias does not appear anymore in the current DEP5 proposal [1].
>
>  [1] http://dep.debian.net/deps/dep5/
>
> In /usr/share/lintian/checks/copyright-file currently is as of version
> 2.2.17:
 

> would it be possible here, that since License-Alias is not anymore in
> DEP5, to include to not report copyright-refers-to-symlink-license
> also if "License: Artistic or GPL-1+" is present?
>
> Would it be possible to have somethin like (not tested yet!)
> ---(patch)--------------------------------------------------------------
> --- lintian-2.2.17.orig/checks/copyright-file 2009-10-04 19:01:38.000000000 +0200
> +++ lintian-2.2.17/checks/copyright-file 2009-10-04 19:04:43.000000000 +0200
> @@ -161,7 +161,8 @@
>  # our false positives for GPL references that don't include a specific version
>  # number, but it will get the obvious ones.
>  if (m,(usr/share/common-licenses/(L?GPL|GFDL))([^-]),i && !m,as Perl itself,i
> -    && !m,License-Alias:\s+Perl,) {
> +    && !m,License-Alias:\s+Perl,
> +    && !m,License:\s+Artistic\s+or\s+GPL-1\+,) {
>      my ($ref, $license, $separator) = ($1, $2, $3);
>      if ($separator =~ /[\d\w]/) {
>   tag 'copyright-refers-to-nonexistent-license-file', "$ref$separator";
> ------------------------------------------------------------------------

Dear all,

the License-Alias field was indeed removed from the DEP 5 proposal, which now
speficies directly that the Perl license keyword means ‘GPL-1+ or Artistic’.
Hence, I would recommend to simply use ‘License: Perl’. Therefore, the above
regular expression could be: m,License(?:-Alias)?\s*:\s+Perl,
(not tested).

Have a nice day,

--
Charles Plessy
Tsurumi, Kanagawa, Japan


--
To UNSUBSCRIBE, email to debian-perl-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...


Re: Bug#549596: lintian: Do not tag copyright-refers-to-symlink-license usr/share/common-licenses/GPL when debian/copyright contains "License: Artistic or GPL-1+"

by Salvatore Bonaccorso-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Charles, hi all

Thanks for your reply on that and sorry for the delay (was on
vacation).

On Mon, Oct 12, 2009 at 06:45:31PM +0900, Charles Plessy wrote:

> Le Sun, Oct 04, 2009 at 07:07:49PM +0200, Salvatore Bonaccorso a écrit :
> >
> > [...]
> >
> > would it be possible here, that since License-Alias is not anymore in
> > DEP5, to include to not report copyright-refers-to-symlink-license
> > also if "License: Artistic or GPL-1+" is present?
> >
> > Would it be possible to have somethin like (not tested yet!)
> > ---(patch)--------------------------------------------------------------
> > --- lintian-2.2.17.orig/checks/copyright-file 2009-10-04 19:01:38.000000000 +0200
> > +++ lintian-2.2.17/checks/copyright-file 2009-10-04 19:04:43.000000000 +0200
> > @@ -161,7 +161,8 @@
> >  # our false positives for GPL references that don't include a specific version
> >  # number, but it will get the obvious ones.
> >  if (m,(usr/share/common-licenses/(L?GPL|GFDL))([^-]),i && !m,as Perl itself,i
> > -    && !m,License-Alias:\s+Perl,) {
> > +    && !m,License-Alias:\s+Perl,
> > +    && !m,License:\s+Artistic\s+or\s+GPL-1\+,) {
> >      my ($ref, $license, $separator) = ($1, $2, $3);
> >      if ($separator =~ /[\d\w]/) {
> >   tag 'copyright-refers-to-nonexistent-license-file', "$ref$separator";
> > ------------------------------------------------------------------------
>
> Dear all,
>
> the License-Alias field was indeed removed from the DEP 5 proposal, which now
> speficies directly that the Perl license keyword means ‘GPL-1+ or Artistic’.
> Hence, I would recommend to simply use ‘License: Perl’. Therefore, the above
> regular expression could be: m,License(?:-Alias)?\s*:\s+Perl,
> (not tested).
Ok, I agree with that. My reasoning was to have also the "License:
Artistic or GPL-1+" matched too, since this is still 'alowed' even
there is the keyword "License: Perl". But my above proposal does not
cover the case "License: Perl", you are right.

Charles, would you agree to have the above for "License-Alias: Perl",
"License: Perl" and "License: Artistic or GPL-1+"?

Bests
Salvatore


signature.asc (853 bytes) Download Attachment

Re: Bug#549596: lintian: Do not tag copyright-refers-to-symlink-license usr/share/common-licenses/GPL when debian/copyright contains "License: Artistic or GPL-1+"

by Charles Plessy-12 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Le Sun, Oct 25, 2009 at 09:18:38AM +0100, Salvatore Bonaccorso a écrit :
>
> Charles, would you agree to have the above for "License-Alias: Perl",
> "License: Perl" and "License: Artistic or GPL-1+"?

No problem.

Cheers,

--
Charles


--
To UNSUBSCRIBE, email to debian-perl-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...


Re: Bug#549596: lintian: Do not tag copyright-refers-to-symlink-license usr/share/common-licenses/GPL when debian/copyright contains "License: Artistic or GPL-1+"

by Salvatore Bonaccorso-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi all

On Sun, Oct 25, 2009 at 07:01:43PM +0900, Charles Plessy wrote:
> Le Sun, Oct 25, 2009 at 09:18:38AM +0100, Salvatore Bonaccorso a écrit :
> >
> > Charles, would you agree to have the above for "License-Alias: Perl",
> > "License: Perl" and "License: Artistic or GPL-1+"?
>
> No problem.

Ok, here is the accordingly updated proposed patch:

---(patch)--------------------------------------------------------------
diff -urN lintian-2.2.17.orig/checks/copyright-file lintian-2.2.17/checks/copyright-file
--- lintian-2.2.17.orig/checks/copyright-file   2009-10-28 10:37:32.000000000 +0100
+++ lintian-2.2.17/checks/copyright-file        2009-10-28 10:39:24.000000000 +0100
@@ -161,7 +161,9 @@
 # our false positives for GPL references that don't include a specific version
 # number, but it will get the obvious ones.
 if (m,(usr/share/common-licenses/(L?GPL|GFDL))([^-]),i && !m,as Perl itself,i
-    && !m,License-Alias:\s+Perl,) {
+    && !m,License-Alias:\s+Perl,
+    && !m,License:\s+Artistic\s+or\s+GPL-1\+,
+    && !m,License:\s+Perl,) {
     my ($ref, $license, $separator) = ($1, $2, $3);
     if ($separator =~ /[\d\w]/) {
        tag 'copyright-refers-to-nonexistent-license-file', "$ref$separator";
------------------------------------------------------------------------

Thank you for checking and consideration
Bests
Salvatore


signature.asc (853 bytes) Download Attachment