Bug#554459: ack-grep: --pager does not work

View: New views
2 Messages — Rating Filter:   Alert me  

Bug#554459: ack-grep: --pager does not work

by Gustavo Noronha Silva :: Rate this Message:

Reply (Restricted by the Administrator) | Reply to Author | View Threaded | Show Only this Message

Package: ack-grep
Version: 1.90-1
Severity: normal

I am trying to use less to pipe the output of ack-grep, but it never
works. Looks like less is never called. I am using it like this:

 $ ack-grep --pager=less search_term

Thanks,

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.31-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages ack-grep depends on:
ii  libfile-next-perl             1.06-1     file-finding iterator
ii  perl                          5.10.1-6   Larry Wall's Practical Extraction

ack-grep recommends no packages.

Versions of packages ack-grep suggests:
ii  bash-completion               1:1.1-1    programmable completion for the ba

-- no debconf information



--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...


Bug#554459: ack-grep: --pager does not work

by Ryan Niebur-3 :: Rate this Message:

Reply (Restricted by the Administrator) | Reply to Author | View Threaded | Show Only this Message

tag 554459 pending
quit

Hi,

On Wed, Nov 04, 2009 at 04:06:38PM -0200, Gustavo Noronha Silva wrote:
> Package: ack-grep
> Version: 1.90-1
> Severity: normal
>
> I am trying to use less to pipe the output of ack-grep, but it never
> works. Looks like less is never called. I am using it like this:
>
>  $ ack-grep --pager=less search_term
>

thanks for the bug report. the problem is that ack tries to detect
whether it's outputting to a pipe, in which case it wouldn't run the
pager. however the logic is backwards. so if it is outputting to a
pipe it will run the pager, but if it isn't, it won't run the pager.
I'll upload the fix and forward it upstream when I get to work.

Cheers,
Ryan

--
_________________________
Ryan Niebur
ryanryan52@...


signature.asc (204 bytes) Download Attachment