Bug#673041: marked as forwarded (dialog: rename button does not work with -nook)

Your message dated Fri, 8 Jun 2012 12:06:59 +0200 (CEST)
with message-id <alpine.DEB.2.02.1206081156300.28677@...>
has caused the   report #673041,
regarding dialog: rename button does not work with -nook
to be marked as having been forwarded to the upstream software
author(s) Thomas Dickey <dickey@...>

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@...
immediately.)


--
673041: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=673041
Debian Bug Tracking System
Contact owner@... with problems

Hello.

Received this report from the Debian BTS.
Is the patch correct?

---------- Forwarded message ----------
From: Serge Hallyn <serge.hallyn@...>
To: Debian Bug Tracking System <submit@...>
Date: Tue, 15 May 2012 11:50:38 -0500
Subject: Bug#673041: dialog: rename button does not work with -nook

Package: dialog
Version: 1.1-20120215-1
Severity: important
Tags: patch
User: ubuntu-devel@...
Usertags: origin-ubuntu quantal ubuntu-patch

Dear Maintainer,

If I do

dialog --clear --nook --inputmenu "a" 20 50 10 "Username:" "a"

then the rename button does not work - it exits immediately rather than
letting me rename the field contents.  With the following patch, thanks
to Lebedev Vadim, it is fixed.

*** /tmp/tmpGdzkvU/bug_body
In Ubuntu, the attached patch was applied to achieve the following:

  [ Lebedev Vadim ]
  * debian/patches/bug_fix_333909: fix -rename and -nook button together.
    (LP: #333909)

Thanks for considering the patch.

diff -Nru dialog-1.1-20120215/debian/patches/bug_fix_333909 dialog-1.1-20120215/debian/patches/bug_fix_333909
--- dialog-1.1-20120215/debian/patches/bug_fix_333909 1969-12-31 18:00:00.000000000 -0600
+++ dialog-1.1-20120215/debian/patches/bug_fix_333909 2012-05-15 11:41:24.000000000 -0500
@@ -0,0 +1,20 @@
+Description: correct mapping of button-codes with --nook option
+Author: Lebedev Vadim <abraham1901@...>
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/dialog/+bug/333909
+Reviewed-By: Serge Hallyn <serge.hallyn@...>
+Last-Update: <15-05-2012>
+
+--- dialog-1.1-20111020.orig/menubox.c
++++ dialog-1.1-20111020/menubox.c
+@@ -686,7 +686,10 @@ dlg_menu(const char *title,
+ FALSE, width);
+ break;
+    case DLGK_ENTER:
+- result = dlg_enter_buttoncode(button);
++                if (is_inputmenu)
++                   result = dlg_ok_buttoncode(button);
++                else
++                   result = dlg_enter_buttoncode(button);
+
+ /*
+ * If dlg_menu() is called from dialog_menu(), we want to
diff -Nru dialog-1.1-20120215/debian/patches/series dialog-1.1-20120215/debian/patches/series
--- dialog-1.1-20120215/debian/patches/series 1969-12-31 18:00:00.000000000 -0600
+++ dialog-1.1-20120215/debian/patches/series 2012-05-15 11:41:03.000000000 -0500
@@ -0,0 +1 @@
+bug_fix_333909