Bug in sigattr.c

View: New views
1 Messages — Rating Filter:   Alert me  

Bug in sigattr.c

by Heyman, Michael :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Using the openscep 0.4.2 port on FreeBSD, scepd cored regularly when
called via the pkiclient.exe perl script. I tracked the problem down to
a debug print line in lib/sigattr.c - the printf was expecting a missing
parameter (I also found "go" instead of "got" in the same printf).

-Michael Heyman



--- sigattr.c.old Thu Sep 20 10:09:19 2007
+++ sigattr.c Thu Sep 20 10:09:30 2007
@@ -96,12 +96,12 @@
  /* get the attribute as an ASN1_OCTET_STRING
*/
  asn1 = sigattr_asn1_octet(scep, attrname);
  if (asn1 == NULL)
  return NULL;
  if (debug)
- BIO_printf(bio_err, "%s:%d: go an asn1 string for %s\n",
- __FILE__, __LINE__);
+ BIO_printf(bio_err, "%s:%d: got an asn1 string for
%s\n",
+ __FILE__, __LINE__, attrname);
 
  /* unpack the ASN1_STRING into a C-String (0-terminated)
*/
  *len = ASN1_STRING_length(asn1);
  data = (unsigned char *)malloc(*len);
  memcpy(data, ASN1_STRING_data(asn1), *len);