Bug in the multi-client code in Player 3.0.0?

View: New views
2 Messages — Rating Filter:   Alert me  

Bug in the multi-client code in Player 3.0.0?

by Michael Bienia-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello,

is there a bug in the multi-client code of libplayerc in Player 3.0.0?
I ask because I have trouble with playernav as it doesn't get any data
back from the player server. After digging in the code and comparing the
playerc_mclient_peek() code with the one for playerc_client_peek(), I
came to the attached fix (or work-around). With this change playernav
works for me again, but as I've only one robot available I can't test
the patch properly.
Could someone please comment on it and/or propose a better fix?

Thanks,
Michael


=== modified file 'client_libs/libplayerc/mclient.c'
--- client_libs/libplayerc/mclient.c 2009-09-21 11:16:07 +0000
+++ client_libs/libplayerc/mclient.c 2009-10-14 13:04:46 +0000
@@ -110,6 +110,7 @@
   // Configure poll structure to wait for incoming data
   for (i = 0; i < mclient->client_count; i++)
   {
+    playerc_client_requestdata(mclient->client[i]);
     mclient->pollfd[i].fd = mclient->client[i]->sock;
     mclient->pollfd[i].events = POLLIN;
     mclient->pollfd[i].revents = 0;



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Playerstage-users mailing list
Playerstage-users@...
https://lists.sourceforge.net/lists/listinfo/playerstage-users

Re: Bug in the multi-client code in Player 3.0.0?

by Toby Collett-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I have applied this to svn trunk, hoepfully this helps with some of the other playernav issues seen recently.

Thanks,
Toby

2009/10/14 Michael Bienia <michael@...>
Hello,

is there a bug in the multi-client code of libplayerc in Player 3.0.0?
I ask because I have trouble with playernav as it doesn't get any data
back from the player server. After digging in the code and comparing the
playerc_mclient_peek() code with the one for playerc_client_peek(), I
came to the attached fix (or work-around). With this change playernav
works for me again, but as I've only one robot available I can't test
the patch properly.
Could someone please comment on it and/or propose a better fix?

Thanks,
Michael

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Playerstage-users mailing list
Playerstage-users@...
https://lists.sourceforge.net/lists/listinfo/playerstage-users



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Playerstage-users mailing list
Playerstage-users@...
https://lists.sourceforge.net/lists/listinfo/playerstage-users