Build 1.4-rc5 this weekend?

[jthomerson]

Can everyone please review open issues against 1.4 and see if there is
anything that would prevent me from building 1.4-rc5 this weekend?
Hopefully we could build it and then promote it fairly quickly to
final.

--
Jeremy Thomerson
http://www.wickettraining.com

[Alexandru Objelean]

I would be happy to see a new release, because it contains a very important fix:
StatelessForm problems with query string. This issue prevents me to make the page stateless and this is quite critical.

Thank you!
Alex Objelean  

Jeremy Thomerson-5 wrote:

Can everyone please review open issues against 1.4 and see if there is
anything that would prevent me from building 1.4-rc5 this weekend?
Hopefully we could build it and then promote it fairly quickly to
final.

--
Jeremy Thomerson
http://www.wickettraining.com

[jthomerson]

That's the specific issue that keeps rc4 from becoming final.  :)

--
Jeremy Thomerson
http://www.wickettraining.com




On Wed, Jun 3, 2009 at 12:19 AM, Alex Objelean <alex_objelean@...> wrote:

>
> I would be happy to see a new release, because it contains a very important
> fix:
> http://issues.apache.org/jira/browse/WICKET-1912 StatelessForm problems with
> query string . This issue prevents me to make the page stateless and this is
> quite critical.
>
> Thank you!
> Alex Objelean
>
>
> Jeremy Thomerson-5 wrote:
>>
>> Can everyone please review open issues against 1.4 and see if there is
>> anything that would prevent me from building 1.4-rc5 this weekend?
>> Hopefully we could build it and then promote it fairly quickly to
>> final.
>>
>> --
>> Jeremy Thomerson
>> http://www.wickettraining.com
>>
>>
>
> --
> View this message in context: http://www.nabble.com/Build-1.4-rc5-this-weekend--tp23840463p23845533.html
> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>
>

[mbrictson]

I would very much appreciate a fix for WICKET-2033 before 1.4 goes final. This issue is causing invalid XHTML markup when an ajax form submit is used: the onclick for AjaxButton gets an unescaped "&" instead of "&" (ampersand amp semicolon).

https://issues.apache.org/jira/browse/WICKET-2033

I've added a patch to the JIRA ticket, but I'm not familiar enough with the internals of Wicket to know whether the fix is entirely appropriate.

Jeremy Thomerson-5 wrote:

Can everyone please review open issues against 1.4 and see if there is
anything that would prevent me from building 1.4-rc5 this weekend?
Hopefully we could build it and then promote it fairly quickly to
final.

--
Jeremy Thomerson
http://www.wickettraining.com

[Stefan Lindner]

Yes, it would be very helpful if this cn be fixed before 1.4 goes final.

-----Ursprüngliche Nachricht-----
Von: mbrictson [mailto:matt@...]
Gesendet: Mittwoch, 3. Juni 2009 22:21
An: dev@...
Betreff: Re: Build 1.4-rc5 this weekend?


I would very much appreciate a fix for WICKET-2033 before 1.4 goes final.
This issue is causing invalid XHTML markup when an ajax form submit is used:
the onclick for AjaxButton gets an unescaped "&" instead of "&"
(ampersand amp semicolon).

https://issues.apache.org/jira/browse/WICKET-2033

I've added a patch to the JIRA ticket, but I'm not familiar enough with the
internals of Wicket to know whether the fix is entirely appropriate.


Jeremy Thomerson-5 wrote:

>
> Can everyone please review open issues against 1.4 and see if there is
> anything that would prevent me from building 1.4-rc5 this weekend?
> Hopefully we could build it and then promote it fairly quickly to
> final.
>
> --
> Jeremy Thomerson
> http://www.wickettraining.com
>
>

--
View this message in context: http://www.nabble.com/Build-1.4-rc5-this-weekend--tp23840463p23858735.html
Sent from the Wicket - Dev mailing list archive at Nabble.com.

[Max Bowsher-5]

Jeremy Thomerson wrote:
> Can everyone please review open issues against 1.4 and see if there is
> anything that would prevent me from building 1.4-rc5 this weekend?
> Hopefully we could build it and then promote it fairly quickly to
> final.


WICKET-2303 is a trivial bug that breaks a large proportions of
wicket-devutils inspector.

This being wicket-devutils' inaugural release, it would be especially
nice if it actually worked :-)

The bug has a patch, too.

Max.

[Johan Compagner]

i fixed that one.

On Fri, Jun 5, 2009 at 11:10, Max Bowsher <maxb@...> wrote:

> Jeremy Thomerson wrote:
> > Can everyone please review open issues against 1.4 and see if there is
> > anything that would prevent me from building 1.4-rc5 this weekend?
> > Hopefully we could build it and then promote it fairly quickly to
> > final.
>
>
> WICKET-2303 is a trivial bug that breaks a large proportions of
> wicket-devutils inspector.
>
> This being wicket-devutils' inaugural release, it would be especially
> nice if it actually worked :-)
>
> The bug has a patch, too.
>
> Max.
>
>

[Johan Compagner]

i applied the patch for 1.4 (if this works ok in RC5 i will also back port
it)

it looks ok. Now it will only escape when it is added a tag attribute in
html



On Wed, Jun 3, 2009 at 22:21, mbrictson <matt@...> wrote:

>
> I would very much appreciate a fix for WICKET-2033 before 1.4 goes final.
> This issue is causing invalid XHTML markup when an ajax form submit is
> used:
> the onclick for AjaxButton gets an unescaped "&" instead of "&"
> (ampersand amp semicolon).
>
> https://issues.apache.org/jira/browse/WICKET-2033
>
> I've added a patch to the JIRA ticket, but I'm not familiar enough with the
> internals of Wicket to know whether the fix is entirely appropriate.
>
>
> Jeremy Thomerson-5 wrote:
> >
> > Can everyone please review open issues against 1.4 and see if there is
> > anything that would prevent me from building 1.4-rc5 this weekend?
> > Hopefully we could build it and then promote it fairly quickly to
> > final.
> >
> > --
> > Jeremy Thomerson
> > http://www.wickettraining.com
> >
> >
>
> --
> View this message in context:
> http://www.nabble.com/Build-1.4-rc5-this-weekend--tp23840463p23858735.html
>   Sent from the Wicket - Dev mailing list archive at Nabble.com.
>
>

[jthomerson]

Thanks Johan for working through those.  Unless I hear otherwise, I
will plan on building a release Sunday or Monday.

Speak now or forever hold your release.  :)

--
Jeremy Thomerson
http://www.wickettraining.com




On Fri, Jun 5, 2009 at 7:48 AM, Johan Compagner <jcompagner@...> wrote:

> i applied the patch for 1.4 (if this works ok in RC5 i will also back port
> it)
>
> it looks ok. Now it will only escape when it is added a tag attribute in
> html
>
>
>
> On Wed, Jun 3, 2009 at 22:21, mbrictson <matt@...> wrote:
>
>>
>> I would very much appreciate a fix for WICKET-2033 before 1.4 goes final.
>> This issue is causing invalid XHTML markup when an ajax form submit is
>> used:
>> the onclick for AjaxButton gets an unescaped "&" instead of "&"
>> (ampersand amp semicolon).
>>
>> https://issues.apache.org/jira/browse/WICKET-2033
>>
>> I've added a patch to the JIRA ticket, but I'm not familiar enough with the
>> internals of Wicket to know whether the fix is entirely appropriate.
>>
>>
>> Jeremy Thomerson-5 wrote:
>> >
>> > Can everyone please review open issues against 1.4 and see if there is
>> > anything that would prevent me from building 1.4-rc5 this weekend?
>> > Hopefully we could build it and then promote it fairly quickly to
>> > final.
>> >
>> > --
>> > Jeremy Thomerson
>> > http://www.wickettraining.com
>> >
>> >
>>
>> --
>> View this message in context:
>> http://www.nabble.com/Build-1.4-rc5-this-weekend--tp23840463p23858735.html
>>   Sent from the Wicket - Dev mailing list archive at Nabble.com.
>>
>>
>