Build Broken?

View: New views
6 Messages — Rating Filter:   Alert me  

Build Broken?

by AnthonyW :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Does Lift have a CI server that people can interrogate/monitor?

I just downloaded the source and trying to build it broke due to a
unit test failure:

Failed tests:
  specifies  Band example with namespaces and empty tag

Tests run: 72, Failures: 1, Errors: 0, Skipped: 0

I'm curious if this is just me, or if the build is broken.
Note that I am trying to build with jdk1.6.0_16, Maven 2.2.1, and
Windows Vista 64-bit.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to liftweb@...
To unsubscribe from this group, send email to liftweb+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---


Re: Build Broken?

by AnthonyW :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


OK, found Hudson:  http://hudson.scala-tools.org/job/Lift/

But now if that isn't broken, why is my fresh clone failing?

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to liftweb@...
To unsubscribe from this group, send email to liftweb+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---


Re: Build Broken?

by Joni Freeman-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Hi,

Can you send me surefire test result file at:
lift-base/lift-json/target/surefire-reports/TEST-
net.liftweb.json.XmlExamplesTest.xml

All tests pass on my machine (Ubuntu 8.10, jdk1.6.0_10, Maven 2.0.9),
but I will investigate why it fails on your setup. You can send the
file directly to me, not sure if Google Groups accepts attachments.

Cheers Joni

On 7 marras, 07:22, aw <anth...@...> wrote:
> OK, found Hudson:  http://hudson.scala-tools.org/job/Lift/
>
> But now if that isn't broken, why is my fresh clone failing?
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to liftweb@...
To unsubscribe from this group, send email to liftweb+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---


Re: Build Broken?

by Joni Freeman-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Thanks for the test results. It looked like a charset problem in unit
test. I changed the assertion in test to use more robust case class
comparison instead of String comparison. Please let us know if this
fixes the build on your machine.

Committers, I pushed this small fix directly into master, skipping
Review Board. Please let me know if this is not allowed even if the
change is very small and just for unit tests.

Cheers Joni


On 7 marras, 07:22, aw <anth...@...> wrote:
> OK, found Hudson:  http://hudson.scala-tools.org/job/Lift/
>
> But now if that isn't broken, why is my fresh clone failing?
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to liftweb@...
To unsubscribe from this group, send email to liftweb+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---


Re: Build Broken?

by AnthonyW :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Build is working now.  Thanks!
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to liftweb@...
To unsubscribe from this group, send email to liftweb+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---


Re: Build Broken?

by Derek Chen-Becker-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I don't know how others feel, but I would like all bugs, even for unit tests, to go through issue tracking and review board. Mostly this is so that we have good documentation of what is happening to the codebase and why.

Derek

On Sat, Nov 7, 2009 at 11:45 AM, Joni Freeman <freeman.joni@...> wrote:

Thanks for the test results. It looked like a charset problem in unit
test. I changed the assertion in test to use more robust case class
comparison instead of String comparison. Please let us know if this
fixes the build on your machine.

Committers, I pushed this small fix directly into master, skipping
Review Board. Please let me know if this is not allowed even if the
change is very small and just for unit tests.

Cheers Joni


On 7 marras, 07:22, aw <anth...@...> wrote:
> OK, found Hudson:  http://hudson.scala-tools.org/job/Lift/
>
> But now if that isn't broken, why is my fresh clone failing?



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to liftweb@...
To unsubscribe from this group, send email to liftweb+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---