Building embedded minimal on Mips64 (2.6.30 needs a patch)

[Jan Rovins]

I was trying a very basic build of Embedded-minimal using Mips64
generic, and it failed on the kernel build.

Turns out that there was a typo in  delay.c for mips, and there is a a
patch already out there.
The patch is included in 2.6.31.rc1,  I wonder if  there will be a  
2.6.30.1 with the fix?
Anyway, here is the patch from off the web:
------------------------------------------------------------------------------------------
[PATCH] Make it compile.
Click to flag this post

by Alexey Zaytsev-3 Jun 10, 2009; 10:00am :: Rate this Message: - Use
ratings to moderate (?)

Reply | Reply to Author | Print | View Threaded | Show Only this Message
Signed-off-by: Alexey Zaytsev <zaytsev@...>
---
 arch/mips/lib/delay.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/lib/delay.c b/arch/mips/lib/delay.c
index f69c6b5..222bed0 100644
--- a/arch/mips/lib/delay.c
+++ b/arch/mips/lib/delay.c
@@ -51,6 +51,6 @@ void __ndelay(unsigned long ns)
 {
  unsigned int lpj = current_cpu_data.udelay_val;
 
- __delay((us * 0x00000005 * HZ * lpj) >> 32);
+ __delay((ns * 0x00000005 * HZ * lpj) >> 32);
 }
 EXPORT_SYMBOL(__ndelay);

Jan



-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
lists@... with a subject of: unsubscribe t2

[Jan Rovins]

Sorry, That patch that I cut & pasted off the web did not apply cleanly,
Had to fix it up by hand.
----------------------------------------------------

--- a/arch/mips/lib/delay.c    2009-06-09 23:05:27.000000000 -0400
+++ b/arch/mips/lib/delay.c    2009-07-01 16:41:32.180306557 -0400

@@ -51,6 +51,6 @@
 {
     unsigned int lpj = current_cpu_data.udelay_val;
 
-    __delay((us * 0x00000005 * HZ * lpj) >> 32);
+    __delay((ns * 0x00000005 * HZ * lpj) >> 32);
 }
 EXPORT_SYMBOL(__ndelay);

------------------------------------------------------

Attaching it as a file too.

So much trouble for a change of only 2 chars :-)

Jan



Jan Rovins wrote:

>
> I was trying a very basic build of Embedded-minimal using Mips64
> generic, and it failed on the kernel build.
>
> Turns out that there was a typo in  delay.c for mips, and there is a a
> patch already out there.
> The patch is included in 2.6.31.rc1,  I wonder if  there will be a  
> 2.6.30.1 with the fix?
> Anyway, here is the patch from off the web:
> ------------------------------------------------------------------------------------------
>
> [PATCH] Make it compile.
> Click to flag this post
>
> by Alexey Zaytsev-3 Jun 10, 2009; 10:00am :: Rate this Message: - Use
> ratings to moderate (?)
>
> Reply | Reply to Author | Print | View Threaded | Show Only this Message
> Signed-off-by: Alexey Zaytsev <zaytsev@...>
> ---
> arch/mips/lib/delay.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/lib/delay.c b/arch/mips/lib/delay.c
> index f69c6b5..222bed0 100644
> --- a/arch/mips/lib/delay.c
> +++ b/arch/mips/lib/delay.c
> @@ -51,6 +51,6 @@ void __ndelay(unsigned long ns)
> {
>  unsigned int lpj = current_cpu_data.udelay_val;
>
> - __delay((us * 0x00000005 * HZ * lpj) >> 32);
> + __delay((ns * 0x00000005 * HZ * lpj) >> 32);
> }
> EXPORT_SYMBOL(__ndelay);
>
> Jan
>
>
>
> ----------------------------------------------------------- If you
> wish to unsubscribe from this mailing, send mail to
> lists@... with a subject of: unsubscribe t2

--- a/arch/mips/lib/delay.c 2009-06-09 23:05:27.000000000 -0400
+++ b/arch/mips/lib/delay.c 2009-07-01 16:41:32.180306557 -0400

@@ -51,6 +51,6 @@
 {
  unsigned int lpj = current_cpu_data.udelay_val;
 
- __delay((us * 0x00000005 * HZ * lpj) >> 32);
+ __delay((ns * 0x00000005 * HZ * lpj) >> 32);
 }
 EXPORT_SYMBOL(__ndelay);

-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
lists@... with a subject of: unsubscribe t2