Buildreport for GnuTLS 2.8.3

[Tom G. Christensen-2]

I grabbed GnuTLS 2.8.3 and tried building it on IRIX 5.3 and 6.2.

It builds and passes the testsuite on IRIX 6.2.
However I'm still seeing these during the build:
In file included from ../gnutls_int.h:29,
                 from opencdk.h:30,
                 from main.c:36:
../config.h:367:1: warning: "SIZE_MAX" redefined
In file included from ./../gl/stdlib.h:52,
                 from ./../gl/unistd.h:40,
                 from main.c:30:
./../gl/stdint.h:473:1: warning: this is the location of the previous definition

Bruno committed a fix for this to size_max.m4 when it was brought up on
bug-gnulib a few months ago but the copies included in gnutls are
too old and don't have the fix.

It fails to build on IRIX 5.3 due to missing siginterrupt function:
ld: ERROR 33: Unresolved text symbol "siginterrupt" -- 1st referenced by
tests.o.

Since gnulib does not provide a siginterrupt replacement I instead added
the replacement used by bash 4.0 to tests.c:
static int
siginterrupt (sig, flag)
     int sig, flag;
{
  struct sigaction act;

  sigaction (sig, (struct sigaction *)NULL, &act);

  if (flag)
    act.sa_flags &= ~SA_RESTART;
  else
    act.sa_flags |= SA_RESTART;

  return (sigaction (sig, &act, (struct sigaction *)NULL));
}

With that added the build completes and passes the testsuite.

-tgc


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Simon Josefsson-2]

"Tom G. Christensen" <tgc@...> writes:

> I grabbed GnuTLS 2.8.3 and tried building it on IRIX 5.3 and 6.2.
>
> It builds and passes the testsuite on IRIX 6.2.
> However I'm still seeing these during the build:
> In file included from ../gnutls_int.h:29,
>                  from opencdk.h:30,
>                  from main.c:36:
> ../config.h:367:1: warning: "SIZE_MAX" redefined
> In file included from ./../gl/stdlib.h:52,
>                  from ./../gl/unistd.h:40,
>                  from main.c:30:
> ./../gl/stdint.h:473:1: warning: this is the location of the previous definition
>
> Bruno committed a fix for this to size_max.m4 when it was brought up on
> bug-gnulib a few months ago but the copies included in gnutls are
> too old and don't have the fix.

I pushed the updated size_max.m4 file from gnulib into the gnutls_2_8_x
branch.  Please test tomorrow's daily snapshot to make sure it fixes
your problem.  I assume it is fixed in 2.9.x already.

Thanks,
/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Tom G. Christensen-2]

On Mon, Aug 17, 2009 at 03:58:44PM +0200, Simon Josefsson wrote:
> I pushed the updated size_max.m4 file from gnulib into the gnutls_2_8_x
> branch.  Please test tomorrow's daily snapshot to make sure it fixes
> your problem.  I assume it is fixed in 2.9.x already.
>
I built the daily snapshot but lib/m4/size_max.m4 is still downrev.

The log was submitted to autobuild.josefsson.org.

-tgc


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Simon Josefsson-2]

"Tom G. Christensen" <tgc@...> writes:

> On Mon, Aug 17, 2009 at 03:58:44PM +0200, Simon Josefsson wrote:
>> I pushed the updated size_max.m4 file from gnulib into the gnutls_2_8_x
>> branch.  Please test tomorrow's daily snapshot to make sure it fixes
>> your problem.  I assume it is fixed in 2.9.x already.
>>
> I built the daily snapshot but lib/m4/size_max.m4 is still downrev.
>
> The log was submitted to autobuild.josefsson.org.

Could you check if the size_max.m4 files in your build have 'serial 9'
in the first line?  Maybe you tested before the packages was updated.
You could test the 2.9.3 release now.

It seems that either Bruno's solution didn't work, or something else
needs to be back-ported as well, but I'm not sure what.

/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Tom G. Christensen-2]

On Thu, Aug 20, 2009 at 12:07:54AM +0200, Simon Josefsson wrote:
> Could you check if the size_max.m4 files in your build have 'serial 9'
> in the first line?  Maybe you tested before the packages was updated.
> You could test the 2.9.3 release now.
>
I was initially using your daily-build script but then I noticed that
the gnutls snapshot has not been updated since Aug 13th.

$ sha1sum ../gnutls-2.9.3.tar.bz2
6e7157274df5c95984fd52c4d500a414a67b9d44  ../gnutls-2.9.3.tar.bz2
[gnutls-2.9.3]$ find . -name 'size_max.m4' | xargs head -1
==> ./gl/m4/size_max.m4 <==
# size_max.m4 serial 9

==> ./lib/m4/size_max.m4 <==
# size_max.m4 serial 6

Brunos fix should be fine, I see the toplevel config.h correctly
guarding the define with an ifndef SIZE_MAX.

-tgc


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Simon Josefsson-2]

"Tom G. Christensen" <tgc@...> writes:

> On Thu, Aug 20, 2009 at 12:07:54AM +0200, Simon Josefsson wrote:
>> Could you check if the size_max.m4 files in your build have 'serial 9'
>> in the first line?  Maybe you tested before the packages was updated.
>> You could test the 2.9.3 release now.
>>
> I was initially using your daily-build script but then I noticed that
> the gnutls snapshot has not been updated since Aug 13th.
>
> $ sha1sum ../gnutls-2.9.3.tar.bz2
> 6e7157274df5c95984fd52c4d500a414a67b9d44  ../gnutls-2.9.3.tar.bz2
> [gnutls-2.9.3]$ find . -name 'size_max.m4' | xargs head -1
> ==> ./gl/m4/size_max.m4 <==
> # size_max.m4 serial 9
>
> ==> ./lib/m4/size_max.m4 <==
> # size_max.m4 serial 6

Oops, the build robot haven't been able to build it since then, the
"resume" test is failing.  I suspect it is related to the TLS session
ticket support that went in recently.  Build log:

http://autobuild.josefsson.org/gnutls/log-200908241414540949000.txt

I'm working on it.

/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Daiki Ueno]

>>>>> In <87skfghqgl.fsf@...>
>>>>> Simon Josefsson <simon@...> wrote:
> Oops, the build robot haven't been able to build it since then, the
> "resume" test is failing.  I suspect it is related to the TLS session
> ticket support that went in recently.  Build log:

> http://autobuild.josefsson.org/gnutls/log-200908241414540949000.txt

> I'm working on it.

Oops, it seems that I installed a double-free bug along with memleak
fixes...  Sorry for taking your time.

Here is a patch to fix it:


diff --git a/tests/resume.c b/tests/resume.c
index 9c23940..cbd4968 100644
--- a/tests/resume.c
+++ b/tests/resume.c
@@ -422,6 +422,7 @@ server (struct params_res *params)
     }
 
   gnutls_free (session_ticket_key.data);
+  session_ticket_key.data = NULL;
 
   success ("server: finished\n");
 }
@@ -459,7 +460,7 @@ doit (void)
       else
  {
   client (&resume_tests[i]);
-  global_stop ();
+  gnutls_global_deinit ();
   exit (0);
  }
     }


Regerds,
--
Daiki Ueno

_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Simon Josefsson-2]

Daiki Ueno <ueno@...> writes:

> Oops, it seems that I installed a double-free bug along with memleak
> fixes...  Sorry for taking your time.

You were too quick!  Thanks, confirmed working and pushed.  Now let's
hope the build robot continues..

/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Tom G. Christensen-2]

On Mon, Aug 24, 2009 at 11:49:03PM +0200, Simon Josefsson wrote:
> You were too quick!  Thanks, confirmed working and pushed.  Now let's
> hope the build robot continues..
>
I see new datestamped tarballs appearing but no gnutls-latest?

Also size_max.m4 is still too old:
$ sha1sum ../gnutls-20090826.tar.bz2
ecdd0903a92dc2bb9fd77a83c2939a393b293fb4  ../gnutls-20090826.tar.bz2
[gnutls-2.9.4]$ find . -name size_max.m4 | xargs head -1
==> ./lib/m4/size_max.m4 <==
# size_max.m4 serial 6
==> ./gl/m4/size_max.m4 <==
# size_max.m4 serial 9

-tgc


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Simon Josefsson-2]

"Tom G. Christensen" <tgc@...> writes:

> On Mon, Aug 24, 2009 at 11:49:03PM +0200, Simon Josefsson wrote:
>> You were too quick!  Thanks, confirmed working and pushed.  Now let's
>> hope the build robot continues..
>>
> I see new datestamped tarballs appearing but no gnutls-latest?

Right, that was because I turned off *.tar.gz, and the script that
created the gnutls-latest ssymlink didn't understand *.bz2.  Fixed now.

> Also size_max.m4 is still too old:
> $ sha1sum ../gnutls-20090826.tar.bz2
> ecdd0903a92dc2bb9fd77a83c2939a393b293fb4  ../gnutls-20090826.tar.bz2
> [gnutls-2.9.4]$ find . -name size_max.m4 | xargs head -1
> ==> ./lib/m4/size_max.m4 <==
> # size_max.m4 serial 6
> ==> ./gl/m4/size_max.m4 <==
> # size_max.m4 serial 9

Ah, lib/m4/size_max.m4 is generated by gettext.  I have added an ugly
workaround to cfg.mk, please try the most recent snapshot.

/Simon


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel

[Tom G. Christensen-2]

On Fri, Aug 28, 2009 at 06:32:23PM +0200, Simon Josefsson wrote:
> Ah, lib/m4/size_max.m4 is generated by gettext.  I have added an ugly
> workaround to cfg.mk, please try the most recent snapshot.
>
Just to confirm that this change indeed took care of it:
http://autobuild.josefsson.org/gnutls/log-200909030118481064000.txt

Thanks.

-tgc


_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@...
http://lists.gnu.org/mailman/listinfo/gnutls-devel