CONTINUUM-1569 and 2193 staged

View: Old framed views
5 Messages — Rating Filter:   Alert me  
Deng Ching-2
CONTINUUM-1569 and 2193 staged
Reply More
Rate this Message:
Print
Show in thread view
Show in list view (by date)
Permalink
Hi,

I've staged the binaries for the continuum-flat-multi-module branch at:

http://people.apache.org/~oching/continuum-flat-multi-module/

These are the changes in the branch:
1. Multi-module projects (both regular and flat) can be checked out into a
single directory. To do this, just tick the 'Checkout multi-module project
in single directory' checkbox when you add a Maven 2 project.
2. Releasing flat multi-module projects is now possible. The regular release
process applies when releasing a flat multi-module project.

I haven't committed the fix in maven-release (MRELEASE-261) yet as I'm still
waiting for someone to review it first. So if you want to build from source,
you need to checkout maven-release first then apply MRELEASE-261 and build
maven-release. The staged binaries which I've built locally already has that
fix in though.

If everyone's ok with the changes I've made, I'll merge the branch to
trunk..

Thanks,
Deng
brettporter
Re: CONTINUUM-1569 and 2193 staged
Reply More
Rate this Message:
Print
Show in thread view
Show in list view (by date)
Permalink
This is one of the mails that I wound up losing track of since May  
was, um, busy :)

Did this already get merged to trunk?

On 13/05/2009, at 8:49 PM, Deng Ching wrote:

> Hi,
>
> I've staged the binaries for the continuum-flat-multi-module branch  
> at:
>
> http://people.apache.org/~oching/continuum-flat-multi-module/
>
> These are the changes in the branch:
> 1. Multi-module projects (both regular and flat) can be checked out  
> into a
> single directory. To do this, just tick the 'Checkout multi-module  
> project
> in single directory' checkbox when you add a Maven 2 project.
> 2. Releasing flat multi-module projects is now possible. The regular  
> release
> process applies when releasing a flat multi-module project.
>
> I haven't committed the fix in maven-release (MRELEASE-261) yet as  
> I'm still
> waiting for someone to review it first. So if you want to build from  
> source,
> you need to checkout maven-release first then apply MRELEASE-261 and  
> build
> maven-release. The staged binaries which I've built locally already  
> has that
> fix in though.
>
> If everyone's ok with the changes I've made, I'll merge the branch to
> trunk..
>
> Thanks,
> Deng

Deng Ching-2
Re: CONTINUUM-1569 and 2193 staged
Reply More
Rate this Message:
Print
Show in thread view
Show in list view (by date)
Permalink
Not yet :( I'm planning to merge it next week..

Thanks,
Deng

On Thu, Jul 2, 2009 at 10:36 AM, Brett Porter <brett@...> wrote:

> This is one of the mails that I wound up losing track of since May was, um,
> busy :)
>
> Did this already get merged to trunk?
>
>
> On 13/05/2009, at 8:49 PM, Deng Ching wrote:
>
>  Hi,
>>
>> I've staged the binaries for the continuum-flat-multi-module branch at:
>>
>> http://people.apache.org/~oching/continuum-flat-multi-module/<http://people.apache.org/%7Eoching/continuum-flat-multi-module/>
>>
>> These are the changes in the branch:
>> 1. Multi-module projects (both regular and flat) can be checked out into a
>> single directory. To do this, just tick the 'Checkout multi-module project
>> in single directory' checkbox when you add a Maven 2 project.
>> 2. Releasing flat multi-module projects is now possible. The regular
>> release
>> process applies when releasing a flat multi-module project.
>>
>> I haven't committed the fix in maven-release (MRELEASE-261) yet as I'm
>> still
>> waiting for someone to review it first. So if you want to build from
>> source,
>> you need to checkout maven-release first then apply MRELEASE-261 and build
>> maven-release. The staged binaries which I've built locally already has
>> that
>> fix in though.
>>
>> If everyone's ok with the changes I've made, I'll merge the branch to
>> trunk..
>>
>> Thanks,
>> Deng
>>
>
>
Emmanuel Venisse-2
Re: CONTINUUM-1569 and 2193 staged
Reply More
Rate this Message:
Print
Show in thread view
Show in list view (by date)
Permalink
Hi Deng,

I finally found some time to look at your binary.
It is good but I have few comments to have something more useable:
- add by default all modules into a single working directory
- allow to change this default by configuration so if a user prefer to store
each module into a separate working directory, he'll can without to check
the checkbox everytime
- run 'svn up' only once instead of one time by module when we use a single
working directory, the 'svn up' on the parent module already update source
tree for modules
- detect new modules automatically in the working directory and add them in
Continuum
- detect removed modules automatically in the working directory and remove
them from Continuum

Emmanuel

On Thu, Jul 2, 2009 at 8:30 AM, Deng Ching <oching@...> wrote:

> Not yet :( I'm planning to merge it next week..
>
> Thanks,
> Deng
>
> On Thu, Jul 2, 2009 at 10:36 AM, Brett Porter <brett@...> wrote:
>
> > This is one of the mails that I wound up losing track of since May was,
> um,
> > busy :)
> >
> > Did this already get merged to trunk?
> >
> >
> > On 13/05/2009, at 8:49 PM, Deng Ching wrote:
> >
> >  Hi,
> >>
> >> I've staged the binaries for the continuum-flat-multi-module branch at:
> >>
> >> http://people.apache.org/~oching/continuum-flat-multi-module/<http://people.apache.org/%7Eoching/continuum-flat-multi-module/>
> <http://people.apache.org/%7Eoching/continuum-flat-multi-module/>
> >>
> >> These are the changes in the branch:
> >> 1. Multi-module projects (both regular and flat) can be checked out into
> a
> >> single directory. To do this, just tick the 'Checkout multi-module
> project
> >> in single directory' checkbox when you add a Maven 2 project.
> >> 2. Releasing flat multi-module projects is now possible. The regular
> >> release
> >> process applies when releasing a flat multi-module project.
> >>
> >> I haven't committed the fix in maven-release (MRELEASE-261) yet as I'm
> >> still
> >> waiting for someone to review it first. So if you want to build from
> >> source,
> >> you need to checkout maven-release first then apply MRELEASE-261 and
> build
> >> maven-release. The staged binaries which I've built locally already has
> >> that
> >> fix in though.
> >>
> >> If everyone's ok with the changes I've made, I'll merge the branch to
> >> trunk..
> >>
> >> Thanks,
> >> Deng
> >>
> >
> >
>
Deng Ching-2
Re: CONTINUUM-1569 and 2193 staged
Reply More
Rate this Message:
Print
Show in thread view
Show in list view (by date)
Permalink
 Thanks for checking out the staged binary :) I'll get the things you've
mentioned below into the branch

-Deng

On Thu, Jul 2, 2009 at 7:37 PM, Emmanuel Venisse <emmanuel.venisse@...
> wrote:

> Hi Deng,
>
> I finally found some time to look at your binary.
> It is good but I have few comments to have something more useable:
> - add by default all modules into a single working directory
> - allow to change this default by configuration so if a user prefer to
> store
> each module into a separate working directory, he'll can without to check
> the checkbox everytime
> - run 'svn up' only once instead of one time by module when we use a single
> working directory, the 'svn up' on the parent module already update source
> tree for modules
> - detect new modules automatically in the working directory and add them in
> Continuum
> - detect removed modules automatically in the working directory and remove
> them from Continuum
>
> Emmanuel
>
> On Thu, Jul 2, 2009 at 8:30 AM, Deng Ching <oching@...> wrote:
>
> > Not yet :( I'm planning to merge it next week..
> >
> > Thanks,
> > Deng
> >
> > On Thu, Jul 2, 2009 at 10:36 AM, Brett Porter <brett@...> wrote:
> >
> > > This is one of the mails that I wound up losing track of since May was,
> > um,
> > > busy :)
> > >
> > > Did this already get merged to trunk?
> > >
> > >
> > > On 13/05/2009, at 8:49 PM, Deng Ching wrote:
> > >
> > >  Hi,
> > >>
> > >> I've staged the binaries for the continuum-flat-multi-module branch
> at:
> > >>
> > >> http://people.apache.org/~oching/continuum-flat-multi-module/<http://people.apache.org/%7Eoching/continuum-flat-multi-module/>
> <http://people.apache.org/%7Eoching/continuum-flat-multi-module/>
> > <http://people.apache.org/%7Eoching/continuum-flat-multi-module/>
> > >>
> > >> These are the changes in the branch:
> > >> 1. Multi-module projects (both regular and flat) can be checked out
> into
> > a
> > >> single directory. To do this, just tick the 'Checkout multi-module
> > project
> > >> in single directory' checkbox when you add a Maven 2 project.
> > >> 2. Releasing flat multi-module projects is now possible. The regular
> > >> release
> > >> process applies when releasing a flat multi-module project.
> > >>
> > >> I haven't committed the fix in maven-release (MRELEASE-261) yet as I'm
> > >> still
> > >> waiting for someone to review it first. So if you want to build from
> > >> source,
> > >> you need to checkout maven-release first then apply MRELEASE-261 and
> > build
> > >> maven-release. The staged binaries which I've built locally already
> has
> > >> that
> > >> fix in though.
> > >>
> > >> If everyone's ok with the changes I've made, I'll merge the branch to
> > >> trunk..
> > >>
> > >> Thanks,
> > >> Deng
> > >>
> > >
> > >
> >
>