|
»
Calling all committers: The pending-commit list is overflowing
|
View:
New views
11 Messages
—
Rating Filter:
Alert me
|
 |
Calling all committers: The pending-commit list is overflowing
by Adam Barth-3
::
Rate this Message:
We have 43 patches that have been reviewed and are waiting to land:
http://webblaze.org/pending-commit If you're a committer, you can help drive that number to zero. Here's what you can do: 1) If you have a patch on that list, please land it. 2) If you see a patch on the list that's ready to land (almost all of them), you can mark it commit-queue+ to have the commit bot land it. When you do this, please be sure to watch the tree for regressions, just like you would if you typed svn commit yourself. Thanks and happy WebKitting, Adam _______________________________________________ webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
|
|
Re: Calling all committers: The pending-commit list is overflowing
by Adam Barth-3
::
Rate this Message:
Mark correctly points out that I meant:
http://webkit.org/pending-commit (webblaze.org is my server for running experiments.) Adam On Sun, Oct 18, 2009 at 11:34 PM, Adam Barth <abarth@...> wrote: > We have 43 patches that have been reviewed and are waiting to land: > > http://webblaze.org/pending-commit > > If you're a committer, you can help drive that number to zero. Here's > what you can do: > > 1) If you have a patch on that list, please land it. > > 2) If you see a patch on the list that's ready to land (almost all of > them), you can mark it commit-queue+ to have the commit bot land it. > When you do this, please be sure to watch the tree for regressions, > just like you would if you typed svn commit yourself. > > Thanks and happy WebKitting, > Adam > webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
|
|
Re: Calling all committers: The pending-commit list isoverflowing
by Yong Li-4
::
Rate this Message:
----- Original Message ----- From: "Adam Barth" <abarth@...> To: <webkit-dev@...> Sent: Monday, October 19, 2009 3:21 AM Subject: Re: [webkit-dev] Calling all committers: The pending-commit list isoverflowing > If you're a committer, you can help drive that number to zero. Here's > what you can do: > > 1) If you have a patch on that list, please land it. > > 2) If you see a patch on the list that's ready to land (almost all of > them), you can mark it commit-queue+ to have the commit bot land it. > When you do this, please be sure to watch the tree for regressions, > just like you would if you typed svn commit yourself. I got this: "You are not authorized to edit this patch." > > Thanks and happy WebKitting, > Adam > _______________________________________________ webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
|
|
|
|
|
Re: Calling all committers: The pending-commit list is overflowing
by Eric Seidel-6
::
Rate this Message:
On Sun, Oct 18, 2009 at 11:34 PM, Adam Barth <abarth@...> wrote:
> 2) If you see a patch on the list that's ready to land (almost all of > them), you can mark it commit-queue+ to have the commit bot land it. > When you do this, please be sure to watch the tree for regressions, > just like you would if you typed svn commit yourself. FYI, if you're using commit-queue+, you should know about: http://webkit-commit-queue.appspot.com/ which gives you a little window into commit-queue's tiny brain. Eventually I hope to move that to http://commit.webkit.org/ or something easier to remember. -eric _______________________________________________ webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
|
|
Re: Calling all committers: The pending-commit list is overflowing
by Eric Seidel-6
::
Rate this Message:
We're back down to 25 after Yong's epic cq+ing this morning. The
queue had a record 13 patch backlog for a while. Thank you Yong for cleaning the pending-commit list! Still 25 to go. All of which require manual attention from committers. -eric On Mon, Oct 19, 2009 at 11:52 AM, Eric Seidel <eric@...> wrote: > On Sun, Oct 18, 2009 at 11:34 PM, Adam Barth <abarth@...> wrote: >> 2) If you see a patch on the list that's ready to land (almost all of >> them), you can mark it commit-queue+ to have the commit bot land it. >> When you do this, please be sure to watch the tree for regressions, >> just like you would if you typed svn commit yourself. > > FYI, if you're using commit-queue+, you should know about: > http://webkit-commit-queue.appspot.com/ > > which gives you a little window into commit-queue's tiny brain. > Eventually I hope to move that to http://commit.webkit.org/ or > something easier to remember. > > -eric > webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
|
|
Re: Calling all committers: The pending-commit list is overflowing
by Adam Barth-3
::
Rate this Message:
WebKit, you are awesome. We're down to our usual 17 now.
Thanks everyone! Adam On Mon, Oct 19, 2009 at 3:27 PM, Eric Seidel <eric@...> wrote: > We're back down to 25 after Yong's epic cq+ing this morning. The > queue had a record 13 patch backlog for a while. Thank you Yong for > cleaning the pending-commit list! > > Still 25 to go. All of which require manual attention from committers. > > -eric > > On Mon, Oct 19, 2009 at 11:52 AM, Eric Seidel <eric@...> wrote: >> On Sun, Oct 18, 2009 at 11:34 PM, Adam Barth <abarth@...> wrote: >>> 2) If you see a patch on the list that's ready to land (almost all of >>> them), you can mark it commit-queue+ to have the commit bot land it. >>> When you do this, please be sure to watch the tree for regressions, >>> just like you would if you typed svn commit yourself. >> >> FYI, if you're using commit-queue+, you should know about: >> http://webkit-commit-queue.appspot.com/ >> >> which gives you a little window into commit-queue's tiny brain. >> Eventually I hope to move that to http://commit.webkit.org/ or >> something easier to remember. >> >> -eric >> > webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
|
|
Re: Calling all committers: The pending-commit list is overflowing
by David Kilzer
::
Rate this Message:
Why are there 17 patches with review+ that never get landed?
This has bothered me in the past, but I wasn't sure if it was the same group of patches or not. Dave On Mon, October 19, 2009 at 7:08:50 PM, Adam Barth wrote: > WebKit, you are awesome. We're down to our usual 17 now. > > Thanks everyone! > Adam > > > On Mon, Oct 19, 2009 at 3:27 PM, Eric Seidel wrote: > > We're back down to 25 after Yong's epic cq+ing this morning. The > > queue had a record 13 patch backlog for a while. Thank you Yong for > > cleaning the pending-commit list! > > > > Still 25 to go. All of which require manual attention from committers. > > > > -eric > > > > On Mon, Oct 19, 2009 at 11:52 AM, Eric Seidel wrote: > >> On Sun, Oct 18, 2009 at 11:34 PM, Adam Barth wrote: > >>> 2) If you see a patch on the list that's ready to land (almost all of > >>> them), you can mark it commit-queue+ to have the commit bot land it. > >>> When you do this, please be sure to watch the tree for regressions, > >>> just like you would if you typed svn commit yourself. > >> > >> FYI, if you're using commit-queue+, you should know about: > >> http://webkit-commit-queue.appspot.com/ > >> > >> which gives you a little window into commit-queue's tiny brain. > >> Eventually I hope to move that to http://commit.webkit.org/ or > >> something easier to remember. > >> > >> -eric > >> > > > _______________________________________________ > webkit-dev mailing list > webkit-dev@... > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
|
|
Re: Calling all committers: The pending-commit list is overflowing
by Adam Barth-3
::
Rate this Message:
On Mon, Oct 19, 2009 at 8:39 PM, David Kilzer <ddkilzer@...> wrote:
> Why are there 17 patches with review+ that never get landed? > > This has bothered me in the past, but I wasn't sure if it was the same group of patches or not. It's not the same group of patches. Sometimes there are patches with review+ but with comments that need to be addressed by the contributor. Other times, there are dependent patches that haven't been landed. We could be more agressive in clearing out the pending-commit list, but it only seems problematic when it piles up. Adam _______________________________________________ webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
|
|
Re: Calling all committers: The pending-commit list is overflowing
by Adam Barth-3
::
Rate this Message:
On Mon, Oct 19, 2009 at 8:54 PM, Adam Barth <abarth@...> wrote:
> On Mon, Oct 19, 2009 at 8:39 PM, David Kilzer <ddkilzer@...> wrote: >> Why are there 17 patches with review+ that never get landed? >> >> This has bothered me in the past, but I wasn't sure if it was the same group of patches or not. > > It's not the same group of patches. Sometimes there are patches with > review+ but with comments that need to be addressed by the > contributor. Other times, there are dependent patches that haven't > been landed. We could be more agressive in clearing out the > pending-commit list, but it only seems problematic when it piles up. As an experiment, I went through this list in detail and brought it down to 11 patches. The rest fall into the following categories: 1) Epic uber bugs that are incomprehensible. For example: https://bugs.webkit.org/show_bug.cgi?id=27651 https://bugs.webkit.org/show_bug.cgi?id=16768 https://bugs.webkit.org/show_bug.cgi?id=3749 2) Apple contributors who have explicitly asked not to have their patches landed for them, for whatever reason. For example: https://bugs.webkit.org/show_bug.cgi?id=29905 https://bugs.webkit.org/show_bug.cgi?id=30421 3) Patches where the patch has been review+ but the contributor has been asked to consider non-trivial (meaning I can't do it for them) changes. For example: https://bugs.webkit.org/show_bug.cgi?id=30083 I don't see a big need to drive this list all the way to zero. If we could get the review queue down to 11 patches, I'd be a really happy man. :) Adam _______________________________________________ webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
|
|
Re: Calling all committers: The pending-commit list is overflowing
by Roland Steiner
::
Rate this Message:
On Tue, Oct 20, 2009 at 1:56 PM, Adam Barth <abarth@...> wrote:
[...] https://bugs.webkit.org/show_bug.cgi?id=3749 @_@ Whoops, didn't realize that these patches are still active. All ruby work went to https://bugs.webkit.org/show_bug.cgi?id=28420 (not that that makes the patches less incomprehensible... ^_-).
I disabled my patches in 3749. Sorry for the unnecessary workload! - Roland _______________________________________________ webkit-dev mailing list webkit-dev@... http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev |
| Free embeddable forum powered by Nabble | Forum Help |
