Code Review Notes - BAM_28/10/09:(Resending)
|
View:
New views
4 Messages
—
Rating Filter:
Alert me
|
 |
Code Review Notes - BAM_28/10/09:(Resending)
by rathav
::
Rate this Message:
Hi all, Following notes were taken from today's session. 1. Merge *BAM.List* and *BAM.Mgt *bundles with core bundle. * Have only org.wso2.carbon.bam and org.wso2.carbon.bam.ui bundles. 2.BAM.Util--->Constants class should go under core bundle. 3. Mgt.UI * pom.xml should not have a <fragment-host> element. Export all the bundles with *carbon ui *header. * i18n all the messages not only in JSPs but also in client classes. * BAMStatqueryDsClient class need to be separated. * BackendServiceURL should point to the service. Remove the operation from ServiceURL in the client class. * Write common client class and share among all other bundles.( gauges&mgt.ui share common client classes) * BAMStatQueryDsclient class has two constructors. Need to remove. * JSPs should handle exception properly. o Before rendering the page, do all the remote calls. o In websphere after deleting a server redirection to the server list page can be done through CarbonUI.utils--->get context root. o Set the error status to 500 . o forward the errors to carbon/error.jsp. Thanks. -Ratha. _______________________________________________ Carbon-dev mailing list Carbon-dev@... https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev |
|
|
Re: Code Review Notes - BAM_28/10/09:(Resending)
by Afkham Azeez-2
::
Rate this Message:
Dumindu,
Please provide a deadline by which you will be able to complete the enhancements that we discussed during the code review. Azeez
On Thu, Oct 29, 2009 at 4:28 AM, ratha <rathav@...> wrote:
-- -- Afkham Azeez azeez@... WSO2 Inc. http://wso2.com Blog: http://afkham.org _______________________________________________ Carbon-dev mailing list Carbon-dev@... https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev |
|
|
Re: Code Review Notes - BAM_28/10/09:(Resending)
by Afkham Azeez-2
::
Rate this Message:
No response yet. Dumindu, are you on this list?
Azeez
On Thu, Oct 29, 2009 at 4:36 AM, Afkham Azeez <azeez@...> wrote: Dumindu, -- -- Afkham Azeez azeez@... WSO2 Inc. http://wso2.com Blog: http://afkham.org _______________________________________________ Carbon-dev mailing list Carbon-dev@... https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev |
|
|
Re: Code Review Notes - BAM_28/10/09:(Resending)
by Samisa Abeysinghe-4
::
Rate this Message:
We will have to fix the major issues like the error handling in JSPs etc, before the release in two weeks time. But I am not sure if we will have time for all the refactoring, in the next two weeks.
We were struggling to get some basic functions to work last weeks, specially moving to 2.0.2 etc. Improvements in DS and Dashboard improvements caused us major pains on our side (problems were either side). So we ran out of time.
We have to prioritize this list and postpone some of those to later. We will do that this week. There are some more key TODOs along with these like memory profiling and testing with other DBs that we must do, before we do the release. However, we will treat the deadline of end of this month to be a hard deadline, and will focus on all the major must fix issues.
Samisa...
On Sun, Nov 15, 2009 at 5:06 AM, Afkham Azeez <azeez@...> wrote: No response yet. Dumindu, are you on this list? -- Samisa Abeysinghe Director, Engineering - WSO2 Inc. http://www.wso2.com/ - "The Open Source SOA Company" _______________________________________________ Carbon-dev mailing list Carbon-dev@... https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev |
| Free embeddable forum powered by Nabble | Forum Help |
