Compilation of the trunk is currently broken! (spi_vscodec.c)

[Ole Reinhardt-2]

Hi all,

currently compilation of the trunk fails at least for ethernut3 with the
following errors:

home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c: In function
‘VsDecoderSetBass’:
/home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:224: error:
‘VS_BASS_REG’ undeclared (first use in this function)
/home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:224: error:
(Each undeclared identifier is reported only once
/home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:224: error:
for each function it appears in.)
/home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:225: error:
‘VS_ST_AMPLITUDE_LSB’ undeclared (first use in this function)
/home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:225: error:
‘VS_ST_FREQLIMIT_LSB’ undeclared (first use in this function)
/home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:226: error:
‘VS_SB_AMPLITUDE_LSB’ undeclared (first use in this function)
/home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:226: error:
‘VS_SB_FREQLIMIT_LSB’ undeclared (first use in this function)

It's because VS_HAS_BAS_REG is not defined for a platform where no VS
codec is selected. In this case the vs chip is set to "AUDIO0_VSAUTO"
where this value is not declared.

I think VsDecoderSetBass(...) should also only be declared if
VS_HAS_BAS_REG is definded, right? Please somebody who is working on
this driver fix this issue. Thanks!

Bye,

Ole


--
 _____________________________________________________________
|                                                             |
| Embedded-IT                                                 |
|                                                             |
| Ole Reinhardt        Tel. / Fax:        [phone] |
| Luisenstraße 29      Mobil:             [phone] |
| 57076 Siegen         eMail:    ole.reinhardt@... |
| Germany              Web:         http://www.embedded-it.de |
|_____________________________________________________________|

_______________________________________________
http://lists.egnite.de/mailman/listinfo/en-nut-discussion

[uprinz]

Sorry Ole,

my foult. Now fixed.
There are several old new an may be obsolete vlsi drivers. So I may have
got lost at some point.

Ulrich

Ole Reinhardt wrote:

> Hi all,
>
> currently compilation of the trunk fails at least for ethernut3 with the
> following errors:
>
> home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c: In function
> ‘VsDecoderSetBass’:
> /home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:224: error:
> ‘VS_BASS_REG’ undeclared (first use in this function)
> /home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:224: error:
> (Each undeclared identifier is reported only once
> /home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:224: error:
> for each function it appears in.)
> /home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:225: error:
> ‘VS_ST_AMPLITUDE_LSB’ undeclared (first use in this function)
> /home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:225: error:
> ‘VS_ST_FREQLIMIT_LSB’ undeclared (first use in this function)
> /home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:226: error:
> ‘VS_SB_AMPLITUDE_LSB’ undeclared (first use in this function)
> /home/ole/work/NutOS/ethernut/trunk/nut/dev/spi_vscodec.c:226: error:
> ‘VS_SB_FREQLIMIT_LSB’ undeclared (first use in this function)
>
> It's because VS_HAS_BAS_REG is not defined for a platform where no VS
> codec is selected. In this case the vs chip is set to "AUDIO0_VSAUTO"
> where this value is not declared.
>
> I think VsDecoderSetBass(...) should also only be declared if
> VS_HAS_BAS_REG is definded, right? Please somebody who is working on
> this driver fix this issue. Thanks!
>
> Bye,
>
> Ole
>
>

_______________________________________________
http://lists.egnite.de/mailman/listinfo/en-nut-discussion