Nabble - Continuum - Dev

Re: CONTINUUM-2391

2009-11-26T06:33:43Z

On Wed, Nov 25, 2009 at 10:57 PM, Gwen Harold Autencio
<gautencio@...> wrote:
> Build Env page.
> After setting the buildagentgroup of the profile. a list of buildagents of
> the buildagentgroup will be display under the installations area.
> And by clicking a buildagent from the list gives the user a list of the
> localRepositories of the buildagent. And the user can choose what localrepo
> will be used on that build env ?

How will it work when distributed builds is not enabled?

How will upgrades be handled? (The local repo selection is currently
done somewhere else, so there will be old data in the wrong place.)

--
Wendy

Re: Continuum 1.3.5

2009-11-26T00:08:04Z

I think too.

Maybe we can add CONTINUUM-2411 as it should be easy to fix

Emmanuel

On Thu, Nov 26, 2009 at 8:33 AM, Marica Tan <marica.tan@...> wrote:

> I think it's time to do another release for the 1.3.x branch and hopefully
> this will be the last :)
>
> There are 3 remaining issues in 1.3.5:
>
> CONTINUUM-2338 unable to export user db
> CONTINUUM-2380 clarify description of build agent attributes
> CONTINUUM-2394 current build result link is wrong with distributed build
> enabled
>
>
> I was thinking of dropping CONTINUUM-2338 from 1.3.5, but it seems like
> Brett moved it there for a reason so will leave it as is.
>
> Are there any more issues that should be fixed in 1.3.5 or issues that
> should not be in 1.3.5?
>
>
> Thanks,
> --
> Marica
>

Continuum 1.3.5

2009-11-25T23:33:15Z

I think it's time to do another release for the 1.3.x branch and hopefully
this will be the last :)

There are 3 remaining issues in 1.3.5:

CONTINUUM-2338 unable to export user db
CONTINUUM-2380 clarify description of build agent attributes
CONTINUUM-2394 current build result link is wrong with distributed build
enabled

I was thinking of dropping CONTINUUM-2338 from 1.3.5, but it seems like
Brett moved it there for a reason so will leave it as is.

Are there any more issues that should be fixed in 1.3.5 or issues that
should not be in 1.3.5?

Thanks,
--
Marica

Re: CONTINUUM-2391

2009-11-25T22:05:42Z

Yes, they are retrieved through xmlrpc.

Brett Porter wrote:

> Sounds ok to me... I guess getting the list will be interesting as you have to retrieve it over XMLRPC?
>
> On 26/11/2009, at 4:57 PM, Gwen Harold Autencio wrote:
>
>
>> Brett Porter wrote:
>>
>>> On 23/11/2009, at 3:53 PM, Gwen Harold Autencio wrote:
>>>
>>>
>>>
>>>> Build Agent
>>>> 1. Local repositories would be configured throught continuum-buildagent.xml
>>>>
>>>>
>>> ...
>>>
>>>
>>>> Master Agent
>>>> 1. Set the local repository in the build environments page that will be used by the build agent.
>>>>
>>>>
>>> What does this mean exactly? Can you paste how the config in continuum-buildagent.xml would look, and describe what fields / options would be added to the build env page for it?
>>>
>>> - Brett
>>>
>>>
>> In the config file of the build-agent maybe it will look something like this ?
>>
>> <continuum-buildagent-configuration>
>> <continuumServerUrl>http://localhost:8080/continuum/master-xmlrpc</continuumServerUrl>
>> <buildOutputDirectory>data/build-output-directory</buildOutputDirectory>
>> <workingDirectory>data/working-directory</workingDirectory>
>> <installations/>
>> <localRepositories>
>> <localRepository>
>> <name>test-one</name>
>> <location>/home/user/one</location>
>> <layout>default</layout> </localRepository>
>> <localRepository>
>> <name>test-two</name>
>> <location>/home/user/two</location>
>> <layout>default</layout> </localRepository>
>> </localRepositories>
>> </continuum-buildagent-configuration>
>>
>> Build Env page.
>> After setting the buildagentgroup of the profile. a list of buildagents of the buildagentgroup will be display under the installations area.
>> And by clicking a buildagent from the list gives the user a list of the localRepositories of the buildagent. And the user can choose what localrepo will be used on that build env ?
>>
>>
>
>
>

Re: CONTINUUM-2391

2009-11-25T22:03:04Z

Sounds ok to me... I guess getting the list will be interesting as you have to retrieve it over XMLRPC?

On 26/11/2009, at 4:57 PM, Gwen Harold Autencio wrote:

> Brett Porter wrote:
>> On 23/11/2009, at 3:53 PM, Gwen Harold Autencio wrote:
>>
>>
>>> Build Agent
>>> 1. Local repositories would be configured throught continuum-buildagent.xml
>>>
>> ...
>>
>>> Master Agent
>>> 1. Set the local repository in the build environments page that will be used by the build agent.
>>>
>>
>> What does this mean exactly? Can you paste how the config in continuum-buildagent.xml would look, and describe what fields / options would be added to the build env page for it?
>>
>> - Brett
>>
> In the config file of the build-agent maybe it will look something like this ?
>
> <continuum-buildagent-configuration>
> <continuumServerUrl>http://localhost:8080/continuum/master-xmlrpc</continuumServerUrl>
> <buildOutputDirectory>data/build-output-directory</buildOutputDirectory>
> <workingDirectory>data/working-directory</workingDirectory>
> <installations/>
> <localRepositories>
> <localRepository>
> <name>test-one</name>
> <location>/home/user/one</location>
> <layout>default</layout> </localRepository>
> <localRepository>
> <name>test-two</name>
> <location>/home/user/two</location>
> <layout>default</layout> </localRepository>
> </localRepositories>
> </continuum-buildagent-configuration>
>
> Build Env page.
> After setting the buildagentgroup of the profile. a list of buildagents of the buildagentgroup will be display under the installations area.
> And by clicking a buildagent from the list gives the user a list of the localRepositories of the buildagent. And the user can choose what localrepo will be used on that build env ?
>

Re: CONTINUUM-2391

2009-11-25T21:57:03Z

Brett Porter wrote:

> On 23/11/2009, at 3:53 PM, Gwen Harold Autencio wrote:
>
>
>> Build Agent
>> 1. Local repositories would be configured throught continuum-buildagent.xml
>>
> ...
>
>> Master Agent
>> 1. Set the local repository in the build environments page that will be used by the build agent.
>>
>
> What does this mean exactly? Can you paste how the config in continuum-buildagent.xml would look, and describe what fields / options would be added to the build env page for it?
>
> - Brett
>

In the config file of the build-agent maybe it will look something like this ?

<continuum-buildagent-configuration>
<continuumServerUrl>http://localhost:8080/continuum/master-xmlrpc</continuumServerUrl>
<buildOutputDirectory>data/build-output-directory</buildOutputDirectory>
<workingDirectory>data/working-directory</workingDirectory>
<installations/>
<localRepositories>
<localRepository>
<name>test-one</name>
<location>/home/user/one</location>
<layout>default</layout>
</localRepository>
<localRepository>
<name>test-two</name>
<location>/home/user/two</location>
<layout>default</layout>
</localRepository>
</localRepositories>
</continuum-buildagent-configuration>

Build Env page.
After setting the buildagentgroup of the profile. a list of buildagents of the buildagentgroup will be display under the installations area.
And by clicking a buildagent from the list gives the user a list of the localRepositories of the buildagent. And the user can choose what localrepo will be used on that build env ?

Re: CONTINUUM-2391

2009-11-25T06:08:14Z

On 23/11/2009, at 3:53 PM, Gwen Harold Autencio wrote:

> Build Agent
> 1. Local repositories would be configured throught continuum-buildagent.xml
...
> Master Agent
> 1. Set the local repository in the build environments page that will be used by the build agent.

What does this mean exactly? Can you paste how the config in continuum-buildagent.xml would look, and describe what fields / options would be added to the build env page for it?

- Brett

CONTINUUM-2391

2009-11-22T20:53:20Z

Hi,

Our team in exist would like to work on CONTINUUM-2391 - Master should
not pass full path to local repository to the agent.

Build Agent
1. Local repositories would be configured throught continuum-buildagent.xml
2. If no local repositories are configured use the default local
repository,
Master Agent
1. Set the local repository in the build environments page that will be
used by the build agent.
2. If the user didn't set a specific build agent, use the default local
repository.

Comments, suggestions and/or violent reactions would help.

Thanks,
Gwen

Re: CONTINUUM-2342

2009-11-18T00:10:37Z

I could be one of them but I think Julien wanted to work on it so I'll let
him send a patch.

I moved it to 1.4.0.

Emmanuel

On Tue, Nov 17, 2009 at 11:42 PM, Brett Porter <brett@...> wrote:

> +1. There are several people here that can fix it, but I'm not one of them
> (unless there are patches :)
>
> Cheers,
> Brett
>
> On 18/11/2009, at 1:17 AM, Emmanuel Venisse wrote:
>
> > Hi,
> >
> > What do you think if we move CONTINUUM-2342 to 1.4.x? It isn't an
> important
> > bug and we have some work to do to fix it.
> >
> > I think we have a risk to fix it now.
> >
> > Emmanuel
>
>

Re: svn commit: r881150 - /continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java

2009-11-17T15:12:05Z

Done. Thanks :D

--
Marica

On Tue, Nov 17, 2009 at 12:55 PM, Brett Porter <brett@...> wrote:

> It is probably more reliable to do result.getOutput().replace( "\\", "/"
> ).contains( "test/executable/mvn" ) in case you get something like
> "test/executable\\mvn"
>
> - Brett
>
> On 17/11/2009, at 3:43 PM, ctan@... wrote:
>
> > Author: ctan
> > Date: Tue Nov 17 04:43:34 2009
> > New Revision: 881150
> >
> > URL: http://svn.apache.org/viewvc?rev=881150&view=rev
> > Log:
> > fixed unit test
> >
> > Modified:
> >
> continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> >
> > Modified:
> continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> > URL:
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java?rev=881150&r1=881149&r2=881150&view=diff
> >
> ==============================================================================
> > ---
> continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> (original)
> > +++
> continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> Tue Nov 17 04:43:34 2009
> > @@ -295,7 +295,8 @@
> >
> > ReleaseResult result = (ReleaseResult)
> releaseManager.getReleaseResults().get( "testRelease" );
> >
> > - if ( !result.getOutput().contains( "test/executable/mvn" ) )
> > + if ( !result.getOutput().contains( "test/executable/mvn" ) &&
> > + !result.getOutput().contains( "test\\executable\\mvn" )
> )
> > {
> > fail( "Error in release:perform. Missing executable" );
> > }
> >
> >
>
>

Re: CONTINUUM-2342

2009-11-17T14:44:02Z

Fine with me :)

--
Marica

On Tue, Nov 17, 2009 at 10:17 PM, Emmanuel Venisse <
emmanuel.venisse@...> wrote:

> Hi,
>
> What do you think if we move CONTINUUM-2342 to 1.4.x? It isn't an important
> bug and we have some work to do to fix it.
>
> I think we have a risk to fix it now.
>
> Emmanuel
>

Re: CONTINUUM-2342

2009-11-17T14:42:47Z

+1. There are several people here that can fix it, but I'm not one of them (unless there are patches :)

Cheers,
Brett

On 18/11/2009, at 1:17 AM, Emmanuel Venisse wrote:

> Hi,
>
> What do you think if we move CONTINUUM-2342 to 1.4.x? It isn't an important
> bug and we have some work to do to fix it.
>
> I think we have a risk to fix it now.
>
> Emmanuel

CONTINUUM-2342

2009-11-17T06:17:41Z

Hi,

What do you think if we move CONTINUUM-2342 to 1.4.x? It isn't an important
bug and we have some work to do to fix it.

I think we have a risk to fix it now.

Emmanuel

Re: svn commit: r881150 - /continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java

2009-11-16T20:55:18Z

It is probably more reliable to do result.getOutput().replace( "\\", "/" ).contains( "test/executable/mvn" ) in case you get something like "test/executable\\mvn"

- Brett

On 17/11/2009, at 3:43 PM, ctan@... wrote:

> Author: ctan
> Date: Tue Nov 17 04:43:34 2009
> New Revision: 881150
>
> URL: http://svn.apache.org/viewvc?rev=881150&view=rev
> Log:
> fixed unit test
>
> Modified:
> continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
>
> Modified: continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java?rev=881150&r1=881149&r2=881150&view=diff
> ==============================================================================
> --- continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java (original)
> +++ continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java Tue Nov 17 04:43:34 2009
> @@ -295,7 +295,8 @@
>
> ReleaseResult result = (ReleaseResult) releaseManager.getReleaseResults().get( "testRelease" );
>
> - if ( !result.getOutput().contains( "test/executable/mvn" ) )
> + if ( !result.getOutput().contains( "test/executable/mvn" ) &&
> + !result.getOutput().contains( "test\\executable\\mvn" ) )
> {
> fail( "Error in release:perform. Missing executable" );
> }
>
>

Re: Update selenium tests in 1.3.x branch

2009-11-10T02:02:18Z

Thanks Marica.

Emmanuel

On Tue, Nov 10, 2009 at 6:57 AM, Marica Tan <marica.tan@...> wrote:

> I updated the selenium tests in 1.3.x branch.
>
> On Tue, Nov 10, 2009 at 8:19 AM, Marica Tan <marica.tan@...> wrote:
>
> > The selenium tests in 1.3.x branch is not updated.
> >
> > Can we merge the changes in continuum-webapp-test of trunk to branch?
> >
> >
> > Thanks,
> > --
> > Marica
> >
>

Re: Update selenium tests in 1.3.x branch

2009-11-09T21:57:05Z

I updated the selenium tests in 1.3.x branch.

On Tue, Nov 10, 2009 at 8:19 AM, Marica Tan <marica.tan@...> wrote:

> The selenium tests in 1.3.x branch is not updated.
>
> Can we merge the changes in continuum-webapp-test of trunk to branch?
>
>
> Thanks,
> --
> Marica
>

Re: svn commit: r825338 - /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java

2009-11-09T18:12:01Z

Yes, thanks pointing that out :)

I need to change this too, because it seems the fix will only works for:

project group 1: Group
project group 2: Group Two

but not with this:

project group 1: Group
project group 2: My Group

Thanks,
--
Marica

On Tue, Oct 27, 2009 at 2:08 AM, Brett Porter <brett@...> wrote:

> Isn't it also correct to say .endsWith( projectGroup.getName() ) ?
>
> Cheers,
> Brett
>
>
> On 15/10/2009, at 10:19 AM, ctan@... wrote:
>
> Author: ctan
>> Date: Wed Oct 14 23:19:28 2009
>> New Revision: 825338
>>
>> URL: http://svn.apache.org/viewvc?rev=825338&view=rev
>> Log:
>> [CONTINUUM-2387] retrieve correct roles to show only the users of the
>> project group in the members tab
>>
>> Modified:
>>
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
>>
>> Modified:
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
>> URL:
>> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java?rev=825338&r1=825337&r2=825338&view=diff
>>
>> ==============================================================================
>> ---
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
>> (original)
>> +++
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
>> Wed Oct 14 23:19:28 2009
>> @@ -689,7 +689,8 @@
>> List<String> roleNames = new ArrayList<String>();
>> for ( Role r : roles )
>> {
>> - if ( r.getName().indexOf( projectGroup.getName() ) > -1 )
>> + int index = r.getName().indexOf( projectGroup.getName()
>> );
>> + if ( index > -1 && r.getName().substring( index
>> ).trim().equals( projectGroup.getName() ) )
>> {
>> roleNames.add( r.getName() );
>> }
>>
>>
>>
>

Update selenium tests in 1.3.x branch

2009-11-09T16:19:04Z

The selenium tests in 1.3.x branch is not updated.

Can we merge the changes in continuum-webapp-test of trunk to branch?

Thanks,
--
Marica

Continuum-ruby in the sandbox

2009-11-04T15:59:15Z

I have added to the sandbox

Ruby library to interact with Continuum, using the XML-RPC interface
and enabling access
to the working copy directories.

https://svn.apache.org/repos/asf/continuum/sandbox/continuum-ruby/

Example
=======

continuum = Continuum::Continuum.new("my.continuum.host", 8080,
"admin", "password", "/continuum")

# xml-rpc interface

xml_rpc = Continuum::XmlRpc.new(continuum)

ok, result = xml_rpc.build_project(1)
error = Continuum.parse_error(result) if !ok

# getting working copy files

working_copy = Continuum::WorkingCopy.new(continuum)
test_results = working_copy.get(1, "target/surefire-reports",
"emailable-report.html")

files = working_copy.dir(1, "target")
files.each do |file|
file_content = working_copy.get(1, "target", file)
end

AUTO: Vivek Nakeesan is out of the office. (returning 11/03/2009)

2009-10-26T13:01:53Z

I am out of the office until 11/03/2009.

Memberweb, Maint, Flask related builds please see Kent

Martini build and infrastructure issues please see Henry.
TFS admin related tasks please see Nuno.

I will respond to your message when I return. For urgent needs please see
Stephen Wheeler.

Note: This is an automated response to your message "Re: svn commit:
r825338
- /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java"
sent on 10/26/2009 2:08:44 PM.

This is the only notification you will receive while this person is away.

Re: svn commit: r825338 - /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java

2009-10-26T11:08:44Z

Isn't it also correct to say .endsWith( projectGroup.getName() ) ?

Cheers,
Brett

On 15/10/2009, at 10:19 AM, ctan@... wrote:

> Author: ctan
> Date: Wed Oct 14 23:19:28 2009
> New Revision: 825338
>
> URL: http://svn.apache.org/viewvc?rev=825338&view=rev
> Log:
> [CONTINUUM-2387] retrieve correct roles to show only the users of
> the project group in the members tab
>
> Modified:
> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/
> org/apache/maven/continuum/web/action/ProjectGroupAction.java
>
> Modified: continuum/branches/continuum-1.3.x/continuum-webapp/src/
> main/java/org/apache/maven/continuum/web/action/
> ProjectGroupAction.java
> URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java?rev=825338&r1=825337&r2=825338&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- continuum/branches/continuum-1.3.x/continuum-webapp/src/main/
> java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
> (original)
> +++ continuum/branches/continuum-1.3.x/continuum-webapp/src/main/
> java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
> Wed Oct 14 23:19:28 2009
> @@ -689,7 +689,8 @@
> List<String> roleNames = new ArrayList<String>();
> for ( Role r : roles )
> {
> - if ( r.getName().indexOf( projectGroup.getName() )
> > -1 )
> + int index = r.getName().indexOf
> ( projectGroup.getName() );
> + if ( index > -1 && r.getName().substring
> ( index ).trim().equals( projectGroup.getName() ) )
> {
> roleNames.add( r.getName() );
> }
>
>

Re: [jira] Updated: (CONTINUUM-2397) Unable to edit the added local repository

2009-10-22T04:17:55Z

I don't think they are critical though. I'll move them to 1.4.0. :)

Brett Porter wrote:

> Unless they are critical to 1.3.x reaching GA, I'd say yes. It's not
> really my call as I've not been doing a lot of work lately, but I
> think that was what was agreed previously...
>
> On 22/10/2009, at 10:07 PM, Jevica Arianne B. Zurbano wrote:
>
>> Ooops. I have added two issues recently in the 1.3.5 bucket, should I
>> move both to the 1.4.0 then?
>>
>> Brett Porter wrote:
>>> I thought we had stopped adding issues to 1.3.5? Will it ever be
>>> released? :)
>>>
>>> On 22/10/2009, at 8:47 PM, Jevica Arianne B. Zurbano (JIRA) wrote:
>>>
>>>>
>>>> [
>>>> http://jira.codehaus.org/browse/CONTINUUM-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>>>
>>>>
>>>> Jevica Arianne B. Zurbano updated CONTINUUM-2397:
>>>> -------------------------------------------------
>>>>
>>>> Fix Version/s: 1.3.5
>>>>
>>>>> Unable to edit the added local repository
>>>>> -----------------------------------------
>>>>>
>>>>> Key: CONTINUUM-2397
>>>>> URL: http://jira.codehaus.org/browse/CONTINUUM-2397
>>>>> Project: Continuum
>>>>> Issue Type: Bug
>>>>> Affects Versions: 1.3.4
>>>>> Reporter: Jevica Arianne B. Zurbano
>>>>> Fix For: 1.3.5
>>>>>
>>>>>
>>>>> Steps to reproduce:
>>>>> # Add a local repository named "DEFAULT" (with a space at the
>>>>> beginning and/or at the end of the name).
>>>>> # View the list of Local Repositories
>>>>> Actual behavior:
>>>>> * The added local repository also appears to be the DEFAULT local
>>>>> repository resulting to multiple DEFAULT local repositories in the
>>>>> list.
>>>>> Wherein, it is not possible to edit/delete the one which was added.
>>>>> Expected Behavior:
>>>>> * It should be possible to edit or delete the added local repository.
>>>>
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> -
>>>> If you think it was sent incorrectly contact one of the
>>>> administrators: http://jira.codehaus.org/secure/Administrators.jspa
>>>> -
>>>> For more information on JIRA, see:
>>>> http://www.atlassian.com/software/jira
>>>>
>>>>
>>>
>>>
>>
>> --
>>
>> Thanks,
>>
>> Jev
>>
>
>

--

Thanks,

Jev

Re: [jira] Updated: (CONTINUUM-2397) Unable to edit the added local repository

2009-10-22T04:12:39Z

Unless they are critical to 1.3.x reaching GA, I'd say yes. It's not
really my call as I've not been doing a lot of work lately, but I
think that was what was agreed previously...

On 22/10/2009, at 10:07 PM, Jevica Arianne B. Zurbano wrote:

> Ooops. I have added two issues recently in the 1.3.5 bucket, should
> I move both to the 1.4.0 then?
>
> Brett Porter wrote:
>> I thought we had stopped adding issues to 1.3.5? Will it ever be
>> released? :)
>>
>> On 22/10/2009, at 8:47 PM, Jevica Arianne B. Zurbano (JIRA) wrote:
>>
>>>
>>> [ http://jira.codehaus.org/browse/CONTINUUM-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Jevica Arianne B. Zurbano updated CONTINUUM-2397:
>>> -------------------------------------------------
>>>
>>> Fix Version/s: 1.3.5
>>>
>>>> Unable to edit the added local repository
>>>> -----------------------------------------
>>>>
>>>> Key: CONTINUUM-2397
>>>> URL: http://jira.codehaus.org/browse/CONTINUUM-2397
>>>> Project: Continuum
>>>> Issue Type: Bug
>>>> Affects Versions: 1.3.4
>>>> Reporter: Jevica Arianne B. Zurbano
>>>> Fix For: 1.3.5
>>>>
>>>>
>>>> Steps to reproduce:
>>>> # Add a local repository named "DEFAULT" (with a space at the
>>>> beginning and/or at the end of the name).
>>>> # View the list of Local Repositories
>>>> Actual behavior:
>>>> * The added local repository also appears to be the DEFAULT local
>>>> repository resulting to multiple DEFAULT local repositories in
>>>> the list.
>>>> Wherein, it is not possible to edit/delete the one which was added.
>>>> Expected Behavior:
>>>> * It should be possible to edit or delete the added local
>>>> repository.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> If you think it was sent incorrectly contact one of the
>>> administrators: http://jira.codehaus.org/secure/Administrators.jspa
>>> -
>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>
>>>
>>
>>
>
> --
>
> Thanks,
>
> Jev
>

Re: [jira] Updated: (CONTINUUM-2397) Unable to edit the added local repository

2009-10-22T04:07:18Z

Ooops. I have added two issues recently in the 1.3.5 bucket, should I
move both to the 1.4.0 then?

Brett Porter wrote:

> I thought we had stopped adding issues to 1.3.5? Will it ever be
> released? :)
>
> On 22/10/2009, at 8:47 PM, Jevica Arianne B. Zurbano (JIRA) wrote:
>
>>
>> [
>> http://jira.codehaus.org/browse/CONTINUUM-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>>
>> Jevica Arianne B. Zurbano updated CONTINUUM-2397:
>> -------------------------------------------------
>>
>> Fix Version/s: 1.3.5
>>
>>> Unable to edit the added local repository
>>> -----------------------------------------
>>>
>>> Key: CONTINUUM-2397
>>> URL: http://jira.codehaus.org/browse/CONTINUUM-2397
>>> Project: Continuum
>>> Issue Type: Bug
>>> Affects Versions: 1.3.4
>>> Reporter: Jevica Arianne B. Zurbano
>>> Fix For: 1.3.5
>>>
>>>
>>> Steps to reproduce:
>>> # Add a local repository named "DEFAULT" (with a space at the
>>> beginning and/or at the end of the name).
>>> # View the list of Local Repositories
>>> Actual behavior:
>>> * The added local repository also appears to be the DEFAULT local
>>> repository resulting to multiple DEFAULT local repositories in the
>>> list.
>>> Wherein, it is not possible to edit/delete the one which was added.
>>> Expected Behavior:
>>> * It should be possible to edit or delete the added local repository.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the
>> administrators: http://jira.codehaus.org/secure/Administrators.jspa
>> -
>> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>
>>
>
>

--

Thanks,

Jev

Re: [jira] Updated: (CONTINUUM-2397) Unable to edit the added local repository

2009-10-22T03:58:42Z

I thought we had stopped adding issues to 1.3.5? Will it ever be
released? :)

On 22/10/2009, at 8:47 PM, Jevica Arianne B. Zurbano (JIRA) wrote:

>
> [ http://jira.codehaus.org/browse/CONTINUUM-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Jevica Arianne B. Zurbano updated CONTINUUM-2397:
> -------------------------------------------------
>
> Fix Version/s: 1.3.5
>
>> Unable to edit the added local repository
>> -----------------------------------------
>>
>> Key: CONTINUUM-2397
>> URL: http://jira.codehaus.org/browse/CONTINUUM-2397
>> Project: Continuum
>> Issue Type: Bug
>> Affects Versions: 1.3.4
>> Reporter: Jevica Arianne B. Zurbano
>> Fix For: 1.3.5
>>
>>
>> Steps to reproduce:
>> # Add a local repository named "DEFAULT" (with a space at the
>> beginning and/or at the end of the name).
>> # View the list of Local Repositories
>> Actual behavior:
>> * The added local repository also appears to be the DEFAULT local
>> repository resulting to multiple DEFAULT local repositories in the
>> list.
>> Wherein, it is not possible to edit/delete the one which was added.
>> Expected Behavior:
>> * It should be possible to edit or delete the added local repository.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
> administrators: http://jira.codehaus.org/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>

Re: Distributed Builds - Logging (CONTINUUM-2373)

2009-10-16T16:07:18Z

On Mon, Oct 5, 2009 at 4:37 PM, George Snyder <George.Snyder@...> wrote:

> As suggested in
> http://www.nabble.com/Distributed-Builds-Always-Use-Same-Agent-td25705964.html,
> I am interested in trying out a snapshot build with improved logging for
> distributed builds, such as described in CONTINUUM-2373. What do I need to
> do?

Welcome! Two options are checking out and building Continuum locally,
which is described on [1], or grabbing a snapshot from the CI server
[2].

Are you interested in trying to fix it? The issue is still open, so
even if you try the latest snapshot, nothing will have changed.

[1] http://continuum.apache.org/development/building.html
[2] http://vmbuild.apache.org/continuum/workingCopy.action?projectId=692&projectName=Apache+Continuum&userDirectory=target

--
Wendy

Re: svn commit: r809963 - in /continuum/branches/continuum-1.3.x/continuum-webapp/src: main/java/org/apache/maven/continuum/web/action/AddProjectAction.java test/java/org/apache/maven/continuum/web/action/AddProjectActionTest.java

2009-10-13T05:15:55Z

shouldn't it be "cannot reproduce" instead of "fixed" then?

On 13/10/2009, at 7:55 PM, Jevica Arianne Zurbano wrote:

> I have reverted the changes made:
> - branch: 824635 (reverts r809963)
> - trunk: 824636 (reverts r809964)
>
> I also could not replicate the issue, so I removed the fix for
> version in
> the ticket too.
>
> Thanks Brett for pointing that out :)

Re: svn commit: r809963 - in /continuum/branches/continuum-1.3.x/continuum-webapp/src: main/java/org/apache/maven/continuum/web/action/AddProjectAction.java test/java/org/apache/maven/continuum/web/action/AddProjectActionTest.java

2009-10-13T01:55:07Z

I have reverted the changes made:
- branch: 824635 (reverts r809963)
- trunk: 824636 (reverts r809964)

I also could not replicate the issue, so I removed the fix for version in
the ticket too.

Thanks Brett for pointing that out :)

Re: svn commit: r809963 - in /continuum/branches/continuum-1.3.x/continuum-webapp/src: main/java/org/apache/maven/continuum/web/action/AddProjectAction.java test/java/org/apache/maven/continuum/web/action/AddProjectActionTest.java

2009-10-12T20:28:12Z

On Tue, Oct 13, 2009 at 8:25 AM, Brett Porter <brett@...> wrote:

> I know this commit is super old, but I haven't got around to reviewing some
> lately...
>
> On 01/09/2009, at 8:47 PM, jzurbano@... wrote:
>
> Author: jzurbano
>> Date: Tue Sep 1 10:47:21 2009
>> New Revision: 809963
>>
>> URL: http://svn.apache.org/viewvc?rev=809963&view=rev
>> Log:
>> [CONTINUUM-2347] - "Project Group is required and all projects must be in
>> a project group" is displayed when adding Ant/Shell Projects
>>
>>
>> Modified:
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>> URL:
>> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java?rev=809963&r1=809962&r2=809963&view=diff
>>
>> ==============================================================================
>> ---
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>> (original)
>> +++
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>> Tue Sep 1 10:47:21 2009
>> @@ -66,7 +66,7 @@
>>
>> private Collection<ProjectGroup> projectGroups;
>>
>> - private int selectedProjectGroup;
>> + private static int selectedProjectGroup;
>>
>
> Why is this static?
>

I made this one static so that when the project is added, it will still have
the value of the project group
and will not return to the page with the error.

> - Brett
>
>

Re: svn commit: r809963 - in /continuum/branches/continuum-1.3.x/continuum-webapp/src: main/java/org/apache/maven/continuum/web/action/AddProjectAction.java test/java/org/apache/maven/continuum/web/action/AddProjectActionTest.java

2009-10-12T17:25:54Z

I know this commit is super old, but I haven't got around to reviewing
some lately...

On 01/09/2009, at 8:47 PM, jzurbano@... wrote:

> Author: jzurbano
> Date: Tue Sep 1 10:47:21 2009
> New Revision: 809963
>
> URL: http://svn.apache.org/viewvc?rev=809963&view=rev
> Log:
> [CONTINUUM-2347] - "Project Group is required and all projects must
> be in a project group" is displayed when adding Ant/Shell Projects
>
>
> Modified: continuum/branches/continuum-1.3.x/continuum-webapp/src/
> main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
> URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java?rev=809963&r1=809962&r2=809963&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- continuum/branches/continuum-1.3.x/continuum-webapp/src/main/
> java/org/apache/maven/continuum/web/action/AddProjectAction.java
> (original)
> +++ continuum/branches/continuum-1.3.x/continuum-webapp/src/main/
> java/org/apache/maven/continuum/web/action/AddProjectAction.java Tue
> Sep 1 10:47:21 2009
> @@ -66,7 +66,7 @@
>
> private Collection<ProjectGroup> projectGroups;
>
> - private int selectedProjectGroup;
> + private static int selectedProjectGroup;

Why is this static?

- Brett

Re: svn commit: r822534 - /continuum/branches/continuum-1.3.x/continuum-core/src/test/java/org/apache/maven/continuum/DefaultContinuumTest.java

2009-10-06T16:35:23Z

On 07/10/2009, at 10:16 AM, ctan@... wrote:
> + continuum.buildProject( project.getId() );
> +
> + // wait for build to finish
> + Thread.sleep( 5000 );

Is there a way to do this without building the project? This is prone
to sporadic failure if the build is > 5s, and otherwise is incredibly
slow.

> +
> + // delete project
> + continuum.removeProject( project.getId() );
> +
> + try
> + {
> + project = continuum.getProject( project.getId() );
> +
> + assertNull( project );
> +
> + fail( "Project was not removed" );

Do we need to check the build results were removed too?

> + }
> + catch ( Exception e )
> + {
> + // successfully removed project
> + }

This needs to catch a more specific exception.

Cheers,
Brett

Re: svn commit: r822134 - /continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java

2009-10-06T15:58:08Z

Sure np :)

On Tue, Oct 6, 2009 at 4:35 PM, Emmanuel Venisse <emmanuel.venisse@...
> wrote:

> Thanks, I didn't see it
>
> Emmanuel
>
> On Tue, Oct 6, 2009 at 7:52 AM, <ctan@...> wrote:
>
> > Author: ctan
> > Date: Tue Oct 6 05:52:47 2009
> > New Revision: 822134
> >
> > URL: http://svn.apache.org/viewvc?rev=822134&view=rev
> > Log:
> > [CONTINUUM-1031] use getBuildResultsForProject instead of
> > getProjectWithBuilds to improve performance when deleting a project
> >
> > Modified:
> >
> >
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> >
> > Modified:
> >
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> > URL:
> >
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java?rev=822134&r1=822133&r2=822134&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> > (original)
> > +++
> >
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> > Tue Oct 6 05:52:47 2009
> > @@ -591,7 +591,7 @@
> > {
> > try
> > {
> > - Project project = getProjectWithBuilds( projectId );
> > + Project project = getProject( projectId );
> >
> > try
> > {
> > @@ -660,9 +660,10 @@
> >
> > log.info( "Remove project " + project.getName() + "(" +
> > projectId + ")" );
> >
> > - for ( Object o : project.getBuildResults() )
> > + Collection<BuildResult> buildResults =
> > getBuildResultsForProject( projectId );
> > +
> > + for ( BuildResult br : buildResults )
> > {
> > - BuildResult br = (BuildResult) o;
> > br.setBuildDefinition( null );
> > //Remove all modified dependencies to prevent SQL errors
> > br.setModifiedDependencies( null );
> >
> >
> >
>

Re: svn commit: r822134 - /continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java

2009-10-06T01:35:38Z

Thanks, I didn't see it

Emmanuel

On Tue, Oct 6, 2009 at 7:52 AM, <ctan@...> wrote:

> Author: ctan
> Date: Tue Oct 6 05:52:47 2009
> New Revision: 822134
>
> URL: http://svn.apache.org/viewvc?rev=822134&view=rev
> Log:
> [CONTINUUM-1031] use getBuildResultsForProject instead of
> getProjectWithBuilds to improve performance when deleting a project
>
> Modified:
>
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
>
> Modified:
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> URL:
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java?rev=822134&r1=822133&r2=822134&view=diff
>
> ==============================================================================
> ---
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> (original)
> +++
> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
> Tue Oct 6 05:52:47 2009
> @@ -591,7 +591,7 @@
> {
> try
> {
> - Project project = getProjectWithBuilds( projectId );
> + Project project = getProject( projectId );
>
> try
> {
> @@ -660,9 +660,10 @@
>
> log.info( "Remove project " + project.getName() + "(" +
> projectId + ")" );
>
> - for ( Object o : project.getBuildResults() )
> + Collection<BuildResult> buildResults =
> getBuildResultsForProject( projectId );
> +
> + for ( BuildResult br : buildResults )
> {
> - BuildResult br = (BuildResult) o;
> br.setBuildDefinition( null );
> //Remove all modified dependencies to prevent SQL errors
> br.setModifiedDependencies( null );
>
>
>

Distributed Builds - Logging (CONTINUUM-2373)

2009-10-05T16:37:20Z

As suggested in http://www.nabble.com/Distributed-Builds-Always-Use-Same-Agent-td25705964.html, I am interested in trying out a snapshot build with improved logging for distributed builds, such as described in CONTINUUM-2373. What do I need to do?

-- George Snyder

Re: svn commit: r820144 - /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/continuum/web/action/admin/BuildAgentAction.java

2009-09-30T17:48:48Z

I'll create one :)

Thanks
--
Marica

On Thu, Oct 1, 2009 at 8:25 AM, Brett Porter <brett@...> wrote:

> Right, but does it test the specific problem you fixed here?
>
>
> On 01/10/2009, at 9:43 AM, Marica Tan wrote:
>
> There's already a unit test in
>> org.apache.maven.continuum.configuration.ConfigurationServiceTest.java
>> for
>> adding/removing build agents in continuum.xml.
>>
>>
>> On Wed, Sep 30, 2009 at 1:58 PM, Brett Porter <brett@...> wrote:
>>
>>
>>> On 30/09/2009, at 11:39 AM, ctan@... wrote:
>>>
>>> Author: ctan
>>>
>>>> Date: Wed Sep 30 01:39:27 2009
>>>> New Revision: 820144
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=820144&view=rev
>>>> Log:
>>>> [CONTINUUM-2377] store configuration changes of build agent in
>>>> continuum.xml
>>>>
>>>>
>>> Is there a way to unit test this?
>>>
>>> - Brett
>>>
>>>
>>>
>