Could not unregister, regression

View: New views
18 Messages — Rating Filter:   Alert me  

Could not unregister, regression

by Michael Rickmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

This is Ekigas answer in the accounts window on Linux now. With the
current git version I cannot unregister my account at ekiga.net any
longer. Also the subcriber threads do not terminate any longer. Ekiga
needs considerably longer to shutdown than it took one week ago and does
not shut down at all when run under gdb. This is
EKIGA_3_2_0-214-g0941186 and ptlib/opal version 22850. I attach the out
put from an gdb --args ekiga -d 1 where I set three brakepoints,
b main.cpp:4562
b sip-endpoint.cpp:554
b sip-endpoint.cpp:610
All I was doing was registering in the accounts window and unregistering
again, then quit. Clearly the subscriber thread 1755 manages to register
as the callback OnRegistered is called, but it makes no use of
AutoDeleteThread and is still active at program end. The subscriber 1756
used to unsubscribe behaves similarly but does not manage to trigger an
OnRegistered callback. Another change is that a week ago I could
outcomment the unsubscribe function in sip-endpoint.cpp:552 and the
linker would not complain. Now it is needed.

Another point: Ekiga cannot be compiled since opal version 2258 because
the SIPEndPoint::Message form called in sip-endpoint.cpp:360 no longer
exists.
Regards
Michael



Could not unregister

Starting program: /home/mrickma/src/ekiga-head/linux/ekiga/src/ekiga -d 1
[Thread debugging using libthread_db enabled]
[New Thread 0xb58a3730 (LWP 1230)]
[Switching to Thread 0xb58a3730 (LWP 1230)]
main (argc=3, argv=0xbfd36274) at gui/main.cpp:4347
4347  gchar *url = NULL;
(gdb) c
Continuing.
2009/06/14 19:50:02.757  0:08.216                       Version 3.3.0 by  on Unix Linux (2.6.28-11-generic-i686) with PTLib (v2.7beta0) at 2009/6/14 19:50:02.757
2009/06/14 19:50:02.757  0:08.216                       Ekiga git revision: EKIGA_3_2_0-214-g0941186
[New Thread 0xb5417b90 (LWP 1492)]
[New Thread 0xb53d6b90 (LWP 1493)]
[New Thread 0xb5395b90 (LWP 1495)]
2009/06/14 19:50:02.772  0:08.231                       Detecting V4L2 devices
[New Thread 0xb5354b90 (LWP 1670)]
2009/06/14 19:50:03.253  0:08.712                       OpalMan Registered endpoint with prefix pc
2009/06/14 19:50:03.384  0:08.843                       OpalMan Registered endpoint with prefix sip
[New Thread 0xb5313b90 (LWP 1680)]
[New Thread 0xb52d2b90 (LWP 1682)]
2009/06/14 19:50:03.391  0:08.850                       OpalMan Registered endpoint with prefix sips
[New Thread 0xb5291b90 (LWP 1684)]
2009/06/14 19:50:03.405  0:08.864                       OpalMan Registered endpoint with prefix h323
2009/06/14 19:50:03.405  0:08.864                       OpalMan Registered endpoint with prefix h323s
[New Thread 0xb5250b90 (LWP 1687)]
[New Thread 0xb520fb90 (LWP 1696)]
[New Thread 0xb51b4b90 (LWP 1700)]
[New Thread 0xb49b3b90 (LWP 1703)]
2009/06/14 19:50:03.917  0:09.376                       Detecting V4L2 devices
2009/06/14 19:50:04.395  0:09.854                       PVidInDev Open() videoFd:-1
2009/06/14 19:50:04.395  0:09.854                       PVidInDev Close() videoFd:-1  started:0
2009/06/14 19:50:04.395  0:09.854                       Detecting V4L2 devices
2009/06/14 19:50:04.855  0:10.314                       PVidInDev Open() devName:/dev/video0  videoFd:-1
2009/06/14 19:50:05.031  0:10.490                       PVidInDev G_PARM failed : Invalid argument
2009/06/14 19:50:05.031  0:10.490                       VideoInputDevice S_STD failed : Invalid argument
2009/06/14 19:50:05.032  0:10.491                       PVidInDev G_PARM failed (preserving frame rate may not work) : Invalid argument
2009/06/14 19:50:05.032  0:10.491                       PVidInDev G_PARM failed (preserving frame rate may not work) : Invalid argument
2009/06/14 19:50:05.323  0:10.782 StunDetector:0xb520fb90 PTLib Destroyed thread 0x87dffc0 StunDetector:0xb520fb90(id = b520fb90)
[Thread 0xb520fb90 (LWP 1696) exited]
2009/06/14 19:50:05.696  0:11.155                       Ekiga version 3.3.0
2009/06/14 19:50:05.696  0:11.155                       OPAL version 3.7.0
2009/06/14 19:50:05.696  0:11.155                       PTLIB version 2.7.0
2009/06/14 19:50:05.696  0:11.155                       GNOME support disabled
2009/06/14 19:50:05.696  0:11.155                       Accelerated rendering support enabled
2009/06/14 19:50:05.696  0:11.155                       DBUS support disabled
2009/06/14 19:50:05.696  0:11.155                       GConf support enabled
2009/06/14 19:50:05.696  0:11.155                       ESound support disabled
[New Thread 0xb4371b90 (LWP 1750)]
2009/06/14 19:50:06.278  0:11.737 GMVideoOut...0xb5395b90 XVideo XQueryShmExtension success
2009/06/14 19:50:06.278  0:11.737 GMVideoOut...0xb5395b90 XVideo Using SHM extension
2009/06/14 19:50:06.279  0:11.738 GMVideoOut...0xb5395b90 X11 Unknown X Event 19 received
[Thread 0xb4371b90 (LWP 1750) exited]
2009/06/14 19:50:06.770  0:12.229 Opal Liste...0xb5291b90 Listen UDP read error.
[Thread 0xb5291b90 (LWP 1684) exited]
2009/06/14 19:50:06.793  0:12.252                       PTLib Destroyed thread 0x8883588 Opal Listener:0xb5291b90(id = b5291b90)
[New Thread 0xb5291b90 (LWP 1752)]
[Thread 0xb5250b90 (LWP 1687) exited]
2009/06/14 19:50:07.347  0:12.806                       PTLib Destroyed thread 0x88841d8 Opal Listener:0xb5250b90(id = b5250b90)
[New Thread 0xb5250b90 (LWP 1753)]
[New Thread 0xb520fb90 (LWP 1754)]
2009/06/14 19:50:15.583  0:21.042  subscriber:0xb520fb90 PTLib Destroyed thread 0x8cf9a40 subscriber:0xb520fb90(id = b520fb90)
[Thread 0xb520fb90 (LWP 1754) exited]
[New Thread 0xb520fb90 (LWP 1755)]
[Switching to Thread 0xb520fb90 (LWP 1755)]

Breakpoint 4, Opal::Sip::EndPoint::OnRegistered (this=0x8881cb0, _aor=@0xb520f00c,
    was_registering=true) at ../../../../lib/engine/components/opal/sip-endpoint.cpp:611
611  std::string aor = (const char *) _aor;
(gdb) c
Continuing.
[Switching to Thread 0xb58a3730 (LWP 1230)]

Breakpoint 3, Opal::Sip::EndPoint::unsubscribe (this=0x8881cb0, account=@0x8881a78)
    at ../../../../lib/engine/components/opal/sip-endpoint.cpp:554
554  if (account.get_protocol_name () != "SIP")
(gdb) c
Continuing.
[New Thread 0xb3b53b90 (LWP 1756)]
[Thread 0xb53d6b90 (LWP 1493) exited]
2009/06/14 19:50:56.721  1:02.180                       PTLib Destroyed thread 0x8867804 AudioEventScheduler:0xb53d6b90(id = b53d6b90)
2009/06/14 19:50:56.721  1:02.180                       PTLib Destroyed thread 0x88672f0 PreviewManager(id = 0)
[Thread 0xb5417b90 (LWP 1492) exited]
[Thread 0xb5395b90 (LWP 1495) exited]
2009/06/14 19:50:56.811  1:02.270                       PTLib Destroyed thread 0x8842e68 GMVideoOutputManager:0xb5395b90(id = b5395b90)
2009/06/14 19:50:56.811  1:02.270                       PTLib Destroyed thread 0x8867558 VideoPreviewManager:0xb5417b90(id = b5417b90)
[New Thread 0xb4371b90 (LWP 1758)]

Breakpoint 2, main (argc=136716108, argv=0x0) at gui/main.cpp:4562
4562  gm_platform_shutdown ();
(gdb) info threads
  19 Thread 0xb4371b90 (LWP 1758)  0xb7f18430 in __kernel_vsyscall ()
  18 Thread 0xb3b53b90 (LWP 1756)  0xb7f18430 in __kernel_vsyscall ()
  17 Thread 0xb520fb90 (LWP 1755)  0xb7f18430 in __kernel_vsyscall ()
  15 Thread 0xb5250b90 (LWP 1753)  0xb7f18430 in __kernel_vsyscall ()
  14 Thread 0xb5291b90 (LWP 1752)  0xb7f18430 in __kernel_vsyscall ()
  12 Thread 0xb49b3b90 (LWP 1703)  0xb7f18430 in __kernel_vsyscall ()
  11 Thread 0xb51b4b90 (LWP 1700)  0xb7f18430 in __kernel_vsyscall ()
  7 Thread 0xb52d2b90 (LWP 1682)  0xb7f18430 in __kernel_vsyscall ()
  6 Thread 0xb5313b90 (LWP 1680)  0xb7f18430 in __kernel_vsyscall ()
  5 Thread 0xb5354b90 (LWP 1670)  0xb7f18430 in __kernel_vsyscall ()
* 1 Thread 0xb58a3730 (LWP 1230)  main (argc=136716108, argv=0x0) at gui/main.cpp:4562
(gdb) c
Continuing.
[Thread 0xb4371b90 (LWP 1758) exited]
Deadlock potential - avoiding evil bug!
[Thread 0xb5313b90 (LWP 1680) exited]
2009/06/14 19:51:14.048  1:19.507                       PTLib Destroyed thread 0x8883ca0 Network Interface Monitor:0xb5313b90(id = b5313b90)
^C
Program received signal SIGINT, Interrupt.
0xb7f18430 in __kernel_vsyscall ()
(gdb)


_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Eugen Dedu :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Michael Rickmann wrote:
> longer. Also the subcriber threads do not terminate any longer. Ekiga
> needs considerably longer to shutdown than it took one week ago and does

I noticed it too...

> Another point: Ekiga cannot be compiled since opal version 2258 because
> the SIPEndPoint::Message form called in sip-endpoint.cpp:360 no longer
> exists.

I am working on this.

--
Eugen
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Michael Rickmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Eugen Dedu schrieb:

> Michael Rickmann wrote:
>> longer. Also the subcriber threads do not terminate any longer. Ekiga
>> needs considerably longer to shutdown than it took one week ago and does
>
> I noticed it too...
>
>> Another point: Ekiga cannot be compiled since opal version 2258
>> because the SIPEndPoint::Message form called in sip-endpoint.cpp:360
>> no longer exists.
>
> I am working on this.
>
Strange things are accumulating at this point. I went back to Ekiga
7bb1d0 (Updated Spanish translation) and Opal/ptlib 22836 which
correspond to the state at Wed Jun 10. Ekiga's unregistration was
already broken at that time. But the subsriber threads were still
shutting down and Ekiga could shut down under gdb.
Regards
Michael
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Eugen Dedu :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Michael Rickmann wrote:
> Eugen Dedu schrieb:
>> Michael Rickmann wrote:
>>> longer. Also the subcriber threads do not terminate any longer. Ekiga
>>> needs considerably longer to shutdown than it took one week ago and does
>>
>> I noticed it too...

Sorry, this was about longer shutdown, not about threads do not terminate.

>>> Another point: Ekiga cannot be compiled since opal version 2258
>>> because the SIPEndPoint::Message form called in sip-endpoint.cpp:360
>>> no longer exists.
>>
>> I am working on this.
>>
> Strange things are accumulating at this point. I went back to Ekiga
> 7bb1d0 (Updated Spanish translation) and Opal/ptlib 22836 which
> correspond to the state at Wed Jun 10. Ekiga's unregistration was
> already broken at that time. But the subsriber threads were still
> shutting down and Ekiga could shut down under gdb.
Unregistration/registration back and forth in Account window works here
on linux with latest code.  Shutting down in gdb too.  Probably a
temporary problem.  Could you try latest trunk/master?  Apply this
patch, until I am 100% sure that it is correct and push in repository
(BTW with this patch could you simply check that chatting works?)

--
Eugen

--- ekiga-svn/lib/engine/components/opal/sip-endpoint.cpp 2009-06-10 12:20:09.000000000 +0200
+++ ekiga/lib/engine/components/opal/sip-endpoint.cpp 2009-06-14 17:09:23.000000000 +0200
@@ -357,8 +357,9 @@
 {
   if (!_uri.empty () && (_uri.find ("sip:") == 0 || _uri.find (':') == string::npos) && !_message.empty ()) {
 
-    SIPEndPoint::Message (_uri, _message);
-
+    PURL fromAddress;
+    PString conversationId;
+    Message (PURL(_uri), "text/plain", _message, fromAddress, conversationId);
     return true;
   }
 

_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Julien PUYDT :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Michael Rickmann a écrit :

> Eugen Dedu schrieb:
>> Michael Rickmann wrote:
>>> longer. Also the subcriber threads do not terminate any longer. Ekiga
>>> needs considerably longer to shutdown than it took one week ago and does
>>
>> I noticed it too...
>>
>>> Another point: Ekiga cannot be compiled since opal version 2258
>>> because the SIPEndPoint::Message form called in sip-endpoint.cpp:360
>>> no longer exists.
>>
>> I am working on this.
>>
> Strange things are accumulating at this point. I went back to Ekiga
> 7bb1d0 (Updated Spanish translation) and Opal/ptlib 22836 which
> correspond to the state at Wed Jun 10. Ekiga's unregistration was
> already broken at that time. But the subsriber threads were still
> shutting down and Ekiga could shut down under gdb.

Here the situation is the following :
- enabling/disabling account works ;
- although disabling seems to always give an error message (I need to
investigate) ;
- ekiga shuts down quickly enough (in or out of gdb).
- calling 500@... doesn't seem to work any more.

Snark
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Eugen Dedu :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Julien Puydt wrote:

> Michael Rickmann a écrit :
>> Eugen Dedu schrieb:
>>> Michael Rickmann wrote:
>>>> longer. Also the subcriber threads do not terminate any longer.
>>>> Ekiga needs considerably longer to shutdown than it took one week
>>>> ago and does
>>>
>>> I noticed it too...
>>>
>>>> Another point: Ekiga cannot be compiled since opal version 2258
>>>> because the SIPEndPoint::Message form called in sip-endpoint.cpp:360
>>>> no longer exists.
>>>
>>> I am working on this.
>>>
>> Strange things are accumulating at this point. I went back to Ekiga
>> 7bb1d0 (Updated Spanish translation) and Opal/ptlib 22836 which
>> correspond to the state at Wed Jun 10. Ekiga's unregistration was
>> already broken at that time. But the subsriber threads were still
>> shutting down and Ekiga could shut down under gdb.
>
> Here the situation is the following :
> - enabling/disabling account works ;
> - although disabling seems to always give an error message (I need to
> investigate) ;

This last point: I noticed it too since the beginning.  I wanted to fix
it in the same time as many other (user confusing) problems with
registration.

--
Eugen
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Damien Sandras :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Le lundi 15 juin 2009 à 13:07 +0200, Eugen Dedu a écrit :

> Julien Puydt wrote:
> > Michael Rickmann a écrit :
> >> Eugen Dedu schrieb:
> >>> Michael Rickmann wrote:
> >>>> longer. Also the subcriber threads do not terminate any longer.
> >>>> Ekiga needs considerably longer to shutdown than it took one week
> >>>> ago and does
> >>>
> >>> I noticed it too...
> >>>
> >>>> Another point: Ekiga cannot be compiled since opal version 2258
> >>>> because the SIPEndPoint::Message form called in sip-endpoint.cpp:360
> >>>> no longer exists.
> >>>
> >>> I am working on this.
> >>>
> >> Strange things are accumulating at this point. I went back to Ekiga
> >> 7bb1d0 (Updated Spanish translation) and Opal/ptlib 22836 which
> >> correspond to the state at Wed Jun 10. Ekiga's unregistration was
> >> already broken at that time. But the subsriber threads were still
> >> shutting down and Ekiga could shut down under gdb.
> >
> > Here the situation is the following :
> > - enabling/disabling account works ;
> > - although disabling seems to always give an error message (I need to
> > investigate) ;
>
> This last point: I noticed it too since the beginning.  I wanted to fix
> it in the same time as many other (user confusing) problems with
> registration.

Do those problems affect STABLE too?
Are they due to changes in OPAL or in Ekiga?
--
 _     Damien Sandras
(o-      
//\    Ekiga Softphone : http://www.ekiga.org/
v_/_   Be IP           : http://www.beip.be/
       FOSDEM          : http://www.fosdem.org/
       SIP Phone       : sip:dsandras@...
                       

_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Julien PUYDT :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Damien Sandras a écrit :

> Le lundi 15 juin 2009 à 13:07 +0200, Eugen Dedu a écrit :
>> Julien Puydt wrote:
>>> Michael Rickmann a écrit :
>>>> Eugen Dedu schrieb:
>>>>> Michael Rickmann wrote:
>>>>>> longer. Also the subcriber threads do not terminate any longer.
>>>>>> Ekiga needs considerably longer to shutdown than it took one week
>>>>>> ago and does
>>>>> I noticed it too...
>>>>>
>>>>>> Another point: Ekiga cannot be compiled since opal version 2258
>>>>>> because the SIPEndPoint::Message form called in sip-endpoint.cpp:360
>>>>>> no longer exists.
>>>>> I am working on this.
>>>>>
>>>> Strange things are accumulating at this point. I went back to Ekiga
>>>> 7bb1d0 (Updated Spanish translation) and Opal/ptlib 22836 which
>>>> correspond to the state at Wed Jun 10. Ekiga's unregistration was
>>>> already broken at that time. But the subsriber threads were still
>>>> shutting down and Ekiga could shut down under gdb.
>>> Here the situation is the following :
>>> - enabling/disabling account works ;
>>> - although disabling seems to always give an error message (I need to
>>> investigate) ;
>> This last point: I noticed it too since the beginning.  I wanted to fix
>> it in the same time as many other (user confusing) problems with
>> registration.
>
> Do those problems affect STABLE too?
> Are they due to changes in OPAL or in Ekiga?

Looking at a -d 4, it seems that ekiga asks to unregister by trying to
register again, and gets a 489 Bad event back...

Perhaps my recent refactoring of the account code is responsible for the
problem...

Snark
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Julien PUYDT :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Julien Puydt a écrit :

> Damien Sandras a écrit :
>> Le lundi 15 juin 2009 à 13:07 +0200, Eugen Dedu a écrit :
>>> Julien Puydt wrote:
>>>> Michael Rickmann a écrit :
>>>>> Eugen Dedu schrieb:
>>>>>> Michael Rickmann wrote:
>>>>>>> longer. Also the subcriber threads do not terminate any longer.
>>>>>>> Ekiga needs considerably longer to shutdown than it took one week
>>>>>>> ago and does
>>>>>> I noticed it too...
>>>>>>
>>>>>>> Another point: Ekiga cannot be compiled since opal version 2258
>>>>>>> because the SIPEndPoint::Message form called in
>>>>>>> sip-endpoint.cpp:360 no longer exists.
>>>>>> I am working on this.
>>>>>>
>>>>> Strange things are accumulating at this point. I went back to Ekiga
>>>>> 7bb1d0 (Updated Spanish translation) and Opal/ptlib 22836 which
>>>>> correspond to the state at Wed Jun 10. Ekiga's unregistration was
>>>>> already broken at that time. But the subsriber threads were still
>>>>> shutting down and Ekiga could shut down under gdb.
>>>> Here the situation is the following :
>>>> - enabling/disabling account works ;
>>>> - although disabling seems to always give an error message (I need
>>>> to investigate) ;
>>> This last point: I noticed it too since the beginning.  I wanted to
>>> fix it in the same time as many other (user confusing) problems with
>>> registration.
>>
>> Do those problems affect STABLE too?
>> Are they due to changes in OPAL or in Ekiga?
>
> Looking at a -d 4, it seems that ekiga asks to unregister by trying to
> register again, and gets a 489 Bad event back...
>
> Perhaps my recent refactoring of the account code is responsible for the
> problem...

Uh... from lib/engine/components/opal/sip-endpoint.cpp :
bool
Opal::Sip::EndPoint::subscribe (const Opal::Account & account)
{
   if (account.get_protocol_name () != "SIP")
     return false;

   new subscriber (account, *this);
   return true;
}


bool
Opal::Sip::EndPoint::unsubscribe (const Opal::Account & account)
{
   if (account.get_protocol_name () != "SIP")
     return false;

   new subscriber (account, *this);
   return true;
}

Is it me or is it doing the same thing in both cases !?

Snark
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Michael Rickmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

...snip

> > Looking at a -d 4, it seems that ekiga asks to unregister by trying to
> > register again, and gets a 489 Bad event back...
> >
> > Perhaps my recent refactoring of the account code is responsible for the
> > problem...
>
> Uh... from lib/engine/components/opal/sip-endpoint.cpp :
> bool
> Opal::Sip::EndPoint::subscribe (const Opal::Account & account)
> {
>    if (account.get_protocol_name () != "SIP")
>      return false;
>
>    new subscriber (account, *this);
>    return true;
> }
>
>
> bool
> Opal::Sip::EndPoint::unsubscribe (const Opal::Account & account)
> {
>    if (account.get_protocol_name () != "SIP")
>      return false;
>
>    new subscriber (account, *this);
>    return true;
> }
>
> Is it me or is it doing the same thing in both cases !?
>
> Snark

I was wondering about that one as well. All I can say is that the
unsubscribe was not used. When studying Ekiga#s exit, I had outcommented
it by a diff the file date of which is Mo 8 Jun and the linker did not
complain. Now unsubscribe is called.
Regards
Michael

_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Damien Sandras :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Le lundi 15 juin 2009 à 13:47 +0200, Michael Rickmann a écrit :

> ...snip
> > > Looking at a -d 4, it seems that ekiga asks to unregister by trying to
> > > register again, and gets a 489 Bad event back...
> > >
> > > Perhaps my recent refactoring of the account code is responsible for the
> > > problem...
> >
> > Uh... from lib/engine/components/opal/sip-endpoint.cpp :
> > bool
> > Opal::Sip::EndPoint::subscribe (const Opal::Account & account)
> > {
> >    if (account.get_protocol_name () != "SIP")
> >      return false;
> >
> >    new subscriber (account, *this);
> >    return true;
> > }
> >
> >
> > bool
> > Opal::Sip::EndPoint::unsubscribe (const Opal::Account & account)
> > {
> >    if (account.get_protocol_name () != "SIP")
> >      return false;
> >
> >    new subscriber (account, *this);
> >    return true;
> > }
> >
> > Is it me or is it doing the same thing in both cases !?
> >
> > Snark
>
> I was wondering about that one as well. All I can say is that the
> unsubscribe was not used. When studying Ekiga#s exit, I had outcommented
> it by a diff the file date of which is Mo 8 Jun and the linker did not
> complain. Now unsubscribe is called.

I suppose account is disabled in one case and not in the other.
--
 _     Damien Sandras
(o-      
//\    Ekiga Softphone : http://www.ekiga.org/
v_/_   Be IP           : http://www.beip.be/
       FOSDEM          : http://www.fosdem.org/
       SIP Phone       : sip:dsandras@...
                       

_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Julien PUYDT :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Michael Rickmann a écrit :
> I was wondering about that one as well. All I can say is that the
> unsubscribe was not used. When studying Ekiga#s exit, I had outcommented
> it by a diff the file date of which is Mo 8 Jun and the linker did not
> complain. Now unsubscribe is called.

Eh... I came to that code by following opal-account.cpp's populate_menu,
which I rewrote very recently -- so indeed it is used now... but if it's
going to erroneous code, we're no better.

Snark
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Julien PUYDT :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Julien Puydt a écrit :
> Michael Rickmann a écrit :
>> I was wondering about that one as well. All I can say is that the
>> unsubscribe was not used. When studying Ekiga#s exit, I had outcommented
>> it by a diff the file date of which is Mo 8 Jun and the linker did not
>> complain. Now unsubscribe is called.
>
> Eh... I came to that code by following opal-account.cpp's populate_menu,
> which I rewrote very recently -- so indeed it is used now... but if it's
> going to erroneous code, we're no better.

I fixed the unregistration problem in master.

For gnome-2-26, I'm still investigating.

Snark
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Julien PUYDT :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Julien Puydt a écrit :

> Julien Puydt a écrit :
>> Michael Rickmann a écrit :
>>> I was wondering about that one as well. All I can say is that the
>>> unsubscribe was not used. When studying Ekiga#s exit, I had outcommented
>>> it by a diff the file date of which is Mo 8 Jun and the linker did not
>>> complain. Now unsubscribe is called.
>>
>> Eh... I came to that code by following opal-account.cpp's
>> populate_menu, which I rewrote very recently -- so indeed it is used
>> now... but if it's going to erroneous code, we're no better.
>
> I fixed the unregistration problem in master.
>
> For gnome-2-26, I'm still investigating.

I just had to cherry-pick :-)

That unregistration problem is gone.

Snark
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Julien PUYDT :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Michael Rickmann a écrit :
> This is Ekigas answer in the accounts window on Linux now.  With the
> current git version I cannot unregister my account at ekiga.net any
> longer.

Ok, that problem was much older, and I just fixed it.

> Also the subcriber threads do not terminate any longer. Ekiga
> needs considerably longer to shutdown than it took one week ago and does
> not shut down at all when run under gdb.

That one is new AFAICT, and I don't see it.

> Another point: Ekiga cannot be compiled since opal version 2258 because
> the SIPEndPoint::Message form called in sip-endpoint.cpp:360 no longer
> exists.

I haven't upgraded ptlib+opal in a while, so perhaps this problem (and
the one above) are new regressions there?

Snark
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Eugen Dedu :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Michael Rickmann wrote:
> needs considerably longer to shutdown than it took one week ago and does

As already said, I have this one too; on shutting down:
[...]
2009/06/17 19:12:07.477  0:15.096 Network In...0xe733a950 IfaceMon
Finished interface monitor thread.
2009/06/17 19:12:07.480  0:15.099
WaitForTermination on 140655467931984 finished
2009/06/17 19:12:07.480  0:15.099                       PTLib
Destroyed thread 0x1c46570 Network Interface Monitor:0xe733a950(id =
7fece733a950)
2009/06/17 19:12:14.095  0:21.714
WaitForTermination on 140655467665744 finished
2009/06/17 19:12:14.095  0:21.714                       PTLib
Destroyed thread 0x1c46800 Housekeeper:0xe72f9950(id = 7fece72f9950)

So it took 6 seconds to wait for the last thread...

Otherwise, it seems this is the last remaining issue among all those you
have risen, is that right?

--
Eugen
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Michael Rickmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Am Mittwoch, den 17.06.2009, 19:16 +0200 schrieb Eugen Dedu:
> Michael Rickmann wrote:
> > needs considerably longer to shutdown than it took one week ago and does
>
snip
> So it took 6 seconds to wait for the last thread...
>
> Otherwise, it seems this is the last remaining issue among all those you
> have risen, is that right?
>
Yes, it is the last one. Surprisingly it effects especially Linux Ekiga.
After Sparks fix. The shutdown time under WinXP was reduced to about one
sec - it was ~3 sec before. Under Win7RC Ekiga is shut down so fast that
I cannot guess.
Regards
Michael

_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list

Re: Could not unregister, regression

by Eugen Dedu :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Damien Sandras wrote:

> Le lundi 15 juin 2009 à 13:07 +0200, Eugen Dedu a écrit :
>> Julien Puydt wrote:
>>> Michael Rickmann a écrit :
>>>> Eugen Dedu schrieb:
>>>>> Michael Rickmann wrote:
>>>>>> longer. Also the subcriber threads do not terminate any longer.
>>>>>> Ekiga needs considerably longer to shutdown than it took one week
>>>>>> ago and does
>>>>> I noticed it too...
>>>>>
>>>>>> Another point: Ekiga cannot be compiled since opal version 2258
>>>>>> because the SIPEndPoint::Message form called in sip-endpoint.cpp:360
>>>>>> no longer exists.
>>>>> I am working on this.
>>>>>
>>>> Strange things are accumulating at this point. I went back to Ekiga
>>>> 7bb1d0 (Updated Spanish translation) and Opal/ptlib 22836 which
>>>> correspond to the state at Wed Jun 10. Ekiga's unregistration was
>>>> already broken at that time. But the subsriber threads were still
>>>> shutting down and Ekiga could shut down under gdb.
>>> Here the situation is the following :
>>> - enabling/disabling account works ;
>>> - although disabling seems to always give an error message (I need to
>>> investigate) ;
>> This last point: I noticed it too since the beginning.  I wanted to fix
>> it in the same time as many other (user confusing) problems with
>> registration.
>
> Do those problems affect STABLE too?
> Are they due to changes in OPAL or in Ekiga?

In case it is still interesting:

Threads considerably longer: master-only
Compilation problem: fixed
Unregistering: just fixed in both mster and branch.  Had existed since
long ago.

--
Eugen
_______________________________________________
Ekiga-devel-list mailing list
Ekiga-devel-list@...
http://mail.gnome.org/mailman/listinfo/ekiga-devel-list