Created: (SUREFIRE-555) Support junit core for parallel running of tests

Support junit core for parallel running of tests
------------------------------------------------

                 Key: SUREFIRE-555
                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
             Project: Maven Surefire
          Issue Type: New Feature
         Environment: All
            Reporter: Kristian Rosenvold
         Attachments: surefire.patch

The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/

The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?





--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Rosenvold updated SUREFIRE-555:
----------------------------------------

    Attachment: surefirev2.patch

Attached is an updated patch for junit 4.7. The revised patch also has no dependencies to any external libraries.

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197069#action_197069 ]

Brett Porter commented on SUREFIRE-555:
---------------------------------------

Who are the original authors in the dual licensed pieces of code and where did it come from?

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197080#action_197080 ]

Kristian Rosenvold commented on SUREFIRE-555:
---------------------------------------------

I am. I made it dual licensed to be compatible with the junit license.

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197080#action_197080 ]

Kristian Rosenvold edited comment on SUREFIRE-555 at 11/3/09 3:49 PM:
----------------------------------------------------------------------

I am. I made it dual licensed to be compatible with the junit license. If this is a problem I can change it - I hope ;)



      was (Author: krosenvold):
    I am. I made it dual licensed to be compatible with the junit license.
 

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197080#action_197080 ]

Kristian Rosenvold edited comment on SUREFIRE-555 at 11/3/09 4:02 PM:
----------------------------------------------------------------------

I am. I made it dual licensed to be compatible with the junit license. If this is a problem I can change it - I hope ;) The project is located at http://github.com/krosenvold/configurable-parallel-computer 



      was (Author: krosenvold):
    I am. I made it dual licensed to be compatible with the junit license. If this is a problem I can change it - I hope ;)


 

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197086#action_197086 ]

Brett Porter commented on SUREFIRE-555:
---------------------------------------

It doesn't have to be, but ideally it would all have the "licensed to Apache..." header they all share. Since it is your own work you can certainly do that. Would you mind resubmitting?

I would like some other changes and clarification:
- instead of "junitcore" is this basically a "junit 4.7+" feature? I got a bit confused by the terminology
- the version parsing seems unusual - can we use a range instead ("[4.7,)")
- can you remove the .orig files from the patch?
- what is the purpose of the separated directory scanner?

Let me know if you need any more info on these.

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197090#action_197090 ]

Kristian Rosenvold commented on SUREFIRE-555:
---------------------------------------------

Yes to all. Will resubmit tomorrow.

The purpose of the separated directory scanner was really just to get it unit-testable as an individual piece. I suppose I couldn't resist the urge to make things more unit-testable, since they're both faster and easier to write. There is also a unit-test for that separate piece of code. At that point I guess It was a bit irresponsible of me not to replace usage in the other plugins too, but I suppose I realized I was getting a bit carried away. The api-contract of the separated scanner is also slightly cleaner than the original.

I can take this both ways (revert to old-style or change the other plugins), what do you think ?

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197110#action_197110 ]

Brett Porter commented on SUREFIRE-555:
---------------------------------------

that's fine, I couldn't see a big change so just checking whether it was meant to do something I couldn't see

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Rosenvold updated SUREFIRE-555:
----------------------------------------

    Attachment: surefirev3.patch

This is version 3 of the patch (surefirev3.patch). Includes all requested changes.

I will try to submit a subsequent patch to change the other providers to use the external scanner, but this patch is totally self-contained.

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch, surefirev3.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197144#action_197144 ]

Kristian Rosenvold commented on SUREFIRE-555:
---------------------------------------------

It turns out I had done "the right" thing and extracted all the directory scanning to the separate class, so this is effectively in use by all the providers (it was done in the base class for the providers and I extracted it to get more precise test coverage and re-use for the junit 4.7 provider)

Since I'm not totally fluent in the maven internals, you may also want to just check the methods isJunit40to46 and isJunit47Compatible in the revised patch, just in case there's a better way to do it.  

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch, surefirev3.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Rosenvold updated SUREFIRE-555:
----------------------------------------

    Attachment: surefirev4.patch

v4 also includes what I hope is the appropriate license headers in all files. T

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch, surefirev3.patch, surefirev4.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197195#action_197195 ]

Kristian Rosenvold edited comment on SUREFIRE-555 at 11/4/09 10:43 AM:
-----------------------------------------------------------------------

v4 also includes what I hope is the appropriate license headers in all files.

Also note that after I artifactid & name of the provider to surefire-junit47 I had to run mvn -N install within the surefire-providers folder and the root folder to get things to compile (assuming you have compiled the previous version within the same checkout)

      was (Author: krosenvold):
    v4 also includes what I hope is the appropriate license headers in all files. T
 

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch, surefirev3.patch, surefirev4.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/SUREFIRE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=201418#action_201418 ]

Igor Minar commented on SUREFIRE-555:
-------------------------------------

hi there,

Will the patch be accepted? This new feature looks very interesting.

thanks,
Igor

> Support junit core for parallel running of tests
> ------------------------------------------------
>
>                 Key: SUREFIRE-555
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-555
>             Project: Maven Surefire
>          Issue Type: New Feature
>         Environment: All
>            Reporter: Kristian Rosenvold
>         Attachments: surefire.patch, surefirev2.patch, surefirev3.patch, surefirev4.patch
>
>
> The enclosed patch adds junitcore support to surefire. The patch requires junit 4.6 (the latest released version) to compile, but is only activated when running with the 4.7 snapshot or higher (due to some bugs in 4.6).  The patch adds one extra setting to the surefire plugin. More details at http://incodewetrustinc.blogspot.com/
> The new plugin also requires an external library which can be found at http://github.com/krosenvold/configurable-parallel-computer/tree/master, which will be bumped to 1.0 when/if you decide to accept the patch. I am requesting that the junit project actually accept the features of the configurable-parallel-computer as a standard feature in junit 4.7, but that's not decided yet. I do not have a public maven repo that is hosting configurable-parallel-computer, but was hoping maybe you could publish it ?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira