Ctrl+L

Please review the following patch.
It makes Konqueror behaive on Ctrl+L like the rest: just select current text in address bar,
so that it can be easily copied or erased by typing (pasting) new one.

currently it removes the previous text and there is no way to have it back
(i.e. ctrl+z doesn't work)

also currently m_combo->clearTemporary(); is called two times during initialization
(directly and via slotClearLocationBar), and the patch fixes this.


Index: apps/konqueror/src/konqmainwindow.cpp
===================================================================
--- apps/konqueror/src/konqmainwindow.cpp       (revision 953909)
+++ apps/konqueror/src/konqmainwindow.cpp       (working copy)
@@ -3265,7 +3265,7 @@
 void KonqMainWindow::slotClearLocationBar()
 {
     slotStop();
-    m_combo->clearTemporary();
+    m_combo->lineEdit()->selectAll();
     focusLocationBar();
 }

[Thiago Macieira]

Nick Shaforostoff wrote:

>Please review the following patch.
>It makes Konqueror behaive on Ctrl+L like the rest: just select current
> text in address bar, so that it can be easily copied or erased by
> typing (pasting) new one.
>
>currently it removes the previous text and there is no way to have it
> back (i.e. ctrl+z doesn't work)
>
>also currently m_combo->clearTemporary(); is called two times during
> initialization (directly and via slotClearLocationBar), and the patch
> fixes this.

KDE 3's Konqueror had a "Location" label next to the line edit, which had
an accelerator. So you could do Alt+o to select it, without erasing the
text.

So, if the label were still there, I'd oppose the patch as unnecessary.

Now, I agree with it.

--
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Using kde 4.2.2 kubuntu packages, alt-o works fine and I use it daily. Just a heads up.

Sent on the Now Network� from my Sprint® BlackBerry

-----Original Message-----
From: Thiago Macieira <thiago@...>

Date: Tue, 14 Apr 2009 23:09:39
To: <kfm-devel@...>
Subject: Re: Ctrl+L


Nick Shaforostoff wrote:

>Please review the following patch.
>It makes Konqueror behaive on Ctrl+L like the rest: just select current
> text in address bar, so that it can be easily copied or erased by
> typing (pasting) new one.
>
>currently it removes the previous text and there is no way to have it
> back (i.e. ctrl+z doesn't work)
>
>also currently m_combo->clearTemporary(); is called two times during
> initialization (directly and via slotClearLocationBar), and the patch
> fixes this.

KDE 3's Konqueror had a "Location" label next to the line edit, which had
an accelerator. So you could do Alt+o to select it, without erasing the
text.

So, if the label were still there, I'd oppose the patch as unnecessary.

Now, I agree with it.

--
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

[Thiago Macieira]

mikebwilliams@... wrote:
>Using kde 4.2.2 kubuntu packages, alt-o works fine and I use it daily.
> Just a heads up.
>
>Sent on the Now Network� from my Sprint® BlackBerry

You're right, Alt+o is still there.

So the patch is unnecessary.

--
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

[Claes H]

On Wed, Apr 15, 2009 at 8:33 AM, Thiago Macieira <thiago@...> wrote:

> mikebwilliams@... wrote:
>>Using kde 4.2.2 kubuntu packages, alt-o works fine and I use it daily.
>> Just a heads up.
>>
>>Sent on the Now Network� from my Sprint® BlackBerry
>
> You're right, Alt+o is still there.
>
> So the patch is unnecessary.
>

But why is it unneccessary to provide familiar behaviour?

Claes

On Wednesday 15 April 2009, Thiago Macieira wrote:
> mikebwilliams@... wrote:
> >Using kde 4.2.2 kubuntu packages, alt-o works fine and I use it daily.
> > Just a heads up.
> >
> >Sent on the Now Network� from my Sprint® BlackBerry
>
> You're right, Alt+o is still there.

F6 does the same, as well.

But I have no opinion on Ctrl+L.

--
David Faure, faure@..., sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).