DO NOT REPLY [Bug 45672] New: LastCellOfRowDummyRecord is returned multiple times per row

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672

           Summary: LastCellOfRowDummyRecord is returned multiple times per
                    row
           Product: POI
           Version: unspecified
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSSF
        AssignedTo: dev@...
        ReportedBy: IBeaumont@...


Created an attachment (id=22473)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22473)
Spreadsheet containing issue

I'm trying to convert a Excel spreadsheet to CSV based on something similar to
the example XLS2CSVmra.java.

This is using the Event API.  For some reason on certain rows of my spreadsheet
I get multiple LastCellOfRowDummyRecord records per row.  These happen at
different points doing the processing of the row.  
For example row 16 returns LastCellOfRowDummyRecord after processing column 12,
column 18 and column 31.

Problem Spreadsheet attached.

Tested in 3.1 and 3.5 beta 1


--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672


Ian Beaumont <IBeaumont@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22473|0                           |1
        is obsolete|                            |




--- Comment #1 from Ian Beaumont <IBeaumont@...>  2008-08-22 09:38:50 PST ---
Created an attachment (id=22475)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22475)
Spreadsheet containing issue

This is a smaller/simpler spreadsheet showing the problem


--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672





--- Comment #2 from Ian Beaumont <IBeaumont@...>  2008-08-22 09:46:48 PST ---
Created an attachment (id=22476)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22476)
Proposed patch to fix issue

On investigating the problem it seems that the issue is because the spreadsheet
contains SharedFormulaRecord and the MissingRecordAwareHSSFListener seems to
generate a LastCellOfRowDummyRecord for the row every time it hits one of these
records.

I've included a patch which updates the MissingRecordAwareHSSFListener to
ignore any SharedFormulaRecord and this seems to fix the issue and the
spreadsheet is now processed correctly.  However I don't have a great
understanding of POI so whether what I've done is valid I'm not sure.
Certainly has fixed my issue.


--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672


Josh Micich <josh@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Josh Micich <josh@...>  2008-08-23 15:58:01 PST ---
I think it is not quite correct to completely ignore the SharedFormulaRecord.

Applied patch with some simplifications in svn r688426

Added junit


--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672





--- Comment #4 from Chris Lott <apache7@...>  2009-06-02 12:33:39 PST ---
I am using the XLS2CSVmra example with POI 3.5beta5 and today I hit a XLS (2003
format) spreadsheet that triggers this exact problem.  The sheet is very wide
but only has 2 rows.  The first row has headers and is read/reported perfectly.
 The second row has data and becomes *9* rows in the output.  I am using Excel
to look at the data in the cells that become the last item in the output.  One
is a date, one is a number stored as a string; neither appears to be a formula.
 Right now the data is proprietary so I cannot upload it.  I am happy to
investigate further, like using the debugger, but don't know what evidence you
need.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672





--- Comment #5 from Adam Pingel <pingel@...>  2009-06-02 15:48:38 PST ---
Hello.  I noticed Chris's earlier note to the user mailing list and then
followed the bug here.  I'm seeing the same issue.  I attached a .java and a
trace of the program as applied to Chris's sample .xls file to that message.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672





--- Comment #6 from David Fisher <dfisher@...>  2009-06-02 16:03:38 PST ---
Hi Adam,

Thanks. If possible, try a recent nightly build first.

BTW - your attachments didn't make it through to the list with your email.
Please attach the files to this issue. Hopefully someone will look into it in
the near future.

Regards,
Dave

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672





--- Comment #7 from Adam Pingel <pingel@...>  2009-06-02 17:15:51 PST ---
I tried again with poi-3.5-beta7-20090602.jar and
poi-ooxml-3.5-beta7-20090602.jar.  I will attach my .java and the resulting
log.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672





--- Comment #8 from Adam Pingel <pingel@...>  2009-06-02 17:18:06 PST ---
Created an attachment (id=23744)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23744)
execution trace of my code applied to Chris's .xls file

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672





--- Comment #9 from Adam Pingel <pingel@...>  2009-06-02 17:19:22 PST ---
Created an attachment (id=23745)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23745)
a reworked XLS2CSVmra that I'm using to create the trace

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672


Chris Lott <apache7@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #10 from Chris Lott <apache7@...>  2009-06-23 04:58:01 PST ---
I reopened this bug -- I hope that's acceptable to the POI committers.  Adam
and I have provided fairly convincing evidence and attached it to this bug
report.  I hope this isn't too hard to fix, and that maybe the fix will be
delivered in time for the 3.5 final release.  Thanks for listening.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672

--- Comment #11 from kirklib@... 2009-10-19 07:16:43 UTC ---
Was very happy to discover this library, and then quickly disappointed by this
bug which is a fairly essential necessity for such a program.

I have detailed the problem I have on the mailing list:
http://www.nabble.com/XLS-to-Tab-delimited-getting-extra-new-lines-to25931161.html#a25935746

An event is thrown signalling the end of a row whenever it encounters various
blank cells in my data.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672

Nick Burch <nick@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Nick Burch <nick@...> 2009-11-03 14:48:43 UTC ---
Ah, I'd forgotten that you can have records that cover multiple cells
(MulBlankRecord and MulRKRecord). MissingRecordAwareHSSFListener wasn't
handling these properly, and probably nor was anyone's code...

I've updated MissingRecordAwareHSSFListener to expand these out into individual
records, so hopefully it'll behave itself better now

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672

--- Comment #13 from Chris Lott <apache7@...> 2009-11-08 06:45:06 UTC ---
Created an attachment (id=24504)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24504)
Two-row spreadsheet that triggers LsatCellOfDummyRowRec failure

I sent this spreadsheet to Adam Pingel but forgot to attach it to this bug.
Running XLS2CSVmra + POI 3.5 FINAL on this input yields 3 rows (expected 2).

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=45672

--- Comment #14 from Chris Lott <apache7@...> 2009-11-08 06:48:52 UTC ---
Nick Burch, thank you very much for the patch.  It works for me!  I tested the
nightly build POI-3.6-beta1-20091108.jar from encore.torchbox.com together with
the XLS2CSVmra program on the two-row spreadsheet that is attached to this bug.
 The failure no longer happens.  POI 3.5 final yields 3 rows, POI 3.6 beta
yields 2 rows, which is what I expect.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...