DO NOT REPLY [Bug 47318] New: Tomcat 6.0.20 does not include imports from included JSP

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318

           Summary: Tomcat 6.0.20 does not include imports from included
                    JSP
           Product: Tomcat 6
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: regression
          Priority: P2
         Component: Jasper
        AssignedTo: dev@...
        ReportedBy: fitness_mania@...


Tomcat 6.0.20 does not include imports from included JSP, i.e.,
- JSP A includes JSP B.
- JSP B has some page imports

Result: JSP A is not able to see page imports imported in JSP B - the page
imports imported in JSP B are not imported on JSP A generated class file.

Expected Result: JSP A is able to see page imports imported in JSP B

This worked in Tomcat 6.0.18.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318


Tim Funk <funkman@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO




--- Comment #1 from Tim Funk <funkman@...>  2009-06-05 04:32:53 PST ---
please attach an example which reproduces this situation. I was unable to
reproduce in a very simplistic setting.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318





--- Comment #2 from fitness_mania@...  2009-06-05 08:46:05 PST ---
Created an attachment (id=23763)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23763)
include-prelude issue

I forgot to mention that this happened when using JSP include-prelude. I did
not try include-coda though.

I have attached a sample.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318


fitness_mania@... changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23763|include-prelude issue       |include-prelude sample
        description|                            |




--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318


Tim Funk <funkman@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW




--- Comment #3 from Tim Funk <funkman@...>  2009-06-05 11:53:30 PST ---
It seems like this might be the culprit:

http://svn.apache.org/viewvc?view=rev&revision=708165

This does look a little serious since its convenient to stick directives into a
include-prelude so that all (or a group) of files can all get the same
directives.

Also moving status back to new - since the attached patch does reproduce the
issue.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318





--- Comment #4 from Mark Thomas <markt@...>  2009-06-05 13:59:28 PST ---
I'll take a look.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318





--- Comment #5 from Mark Thomas <markt@...>  2009-06-05 16:49:32 PST ---
Yep, that patch was the culprit although a little indirectly.

It has been fixed in trunk and the patch proposed for 6.0.x. I've also added it
to the 5.5.x back port

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318





--- Comment #6 from Tim Funk <funkman@...>  2009-06-08 06:07:38 PST ---
Created an attachment (id=23775)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23775)
webapp with tag files fail

The same war file as previous attached with the new use case where tag file
fail

Now fails with
javax.servlet.error.exception: java.lang.RuntimeException:
org.apache.jasper.JasperException: ...  <%@ page directive cannot be used in a
tag file

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318





--- Comment #7 from Tim Funk <funkman@...>  2009-06-09 10:08:14 PST ---
Created an attachment (id=23781)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23781)
Patch for jasper

Here is a patch derived from 6.0.x
[https://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk ]

Changed files are
 - java/org/apache/jasper/compiler/ParserController.java
 - java/org/apache/jasper/compiler/Compiler.java

It works on both test cases attached to the bug as well as some other code I
have locally. Placing here instead of committing to trunk since this is my
first dive into jasper.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318





--- Comment #8 from Mark Thomas <markt@...>  2009-06-10 05:33:15 PST ---
Better fix is now in trunk and proposed for 6.0.x. I went for a patch that kept
the changes in parser.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318


Mark Thomas <markt@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #9 from Mark Thomas <markt@...>  2009-06-12 15:43:47 PST ---
This has been fixed in 6.0.x and will be included in 6.0.21 onwards.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47318


Mark Thomas <markt@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |damien@...




--- Comment #10 from Mark Thomas <markt@...>  2009-07-02 05:02:54 PST ---
*** Bug 47466 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...