DO NOT REPLY [Bug 47430] New: rendering problem with image in fo:block in multiple fo:inline

https://issues.apache.org/bugzilla/show_bug.cgi?id=47430

           Summary: rendering problem with image in fo:block in multiple
                    fo:inline
           Product: Fop
           Version: 0.95
          Platform: PC
        OS/Version: Windows Vista
            Status: NEW
          Severity: normal
          Priority: P2
         Component: pdf
        AssignedTo: fop-dev@...
        ReportedBy: fworsley@...


This PDF rendering problem occurs with a fo:external-graphic nested inside of a
fo:block that is itself nested inside at least two fo:inline elements.

See the attached "good.pdf" output for what I would expect and the "bad.pdf"
output for what actually happens. The "test.fo.xml" file is a XML-FO example
file that will produce the bad rendering.

Notice that removing either the fo:block or the second fo:inline element will
fix the problem.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47430





--- Comment #1 from Frank Worsley <fworsley@...>  2009-06-25 10:15:03 PST ---
Created an attachment (id=23879)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23879)
the good rendering that is expected

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47430





--- Comment #2 from Frank Worsley <fworsley@...>  2009-06-25 10:15:26 PST ---
Created an attachment (id=23880)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23880)
the bad rendering that actually happens

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47430





--- Comment #3 from Frank Worsley <fworsley@...>  2009-06-25 10:16:23 PST ---
Created an attachment (id=23881)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23881)
a small XML-FO file that causes the bad rendering

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47430





--- Comment #4 from Frank Worsley <fworsley@...>  2009-06-25 10:16:42 PST ---
Created an attachment (id=23882)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23882)
an image to use with the XML-FO example file

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47430





--- Comment #5 from Frank Worsley <fworsley@...>  2009-07-05 21:51:48 PST ---
Created an attachment (id=23931)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23931)
another XML-FO test file that results in a bad rendering

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47430





--- Comment #6 from Frank Worsley <fworsley@...>  2009-07-05 21:54:53 PST ---
Created an attachment (id=23932)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23932)
first attempt at patch that fixes the problem

I've attached a small patch that fixes the problem for me. I don't know enough
about FOP to say whether this is the best approach.

Looking through the code it looks like it would be possible to get rid of
InlineBlockParent. The differences between it and the basic InlineParent class
are quite small. Cleaning up the patch to get rid of InlineBlockParent would
probably be a good idea.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47430





--- Comment #7 from Frank Worsley <fworsley@...>  2009-07-05 22:15:09 PST ---
Another comment: This patch causes quite a few of the unit tests to fail.
Unfortunately I don't have time to look into why right now.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47430





--- Comment #8 from Andreas L. Delmelle <adelmelle@...>  2009-07-06 06:39:41 PST ---
(In reply to comment #7)

Hi Frank

> Another comment: This patch causes quite a few of the unit tests to fail.
> Unfortunately I don't have time to look into why right now.

No problem. The patch is already a good starting point, and shows where
something is missing.

Thanks a lot for the contribution!

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.