DO NOT REPLY [Bug 47708] New: Infinite loop in ImageLoaderImageIO.java when reading PNG

https://issues.apache.org/bugzilla/show_bug.cgi?id=47708

           Summary: Infinite loop in ImageLoaderImageIO.java when reading
                    PNG
           Product: XMLGraphicsCommons
           Version: Trunk
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Utilities
        AssignedTo: general@...
        ReportedBy: holz@...


--- Comment #0 from Martin Holz <holz@...> 2009-08-19 06:43:16 PDT ---
Created an attachment (id=24146)
Sample image, which causes a infinite loop

When reading the attached PNG image the loop at line 295
http://svn.apache.org/repos/asf/xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/image/loader/impl/imageio/ImageLoaderImageIO.java,
Rev 798806
will not terminate.  resultLength is always 0.

I don't know. how the image was created and if the format is correct. At least
it looks fine in Firefox.

Java(TM) SE Runtime Environment (build 1.6.0_14-b08)
Ubuntu Linux 8.04 LTS

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@...
For additional commands, e-mail: general-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47708



--- Comment #1 from Martin Holz <holz@...> 2009-08-19 06:46:41 PDT ---
Created an attachment (id=24147)
Test case

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@...
For additional commands, e-mail: general-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47708


Max Berger <max@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |general@....
                   |                            |org
         AssignedTo|general@.... |max@...
                   |org                         |


--- Comment #2 from Max Berger <max@...> 2009-08-20 02:50:29 PDT ---
My fault, so I will fix it.

May I include this image as a test case into xmlgraphics-commons, e.g. can you
release it under APL2 or did you get it from a third party source?

Max

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@...
For additional commands, e-mail: general-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47708



--- Comment #3 from Martin Holz <holz@...> 2009-08-20 04:41:38 PDT ---
(In reply to comment #2)
The sample image hads.png was create by Knut Schulz from University Oldenburg
for the project http.//www.vs-c.de .  
It is publised under
http://www.chemgapedia.de/vsengine/media/vsc/de/ch/10/adsorption/grundlagen/grundbegriffe_der_adsorption/medien/hads.png
.

FIZ CHEMIE Berlin hereby grant to the Apache Software Foundation and to
recipients of software distributed by the Foundation a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare derivative works of,
publicly display, publicly perform, sublicense, and distribute
that image and any derivative works.

Note: This applies only to that image,
not to any other image at that website.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@...
For additional commands, e-mail: general-help@...

https://issues.apache.org/bugzilla/show_bug.cgi?id=47708


Max Berger <max@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


--- Comment #4 from Max Berger <max@...> 2009-08-20 12:39:56 PDT ---
http://svn.apache.org/viewvc?rev=806319&view=rev

resultLength == 0 means the deflater which is trying to read the embedded ICC
profile needs more input. However, there is not extra input available!

Decided to terminate the loop. Since this will result in an invalid ICC
profile, it is ignored, and the image will be loaded without the profile.
Testcase is added.

Max

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@...
For additional commands, e-mail: general-help@...