DO NOT REPLY [Bug 47835] New: Percentages not working for provisional-distance-between-starts

https://issues.apache.org/bugzilla/show_bug.cgi?id=47835

           Summary: Percentages not working for
                    provisional-distance-between-starts
           Product: Fop
           Version: 0.95
          Platform: PC
        OS/Version: Windows Vista
            Status: NEW
          Severity: normal
          Priority: P2
         Component: page-master/layout
        AssignedTo: fop-dev@...
        ReportedBy: eric.amick@...


Created an attachment (id=24256)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24256)
FO demonstrating bug. The first list uses percentage, the second doesn't.

According to the spec, percentages are allowed for
provisional-distance-between-starts, but FOP doesn't handle it correctly.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47835

--- Comment #1 from Jonathan Levinson <levinson@...> 2009-09-17 14:49:13 PDT ---
Created an attachment (id=24285)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24285)
Let provisional-distance-between-starts act correctly as percentage

This is a patch to FOPPropertyMapping.java.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47835

--- Comment #2 from Jonathan Levinson <levinson@...> 2009-09-17 14:54:57 PDT ---
According to standard:

The "provisional-distance-between-start" is specified as a percentage of the
inline progression dimension of the closet ancestor block-area.

To its definition in FOPPropertyMapping.java I added the following:

        m.setPercentBase(LengthBase.CONTAINING_BLOCK_WIDTH);

I ran the JUNIT tests and no new problems resulted.

I generated the PDF with the new fop.jar and the percentage distances seemed
correct.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47835

--- Comment #3 from Venkat Reddy <vanukuri.venkat@...> 2009-09-18 02:30:31 PDT ---
(In reply to comment #2)
> According to standard:
> The "provisional-distance-between-start" is specified as a percentage of the
> inline progression dimension of the closet ancestor block-area.
> To its definition in FOPPropertyMapping.java I added the following:
>         m.setPercentBase(LengthBase.CONTAINING_BLOCK_WIDTH);
> I ran the JUNIT tests and no new problems resulted.
> I generated the PDF with the new fop.jar and the percentage distances seemed
> correct.

Yes. This patch is working perfectly. I have tested the orginal pdabs.fo with
provisional-distance-between-start="50%", the space created between elements.
Excellent.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47835

Vincent Hennebert <vhennebert@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Vincent Hennebert <vhennebert@...> 2009-10-13 03:26:57 UTC ---
Fixed in revision 824668:
http://svn.apache.org/viewvc?rev=824668&view=rev
Thanks for the patch!

Vincent

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.