DO NOT REPLY [Bug 48003] New: [PATCH] Improved variable names around Kerning and KnuthElement

View: New views
3 Messages — Rating Filter:   Alert me  

DO NOT REPLY [Bug 48003] New: [PATCH] Improved variable names around Kerning and KnuthElement

by Bugzilla from bugzilla@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://issues.apache.org/bugzilla/show_bug.cgi?id=48003

           Summary: [PATCH] Improved variable names around Kerning and
                    KnuthElement
           Product: Fop
           Version: all
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: page-master/layout
        AssignedTo: fop-dev@...
        ReportedBy: alexanderkiel@...


Created an attachment (id=24381)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24381)
patch file

Just some small things from me to start with something that can applied
separately.

- improved variable names around Kerning and KnuthElement
- changed Font#getKerningValue(char, char) to return the value in pt instead of
milliem

The most critical change is that of Font#getKerningValue(char, char). Can
someone check, that nobody else except TextLayoutManager uses it?

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48003] [PATCH] Improved variable names around Kerning and KnuthElement

by Bugzilla from bugzilla@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://issues.apache.org/bugzilla/show_bug.cgi?id=48003

Adrian Cumiskey <dev@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Adrian Cumiskey <dev@...> 2009-10-15 13:47:57 UTC ---
Patch applied to trunk.

Thanks for the improving the readability of what is a complex area of FOP.  It
should not be underestimated how valuable these kind of patches are to the
health of the project.  Its unselfish work, much appreciated and very good to
see :).

Adrian.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 48003] [PATCH] Improved variable names around Kerning and KnuthElement

by Bugzilla from bugzilla@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

https://issues.apache.org/bugzilla/show_bug.cgi?id=48003

--- Comment #2 from Alexander Kiel <alexanderkiel@...> 2009-10-16 05:07:53 UTC ---
Thanks for applying my patch.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.