DO NOT REPLY [Bug 48053] New: [Patch] Footnotes in absolute block containers cause NPE

https://issues.apache.org/bugzilla/show_bug.cgi?id=48053

           Summary: [Patch] Footnotes in absolute block containers cause
                    NPE
           Product: Fop
           Version: 1.0dev
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: page-master/layout
        AssignedTo: fop-dev@...
        ReportedBy: matthias8283@...


Created an attachment (id=24415)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24415)
Patch

Using footnotes inside block containers, which have an absolute position,
causes a NullPointerException.

Attaching fo file for reproducing the error and a patch.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=48053

--- Comment #1 from Matthias Reischenbacher <matthias8283@...> 2009-10-25 20:13:51 UTC ---
Created an attachment (id=24416)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24416)
testcase

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=48053

Matthias Reischenbacher <matthias8283@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24415|0                           |1
        is obsolete|                            |

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=48053

--- Comment #2 from Matthias Reischenbacher <matthias8283@...> 2009-10-25 20:28:31 UTC ---
Created an attachment (id=24417)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24417)
Patch v2

Fixed compilation problem caused by previous patch

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=48053

--- Comment #3 from Vincent Hennebert <vhennebert@...> 2009-10-26 03:48:31 UTC ---
Hi Matthias,

My answer might be a bit disappointing, but footnotes aren't allowed as
children of absolutely positioned block-containers in the first place:
http://www.w3.org/TR/2006/REC-xsl11-20061205/#fo_footnote
"It is an error if the fo:footnote occurs as a descendant of [...] an
fo:block-container that generates absolutely positioned areas."

There is a bug in FOP, but it has different origins: FOP should issue an error
and handle the children of the footnote-body element as normal blocks.

So I'm leaving the bug report open, but it must be resolved a different way.

Thanks,
Vincent

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=48053

--- Comment #4 from Matthias Reischenbacher <matthias8283@...> 2009-10-26 06:49:59 UTC ---
Hi Vincent,

I wasn't aware of that. A validation exception would be nice in this case.

Would it be a valid approach to use an extension (<fox:footnote/>) in order to
allow footnotes inside absolute block-containers?

Regards,
Matthias

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=48053

--- Comment #5 from Vincent Hennebert <vhennebert@...> 2009-10-27 03:07:45 UTC ---
Hi Matthias,

(In reply to comment #4)
> Hi Vincent,
>
> I wasn't aware of that. A validation exception would be nice in this case.
>
> Would it be a valid approach to use an extension (<fox:footnote/>) in order to
> allow footnotes inside absolute block-containers?

I guess FOP could be taught to accept footnotes from absolutely positioned
block containers. In that case no new element would be necessary, we would just
have to extend the scope of the existing fo:footnote element (that would
possibly make the FO file incompatible with other FO processors, but IMO
portable FO files will always remain a legend anyway).

However, I'd rather investigate if you really need a footnote in an absolutely
positioned block-container in the first place, or if that block really needs to
be absolutely positioned. You may want to ask for advice on the fop-users
mailing list.


Vincent

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.